* gdbtypes.c (replace_type): Doc fix.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4ec99722c3f72cdc27b767a96aacf1f8cefbc134..bb918d2529742f2480745da0ba6b3c21890249ec 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2002-05-04  Jim Blandy  <jimb@redhat.com>
+
+       * gdbtypes.c (replace_type): Doc fix.
+
 2002-05-04  Andrew Cagney  <ac131313@redhat.com>
 
        * valprint.c (strcat_longest): Delete commented out function.

diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index 9132c40b5fe06ac83861694355064c89976504a1..290d4fe09c54d69b531ac7c243900f038c89059e 100644 (file)
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -521,10 +521,16 @@ finish_cv_type (struct type *type)
 
 /* Replace the contents of ntype with the type *type.
 
-   When building recursive types, it is necessary to update a type's
-   definition after people already have references to it.  The C
-   language's concept of an `incomplete type' is an acknowledgement of
-   this.  */
+   In order to build recursive types, it's inevitable that we'll need
+   to update types in place --- but this sort of indiscriminate
+   smashing is ugly, and needs to be replaced with something more
+   controlled.  For example, Daniel Jacobowitz has suggested moving
+   the fields common to a set of c/v variants into their own object,
+   which the variants would share.
+
+   This function does not handle the replacement type being
+   cv-qualified; it could be easily fixed to, but it would be better
+   to just change the whole approach.  */
 void
 replace_type (struct type *ntype, struct type *type)
 {