PCI: Remove unnecessary list_empty(&pci_pme_list) check
authorBjorn Helgaas <bhelgaas@google.com>
Fri, 24 Jan 2014 16:51:06 +0000 (09:51 -0700)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 4 Feb 2014 06:11:31 +0000 (22:11 -0800)
list_for_each_entry() handles empty lists just fine, so there's no need to
check whether the list is empty first.

No functional change.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Rafael J. Wysocki <rjw@rjwysocki.net>
drivers/pci/pci.c

index 1febe90831b442303b7414faec770d4850ca53ed..52e10e1181d069c62d59684be269e9da1d935b64 100644 (file)
@@ -1611,29 +1611,27 @@ static void pci_pme_list_scan(struct work_struct *work)
        struct pci_pme_device *pme_dev, *n;
 
        mutex_lock(&pci_pme_list_mutex);
-       if (!list_empty(&pci_pme_list)) {
-               list_for_each_entry_safe(pme_dev, n, &pci_pme_list, list) {
-                       if (pme_dev->dev->pme_poll) {
-                               struct pci_dev *bridge;
-
-                               bridge = pme_dev->dev->bus->self;
-                               /*
-                                * If bridge is in low power state, the
-                                * configuration space of subordinate devices
-                                * may be not accessible
-                                */
-                               if (bridge && bridge->current_state != PCI_D0)
-                                       continue;
-                               pci_pme_wakeup(pme_dev->dev, NULL);
-                       } else {
-                               list_del(&pme_dev->list);
-                               kfree(pme_dev);
-                       }
+       list_for_each_entry_safe(pme_dev, n, &pci_pme_list, list) {
+               if (pme_dev->dev->pme_poll) {
+                       struct pci_dev *bridge;
+
+                       bridge = pme_dev->dev->bus->self;
+                       /*
+                        * If bridge is in low power state, the
+                        * configuration space of subordinate devices
+                        * may be not accessible
+                        */
+                       if (bridge && bridge->current_state != PCI_D0)
+                               continue;
+                       pci_pme_wakeup(pme_dev->dev, NULL);
+               } else {
+                       list_del(&pme_dev->list);
+                       kfree(pme_dev);
                }
-               if (!list_empty(&pci_pme_list))
-                       schedule_delayed_work(&pci_pme_work,
-                                             msecs_to_jiffies(PME_TIMEOUT));
        }
+       if (!list_empty(&pci_pme_list))
+               schedule_delayed_work(&pci_pme_work,
+                                     msecs_to_jiffies(PME_TIMEOUT));
        mutex_unlock(&pci_pme_list_mutex);
 }
 
This page took 0.027575 seconds and 5 git commands to generate.