tmf: Consolidate constructors in coalesced requests
authorAlexandre Montplaisir <alexmonthy@voxpopuli.im>
Tue, 30 Jul 2013 15:18:49 +0000 (11:18 -0400)
committerAlexandre Montplaisir <alexmonthy@voxpopuli.im>
Tue, 30 Jul 2013 19:19:42 +0000 (15:19 -0400)
And some formatting fixes.

Change-Id: I9c8b51694ee82b4b55aa0d98b873cfda17625cf2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14978
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/request/TmfCoalescedDataRequestTest.java
org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/request/TmfCoalescedEventRequestTest.java
org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/request/TmfCoalescedDataRequest.java
org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/request/TmfCoalescedEventRequest.java

index c0771e0412344b4946ec0d6823b4c300ad1581a3..14cb47d5fdd5ceef509f1c7f59816ea149c700a9 100644 (file)
@@ -21,6 +21,7 @@ import static org.junit.Assert.assertTrue;
 import org.eclipse.linuxtools.internal.tmf.core.request.TmfCoalescedDataRequest;
 import org.eclipse.linuxtools.tmf.core.event.ITmfEvent;
 import org.eclipse.linuxtools.tmf.core.request.TmfDataRequest;
+import org.eclipse.linuxtools.tmf.core.request.ITmfDataRequest.ExecutionType;
 import org.eclipse.linuxtools.tmf.tests.stubs.request.TmfDataRequestStub;
 import org.junit.Before;
 import org.junit.Test;
@@ -52,20 +53,20 @@ public class TmfCoalescedDataRequestTest {
     @Before
     public void setUp() {
         TmfDataRequest.reset();
-        fRequest1 = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200);
-        fRequest2 = new TmfCoalescedDataRequest(ITmfEvent.class, 20, 100, 200);
-        fRequest3 = new TmfCoalescedDataRequest(ITmfEvent.class, 20, 200, 200);
-        fRequest4 = new TmfCoalescedDataRequest(ITmfEvent.class, 20, 200, 300);
+        fRequest1 = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200, ExecutionType.FOREGROUND);
+        fRequest2 = new TmfCoalescedDataRequest(ITmfEvent.class, 20, 100, 200, ExecutionType.FOREGROUND);
+        fRequest3 = new TmfCoalescedDataRequest(ITmfEvent.class, 20, 200, 200, ExecutionType.FOREGROUND);
+        fRequest4 = new TmfCoalescedDataRequest(ITmfEvent.class, 20, 200, 300, ExecutionType.FOREGROUND);
 
-        fRequest1b = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200);
-        fRequest1c = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200);
+        fRequest1b = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200, ExecutionType.FOREGROUND);
+        fRequest1c = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200, ExecutionType.FOREGROUND);
 
         fRequestCount = fRequest1c.getRequestId() + 1;
     }
 
     private static TmfCoalescedDataRequest setupTestRequest(final boolean[] flags) {
 
-        TmfCoalescedDataRequest request = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200) {
+        TmfCoalescedDataRequest request = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200, ExecutionType.FOREGROUND) {
             @Override
             public void handleCompleted() {
                 super.handleCompleted();
@@ -94,63 +95,12 @@ public class TmfCoalescedDataRequestTest {
     }
 
     // ------------------------------------------------------------------------
-    // Constructors
+    // Constructor
     // ------------------------------------------------------------------------
 
-    @Test
-    public void testTmfCoalescedDataRequest() {
-        TmfCoalescedDataRequest request = new TmfCoalescedDataRequest(ITmfEvent.class);
-
-        assertEquals("getRequestId", fRequestCount++, request.getRequestId());
-        assertEquals("getDataType", ITmfEvent.class, request.getDataType());
-
-        assertEquals("getIndex", 0, request.getIndex());
-        assertEquals("getNbRequestedEvents", TmfDataRequest.ALL_DATA, request.getNbRequested());
-
-        assertFalse("isCompleted", request.isCompleted());
-        assertFalse("isFailed", request.isFailed());
-        assertFalse("isCancelled", request.isCancelled());
-
-        assertEquals("getNbRead", 0, request.getNbRead());
-    }
-
-    @Test
-    public void testTmfCoalescedDataRequestIndex() {
-        TmfCoalescedDataRequest request = new TmfCoalescedDataRequest(ITmfEvent.class, 10);
-
-        assertEquals("getRequestId", fRequestCount++, request.getRequestId());
-        assertEquals("getDataType", ITmfEvent.class, request.getDataType());
-
-        assertEquals("getIndex", 10, request.getIndex());
-        assertEquals("getNbRequestedEvents", TmfDataRequest.ALL_DATA, request.getNbRequested());
-
-        assertFalse("isCompleted", request.isCompleted());
-        assertFalse("isFailed", request.isFailed());
-        assertFalse("isCancelled", request.isCancelled());
-
-        assertEquals("getNbRead", 0, request.getNbRead());
-    }
-
-    @Test
-    public void testTmfCoalescedDataRequestIndexNbRequested() {
-        TmfCoalescedDataRequest request = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100);
-
-        assertEquals("getRequestId", fRequestCount++, request.getRequestId());
-        assertEquals("getDataType", ITmfEvent.class, request.getDataType());
-
-        assertEquals("getIndex", 10, request.getIndex());
-        assertEquals("getNbRequestedEvents", 100, request.getNbRequested());
-
-        assertFalse("isCompleted", request.isCompleted());
-        assertFalse("isFailed", request.isFailed());
-        assertFalse("isCancelled", request.isCancelled());
-
-        assertEquals("getNbRead", 0, request.getNbRead());
-    }
-
     @Test
     public void testTmfCoalescedDataRequestIndexNbEventsBlocksize() {
-        TmfCoalescedDataRequest request = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200);
+        TmfCoalescedDataRequest request = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200, ExecutionType.FOREGROUND);
 
         assertEquals("getRequestId", fRequestCount++, request.getRequestId());
         assertEquals("getDataType", ITmfEvent.class, request.getDataType());
@@ -236,7 +186,7 @@ public class TmfCoalescedDataRequestTest {
 
     @Test
     public void testIsCompatible() {
-        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200);
+        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200, ExecutionType.FOREGROUND);
         TmfDataRequest request1 = new TmfDataRequestStub(ITmfEvent.class, 10, 100, 200);
         TmfDataRequest request2 = new TmfDataRequestStub(ITmfEvent.class, 5, 100, 200);
         TmfDataRequest request3 = new TmfDataRequestStub(ITmfEvent.class, 5, 4, 200);
@@ -268,7 +218,7 @@ public class TmfCoalescedDataRequestTest {
 
     @Test
     public void testAddRequest1() {
-        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200);
+        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200, ExecutionType.FOREGROUND);
         TmfDataRequest request = new TmfDataRequestStub(ITmfEvent.class, 10, 100, 200);
 
         assertTrue("isCompatible", coalescedRequest.isCompatible(request));
@@ -280,7 +230,7 @@ public class TmfCoalescedDataRequestTest {
 
     @Test
     public void testAddRequest2() {
-        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200);
+        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200, ExecutionType.FOREGROUND);
         TmfDataRequest request = new TmfDataRequestStub(ITmfEvent.class, 5, 100, 200);
 
         assertTrue("isCompatible", coalescedRequest.isCompatible(request));
@@ -292,7 +242,7 @@ public class TmfCoalescedDataRequestTest {
 
     @Test
     public void testAddRequest3() {
-        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200);
+        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200, ExecutionType.FOREGROUND);
         TmfDataRequest request = new TmfDataRequestStub(ITmfEvent.class, 5, 4, 200);
 
         assertTrue("isCompatible", coalescedRequest.isCompatible(request));
@@ -304,7 +254,7 @@ public class TmfCoalescedDataRequestTest {
 
     @Test
     public void testAddRequest4() {
-        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200);
+        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200, ExecutionType.FOREGROUND);
         TmfDataRequest request = new TmfDataRequestStub(ITmfEvent.class, 5, 5, 200);
 
         assertTrue("isCompatible", coalescedRequest.isCompatible(request));
@@ -316,7 +266,7 @@ public class TmfCoalescedDataRequestTest {
 
     @Test
     public void testAddRequest5() {
-        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200);
+        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200, ExecutionType.FOREGROUND);
         TmfDataRequest request = new TmfDataRequestStub(ITmfEvent.class,  15, 100, 200);
 
         assertTrue("isCompatible", coalescedRequest.isCompatible(request));
@@ -328,7 +278,7 @@ public class TmfCoalescedDataRequestTest {
 
     @Test
     public void testAddRequest6() {
-        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200);
+        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200, ExecutionType.FOREGROUND);
         TmfDataRequest request = new TmfDataRequestStub(ITmfEvent.class, 100, 100, 200);
 
         assertTrue("isCompatible", coalescedRequest.isCompatible(request));
@@ -340,7 +290,7 @@ public class TmfCoalescedDataRequestTest {
 
     @Test
     public void testAddRequest7() {
-        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200);
+        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200, ExecutionType.FOREGROUND);
         TmfDataRequest request = new TmfDataRequestStub(ITmfEvent.class, 110, 100, 200);
 
         assertTrue("isCompatible", coalescedRequest.isCompatible(request));
@@ -352,7 +302,7 @@ public class TmfCoalescedDataRequestTest {
 
     @Test
     public void testAddRequest8() {
-        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200);
+        TmfCoalescedDataRequest coalescedRequest = new TmfCoalescedDataRequest(ITmfEvent.class, 10, 100, 200, ExecutionType.FOREGROUND);
         TmfDataRequest request = new TmfDataRequestStub(ITmfEvent.class, 111, 100, 200);
 
         assertTrue("isCompatible", coalescedRequest.isCompatible(request));
index 1d87c58d393696897ff18f521bc37ae28a2eb4f1..4f69c748a275ed920f36e1f8dd8456b4820facd2 100644 (file)
@@ -75,20 +75,20 @@ public class TmfCoalescedEventRequestTest {
     @Before
     public void setUp() {
         TmfDataRequest.reset();
-        fRequest1 = new TmfCoalescedEventRequest(ITmfEvent.class, range1, 100, 200);
-        fRequest2 = new TmfCoalescedEventRequest(ITmfEvent.class, range2, 100, 200);
-        fRequest3 = new TmfCoalescedEventRequest(ITmfEvent.class, range2, 200, 200);
-        fRequest4 = new TmfCoalescedEventRequest(ITmfEvent.class, range2, 200, 300);
+        fRequest1 = new TmfCoalescedEventRequest(ITmfEvent.class, range1, 0, 100, 200, ExecutionType.FOREGROUND);
+        fRequest2 = new TmfCoalescedEventRequest(ITmfEvent.class, range2, 0, 100, 200, ExecutionType.FOREGROUND);
+        fRequest3 = new TmfCoalescedEventRequest(ITmfEvent.class, range2, 0, 200, 200, ExecutionType.FOREGROUND);
+        fRequest4 = new TmfCoalescedEventRequest(ITmfEvent.class, range2, 0, 200, 300, ExecutionType.FOREGROUND);
 
-        fRequest1b = new TmfCoalescedEventRequest(ITmfEvent.class, range1, 100, 200);
-        fRequest1c = new TmfCoalescedEventRequest(ITmfEvent.class, range1, 100, 200);
+        fRequest1b = new TmfCoalescedEventRequest(ITmfEvent.class, range1, 0, 100, 200, ExecutionType.FOREGROUND);
+        fRequest1c = new TmfCoalescedEventRequest(ITmfEvent.class, range1, 0, 100, 200, ExecutionType.FOREGROUND);
 
         fRequestCount = fRequest1c.getRequestId() + 1;
     }
 
     private TmfCoalescedEventRequest setupTestRequest(final boolean[] flags) {
 
-        TmfCoalescedEventRequest request = new TmfCoalescedEventRequest(ITmfEvent.class, range1, 100, 200) {
+        TmfCoalescedEventRequest request = new TmfCoalescedEventRequest(ITmfEvent.class, range1, 0, 100, 200, ExecutionType.FOREGROUND) {
             @Override
             public void handleCompleted() {
                 super.handleCompleted();
@@ -117,62 +117,12 @@ public class TmfCoalescedEventRequestTest {
     }
 
     // ------------------------------------------------------------------------
-    // Constructors
+    // Constructor
     // ------------------------------------------------------------------------
 
-    @Test
-    public void testTmfCoalescedEventRequest() {
-        TmfCoalescedEventRequest request = new TmfCoalescedEventRequest(ITmfEvent.class);
-
-        assertEquals("getRequestId", fRequestCount++, request.getRequestId());
-        assertEquals("getDataType", ITmfEvent.class, request.getDataType());
-
-        assertEquals("getRange", range1, request.getRange());
-        assertEquals("getNbRequestedEvents", TmfDataRequest.ALL_DATA, request.getNbRequested());
-
-        assertFalse("isCompleted", request.isCompleted());
-        assertFalse("isFailed", request.isFailed());
-        assertFalse("isCancelled", request.isCancelled());
-
-        assertEquals("getNbRead", 0, request.getNbRead());
-    }
-
-    @Test
-    public void testTmfCoalescedEventRequestIndex() {
-        TmfCoalescedEventRequest request = new TmfCoalescedEventRequest(ITmfEvent.class, range1);
-
-        assertEquals("getRequestId", fRequestCount++, request.getRequestId());
-        assertEquals("getDataType", ITmfEvent.class, request.getDataType());
-
-        assertEquals("getRange", range1, request.getRange());
-        assertEquals("getNbRequestedEvents", TmfDataRequest.ALL_DATA, request.getNbRequested());
-
-        assertFalse("isCompleted", request.isCompleted());
-        assertFalse("isFailed", request.isFailed());
-        assertFalse("isCancelled", request.isCancelled());
-
-        assertEquals("getNbRead", 0, request.getNbRead());
-    }
-
-    public void testTmfCoalescedEventRequestIndexNbRequested() {
-        TmfCoalescedEventRequest request = new TmfCoalescedEventRequest(ITmfEvent.class, range1, 100);
-
-        assertEquals("getRequestId", fRequestCount++, request.getRequestId());
-        assertEquals("getDataType", ITmfEvent.class, request.getDataType());
-
-        assertEquals("getRange", range1, request.getRange());
-        assertEquals("getNbRequestedEvents", 100, request.getNbRequested());
-
-        assertFalse("isCompleted", request.isCompleted());
-        assertFalse("isFailed", request.isFailed());
-        assertFalse("isCancelled", request.isCancelled());
-
-        assertEquals("getNbRead", 0, request.getNbRead());
-    }
-
     @Test
     public void testTmfCoalescedEventRequestIndexNbEventsBlocksize() {
-        TmfCoalescedEventRequest request = new TmfCoalescedEventRequest(ITmfEvent.class, range1, 100, 200);
+        TmfCoalescedEventRequest request = new TmfCoalescedEventRequest(ITmfEvent.class, range1, 0, 100, 200, ExecutionType.FOREGROUND);
 
         assertEquals("getRequestId", fRequestCount++, request.getRequestId());
         assertEquals("getDataType", ITmfEvent.class, request.getDataType());
@@ -227,11 +177,23 @@ public class TmfCoalescedEventRequestTest {
     @Test
     public void testEqualsSuper() {
         TmfCoalescedDataRequest dataRequest1 = new TmfCoalescedDataRequest(
-                fRequest1.getDataType(), fRequest1.getIndex(), fRequest1.getNbRequested());
+                fRequest1.getDataType(),
+                fRequest1.getIndex(),
+                fRequest1.getNbRequested(),
+                TmfDataRequest.DEFAULT_BLOCK_SIZE,
+                ExecutionType.FOREGROUND);
         TmfCoalescedDataRequest dataRequest2 = new TmfCoalescedDataRequest(
-                fRequest1.getDataType(), fRequest1.getIndex(), fRequest1.getNbRequested());
+                fRequest1.getDataType(),
+                fRequest1.getIndex(),
+                fRequest1.getNbRequested(),
+                TmfDataRequest.DEFAULT_BLOCK_SIZE,
+                ExecutionType.FOREGROUND);
         TmfCoalescedDataRequest dataRequest3 = new TmfCoalescedDataRequest(
-                fRequest3.getDataType(), fRequest3.getIndex(), fRequest3.getNbRequested());
+                fRequest3.getDataType(),
+                fRequest3.getIndex(),
+                fRequest3.getNbRequested(),
+                TmfDataRequest.DEFAULT_BLOCK_SIZE,
+                ExecutionType.FOREGROUND);
 
         assertTrue("equals", fRequest1.equals(dataRequest2));
         assertTrue("equals", fRequest2.equals(dataRequest1));
@@ -273,7 +235,7 @@ public class TmfCoalescedEventRequestTest {
 
     @Test
     public void testIsCompatible() {
-        TmfCoalescedEventRequest coalescedRequest = new TmfCoalescedEventRequest(ITmfEvent.class, range1, 100, 200);
+        TmfCoalescedEventRequest coalescedRequest = new TmfCoalescedEventRequest(ITmfEvent.class, range1, 0, 100, 200, ExecutionType.FOREGROUND);
         TmfEventRequest req1 = new TmfEventRequestStub(ITmfEvent.class, range1, 100, 200);
         TmfEventRequest req2 = new TmfEventRequestStub(ITmfEvent.class, range2, 100, 200);
         TmfEventRequest req3 = new TmfEventRequestStub(ITmfEvent.class, range1, 101, 200);
index 0b29fad6d3590a2425394dfc28939e47485fec33..569542fbc7bec50651f03b399a8e8e496fc9efa4 100644 (file)
@@ -12,7 +12,8 @@
 
 package org.eclipse.linuxtools.internal.tmf.core.request;
 
-import java.util.Vector;
+import java.util.ArrayList;
+import java.util.List;
 
 import org.eclipse.linuxtools.tmf.core.event.ITmfEvent;
 import org.eclipse.linuxtools.tmf.core.request.ITmfDataRequest;
@@ -30,108 +31,39 @@ public class TmfCoalescedDataRequest extends TmfDataRequest {
     // Attributes
     // ------------------------------------------------------------------------
 
-       /**
-        * The list of coalesced requests
-        */
-       protected Vector<ITmfDataRequest> fRequests = new Vector<ITmfDataRequest>();
+    /**
+     * The list of coalesced requests
+     */
+    protected final List<ITmfDataRequest> fRequests = new ArrayList<ITmfDataRequest>();
 
     // ------------------------------------------------------------------------
     // Constructor
     // ------------------------------------------------------------------------
 
-    /**
-     * Request all the events of a given type (high priority)
-     * Events are returned in blocks of the default size (DEFAULT_BLOCK_SIZE).
-     *
-     * @param dataType the requested data type
-     */
-    public TmfCoalescedDataRequest(Class<? extends ITmfEvent> dataType) {
-        this(dataType, 0, ALL_DATA, DEFAULT_BLOCK_SIZE, ExecutionType.FOREGROUND);
-    }
-
-    /**
-     * Request all the events of a given type (given priority)
-     * Events are returned in blocks of the default size (DEFAULT_BLOCK_SIZE).
-     *
-     * @param dataType the requested data type
-     * @param priority the requested execution priority
-     */
-    public TmfCoalescedDataRequest(Class<? extends ITmfEvent> dataType, ExecutionType priority) {
-        this(dataType, 0, ALL_DATA, DEFAULT_BLOCK_SIZE, priority);
-    }
-
-    /**
-     * Request all the events of a given type from the given index (high priority)
-     * Events are returned in blocks of the default size (DEFAULT_BLOCK_SIZE).
-     *
-     * @param dataType the requested data type
-     * @param index the index of the first event to retrieve
-     */
-    public TmfCoalescedDataRequest(Class<? extends ITmfEvent> dataType, long index) {
-        this(dataType, index, ALL_DATA, DEFAULT_BLOCK_SIZE, ExecutionType.FOREGROUND);
-    }
-
-    /**
-     * Request all the events of a given type from the given index (given priority)
-     * Events are returned in blocks of the default size (DEFAULT_BLOCK_SIZE).
-     *
-     * @param dataType the requested data type
-     * @param index the index of the first event to retrieve
-     * @param priority the requested execution priority
-     */
-    public TmfCoalescedDataRequest(Class<? extends ITmfEvent> dataType, long index, ExecutionType priority) {
-        this(dataType, index, ALL_DATA, DEFAULT_BLOCK_SIZE, priority);
-    }
-
-    /**
-     * Request 'n' events of a given type from the given index (high priority)
-     * Events are returned in blocks of the default size (DEFAULT_BLOCK_SIZE).
-     *
-     * @param dataType the requested data type
-     * @param index the index of the first event to retrieve
-     * @param nbRequested the number of events requested
-     */
-    public TmfCoalescedDataRequest(Class<? extends ITmfEvent> dataType, long index, int nbRequested) {
-        this(dataType, index, nbRequested, DEFAULT_BLOCK_SIZE, ExecutionType.FOREGROUND);
-    }
-
-    /**
-     * Request 'n' events of a given type from the given index (given priority)
-     * Events are returned in blocks of the default size (DEFAULT_BLOCK_SIZE).
-     *
-     * @param dataType the requested data type
-     * @param index the index of the first event to retrieve
-     * @param nbRequested the number of events requested
-     * @param priority the requested execution priority
-     */
-    public TmfCoalescedDataRequest(Class<? extends ITmfEvent> dataType, long index, int nbRequested, ExecutionType priority) {
-        this(dataType, index, nbRequested, DEFAULT_BLOCK_SIZE, priority);
-    }
-
-    /**
-     * Request 'n' events of a given type from the given index (high priority).
-     * Events are returned in blocks of the given size.
-     *
-     * @param dataType the requested data type
-     * @param index the index of the first event to retrieve
-     * @param nbRequested the number of events requested
-     * @param blockSize the number of events per block
-     */
-    public TmfCoalescedDataRequest(Class<? extends ITmfEvent> dataType, long index, int nbRequested, int blockSize) {
-        super(ITmfEvent.class, index, nbRequested, blockSize, ExecutionType.FOREGROUND);
-    }
-
     /**
      * Request 'n' events of a given type from the given index (given priority).
      * Events are returned in blocks of the given size.
      *
-     * @param dataType the requested data type
-     * @param index the index of the first event to retrieve
-     * @param nbRequested the number of events requested
-     * @param blockSize the number of events per block
-     * @param priority the requested execution priority
+     * @param dataType
+     *            The requested data type
+     * @param index
+     *            The index of the first event to retrieve. Use '0' to start at
+     *            the beginning.
+     * @param nbRequested
+     *            The number of events requested. You can use
+     *            {@link TmfDataRequest#ALL_DATA} to request all events.
+     * @param blockSize
+     *            The number of events per block. You can use
+     *            {@link TmfDataRequest#DEFAULT_BLOCK_SIZE} to use a default
+     *            value.
+     * @param priority
+     *            The requested execution priority
      */
-    public TmfCoalescedDataRequest(Class<? extends ITmfEvent> dataType, long index, int nbRequested, int blockSize, ExecutionType priority) {
+    public TmfCoalescedDataRequest(Class<? extends ITmfEvent> dataType,
+            long index,
+            int nbRequested,
+            int blockSize,
+            ExecutionType priority) {
         super(ITmfEvent.class, index, nbRequested, blockSize, priority);
     }
 
@@ -142,7 +74,8 @@ public class TmfCoalescedDataRequest extends TmfDataRequest {
     /**
      * Add a request to this one.
      *
-     * @param request The request to add
+     * @param request
+     *            The request to add
      */
     public void addRequest(ITmfDataRequest request) {
         fRequests.add(request);
@@ -183,7 +116,7 @@ public class TmfCoalescedDataRequest extends TmfDataRequest {
             fIndex = start;
         }
         if ((request.getNbRequested() == TmfDataRequest.ALL_DATA) ||
-             (fNbRequested == TmfDataRequest.ALL_DATA))
+                (fNbRequested == TmfDataRequest.ALL_DATA))
         {
             fNbRequested = TmfDataRequest.ALL_DATA;
         } else {
@@ -191,36 +124,36 @@ public class TmfCoalescedDataRequest extends TmfDataRequest {
         }
     }
 
-       /**
-        * @return The list of IDs of the sub-requests
-        */
-       @SuppressWarnings("nls")
+    /**
+     * @return The list of IDs of the sub-requests
+     */
+    @SuppressWarnings("nls")
     public String getSubRequestIds() {
-           StringBuffer result = new StringBuffer("[");
-           for (int i = 0; i < fRequests.size(); i++) {
-               if (i != 0) {
+        StringBuffer result = new StringBuffer("[");
+        for (int i = 0; i < fRequests.size(); i++) {
+            if (i != 0) {
                 result.append(", ");
             }
-               result.append(fRequests.get(i).getRequestId());
-           }
-           result.append("]");
-           return result.toString();
-       }
+            result.append(fRequests.get(i).getRequestId());
+        }
+        result.append("]");
+        return result.toString();
+    }
 
     // ------------------------------------------------------------------------
     // ITmfDataRequest
     // ------------------------------------------------------------------------
 
     @Override
-       public void handleData(ITmfEvent data) {
-               super.handleData(data);
-       // Don't call sub-requests handleData() unless this is a
-               // TmfCoalescedDataRequest; extended classes should call
-               // the sub-requests handleData().
-               if (getClass() == TmfCoalescedDataRequest.class) {
-                   long index = getIndex() + getNbRead() - 1;
-               for (ITmfDataRequest request : fRequests) {
-                   if (!request.isCompleted()) {
+    public void handleData(ITmfEvent data) {
+        super.handleData(data);
+        // Don't call sub-requests handleData() unless this is a
+        // TmfCoalescedDataRequest; extended classes should call
+        // the sub-requests handleData().
+        if (getClass() == TmfCoalescedDataRequest.class) {
+            long index = getIndex() + getNbRead() - 1;
+            for (ITmfDataRequest request : fRequests) {
+                if (!request.isCompleted()) {
                     if (request.getDataType().isInstance(data)) {
                         long start = request.getIndex();
                         long end = start + request.getNbRequested();
@@ -243,32 +176,32 @@ public class TmfCoalescedDataRequest extends TmfDataRequest {
         super.start();
     }
 
-       @Override
+    @Override
     public void done() {
-       for (ITmfDataRequest request : fRequests) {
-           if (!request.isCompleted()) {
-               request.done();
-           }
-       }
-       super.done();
+        for (ITmfDataRequest request : fRequests) {
+            if (!request.isCompleted()) {
+                request.done();
+            }
+        }
+        super.done();
     }
 
     @Override
     public void fail() {
-       for (ITmfDataRequest request : fRequests) {
-               request.fail();
-       }
-       super.fail();
+        for (ITmfDataRequest request : fRequests) {
+            request.fail();
+        }
+        super.fail();
     }
 
     @Override
     public void cancel() {
-       for (ITmfDataRequest request : fRequests) {
-           if (!request.isCompleted()) {
-               request.cancel();
-           }
-       }
-       super.cancel();
+        for (ITmfDataRequest request : fRequests) {
+            if (!request.isCompleted()) {
+                request.cancel();
+            }
+        }
+        super.cancel();
     }
 
     @Override
@@ -318,7 +251,6 @@ public class TmfCoalescedDataRequest extends TmfDataRequest {
 
     }
 
-
     // ------------------------------------------------------------------------
     // Object
     // ------------------------------------------------------------------------
@@ -326,25 +258,25 @@ public class TmfCoalescedDataRequest extends TmfDataRequest {
     @Override
     // All requests have a unique id
     public int hashCode() {
-       return super.hashCode();
+        return super.hashCode();
     }
 
     @Override
     public boolean equals(Object other) {
-       if (other instanceof TmfCoalescedDataRequest) {
-               TmfCoalescedDataRequest request = (TmfCoalescedDataRequest) other;
-                       return  (request.getDataType()    == getDataType())   &&
-                                       (request.getIndex()       == getIndex())      &&
-                                       (request.getNbRequested() == getNbRequested() &&
-                               (request.getExecType()    == getExecType()));
-               }
-               return false;
+        if (other instanceof TmfCoalescedDataRequest) {
+            TmfCoalescedDataRequest request = (TmfCoalescedDataRequest) other;
+            return (request.getDataType() == getDataType()) &&
+                    (request.getIndex() == getIndex()) &&
+                    (request.getNbRequested() == getNbRequested() &&
+                    (request.getExecType() == getExecType()));
+        }
+        return false;
     }
 
     @Override
     @SuppressWarnings("nls")
     public String toString() {
-               return "[TmfCoalescedDataRequest(" + getRequestId() + "," + getDataType().getSimpleName()
-                       + "," + getIndex() + "," + getNbRequested() + "," + getBlockSize() + ")]";
+        return "[TmfCoalescedDataRequest(" + getRequestId() + "," + getDataType().getSimpleName()
+                + "," + getIndex() + "," + getNbRequested() + "," + getBlockSize() + ")]";
     }
 }
index b75cd1d547694e356702495d69b48e3882029992..fd2d4d518a185fe112837e1e7e5d4f60836785bb 100644 (file)
@@ -32,120 +32,40 @@ public class TmfCoalescedEventRequest extends TmfCoalescedDataRequest implements
     // Attributes
     // ------------------------------------------------------------------------
 
-       private TmfTimeRange fRange;    // The requested events time range
+    private TmfTimeRange fRange; // The requested events time range
 
     // ------------------------------------------------------------------------
     // Constructor
     // ------------------------------------------------------------------------
 
     /**
-     * Request all the events of a given type (high priority)
-     * Events are returned in blocks of the default size (DEFAULT_BLOCK_SIZE).
+     * Request 'n' events of a given type for the given time range (given
+     * priority). Events are returned in blocks of the given size.
      *
-     * @param dataType the requested data type
+     * @param dataType
+     *            The requested data type
+     * @param range
+     *            The range of the request. You can use
+     *            {@link TmfTimeRange#ETERNITY} to request all events.
+     * @param index
+     *            The index of the first event to retrieve. Use '0' to start at
+     *            the beginning.
+     * @param nbRequested
+     *            The number of events requested. You can use
+     *            {@link TmfDataRequest#ALL_DATA} to request all events.
+     * @param blockSize
+     *            The number of events per block. You can use
+     *            {@link TmfDataRequest#DEFAULT_BLOCK_SIZE} to use a default
+     *            value.
+     * @param priority
+     *            The requested execution priority
      */
-    public TmfCoalescedEventRequest(Class<? extends ITmfEvent> dataType) {
-        this(dataType, TmfTimeRange.ETERNITY, ALL_DATA, DEFAULT_BLOCK_SIZE, ExecutionType.FOREGROUND);
-    }
-
-    /**
-     * Request all the events of a given type (given priority)
-     * Events are returned in blocks of the default size (DEFAULT_BLOCK_SIZE).
-     *
-     * @param dataType the requested data type
-     * @param priority the requested execution priority
-     */
-    public TmfCoalescedEventRequest(Class<? extends ITmfEvent> dataType, ExecutionType priority) {
-        this(dataType, TmfTimeRange.ETERNITY, ALL_DATA, DEFAULT_BLOCK_SIZE, priority);
-    }
-
-    /**
-     * Request all the events of a given type for the given time range (high priority)
-     * Events are returned in blocks of the default size (DEFAULT_BLOCK_SIZE).
-     *
-     * @param dataType the requested data type
-     * @param range the time range of the requested events
-     */
-    public TmfCoalescedEventRequest(Class<? extends ITmfEvent> dataType, TmfTimeRange range) {
-        this(dataType, range, ALL_DATA, DEFAULT_BLOCK_SIZE, ExecutionType.FOREGROUND);
-    }
-
-    /**
-     * Request all the events of a given type for the given time range (given priority)
-     * Events are returned in blocks of the default size (DEFAULT_BLOCK_SIZE).
-     *
-     * @param dataType the requested data type
-     * @param range the time range of the requested events
-     * @param priority the requested execution priority
-     */
-    public TmfCoalescedEventRequest(Class<? extends ITmfEvent> dataType, TmfTimeRange range, ExecutionType priority) {
-        this(dataType, range, ALL_DATA, DEFAULT_BLOCK_SIZE, priority);
-    }
-
-    /**
-     * Request 'n' events of a given type from the given time range (high priority)
-     * Events are returned in blocks of the default size (DEFAULT_BLOCK_SIZE).
-     *
-     * @param dataType the requested data type
-     * @param range the time range of the requested events
-     * @param nbRequested the number of events requested
-     */
-    public TmfCoalescedEventRequest(Class<? extends ITmfEvent> dataType, TmfTimeRange range, int nbRequested) {
-        this(dataType, range, nbRequested, DEFAULT_BLOCK_SIZE, ExecutionType.FOREGROUND);
-    }
-
-    /**
-     * Request 'n' events of a given type for the given time range (given priority)
-     * Events are returned in blocks of the default size (DEFAULT_BLOCK_SIZE).
-     *
-     * @param dataType the requested data type
-     * @param range the time range of the requested events
-     * @param nbRequested the number of events requested
-     * @param priority the requested execution priority
-     */
-    public TmfCoalescedEventRequest(Class<? extends ITmfEvent> dataType, TmfTimeRange range, int nbRequested, ExecutionType priority) {
-        this(dataType, range, nbRequested, DEFAULT_BLOCK_SIZE, priority);
-    }
-
-    /**
-     * Request 'n' events of a given type for the given time range (high priority).
-     * Events are returned in blocks of the given size.
-     *
-     * @param dataType the requested data type
-     * @param range the time range of the requested events
-     * @param nbRequested the number of events requested
-     * @param blockSize the number of events per block
-     */
-    public TmfCoalescedEventRequest(Class<? extends ITmfEvent> dataType, TmfTimeRange range, int nbRequested, int blockSize) {
-        this(dataType, range, 0, nbRequested, blockSize, ExecutionType.FOREGROUND);
-    }
-
-    /**
-     * Request 'n' events of a given type for the given time range (given priority).
-     * Events are returned in blocks of the given size.
-     *
-     * @param dataType the requested data type
-     * @param range the time range of the requested events
-     * @param nbRequested the number of events requested
-     * @param blockSize the number of events per block
-     * @param priority the requested execution priority
-     */
-    public TmfCoalescedEventRequest(Class<? extends ITmfEvent> dataType, TmfTimeRange range, int nbRequested, int blockSize, ExecutionType priority) {
-        this(dataType, range, 0, nbRequested, blockSize, priority);
-    }
-
-    /**
-     * Request 'n' events of a given type for the given time range (given priority).
-     * Events are returned in blocks of the given size.
-     *
-     * @param dataType the requested data type
-     * @param range the time range of the requested events
-     * @param index the index of the first event to retrieve
-     * @param nbRequested the number of events requested
-     * @param blockSize the number of events per block
-     * @param priority the requested execution priority
-     */
-    public TmfCoalescedEventRequest(Class<? extends ITmfEvent> dataType, TmfTimeRange range, long index, int nbRequested, int blockSize, ExecutionType priority) {
+    public TmfCoalescedEventRequest(Class<? extends ITmfEvent> dataType,
+            TmfTimeRange range,
+            long index,
+            int nbRequested,
+            int blockSize,
+            ExecutionType priority) {
         super(ITmfEvent.class, index, nbRequested, blockSize, priority);
         fRange = range;
 
@@ -174,25 +94,25 @@ public class TmfCoalescedEventRequest extends TmfCoalescedDataRequest implements
         }
     }
 
-       @Override
-       public boolean isCompatible(ITmfDataRequest request) {
-           if (request instanceof ITmfEventRequest) {
-               if (super.isCompatible(request)) {
-                   return overlaps((ITmfEventRequest) request);
-               }
-           }
-           return false;
-       }
+    @Override
+    public boolean isCompatible(ITmfDataRequest request) {
+        if (request instanceof ITmfEventRequest) {
+            if (super.isCompatible(request)) {
+                return overlaps((ITmfEventRequest) request);
+            }
+        }
+        return false;
+    }
 
     private boolean overlaps(ITmfEventRequest request) {
         ITmfTimestamp startTime = request.getRange().getStartTime();
-        ITmfTimestamp endTime   = request.getRange().getEndTime();
+        ITmfTimestamp endTime = request.getRange().getEndTime();
         return (startTime.compareTo(endTime) <= 0) && (fRange.getStartTime().compareTo(fRange.getEndTime()) <= 0);
     }
 
     private void merge(ITmfEventRequest request) {
         ITmfTimestamp startTime = request.getRange().getStartTime();
-        ITmfTimestamp endTime   = request.getRange().getEndTime();
+        ITmfTimestamp endTime = request.getRange().getEndTime();
         if (!fRange.contains(startTime) && fRange.getStartTime().compareTo(startTime) > 0) {
             fRange = new TmfTimeRange(startTime, fRange.getEndTime());
         }
@@ -242,15 +162,15 @@ public class TmfCoalescedEventRequest extends TmfCoalescedDataRequest implements
     // ITmfEventRequest
     // ------------------------------------------------------------------------
 
-       @Override
-       public TmfTimeRange getRange() {
-               return fRange;
-       }
+    @Override
+    public TmfTimeRange getRange() {
+        return fRange;
+    }
 
-       @Override
-       public void setStartIndex(int index) {
-               setIndex(index);
-       }
+    @Override
+    public void setStartIndex(int index) {
+        setIndex(index);
+    }
 
     // ------------------------------------------------------------------------
     // Object
@@ -259,29 +179,29 @@ public class TmfCoalescedEventRequest extends TmfCoalescedDataRequest implements
     @Override
     // All requests have a unique id
     public int hashCode() {
-       return super.hashCode();
+        return super.hashCode();
     }
 
     @Override
     public boolean equals(Object other) {
-       if (other instanceof TmfCoalescedEventRequest) {
-               TmfCoalescedEventRequest request = (TmfCoalescedEventRequest) other;
-                       return  (request.getDataType()    == getDataType()) &&
-                                       (request.getIndex()       == getIndex())    &&
-                                       (request.getNbRequested() == getNbRequested()) &&
-                               (request.getRange().equals(getRange()));
-               }
-       if (other instanceof TmfCoalescedDataRequest) {
-                       return super.equals(other);
-       }
-               return false;
+        if (other instanceof TmfCoalescedEventRequest) {
+            TmfCoalescedEventRequest request = (TmfCoalescedEventRequest) other;
+            return (request.getDataType() == getDataType()) &&
+                    (request.getIndex() == getIndex()) &&
+                    (request.getNbRequested() == getNbRequested()) &&
+                    (request.getRange().equals(getRange()));
+        }
+        if (other instanceof TmfCoalescedDataRequest) {
+            return super.equals(other);
+        }
+        return false;
     }
 
     @Override
     @SuppressWarnings("nls")
     public String toString() {
-               return "[TmfCoalescedEventRequest(" + getRequestId() + "," + getDataType().getSimpleName()
-                       + "," + getRange() + "," + getIndex() + "," + getNbRequested() + "," + getBlockSize() + ")]";
+        return "[TmfCoalescedEventRequest(" + getRequestId() + "," + getDataType().getSimpleName()
+                + "," + getRange() + "," + getIndex() + "," + getNbRequested() + "," + getBlockSize() + ")]";
     }
 
 }
This page took 0.040335 seconds and 5 git commands to generate.