drivers: staging: rtl8723au: remove unneeded null test
authorCihangir Akturk <cakturk@gmail.com>
Fri, 4 Mar 2016 13:43:10 +0000 (15:43 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 Mar 2016 06:09:09 +0000 (22:09 -0800)
null test on pnetwork removed, because the iterator variable
list_for_each_entry_safe cannot be null.

This commit fixes the following error reported by coccinelle:

drivers/staging/rtl8723au/core/rtw_mlme.c:1621:7-15: ERROR: iterator
variable bound on line 1620 cannot be NULL

Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723au/core/rtw_mlme.c

index 3adda555becbccb1fe807cf657c8d44e4e4338a3..a786fc4bdb53e8f2b854cf12697dbf1be4bbc102 100644 (file)
@@ -1617,19 +1617,10 @@ rtw_select_candidate_from_queue(struct mlme_priv *pmlmepriv)
 
        spin_lock_bh(&pmlmepriv->scanned_queue.lock);
        phead = get_list_head(queue);
-       list_for_each_entry_safe(pnetwork, ptmp, phead, list) {
-               if (!pnetwork) {
-                       RT_TRACE(_module_rtl871x_mlme_c_, _drv_err_,
-                                "%s: return _FAIL:(pnetwork == NULL)\n",
-                                __func__);
-                       goto exit;
-               }
-
+       list_for_each_entry_safe(pnetwork, ptmp, phead, list)
                rtw_check_join_candidate(pmlmepriv, &candidate, pnetwork);
-       }
-
-exit:
        spin_unlock_bh(&pmlmepriv->scanned_queue.lock);
+
        return candidate;
 }
 
This page took 0.026865 seconds and 5 git commands to generate.