Use gdb::byte_vector in target_write_memory

Pedro pointed out that target_write_memory should use gdb::byte_vector
rather than std::vector<unsigned char>.

gdb/gdbserver/ChangeLog
2019-08-15  Tom Tromey  <tromey@adacore.com>

	* target.c (target_write_memory): Use gdb::byte_vector.

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index f53668672b8566c5b43636d2e98dd24c7e1368ca..adac3e8c8d74e93c67ea80e9d26e513783d248e2 100644 (file)
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,7 @@
+2019-08-15  Tom Tromey  <tromey@adacore.com>
+
+       * target.c (target_write_memory): Use gdb::byte_vector.
+
 2019-08-15  Tom Tromey  <tromey@adacore.com>
 
        * tracepoint.c (write_inferior_data_pointer)

diff --git a/gdb/gdbserver/target.c b/gdb/gdbserver/target.c
index 6f6b448ecf4ee53c2223ef7762f6c151818332af..0b45b6c956dc14f6b80e65907a2981fe6a8f98a2 100644 (file)
--- a/gdb/gdbserver/target.c
+++ b/gdb/gdbserver/target.c
@@ -20,6 +20,7 @@
 
 #include "server.h"
 #include "tracepoint.h"
+#include "gdbsupport/byte-vector.h"
 
 struct target_ops *the_target;
 
@@ -154,7 +155,7 @@ target_write_memory (CORE_ADDR memaddr, const unsigned char *myaddr,
 {
   /* Make a copy of the data because check_mem_write may need to
      update it.  */
-  std::vector<unsigned char> buffer (myaddr, myaddr + len);
+  gdb::byte_vector buffer (myaddr, myaddr + len);
   check_mem_write (memaddr, buffer.data (), myaddr, len);
   return (*the_target->write_memory) (memaddr, buffer.data (), len);
 }