[testsuite] Pass -pie in ldflags

-pie is a linker flag, it should be passed via "ldflags", instead
of "additional_flags".  Otherwise, clang complains,

clang: warning: argument unused during compilation: '-pie'

gdb/testsuite:

2017-11-22  Yao Qi  <yao.qi@linaro.org>

	* gdb.base/attach-pie-noexec.exp: Pass "-pie" in ldflags.
	* gdb.base/break-interp.exp: Likewise.
	* gdb.base/jit-attach-pie.exp: Likewise.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 00279828a0b8c84211ad4767af02d5d495b815b5..110fcb1d7f63dfdc371729ee97407bcb19752306 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2017-11-22  Yao Qi  <yao.qi@linaro.org>
+
+       * gdb.base/attach-pie-noexec.exp: Pass "-pie" in ldflags.
+       * gdb.base/break-interp.exp: Likewise.
+       * gdb.base/jit-attach-pie.exp: Likewise.
+
 2017-11-22  Ulrich Weigand  <uweigand@de.ibm.com>
 
        * gdb.base/float128.c (large128): New variable.

diff --git a/gdb/testsuite/gdb.base/attach-pie-noexec.exp b/gdb/testsuite/gdb.base/attach-pie-noexec.exp
index 82e6af6ab22c30930d9b379d97bc63b1fd9fa641..56a42cb240f0360dc2797d9d39157a7645cdac8e 100644 (file)
--- a/gdb/testsuite/gdb.base/attach-pie-noexec.exp
+++ b/gdb/testsuite/gdb.base/attach-pie-noexec.exp
@@ -20,7 +20,7 @@ if {![can_spawn_for_attach]} {
 standard_testfile .c
 set executable ${testfile}
 
-if { [prepare_for_testing "failed to prepare" $executable "" [list debug "additional_flags=-fPIE -pie"]] } {
+if { [prepare_for_testing "failed to prepare" $executable "" [list debug "additional_flags=-fPIE" "ldflags=-pie"]] } {
     return -1
 }
 

diff --git a/gdb/testsuite/gdb.base/break-interp.exp b/gdb/testsuite/gdb.base/break-interp.exp
index 3a6d9a9717c8f125809ecf77c6b0382ac73888f5..460e5f6cf41eec1b25f9555686aee91b21638e52 100644 (file)
--- a/gdb/testsuite/gdb.base/break-interp.exp
+++ b/gdb/testsuite/gdb.base/break-interp.exp
@@ -625,7 +625,8 @@ foreach ldprelink {NO YES} {
                                lappend opts {debug}
                            }
                            if {$binpie != "NO"} {
-                               lappend opts {additional_flags=-fPIE -pie}
+                               lappend opts {additional_flags=-fPIE}
+                               lappend opts {ldflags=-pie}
                            }
 
                            set dir ${exec}.d

diff --git a/gdb/testsuite/gdb.base/jit-attach-pie.exp b/gdb/testsuite/gdb.base/jit-attach-pie.exp
index da77a4a0cda1683717eb8549c6898433f1363c0f..eb484a3910a94194dbe18686826d713ade974e8a 100644 (file)
--- a/gdb/testsuite/gdb.base/jit-attach-pie.exp
+++ b/gdb/testsuite/gdb.base/jit-attach-pie.exp
@@ -21,7 +21,7 @@ standard_testfile .c
 set executable ${testfile}
 
 if { [build_executable ${testfile}.exp $executable $srcfile \
-                         [list debug pthreads "additional_flags=-fPIE -pie"]] } {
+                         [list debug pthreads "additional_flags=-fPIE" "ldflags=-pie"]] } {
     return -1
 }