sink.text.pretty: use bt_common_g_string_append and bt_common_g_string_append_c

Use our own inline implementation of g_string_append and g_string_append_c
to improve text pretty-printing speed.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I39254ae912cb9bd227c68519552b4b610c15755f
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1506
CI-Build: Philippe Proulx <eeppeliteloop@gmail.com>
Tested-by: jenkins <jenkins@lttng.org>
Reviewed-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>

diff --git a/src/plugins/text/pretty/print.c b/src/plugins/text/pretty/print.c
index b3aaeb44d030785c7064daf1114b4b1d686b8f05..8474c43c1e2107dcb722ef0863ce43706e66191e 100644 (file)
--- a/src/plugins/text/pretty/print.c
+++ b/src/plugins/text/pretty/print.c
@@ -59,26 +59,26 @@ static
 void print_name_equal(struct pretty_component *pretty, const char *name)
 {
        if (pretty->use_colors) {
-               g_string_append(pretty->string, COLOR_NAME);
-               g_string_append(pretty->string, name);
-               g_string_append(pretty->string, COLOR_RST);
+               bt_common_g_string_append(pretty->string, COLOR_NAME);
+               bt_common_g_string_append(pretty->string, name);
+               bt_common_g_string_append(pretty->string, COLOR_RST);
        } else {
-               g_string_append(pretty->string, name);
+               bt_common_g_string_append(pretty->string, name);
        }
-       g_string_append(pretty->string, " = ");
+       bt_common_g_string_append(pretty->string, " = ");
 }
 
 static
 void print_field_name_equal(struct pretty_component *pretty, const char *name)
 {
        if (pretty->use_colors) {
-               g_string_append(pretty->string, COLOR_FIELD_NAME);
-               g_string_append(pretty->string, name);
-               g_string_append(pretty->string, COLOR_RST);
+               bt_common_g_string_append(pretty->string, COLOR_FIELD_NAME);
+               bt_common_g_string_append(pretty->string, name);
+               bt_common_g_string_append(pretty->string, COLOR_RST);
        } else {
-               g_string_append(pretty->string, name);
-}
-       g_string_append(pretty->string, " = ");
+               bt_common_g_string_append(pretty->string, name);
+       }
+       bt_common_g_string_append(pretty->string, " = ");
 }
 
 static
@@ -110,14 +110,14 @@ void print_timestamp_wall(struct pretty_component *pretty,
        bool is_negative;
 
        if (!clock_snapshot) {
-               g_string_append(pretty->string, "??:??:??.?????????");
+               bt_common_g_string_append(pretty->string, "??:??:??.?????????");
                return;
        }
 
        ret = bt_clock_snapshot_get_ns_from_origin(clock_snapshot, &ts_nsec);
        if (ret) {
                // TODO: log, this is unexpected
-               g_string_append(pretty->string, "Error");
+               bt_common_g_string_append(pretty->string, "Error");
                return;
        }
 
@@ -201,7 +201,7 @@ void print_timestamp_wall(struct pretty_component *pretty,
                                goto seconds;
                        }
 
-                       g_string_append(pretty->string, timestr);
+                       bt_common_g_string_append(pretty->string, timestr);
                }
 
                /* Print time in HH:MM:SS.ns */
@@ -236,10 +236,10 @@ int print_event_timestamp(struct pretty_component *pretty,
        if (print_names) {
                print_name_equal(pretty, "timestamp");
        } else {
-               g_string_append(pretty->string, "[");
+               bt_common_g_string_append(pretty->string, "[");
        }
        if (pretty->use_colors) {
-               g_string_append(pretty->string, COLOR_TIMESTAMP);
+               bt_common_g_string_append(pretty->string, COLOR_TIMESTAMP);
        }
        if (pretty->options.print_timestamp_cycles) {
                print_timestamp_cycles(pretty, clock_snapshot, true);
@@ -247,22 +247,22 @@ int print_event_timestamp(struct pretty_component *pretty,
                print_timestamp_wall(pretty, clock_snapshot, true);
        }
        if (pretty->use_colors) {
-               g_string_append(pretty->string, COLOR_RST);
+               bt_common_g_string_append(pretty->string, COLOR_RST);
        }
 
        if (!print_names)
-               g_string_append(pretty->string, "] ");
+               bt_common_g_string_append(pretty->string, "] ");
 
        if (pretty->options.print_delta_field) {
                if (print_names) {
-                       g_string_append(pretty->string, ", ");
+                       bt_common_g_string_append(pretty->string, ", ");
                        print_name_equal(pretty, "delta");
                } else {
-                       g_string_append(pretty->string, "(");
+                       bt_common_g_string_append(pretty->string, "(");
                }
                if (pretty->options.print_timestamp_cycles) {
                        if (pretty->delta_cycles == -1ULL) {
-                               g_string_append(pretty->string,
+                               bt_common_g_string_append(pretty->string,
                                        "+??????????\?\?"); /* Not a trigraph. */
                        } else {
                                bt_common_g_string_append_printf(pretty->string,
@@ -279,11 +279,11 @@ int print_event_timestamp(struct pretty_component *pretty,
                                        "+%" PRIu64 ".%09" PRIu64,
                                        delta_sec, delta_nsec);
                        } else {
-                               g_string_append(pretty->string, "+?.?????????");
+                               bt_common_g_string_append(pretty->string, "+?.?????????");
                        }
                }
                if (!print_names) {
-                       g_string_append(pretty->string, ") ");
+                       bt_common_g_string_append(pretty->string, ") ");
                }
        }
        *start_line = !print_names;
@@ -319,16 +319,16 @@ int print_event_header(struct pretty_component *pretty,
                name = bt_trace_get_name(trace);
                if (name) {
                        if (!pretty->start_line) {
-                               g_string_append(pretty->string, ", ");
+                               bt_common_g_string_append(pretty->string, ", ");
                        }
                        if (print_names) {
                                print_name_equal(pretty, "trace");
                        }
 
-                       g_string_append(pretty->string, name);
+                       bt_common_g_string_append(pretty->string, name);
 
                        if (print_names) {
-                               g_string_append(pretty->string, ", ");
+                               bt_common_g_string_append(pretty->string, ", ");
                        }
                }
        }
@@ -341,13 +341,13 @@ int print_event_header(struct pretty_component *pretty,
                        const char *str;
 
                        if (!pretty->start_line) {
-                               g_string_append(pretty->string, ", ");
+                               bt_common_g_string_append(pretty->string, ", ");
                        }
                        if (print_names) {
                                print_name_equal(pretty, "trace:hostname");
                        }
                        str = bt_value_string_get(hostname_str);
-                       g_string_append(pretty->string, str);
+                       bt_common_g_string_append(pretty->string, str);
                        dom_print = 1;
                }
        }
@@ -360,15 +360,15 @@ int print_event_header(struct pretty_component *pretty,
                        const char *str;
 
                        if (!pretty->start_line) {
-                               g_string_append(pretty->string, ", ");
+                               bt_common_g_string_append(pretty->string, ", ");
                        }
                        if (print_names) {
                                print_name_equal(pretty, "trace:domain");
                        } else if (dom_print) {
-                               g_string_append(pretty->string, ":");
+                               bt_common_g_string_append(pretty->string, ":");
                        }
                        str = bt_value_string_get(domain_str);
-                       g_string_append(pretty->string, str);
+                       bt_common_g_string_append(pretty->string, str);
                        dom_print = 1;
                }
        }
@@ -381,15 +381,15 @@ int print_event_header(struct pretty_component *pretty,
                        const char *str;
 
                        if (!pretty->start_line) {
-                               g_string_append(pretty->string, ", ");
+                               bt_common_g_string_append(pretty->string, ", ");
                        }
                        if (print_names) {
                                print_name_equal(pretty, "trace:procname");
                        } else if (dom_print) {
-                               g_string_append(pretty->string, ":");
+                               bt_common_g_string_append(pretty->string, ":");
                        }
                        str = bt_value_string_get(procname_str);
-                       g_string_append(pretty->string, str);
+                       bt_common_g_string_append(pretty->string, str);
                        dom_print = 1;
                }
        }
@@ -402,12 +402,12 @@ int print_event_header(struct pretty_component *pretty,
                        int64_t value;
 
                        if (!pretty->start_line) {
-                               g_string_append(pretty->string, ", ");
+                               bt_common_g_string_append(pretty->string, ", ");
                        }
                        if (print_names) {
                                print_name_equal(pretty, "trace:vpid");
                        } else if (dom_print) {
-                               g_string_append(pretty->string, ":");
+                               bt_common_g_string_append(pretty->string, ":");
                        }
                        value = bt_value_integer_signed_get(vpid_value);
                        bt_common_g_string_append_printf(pretty->string,
@@ -443,15 +443,15 @@ int print_event_header(struct pretty_component *pretty,
                        BT_ASSERT(log_level_str);
 
                        if (!pretty->start_line) {
-                               g_string_append(pretty->string, ", ");
+                               bt_common_g_string_append(pretty->string, ", ");
                        }
                        if (print_names) {
                                print_name_equal(pretty, "loglevel");
                        } else if (dom_print) {
-                               g_string_append(pretty->string, ":");
+                               bt_common_g_string_append(pretty->string, ":");
                        }
 
-                       g_string_append(pretty->string, log_level_str);
+                       bt_common_g_string_append(pretty->string, log_level_str);
                        bt_common_g_string_append_printf(
                                pretty->string, " (%d)", (int) log_level);
                        dom_print = 1;
@@ -463,23 +463,23 @@ int print_event_header(struct pretty_component *pretty,
                uri_str = bt_event_class_get_emf_uri(event_class);
                if (uri_str) {
                        if (!pretty->start_line) {
-                               g_string_append(pretty->string, ", ");
+                               bt_common_g_string_append(pretty->string, ", ");
                        }
                        if (print_names) {
                                print_name_equal(pretty, "model.emf.uri");
                        } else if (dom_print) {
-                               g_string_append(pretty->string, ":");
+                               bt_common_g_string_append(pretty->string, ":");
                        }
 
-                       g_string_append(pretty->string, uri_str);
+                       bt_common_g_string_append(pretty->string, uri_str);
                        dom_print = 1;
                }
        }
        if (dom_print && !print_names) {
-               g_string_append(pretty->string, " ");
+               bt_common_g_string_append(pretty->string, " ");
        }
        if (!pretty->start_line) {
-               g_string_append(pretty->string, ", ");
+               bt_common_g_string_append(pretty->string, ", ");
        }
        pretty->start_line = true;
        if (print_names) {
@@ -488,23 +488,25 @@ int print_event_header(struct pretty_component *pretty,
        ev_name = bt_event_class_get_name(event_class);
        if (pretty->use_colors) {
                if (ev_name) {
-                       g_string_append(pretty->string, COLOR_EVENT_NAME);
+                       bt_common_g_string_append(pretty->string,
+                               COLOR_EVENT_NAME);
                } else {
-                       g_string_append(pretty->string, COLOR_UNKNOWN);
+                       bt_common_g_string_append(pretty->string,
+                               COLOR_UNKNOWN);
                }
        }
        if (ev_name) {
-               g_string_append(pretty->string, ev_name);
+               bt_common_g_string_append(pretty->string, ev_name);
        } else {
-               g_string_append(pretty->string, "<unknown>");
+               bt_common_g_string_append(pretty->string, "<unknown>");
        }
        if (pretty->use_colors) {
-               g_string_append(pretty->string, COLOR_RST);
+               bt_common_g_string_append(pretty->string, COLOR_RST);
        }
        if (!print_names) {
-               g_string_append(pretty->string, ": ");
+               bt_common_g_string_append(pretty->string, ": ");
        } else {
-               g_string_append(pretty->string, ", ");
+               bt_common_g_string_append(pretty->string, ", ");
        }
 
 end:
@@ -536,7 +538,7 @@ int print_integer(struct pretty_component *pretty,
        }
 
        if (pretty->use_colors) {
-               g_string_append(pretty->string, COLOR_NUMBER_VALUE);
+               bt_common_g_string_append(pretty->string, COLOR_NUMBER_VALUE);
                rst_color = true;
        }
 
@@ -547,7 +549,7 @@ int print_integer(struct pretty_component *pretty,
                int bitnr, len;
 
                len = bt_field_class_integer_get_field_value_range(int_fc);
-               g_string_append(pretty->string, "0b");
+               bt_common_g_string_append(pretty->string, "0b");
                _bt_safe_lshift(v.u, 64 - len);
                for (bitnr = 0; bitnr < len; bitnr++) {
                        bt_common_g_string_append_printf(pretty->string, "%u", (v.u & (1ULL << 63)) ? 1 : 0);
@@ -605,7 +607,7 @@ int print_integer(struct pretty_component *pretty,
        }
 end:
        if (rst_color) {
-               g_string_append(pretty->string, COLOR_RST);
+               bt_common_g_string_append(pretty->string, COLOR_RST);
        }
        return ret;
 }
@@ -615,58 +617,58 @@ void print_escape_string(struct pretty_component *pretty, const char *str)
 {
        int i;
 
-       g_string_append_c(pretty->string, '"');
+       bt_common_g_string_append_c(pretty->string, '"');
 
        for (i = 0; i < strlen(str); i++) {
                /* Escape sequences not recognized by iscntrl(). */
                switch (str[i]) {
                case '\\':
-                       g_string_append(pretty->string, "\\\\");
+                       bt_common_g_string_append(pretty->string, "\\\\");
                        continue;
                case '\'':
-                       g_string_append(pretty->string, "\\\'");
+                       bt_common_g_string_append(pretty->string, "\\\'");
                        continue;
                case '\"':
-                       g_string_append(pretty->string, "\\\"");
+                       bt_common_g_string_append(pretty->string, "\\\"");
                        continue;
                case '\?':
-                       g_string_append(pretty->string, "\\\?");
+                       bt_common_g_string_append(pretty->string, "\\\?");
                        continue;
                }
 
                /* Standard characters. */
                if (!iscntrl(str[i])) {
-                       g_string_append_c(pretty->string, str[i]);
+                       bt_common_g_string_append_c(pretty->string, str[i]);
                        continue;
                }
 
                switch (str[i]) {
                case '\0':
-                       g_string_append(pretty->string, "\\0");
+                       bt_common_g_string_append(pretty->string, "\\0");
                        break;
                case '\a':
-                       g_string_append(pretty->string, "\\a");
+                       bt_common_g_string_append(pretty->string, "\\a");
                        break;
                case '\b':
-                       g_string_append(pretty->string, "\\b");
+                       bt_common_g_string_append(pretty->string, "\\b");
                        break;
                case '\e':
-                       g_string_append(pretty->string, "\\e");
+                       bt_common_g_string_append(pretty->string, "\\e");
                        break;
                case '\f':
-                       g_string_append(pretty->string, "\\f");
+                       bt_common_g_string_append(pretty->string, "\\f");
                        break;
                case '\n':
-                       g_string_append(pretty->string, "\\n");
+                       bt_common_g_string_append(pretty->string, "\\n");
                        break;
                case '\r':
-                       g_string_append(pretty->string, "\\r");
+                       bt_common_g_string_append(pretty->string, "\\r");
                        break;
                case '\t':
-                       g_string_append(pretty->string, "\\t");
+                       bt_common_g_string_append(pretty->string, "\\t");
                        break;
                case '\v':
-                       g_string_append(pretty->string, "\\v");
+                       bt_common_g_string_append(pretty->string, "\\v");
                        break;
                default:
                        /* Unhandled control-sequence, print as hex. */
@@ -675,7 +677,7 @@ void print_escape_string(struct pretty_component *pretty, const char *str)
                }
        }
 
-       g_string_append_c(pretty->string, '"');
+       bt_common_g_string_append_c(pretty->string, '"');
 }
 
 static
@@ -712,14 +714,14 @@ int print_enum(struct pretty_component *pretty,
                goto end;
        }
 
-       g_string_append(pretty->string, "( ");
+       bt_common_g_string_append(pretty->string, "( ");
        if (label_count == 0) {
                if (pretty->use_colors) {
-                       g_string_append(pretty->string, COLOR_UNKNOWN);
+                       bt_common_g_string_append(pretty->string, COLOR_UNKNOWN);
                }
-               g_string_append(pretty->string, "<unknown>");
+               bt_common_g_string_append(pretty->string, "<unknown>");
                if (pretty->use_colors) {
-                       g_string_append(pretty->string, COLOR_RST);
+                       bt_common_g_string_append(pretty->string, COLOR_RST);
                }
                goto skip_loop;
        }
@@ -727,23 +729,23 @@ int print_enum(struct pretty_component *pretty,
                const char *mapping_name = label_array[i];
 
                if (i != 0) {
-                       g_string_append(pretty->string, ", ");
+                       bt_common_g_string_append(pretty->string, ", ");
                }
                if (pretty->use_colors) {
-                       g_string_append(pretty->string, COLOR_ENUM_MAPPING_NAME);
+                       bt_common_g_string_append(pretty->string, COLOR_ENUM_MAPPING_NAME);
                }
                print_escape_string(pretty, mapping_name);
                if (pretty->use_colors) {
-                       g_string_append(pretty->string, COLOR_RST);
+                       bt_common_g_string_append(pretty->string, COLOR_RST);
                }
        }
 skip_loop:
-       g_string_append(pretty->string, " : container = ");
+       bt_common_g_string_append(pretty->string, " : container = ");
        ret = print_integer(pretty, field);
        if (ret != 0) {
                goto end;
        }
-       g_string_append(pretty->string, " )");
+       bt_common_g_string_append(pretty->string, " )");
 end:
        return ret;
 }
@@ -770,9 +772,9 @@ int print_struct_field(struct pretty_component *pretty,
        field_name = bt_field_class_structure_member_get_name(member);
 
        if (*nr_printed_fields > 0) {
-               g_string_append(pretty->string, ", ");
+               bt_common_g_string_append(pretty->string, ", ");
        } else {
-               g_string_append(pretty->string, " ");
+               bt_common_g_string_append(pretty->string, " ");
        }
        if (print_names) {
                print_field_name_equal(pretty, field_name);
@@ -800,7 +802,7 @@ int print_struct(struct pretty_component *pretty,
 
        nr_fields = bt_field_class_structure_get_member_count(struct_class);
 
-       g_string_append(pretty->string, "{");
+       bt_common_g_string_append(pretty->string, "{");
        pretty->depth++;
        nr_printed_fields = 0;
        for (i = 0; i < nr_fields; i++) {
@@ -811,7 +813,7 @@ int print_struct(struct pretty_component *pretty,
                }
        }
        pretty->depth--;
-       g_string_append(pretty->string, " }");
+       bt_common_g_string_append(pretty->string, " }");
 
 end:
        return ret;
@@ -824,9 +826,9 @@ int print_array_field(struct pretty_component *pretty,
        const bt_field *field = NULL;
 
        if (i != 0) {
-               g_string_append(pretty->string, ", ");
+               bt_common_g_string_append(pretty->string, ", ");
        } else {
-               g_string_append(pretty->string, " ");
+               bt_common_g_string_append(pretty->string, " ");
        }
        if (print_names) {
                bt_common_g_string_append_printf(pretty->string, "[%" PRIu64 "] = ", i);
@@ -852,7 +854,7 @@ int print_array(struct pretty_component *pretty,
                goto end;
        }
        len = bt_field_array_get_length(array);
-       g_string_append(pretty->string, "[");
+       bt_common_g_string_append(pretty->string, "[");
        pretty->depth++;
        for (i = 0; i < len; i++) {
                ret = print_array_field(pretty, array, i, print_names);
@@ -861,7 +863,7 @@ int print_array(struct pretty_component *pretty,
                }
        }
        pretty->depth--;
-       g_string_append(pretty->string, " ]");
+       bt_common_g_string_append(pretty->string, " ]");
 
 end:
        return ret;
@@ -874,9 +876,9 @@ int print_sequence_field(struct pretty_component *pretty,
        const bt_field *field = NULL;
 
        if (i != 0) {
-               g_string_append(pretty->string, ", ");
+               bt_common_g_string_append(pretty->string, ", ");
        } else {
-               g_string_append(pretty->string, " ");
+               bt_common_g_string_append(pretty->string, " ");
        }
        if (print_names) {
                bt_common_g_string_append_printf(pretty->string, "[%" PRIu64 "] = ", i);
@@ -896,7 +898,7 @@ int print_sequence(struct pretty_component *pretty,
        uint64_t i;
 
        len = bt_field_array_get_length(seq);
-       g_string_append(pretty->string, "[");
+       bt_common_g_string_append(pretty->string, "[");
 
        pretty->depth++;
        for (i = 0; i < len; i++) {
@@ -906,7 +908,7 @@ int print_sequence(struct pretty_component *pretty,
                }
        }
        pretty->depth--;
-       g_string_append(pretty->string, " ]");
+       bt_common_g_string_append(pretty->string, " ]");
 
 end:
        return ret;
@@ -921,7 +923,7 @@ int print_variant(struct pretty_component *pretty,
 
        field = bt_field_variant_borrow_selected_option_field_const(variant);
        BT_ASSERT(field);
-       g_string_append(pretty->string, "{ ");
+       bt_common_g_string_append(pretty->string, "{ ");
        pretty->depth++;
        if (print_names) {
                // TODO: find tag's name using field path
@@ -932,7 +934,7 @@ int print_variant(struct pretty_component *pretty,
                goto end;
        }
        pretty->depth--;
-       g_string_append(pretty->string, " }");
+       bt_common_g_string_append(pretty->string, " }");
 
 end:
        return ret;
@@ -955,11 +957,11 @@ int print_field(struct pretty_component *pretty,
 
                v = bt_field_real_get_value(field);
                if (pretty->use_colors) {
-                       g_string_append(pretty->string, COLOR_NUMBER_VALUE);
+                       bt_common_g_string_append(pretty->string, COLOR_NUMBER_VALUE);
                }
                bt_common_g_string_append_printf(pretty->string, "%g", v);
                if (pretty->use_colors) {
-                       g_string_append(pretty->string, COLOR_RST);
+                       bt_common_g_string_append(pretty->string, COLOR_RST);
                }
                return 0;
        }
@@ -976,11 +978,11 @@ int print_field(struct pretty_component *pretty,
                }
 
                if (pretty->use_colors) {
-                       g_string_append(pretty->string, COLOR_STRING_VALUE);
+                       bt_common_g_string_append(pretty->string, COLOR_STRING_VALUE);
                }
                print_escape_string(pretty, str);
                if (pretty->use_colors) {
-                       g_string_append(pretty->string, COLOR_RST);
+                       bt_common_g_string_append(pretty->string, COLOR_RST);
                }
                return 0;
        }
@@ -1018,7 +1020,7 @@ int print_stream_packet_context(struct pretty_component *pretty,
                goto end;
        }
        if (!pretty->start_line) {
-               g_string_append(pretty->string, ", ");
+               bt_common_g_string_append(pretty->string, ", ");
        }
        pretty->start_line = false;
        if (pretty->options.print_scope_field_names) {
@@ -1043,7 +1045,7 @@ int print_stream_event_context(struct pretty_component *pretty,
                goto end;
        }
        if (!pretty->start_line) {
-               g_string_append(pretty->string, ", ");
+               bt_common_g_string_append(pretty->string, ", ");
        }
        pretty->start_line = false;
        if (pretty->options.print_scope_field_names) {
@@ -1068,7 +1070,7 @@ int print_event_context(struct pretty_component *pretty,
                goto end;
        }
        if (!pretty->start_line) {
-               g_string_append(pretty->string, ", ");
+               bt_common_g_string_append(pretty->string, ", ");
        }
        pretty->start_line = false;
        if (pretty->options.print_scope_field_names) {
@@ -1093,7 +1095,7 @@ int print_event_payload(struct pretty_component *pretty,
                goto end;
        }
        if (!pretty->start_line) {
-               g_string_append(pretty->string, ", ");
+               bt_common_g_string_append(pretty->string, ", ");
        }
        pretty->start_line = false;
        if (pretty->options.print_scope_field_names) {
@@ -1159,7 +1161,7 @@ int pretty_print_event(struct pretty_component *pretty,
                goto end;
        }
 
-       g_string_append_c(pretty->string, '\n');
+       bt_common_g_string_append_c(pretty->string, '\n');
        if (flush_buf(pretty->out, pretty)) {
                ret = -1;
                goto end;
@@ -1235,16 +1237,16 @@ int print_discarded_elements_msg(struct pretty_component *pretty,
                        count == 1 ? "" : "s");
        }
 
-       g_string_append_c(pretty->string, ' ');
+       bt_common_g_string_append_c(pretty->string, ' ');
 
        if (begin_clock_snapshot && end_clock_snapshot) {
-               g_string_append(pretty->string, "between [");
+               bt_common_g_string_append(pretty->string, "between [");
                print_timestamp_wall(pretty, begin_clock_snapshot, false);
-               g_string_append(pretty->string, "] and [");
+               bt_common_g_string_append(pretty->string, "] and [");
                print_timestamp_wall(pretty, end_clock_snapshot, false);
-               g_string_append(pretty->string, "]");
+               bt_common_g_string_append(pretty->string, "]");
        } else {
-               g_string_append(pretty->string, "(unknown time range)");
+               bt_common_g_string_append(pretty->string, "(unknown time range)");
        }
 
        bt_common_g_string_append_printf(pretty->string, " in trace \"%s\" ", trace_name);
@@ -1254,7 +1256,7 @@ int print_discarded_elements_msg(struct pretty_component *pretty,
                        "(UUID: " BT_UUID_FMT ") ",
                        BT_UUID_FMT_VALUES(trace_uuid));
        } else {
-               g_string_append(pretty->string, "(no UUID) ");
+               bt_common_g_string_append(pretty->string, "(no UUID) ");
        }
 
        bt_common_g_string_append_printf(pretty->string,
@@ -1265,7 +1267,7 @@ int print_discarded_elements_msg(struct pretty_component *pretty,
                bt_common_g_string_append_printf(pretty->string,
                        "stream ID: %" PRIu64, stream_id);
        } else {
-               g_string_append(pretty->string, "no stream ID");
+               bt_common_g_string_append(pretty->string, "no stream ID");
        }
 
        bt_common_g_string_append_printf(pretty->string, ").%s\n",