parisc: Remove BKL from eisa_eeprom
authorThomas Gleixner <tglx@linutronix.de>
Sat, 10 Oct 2009 13:33:17 +0000 (15:33 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 14 Oct 2009 15:36:52 +0000 (17:36 +0200)
Remove the empty ioctl and the cycle_kernel_lock() in
eisa_eeprom_open() which got there with the big BKL push down. There
is nothing to wait for and sychronize with after the misc device has
been registered.

Remove the empty ioctl as well. The generic code handles the -ENOTTY
if no ioctl function is provided.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
LKML-Reference: <20091010153350.086917493@linutronix.de>
Cc: Kyle McMartin <kyle@parisc-linux.org>
drivers/parisc/eisa_eeprom.c

index 8c0b26e9b98a0857f022e009dba200783a45c876..cce00ed81f37908fd062d34a89ad3f8f49a5d4e3 100644 (file)
@@ -75,17 +75,8 @@ static ssize_t eisa_eeprom_read(struct file * file,
        return ret;
 }
 
-static int eisa_eeprom_ioctl(struct inode *inode, struct file *file, 
-                          unsigned int cmd,
-                          unsigned long arg)
-{
-       return -ENOTTY;
-}
-
 static int eisa_eeprom_open(struct inode *inode, struct file *file)
 {
-       cycle_kernel_lock();
-
        if (file->f_mode & FMODE_WRITE)
                return -EINVAL;
    
@@ -104,7 +95,6 @@ static const struct file_operations eisa_eeprom_fops = {
        .owner =        THIS_MODULE,
        .llseek =       eisa_eeprom_llseek,
        .read =         eisa_eeprom_read,
-       .ioctl =        eisa_eeprom_ioctl,
        .open =         eisa_eeprom_open,
        .release =      eisa_eeprom_release,
 };
This page took 0.025276 seconds and 5 git commands to generate.