convert to_save_record

2014-02-19  Tom Tromey  <tromey@redhat.com>

	* target-delegates.c: Rebuild.
	* target.c (target_save_record): Unconditionally delegate.
	* target.h (struct target_ops) <to_save_record>: Use
	TARGET_DEFAULT_NORETURN.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3e54272be4f4a02d8364fed18e01fc2bc69ad7b5..4dc1725f86ae4752d5d637a3cb3e77fd5a56f30d 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2014-02-19  Tom Tromey  <tromey@redhat.com>
+
+       * target-delegates.c: Rebuild.
+       * target.c (target_save_record): Unconditionally delegate.
+       * target.h (struct target_ops) <to_save_record>: Use
+       TARGET_DEFAULT_NORETURN.
+
 2014-02-19  Tom Tromey  <tromey@redhat.com>
 
        * target-delegates.c: Rebuild.

diff --git a/gdb/target-delegates.c b/gdb/target-delegates.c
index 4e5fd1ae416be23d6577b6ed1c60cb872d95341a..62f68cc1ecd646d0d9dccd58ae37de1fa0ae276e 100644 (file)
--- a/gdb/target-delegates.c
+++ b/gdb/target-delegates.c
@@ -1260,6 +1260,19 @@ tdefault_supports_btrace (struct target_ops *self)
   return 0;
 }
 
+static void
+delegate_save_record (struct target_ops *self, const char *arg1)
+{
+  self = self->beneath;
+  self->to_save_record (self, arg1);
+}
+
+static void
+tdefault_save_record (struct target_ops *self, const char *arg1)
+{
+  tcomplain ();
+}
+
 static void
 delegate_delete_record (struct target_ops *self)
 {
@@ -1631,6 +1644,8 @@ install_delegators (struct target_ops *ops)
     ops->to_can_use_agent = delegate_can_use_agent;
   if (ops->to_supports_btrace == NULL)
     ops->to_supports_btrace = delegate_supports_btrace;
+  if (ops->to_save_record == NULL)
+    ops->to_save_record = delegate_save_record;
   if (ops->to_delete_record == NULL)
     ops->to_delete_record = delegate_delete_record;
   if (ops->to_record_is_replaying == NULL)
@@ -1766,6 +1781,7 @@ install_dummy_methods (struct target_ops *ops)
   ops->to_use_agent = tdefault_use_agent;
   ops->to_can_use_agent = tdefault_can_use_agent;
   ops->to_supports_btrace = tdefault_supports_btrace;
+  ops->to_save_record = tdefault_save_record;
   ops->to_delete_record = tdefault_delete_record;
   ops->to_record_is_replaying = tdefault_record_is_replaying;
   ops->to_goto_record_begin = tdefault_goto_record_begin;

diff --git a/gdb/target.c b/gdb/target.c
index 5b8c591b1ce871b7bd209420a013e0b389148572..17077aabba3d830abae09b4d557bd3922bce2f63 100644 (file)
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -3899,16 +3899,7 @@ target_info_record (void)
 void
 target_save_record (const char *filename)
 {
-  struct target_ops *t;
-
-  for (t = current_target.beneath; t != NULL; t = t->beneath)
-    if (t->to_save_record != NULL)
-      {
-       t->to_save_record (t, filename);
-       return;
-      }
-
-  tcomplain ();
+  current_target.to_save_record (&current_target, filename);
 }
 
 /* See target.h.  */

diff --git a/gdb/target.h b/gdb/target.h
index 0bce110866f16700d3a802d60f4f0fc8fbaf6a9a..e3d7ed80b5d3d7dd06f281cb906ce2c385e8a6cb 100644 (file)
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -1026,7 +1026,8 @@ struct target_ops
     void (*to_info_record) (struct target_ops *);
 
     /* Save the recorded execution trace into a file.  */
-    void (*to_save_record) (struct target_ops *, const char *filename);
+    void (*to_save_record) (struct target_ops *, const char *filename)
+      TARGET_DEFAULT_NORETURN (tcomplain ());
 
     /* Delete the recorded execution trace from the current position onwards.  */
     void (*to_delete_record) (struct target_ops *)