ata: libahci: Use of_platform_device_create only if supported
authorGuenter Roeck <linux@roeck-us.net>
Sat, 31 Jan 2015 18:36:22 +0000 (10:36 -0800)
committerTejun Heo <tj@kernel.org>
Tue, 3 Feb 2015 12:12:54 +0000 (07:12 -0500)
of_platform_device_create does not exist if OF_ADDRESS is not configured,
so limit its use accordingly.

Without this fix, the sparc64:allmodconfig build fails with

ERROR: "of_platform_device_create" [drivers/ata/libahci_platform.ko] undefined!

Fixes: c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators")
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/libahci_platform.c

index 077c7a26135470d24c01ddd722ac318e25da1693..d89305d289f63f8a4afcb78773a19e42088790ba 100644 (file)
@@ -418,7 +418,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
        if (child_nodes) {
                for_each_child_of_node(dev->of_node, child) {
                        u32 port;
-                       struct platform_device *port_dev;
+                       struct platform_device *port_dev __maybe_unused;
 
                        if (!of_device_is_available(child))
                                continue;
@@ -434,6 +434,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
                        }
                        mask_port_map |= BIT(port);
 
+#ifdef CONFIG_OF_ADDRESS
                        of_platform_device_create(child, NULL, NULL);
 
                        port_dev = of_find_device_by_node(child);
@@ -444,6 +445,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
                                if (rc == -EPROBE_DEFER)
                                        goto err_out;
                        }
+#endif
 
                        rc = ahci_platform_get_phy(hpriv, port, dev, child);
                        if (rc)
This page took 0.025429 seconds and 5 git commands to generate.