backlight: 88pm860x_bl: Add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 10 Oct 2015 12:30:50 +0000 (14:30 +0200)
committerLee Jones <lee.jones@linaro.org>
Thu, 15 Oct 2015 11:06:21 +0000 (12:06 +0100)
for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
+  of_node_put(child);
?  break;
   ...
}
... when != child
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/video/backlight/88pm860x_bl.c

index 2da5862876d1fe78fb53371bce64dde5269ad71b..6d8dc2c775205529a2a6f069e7c12439c12aa53d 100644 (file)
@@ -180,6 +180,7 @@ static int pm860x_backlight_dt_init(struct platform_device *pdev,
                        data->iset = PM8606_WLED_CURRENT(iset);
                        of_property_read_u32(np, "marvell,88pm860x-pwm",
                                             &data->pwm);
+                       of_node_put(np);
                        break;
                }
        }
This page took 0.025442 seconds and 5 git commands to generate.