From: Greg Kroah-Hartman Date: Thu, 30 Apr 2015 09:22:05 +0000 (+0200) Subject: tty: amiserial.c: move assignment out of if () block X-Git-Url: http://git.efficios.com/?a=commitdiff_plain;h=2eeaf0bbca79412f15d00a08b930cbd9235fc3a2;p=deliverable%2Flinux.git tty: amiserial.c: move assignment out of if () block We should not be doing assignments within an if () block so fix up the code to not do this. change was created using Coccinelle. CC: Jiri Slaby Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c index 894d3a84e285..e53d9a512c6d 100644 --- a/drivers/tty/amiserial.c +++ b/drivers/tty/amiserial.c @@ -1782,7 +1782,8 @@ static int __exit amiga_serial_remove(struct platform_device *pdev) struct serial_state *state = platform_get_drvdata(pdev); /* printk("Unloading %s: version %s\n", serial_name, serial_version); */ - if ((error = tty_unregister_driver(serial_driver))) + error = tty_unregister_driver(serial_driver); + if (error) printk("SERIAL: failed to unregister serial driver (%d)\n", error); put_tty_driver(serial_driver);