From: Eric W. Biederman <ebiederm@xmission.com>
Date: Thu, 12 Nov 2009 03:32:48 +0000 (-0800)
Subject: sysctl:  Warn about all uses of sys_sysctl.
X-Git-Url: http://git.efficios.com/?a=commitdiff_plain;h=2fb10732c3b3c9671b1a391996ce7e551876c25e;p=deliverable%2Flinux.git

sysctl:  Warn about all uses of sys_sysctl.

Now that the glibc pthread implemenation no longers uses sysctl() users
of sysctl are as rare as hen's teeth.  So remove the glibc exception
from the warning, and use the standard printk_ratelimit instead of
rolling our own.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---

diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c
index 471438bbece6..bf0a4b06782a 100644
--- a/kernel/sysctl_binary.c
+++ b/kernel/sysctl_binary.c
@@ -1393,15 +1393,9 @@ static ssize_t binary_sysctl(const int *name, int nlen,
 
 static void deprecated_sysctl_warning(const int *name, int nlen)
 {
-	static int msg_count;
 	int i;
 
-	/* Ignore accesses to kernel.version */
-	if ((nlen == 2) && (name[0] == CTL_KERN) && (name[1] == KERN_VERSION))
-		return;
-
-	if (msg_count < 5) {
-		msg_count++;
+	if (printk_ratelimit()) {
 		printk(KERN_INFO
 			"warning: process `%s' used the deprecated sysctl "
 			"system call with ", current->comm);