From: Patrick Tasse Date: Wed, 11 Nov 2015 15:21:50 +0000 (-0500) Subject: tmf: Fix trace markers with experiments in AbstractTimeGraphView X-Git-Url: http://git.efficios.com/?a=commitdiff_plain;h=4e94ae249a1db80edf5d9ba822e9f521894cbb2f;p=deliverable%2Ftracecompass.git tmf: Fix trace markers with experiments in AbstractTimeGraphView The key of the marker event sources map should always be the view trace. Change-Id: Iecb458fd291c3ae1b62a5fed9f9954306f41a09a Signed-off-by: Patrick Tasse Reviewed-on: https://git.eclipse.org/r/60138 Reviewed-by: Hudson CI Reviewed-by: Marc-Andre Laperle Tested-by: Marc-Andre Laperle --- diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/timegraph/AbstractTimeGraphView.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/timegraph/AbstractTimeGraphView.java index 68e98e4263..79b67cfa97 100644 --- a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/timegraph/AbstractTimeGraphView.java +++ b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/timegraph/AbstractTimeGraphView.java @@ -1244,9 +1244,9 @@ public abstract class AbstractTimeGraphView extends TmfView implements ITmfTimeA if (buildThread != null) { buildThread.cancel(); } - fMarkerEventSourcesMap.remove(trace); } } + fMarkerEventSourcesMap.remove(signal.getTrace()); synchronized (fEntryListMap) { fEntryListMap.remove(signal.getTrace()); } @@ -1370,17 +1370,19 @@ public abstract class AbstractTimeGraphView extends TmfView implements ITmfTimeA if (viewTrace == null) { return; } + List markerEventSources = new ArrayList<>(); synchronized (fBuildThreadMap) { for (ITmfTrace trace : getTracesToBuild(viewTrace)) { if (trace == null) { break; } - fMarkerEventSourcesMap.put(trace, TmfTraceAdapterManager.getAdapters(trace, IMarkerEventSource.class)); + markerEventSources.addAll(TmfTraceAdapterManager.getAdapters(trace, IMarkerEventSource.class)); BuildThread buildThread = new BuildThread(trace, viewTrace, getName()); fBuildThreadMap.put(trace, buildThread); buildThread.start(); } } + fMarkerEventSourcesMap.put(viewTrace, markerEventSources); } /** @@ -1510,7 +1512,7 @@ public abstract class AbstractTimeGraphView extends TmfView implements ITmfTimeA protected @NonNull List getTraceMarkerList(long startTime, long endTime, long resolution, @NonNull IProgressMonitor monitor) { List markers = new ArrayList<>(); - for (IMarkerEventSource markerEventSource : getMarkerEventSources(getTrace())) { + for (IMarkerEventSource markerEventSource : getMarkerEventSources(fTrace)) { for (String category : markerEventSource.getMarkerCategories()) { if (monitor.isCanceled()) { break;