From: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Date: Wed, 16 Dec 2015 03:35:31 +0000 (-0500)
Subject: Disable overlay scrollbars when running tests to prevent crash
X-Git-Url: http://git.efficios.com/?a=commitdiff_plain;h=7d97c73c7c90490124371da51c40ba43e1cff0d2;hp=c2a843a8b3e610414f03ee644cc224649d468a75;p=deliverable%2Ftracecompass.git

Disable overlay scrollbars when running tests to prevent crash

When running tests, the Eclipse launcher is not used which means
that the code that usually disables the overlay scrollbars is not
executed. The overlay scrollbars under GTK2 are unstable and can
cause crash. Specifically, a crash was frequently seen in
tmf.ui.swtbot.tests on Ubuntu.

Change-Id: I130d7fd95affa4f7eb68d2c2d1e0b0134e84ee07
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62780
Reviewed-by: Hudson CI
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
---

diff --git a/analysis/org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests/pom.xml b/analysis/org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests/pom.xml
index fe63279575..4a9543497f 100644
--- a/analysis/org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests/pom.xml
+++ b/analysis/org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests/pom.xml
@@ -38,6 +38,7 @@
           <product>org.eclipse.platform.ide</product>
           <environmentVariables>
             <SWT_GTK3>${SWT_GTK3}</SWT_GTK3>
+            <LIBOVERLAY_SCROLLBAR>0</LIBOVERLAY_SCROLLBAR>
           </environmentVariables>
         </configuration>
       </plugin>
diff --git a/ctf/org.eclipse.tracecompass.tmf.ctf.ui.swtbot.tests/pom.xml b/ctf/org.eclipse.tracecompass.tmf.ctf.ui.swtbot.tests/pom.xml
index 01cd956236..156778c5db 100644
--- a/ctf/org.eclipse.tracecompass.tmf.ctf.ui.swtbot.tests/pom.xml
+++ b/ctf/org.eclipse.tracecompass.tmf.ctf.ui.swtbot.tests/pom.xml
@@ -39,6 +39,7 @@
           <product>org.eclipse.platform.ide</product>
           <environmentVariables>
             <SWT_GTK3>${SWT_GTK3}</SWT_GTK3>
+            <LIBOVERLAY_SCROLLBAR>0</LIBOVERLAY_SCROLLBAR>
           </environmentVariables>
         </configuration>
       </plugin>
diff --git a/lttng/org.eclipse.tracecompass.lttng2.control.ui.swtbot.tests/pom.xml b/lttng/org.eclipse.tracecompass.lttng2.control.ui.swtbot.tests/pom.xml
index b6c1a14047..d875112fe3 100644
--- a/lttng/org.eclipse.tracecompass.lttng2.control.ui.swtbot.tests/pom.xml
+++ b/lttng/org.eclipse.tracecompass.lttng2.control.ui.swtbot.tests/pom.xml
@@ -41,6 +41,7 @@
 <!-- Disable GTK3 with Luna because it makes the test hang (bug in IcedTea http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1736) -->
           <environmentVariables>
             <SWT_GTK3>${SWT_GTK3}</SWT_GTK3>
+            <LIBOVERLAY_SCROLLBAR>0</LIBOVERLAY_SCROLLBAR>
           </environmentVariables>
         </configuration>
       </plugin>
diff --git a/lttng/org.eclipse.tracecompass.lttng2.kernel.ui.swtbot.tests/pom.xml b/lttng/org.eclipse.tracecompass.lttng2.kernel.ui.swtbot.tests/pom.xml
index 5c39676521..d92640e063 100644
--- a/lttng/org.eclipse.tracecompass.lttng2.kernel.ui.swtbot.tests/pom.xml
+++ b/lttng/org.eclipse.tracecompass.lttng2.kernel.ui.swtbot.tests/pom.xml
@@ -39,6 +39,7 @@
           <product>org.eclipse.platform.ide</product>
           <environmentVariables>
             <SWT_GTK3>${SWT_GTK3}</SWT_GTK3>
+            <LIBOVERLAY_SCROLLBAR>0</LIBOVERLAY_SCROLLBAR>
           </environmentVariables>
         </configuration>
       </plugin>
diff --git a/lttng/org.eclipse.tracecompass.lttng2.ust.ui.swtbot.tests/pom.xml b/lttng/org.eclipse.tracecompass.lttng2.ust.ui.swtbot.tests/pom.xml
index ad709a064e..e9d4834182 100644
--- a/lttng/org.eclipse.tracecompass.lttng2.ust.ui.swtbot.tests/pom.xml
+++ b/lttng/org.eclipse.tracecompass.lttng2.ust.ui.swtbot.tests/pom.xml
@@ -41,6 +41,7 @@
 <!-- Disable GTK3 with Luna because it makes the test hang (bug in IcedTea http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1736) -->
           <environmentVariables>
             <SWT_GTK3>${SWT_GTK3}</SWT_GTK3>
+            <LIBOVERLAY_SCROLLBAR>0</LIBOVERLAY_SCROLLBAR>
           </environmentVariables>
         </configuration>
       </plugin>
diff --git a/pcap/org.eclipse.tracecompass.tmf.pcap.ui.swtbot.tests/pom.xml b/pcap/org.eclipse.tracecompass.tmf.pcap.ui.swtbot.tests/pom.xml
index 31c6cafa30..98b6fdcbc2 100644
--- a/pcap/org.eclipse.tracecompass.tmf.pcap.ui.swtbot.tests/pom.xml
+++ b/pcap/org.eclipse.tracecompass.tmf.pcap.ui.swtbot.tests/pom.xml
@@ -39,6 +39,7 @@
           <product>org.eclipse.platform.ide</product>
           <environmentVariables>
             <SWT_GTK3>${SWT_GTK3}</SWT_GTK3>
+            <LIBOVERLAY_SCROLLBAR>0</LIBOVERLAY_SCROLLBAR>
           </environmentVariables>
         </configuration>
       </plugin>
diff --git a/releng/org.eclipse.tracecompass.alltests/pom.xml b/releng/org.eclipse.tracecompass.alltests/pom.xml
index 605e48da7b..83fc706f6e 100644
--- a/releng/org.eclipse.tracecompass.alltests/pom.xml
+++ b/releng/org.eclipse.tracecompass.alltests/pom.xml
@@ -66,6 +66,7 @@
               <product>org.eclipse.platform.ide</product>
               <environmentVariables>
                 <SWT_GTK3>${SWT_GTK3}</SWT_GTK3>
+                <LIBOVERLAY_SCROLLBAR>0</LIBOVERLAY_SCROLLBAR>
               </environmentVariables>
             </configuration>
           </plugin>
diff --git a/tmf/org.eclipse.tracecompass.tmf.remote.ui.swtbot.tests/pom.xml b/tmf/org.eclipse.tracecompass.tmf.remote.ui.swtbot.tests/pom.xml
index f90db8daef..c1e0d99410 100644
--- a/tmf/org.eclipse.tracecompass.tmf.remote.ui.swtbot.tests/pom.xml
+++ b/tmf/org.eclipse.tracecompass.tmf.remote.ui.swtbot.tests/pom.xml
@@ -39,6 +39,7 @@
           <product>org.eclipse.platform.ide</product>
           <environmentVariables>
             <SWT_GTK3>${SWT_GTK3}</SWT_GTK3>
+            <LIBOVERLAY_SCROLLBAR>0</LIBOVERLAY_SCROLLBAR>
           </environmentVariables>
         </configuration>
       </plugin>
diff --git a/tmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/pom.xml b/tmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/pom.xml
index eededa3462..4394cbeebf 100644
--- a/tmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/pom.xml
+++ b/tmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/pom.xml
@@ -39,6 +39,7 @@
           <product>org.eclipse.platform.ide</product>
           <environmentVariables>
             <SWT_GTK3>${SWT_GTK3}</SWT_GTK3>
+            <LIBOVERLAY_SCROLLBAR>0</LIBOVERLAY_SCROLLBAR>
           </environmentVariables>
         </configuration>
       </plugin>