From: Andrew Cagney <cagney@redhat.com>
Date: Wed, 29 Mar 2000 00:51:17 +0000 (+0000)
Subject: Fix various GCC warnings.
X-Git-Url: http://git.efficios.com/?a=commitdiff_plain;h=80ce1ecb70abc7e20c1e7b6db8f2ead5c603be30;p=deliverable%2Fbinutils-gdb.git

Fix various GCC warnings.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 44d8c63a08..2e333f883a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+Wed Mar 29 10:16:35 2000  Andrew Cagney  <cagney@b1.cygnus.com>
+
+	* breakpoint.h (remove_hw_watchpoints): Add declaration.
+	* breakpoints.c (remove_hw_watchpoints): Update.
+	* maint.c (maintenance_do_deprecate): Avoid assignment within IF
+ 	condition.
+
 2000-03-28  Peter Schauer  <pes@regent.e-technik.tu-muenchen.de>
 
 	breakpoint.c, breakpoint.h (remove_hw_watchpoints):  New function.
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 768a67f753..1efa23bb5a 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -1096,7 +1096,7 @@ remove_breakpoints ()
 }
 
 int
-remove_hw_watchpoints ()
+remove_hw_watchpoints (void)
 {
   register struct breakpoint *b;
   int val;
diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
index f8358a9fa1..1b4e02aa7b 100644
--- a/gdb/breakpoint.h
+++ b/gdb/breakpoint.h
@@ -693,4 +693,8 @@ extern struct breakpoint *set_breakpoint_sal PARAMS ((struct symtab_and_line));
    deletes all breakpoints. */
 extern void delete_command (char *arg, int from_tty);
 
+/* Pull all H/W watchpoints from the target. Return non-zero if the
+   remove fails. */
+extern int remove_hw_watchpoints (void);
+
 #endif /* !defined (BREAKPOINT_H) */
diff --git a/gdb/maint.c b/gdb/maint.c
index dd974b7d0d..8a8df59480 100644
--- a/gdb/maint.c
+++ b/gdb/maint.c
@@ -425,10 +425,12 @@ maintenance_do_deprecate (char *text, int deprecate)
   if (deprecate)
     {
       /* look for a replacement command */
-      if (start_ptr = strchr (text, '\"'))
+      start_ptr = strchr (text, '\"');
+      if (start_ptr != NULL)
 	{
 	  start_ptr++;
-	  if (end_ptr = strrchr (start_ptr, '\"'))
+	  end_ptr = strrchr (start_ptr, '\"');
+	  if (end_ptr != NULL)
 	    {
 	      len = end_ptr - start_ptr;
 	      start_ptr[len] = '\0';