From: Mike Frysinger <vapier@gentoo.org>
Date: Fri, 10 Dec 2010 20:42:59 +0000 (+0000)
Subject: Blackfin: bf54x: don't ack GPIO ints when unmasking them
X-Git-Url: http://git.efficios.com/?a=commitdiff_plain;h=b66acb63f5593ac11e39ab1cf17e1f987bc5ff9c;p=deliverable%2Flinux.git

Blackfin: bf54x: don't ack GPIO ints when unmasking them

When unmasking a GPIO interrupt on a BF54x part, the code will implicitly
ack any pending interrupts.  This is not what unmasking should do and can
cause people to miss interrupts from their devices, so punt the code.

Reported-by: Rutger Hofman <rutger@cs.vu.nl>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---

diff --git a/arch/blackfin/mach-common/ints-priority.c b/arch/blackfin/mach-common/ints-priority.c
index da7e3c63746b..a604f19d8dc3 100644
--- a/arch/blackfin/mach-common/ints-priority.c
+++ b/arch/blackfin/mach-common/ints-priority.c
@@ -866,7 +866,6 @@ static void bfin_gpio_unmask_irq(unsigned int irq)
 	u32 pintbit = PINT_BIT(pint_val);
 	u32 bank = PINT_2_BANK(pint_val);
 
-	pint[bank]->request = pintbit;
 	pint[bank]->mask_set = pintbit;
 }