lttng-tools.git
10 years agoRefactor JUL to agent namespace
David Goulet [Mon, 28 Jul 2014 20:06:35 +0000 (16:06 -0400)] 
Refactor JUL to agent namespace

The specific JUL concept has been removed and it is now "agent" objects.
This is the first step to support multiple agents within the same
subsystem.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoTest: Ensure wildcards may only appear last in a string literal
Jérémie Galarneau [Mon, 4 Aug 2014 18:10:28 +0000 (14:10 -0400)] 
Test: Ensure wildcards may only appear last in a string literal

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoDisallow wildcards in event names except as the last character
Jérémie Galarneau [Mon, 4 Aug 2014 18:10:29 +0000 (14:10 -0400)] 
Disallow wildcards in event names except as the last character

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoWarn that wildcards must be used as the last character in a string
Jérémie Galarneau [Mon, 4 Aug 2014 18:10:27 +0000 (14:10 -0400)] 
Warn that wildcards must be used as the last character in a string

Wildcards are currently only supported as the last character in a string
literal used in an event filter. This rule is not checked which may
confuse users who expect complete wildcard support in filter
expressions.

An error is now reported and the filter string is treated as invalid.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: disable JUL event on destroy
David Goulet [Tue, 29 Jul 2014 18:11:48 +0000 (14:11 -0400)] 
Fix: disable JUL event on destroy

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: git version build system integration (v2)
Mathieu Desnoyers [Tue, 29 Jul 2014 22:36:51 +0000 (18:36 -0400)] 
Fix: git version build system integration (v2)

Fix:
- Don't overwrite version.h if the previous content matches.
- While we are there, if we notice the previous content matches,
  print a (cached) message to show that we do not overwrite the
  content.
- Introduce LTTNG_TOOLS_BUILD_GIT_SOURCE automake conditional rather
  than compile-time define to disable the feature. It ensures we
  do not invoke "git describe" when configure --disable-git-version
  has been requested.
- Use git describe rather than git describe --long --all. Based
  on the last tag, and adds the first numbers of git revision.
  Last tag is useful both to the developer and in a bug report,
  whereas the branch name returned by --long --all is meaningless
  in a bug report.
- We want to ship version.h.tmpl in the tarball (make dist), not
  version.h which is generated. Someone could very well do a
  git init on the extracted tarball and want to have git tracking
  support.
- Fix the git prefix " - " that is incorrectly printed in some
  situations, e.g. when GIT_SOURCE was active, but we are in
  a non-git tree (or git is not available).
- Fix incorrect handling of out of tree build. Invoke git describe from
  top_srcdir.

Changelog since v1:
- Add missing comma for lttng usage output.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: out of tree build by adding missing ini.c include
Mathieu Desnoyers [Tue, 29 Jul 2014 22:10:27 +0000 (18:10 -0400)] 
Fix: out of tree build by adding missing ini.c include

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: mi: missing files on make dist
Jonathan Rajotte Julien [Tue, 29 Jul 2014 19:24:16 +0000 (15:24 -0400)] 
Fix: mi: missing files on make dist

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agomi: add machine interface description to man page
Jonathan Rajotte Julien [Tue, 29 Jul 2014 14:25:52 +0000 (10:25 -0400)] 
mi: add machine interface description to man page

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: always use git describe --all --long for the git version
David Goulet [Tue, 29 Jul 2014 15:38:44 +0000 (11:38 -0400)] 
Fix: always use git describe --all --long for the git version

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoAdd --disable-git-version to configure
David Goulet [Tue, 29 Jul 2014 15:28:51 +0000 (11:28 -0400)] 
Add --disable-git-version to configure

By default, GIT_SOURCE variable is defined to 1. The disable option
makes the configure to NOT define it.

This way, anyone not wanting the git version like for instance packager
building from the git repository, it can be used to remove it.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoAlways print GIT_VERSION even if empty
Jonathan Rajotte Julien [Mon, 28 Jul 2014 19:43:29 +0000 (15:43 -0400)] 
Always print GIT_VERSION even if empty

Adjustment from last proposed patch. Less crowded and more standard.
This should not break any packaging.

feedback?

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoFix: mi: logically dead code, missing ret assignment
Jonathan Rajotte Julien [Mon, 28 Jul 2014 19:50:28 +0000 (15:50 -0400)] 
Fix: mi: logically dead code, missing ret assignment

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoChange wfq usages for wfcq
Simon Marchi [Sat, 26 Jul 2014 05:26:56 +0000 (01:26 -0400)] 
Change wfq usages for wfcq

This removes the deprecated warnings when building lttng-tools. We can
now build with -Werror, woohoo!

This makes lttng-tools depends on userspace-rcu version 0.8.0 and above.
The configure.ac and README files have been updated for this.

Verified by running make check.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: unbalanced ustconsumer32_data.pid_mutex lock
Mathieu Desnoyers [Mon, 28 Jul 2014 00:38:50 +0000 (20:38 -0400)] 
Fix: unbalanced ustconsumer32_data.pid_mutex lock

It is never locked in this function, but should be. This is triggering
spurious runtime failures on my system, where it seems that sessiond was
sometimes breaking the communication pipe with liblttng-ctl when the
unbalanced unlock is reached.

This should be backported to stable-2.4 and stable-2.5.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoMi test: make sure to not auto load session when using lttng-sessiond
Jonathan Rajotte Julien [Mon, 28 Jul 2014 14:56:05 +0000 (10:56 -0400)] 
Mi test: make sure to not auto load session when using lttng-sessiond

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoFix: comment syntax and indentation
David Goulet [Mon, 28 Jul 2014 14:39:26 +0000 (10:39 -0400)] 
Fix: comment syntax and indentation

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: remove duplicate elements definition in mi_lttng.xsd
Jonathan Rajotte Julien [Fri, 25 Jul 2014 14:03:28 +0000 (10:03 -0400)] 
Fix: remove duplicate elements definition in mi_lttng.xsd

The presence of a *duplicate* elements can lead to ambiguity when
validating when using java validator. This is a mostly rebasing error.

10 years agoMi: fix: use GIT_VERSION inplace of FULL_NAME
Jonathan Rajotte Julien [Wed, 23 Jul 2014 18:12:14 +0000 (14:12 -0400)] 
Mi: fix: use GIT_VERSION inplace of FULL_NAME

10 years agoFix: Mi: use sub field of version struct for version string
Jonathan Rajotte Julien [Wed, 23 Jul 2014 15:33:04 +0000 (11:33 -0400)] 
Fix: Mi: use sub field of version struct for version string

10 years agoAdd test utilities to gitignore
Jonathan Rajotte Julien [Tue, 22 Jul 2014 19:31:42 +0000 (15:31 -0400)] 
Add test utilities to gitignore

10 years agoTest: Mi test suite
Jonathan Rajotte Julien [Thu, 3 Jul 2014 18:08:43 +0000 (14:08 -0400)] 
Test: Mi test suite

Test case:
enable ust event
disable ust event
list channel
list domain
list session
list ust event
start command
stop command
snapshot command

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoFix test: use local prefix for function scoped variable
Jonathan Rajotte Julien [Wed, 2 Jul 2014 21:08:19 +0000 (17:08 -0400)] 
Fix test: use local prefix for function scoped variable

This prevent unexpected behaviour when the caller function have similar
variable.

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi test: Refactoring and multiple test suites
Jonathan Rajotte Julien [Wed, 2 Jul 2014 14:12:02 +0000 (10:12 -0400)] 
Mi test: Refactoring and multiple test suites

Test for: destroy command
          basic list command
          enable_channel
          disable_channel

10 years agoFix test: add custom output redirector to utils.sh
Jonathan Rajotte Julien [Tue, 1 Jul 2014 22:17:35 +0000 (18:17 -0400)] 
Fix test: add custom output redirector to utils.sh

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi test: Basic test structure
Jonathan Rajotte Julien [Thu, 17 Jul 2014 18:34:08 +0000 (14:34 -0400)] 
Mi test: Basic test structure

Added two utils: an xml xpath extractor and xml xsd validator.

Test for session command

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoFix mi: validation for snapshot element
Jonathan Rajotte Julien [Tue, 22 Jul 2014 14:48:03 +0000 (10:48 -0400)] 
Fix mi: validation for snapshot element

10 years agoMi fix: conserve original error handling behaviour
Jonathan Rajotte Julien [Mon, 21 Jul 2014 18:19:41 +0000 (14:19 -0400)] 
Mi fix: conserve original error handling behaviour

Make sure success is put to zero when an error happens

10 years agoImprove bash completion with the use of mi and xmllint
Jonathan Rajotte Julien [Thu, 17 Jul 2014 18:13:20 +0000 (14:13 -0400)] 
Improve bash completion with the use of mi and xmllint

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoFix mi: use of wrong variable for error propagation
Jonathan Rajotte Julien [Thu, 3 Jul 2014 13:57:11 +0000 (09:57 -0400)] 
Fix mi: use of wrong variable for error propagation

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi fix: refactor disable_channel mi output to success element
Jonathan Rajotte Julien [Wed, 2 Jul 2014 19:25:33 +0000 (15:25 -0400)] 
Mi fix: refactor disable_channel mi output to success element

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoComment mi: update mi_lttng_domain todo
Jonathan Rajotte Julien [Wed, 25 Jun 2014 17:52:00 +0000 (13:52 -0400)] 
Comment mi: update mi_lttng_domain todo

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoFix mi: add support for Jul loglevel
Jonathan Rajotte Julien [Wed, 25 Jun 2014 17:34:12 +0000 (13:34 -0400)] 
Fix mi: add support for Jul loglevel

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi fix: basic formatting
Jonathan Rajotte Julien [Thu, 19 Jun 2014 21:08:29 +0000 (17:08 -0400)] 
Mi fix: basic formatting

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi disable-channel command: support and validation
Jonathan Rajotte Julien [Thu, 12 Jun 2014 19:51:13 +0000 (15:51 -0400)] 
Mi disable-channel command: support and validation

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi disable-event command: support and validation
Jonathan Rajotte Julien [Tue, 3 Jun 2014 13:56:53 +0000 (09:56 -0400)] 
Mi disable-event command: support and validation

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi set-session command: support and validation
Jonathan Rajotte Julien [Wed, 18 Jun 2014 21:26:15 +0000 (17:26 -0400)] 
Mi set-session command: support and validation

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi enable-event command: support for enable-event command
Jonathan Rajotte Julien [Wed, 18 Jun 2014 21:12:41 +0000 (17:12 -0400)] 
Mi enable-event command: support for enable-event command

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi enable-channel command: support and validation
Jonathan Rajotte Julien [Wed, 18 Jun 2014 19:49:15 +0000 (15:49 -0400)] 
Mi enable-channel command: support and validation

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi add-context command: support and validation
Jonathan Rajotte Julien [Wed, 18 Jun 2014 19:22:11 +0000 (15:22 -0400)] 
Mi add-context command: support and validation

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi calibrate command: support and validation
Jonathan Rajotte Julien [Wed, 18 Jun 2014 18:28:04 +0000 (14:28 -0400)] 
Mi calibrate command: support and validation

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi destroy command: support and validation
Jonathan Rajotte Julien [Wed, 18 Jun 2014 15:50:19 +0000 (11:50 -0400)] 
Mi destroy command: support and validation

Function destroy_session now take a session as argument. It simplifies the mi
support and give further information on the destroyed session.

Regular output is not affected but the refactoring. We could add the
supplementary information for regular printing if wanted.

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi create command: support and validation
Jonathan Rajotte Julien [Wed, 18 Jun 2014 14:44:16 +0000 (10:44 -0400)] 
Mi create command: support and validation

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi stop command: support and validation
Jonathan Rajotte Julien [Thu, 5 Jun 2014 19:50:40 +0000 (15:50 -0400)] 
Mi stop command: support and validation

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi start command: support and validation
Jonathan Rajotte Julien [Thu, 5 Jun 2014 14:27:41 +0000 (10:27 -0400)] 
Mi start command: support and validation

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi save&load command: support and validation
Jonathan Rajotte Julien [Tue, 17 Jun 2014 17:00:38 +0000 (13:00 -0400)] 
Mi save&load command: support and validation

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
10 years agoMi version command: add commit version to mi version
Jonathan Rajotte Julien [Thu, 15 May 2014 16:10:17 +0000 (12:10 -0400)] 
Mi version command: add commit version to mi version

10 years agoMi: mi xsd validation
Jonathan Rajotte [Wed, 16 Apr 2014 21:14:08 +0000 (17:14 -0400)] 
Mi: mi xsd validation

Command list and version supported

10 years agoMi: support for command list
Jonathan Rajotte [Wed, 16 Apr 2014 21:03:31 +0000 (17:03 -0400)] 
Mi: support for command list

Signed-off-by: Jonathan Rajotte <jonathan.r.julien@gmail.com>
10 years agoMi: add mi support for lttng struct
Jonathan Rajotte [Wed, 16 Apr 2014 20:08:38 +0000 (16:08 -0400)] 
Mi: add mi support for lttng struct

Add mi-lttng support to the following struct:
    lttng_domain
    lttng_channel
    lttng_channel_attr
    lttng_event
        +multiple mi utility format:
            common attribute
            tracepoint_loglevel
            tracepoint_no_loglevel
            function probe
            function entry
    lttng_event_field

mi-lttng other element
    pid element

Rebase on master:
Fix: remove extra linking due to add of mi-lttng to libcommon

10 years agoMi: mi backend + mi for command version
Jonathan Rajotte [Sun, 6 Apr 2014 19:30:32 +0000 (15:30 -0400)] 
Mi: mi backend + mi for command version

The machine interface option is now available for version. Other
commands will shortly follow. Mi backend is expected to grow with
addition of mi support to other commands.

How to use:
lttng --mi <mi_output_type> <command>

This syntax will be the same for all commands. Currently *only xml is
supported as machine interface output.*

As for errors handling, if an error/warning occurs while using mi it
will be reported on stderr as normal. The integrity of the mi output
cannot be guaranteed if an error/warning occurs. The error output format
is consistent and easy for a machine client to parse. Thus no mi output
format is required for error output.

Example:
lttng --mi xml version
Output:
<?xml version="1.0" encoding="UTF-8"?>
  <command>
    <name>version</name>
    <output>
      <string>2.4.0-rc2</string>
      <major>2</major>
      <minor>4</minor>
      <patchLevel>0</patchLevel>
      <name>Époque Opaque</name>
      <description>The Époque Opaque is a black IPA from Trou du Diable
      brewery. The nose is eerily reminiscent of the coffee crisp candy from
      of our childhood. These strong mocha accents are present on the palate,
      which are quickly subdued by Japanese and Australian hops leading to a
      final state of satisfaction enjoyable for any fan of bitter
      beer.</description>
      <url>http://lttng.org</url>
      <license>lttng is free software and under the GPL license and part
      LGPL</license>
  </output>
</command>

Signed-off-by: Olivier Cotte <olivier.cotte@polymtl.ca>
Signed-off-by: Jonathan Rajotte <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoUpdate ChangeLog with 2.4.2 and 2.5.0 release
David Goulet [Wed, 16 Jul 2014 20:23:52 +0000 (16:23 -0400)] 
Update ChangeLog with 2.4.2 and 2.5.0 release

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: validate file path creds in autoload mode
David Goulet [Wed, 16 Jul 2014 19:50:31 +0000 (15:50 -0400)] 
Fix: validate file path creds in autoload mode

Validate the credentials only when in auto load mode for the auto/
directory. The lttng load command now checks the session file creds and
validate if it's readable before trying to do so.

Thus with this, a user can load a session from the system wide directory
as long as she/he has the rights to read it.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: change session file loading order
David Goulet [Wed, 16 Jul 2014 18:02:56 +0000 (14:02 -0400)] 
Fix: change session file loading order

Libconfig now tries to load a session file from the user directory
followed by the system wide. A user session file should always
supersedes the system wide.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: add Loading Sessions section to lttng-sessiond.8
David Goulet [Wed, 16 Jul 2014 17:06:17 +0000 (13:06 -0400)] 
Fix: add Loading Sessions section to lttng-sessiond.8

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: add default session conf. dir to manpage
David Goulet [Wed, 16 Jul 2014 16:52:08 +0000 (12:52 -0400)] 
Fix: add default session conf. dir to manpage

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: on session load, add it to the .lttngrc
David Goulet [Tue, 15 Jul 2014 18:28:38 +0000 (14:28 -0400)] 
Fix: on session load, add it to the .lttngrc

Fixes #818

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: clarify session conf. directory in man
David Goulet [Tue, 15 Jul 2014 18:21:56 +0000 (14:21 -0400)] 
Fix: clarify session conf. directory in man

Fixes #817

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: filter error path could free invalid ptr
David Goulet [Tue, 15 Jul 2014 13:16:54 +0000 (09:16 -0400)] 
Fix: filter error path could free invalid ptr

Also add a check for a NULL pointer when freeing the filter bytecode so
we don't deref an invalid ptr.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: Create a lock file to prevent multiple session daemons
Jérémie Galarneau [Mon, 14 Jul 2014 18:57:10 +0000 (14:57 -0400)] 
Fix: Create a lock file to prevent multiple session daemons

A lock file is used to ensure that only one session daemon per UID is
running on the system. The lock file is created in the rundir.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: relayd stream set close_flag on stream close
David Goulet [Mon, 14 Jul 2014 20:37:05 +0000 (16:37 -0400)] 
Fix: relayd stream set close_flag on stream close

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: ustctl_get_stream_id without UST support
David Goulet [Mon, 14 Jul 2014 19:49:02 +0000 (15:49 -0400)] 
Fix: ustctl_get_stream_id without UST support

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: avoid freeing invalid ptr in filter bytecode
David Goulet [Mon, 14 Jul 2014 18:32:10 +0000 (14:32 -0400)] 
Fix: avoid freeing invalid ptr in filter bytecode

Reported-by: Jonathan Rajotte <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: get the stream_id when generating live beacons
Julien Desfossez [Mon, 14 Jul 2014 18:05:48 +0000 (14:05 -0400)] 
Fix: get the stream_id when generating live beacons

When we send an empty index (beacon), we need to extract the stream_id
to avoid stalling the client on inactive streams on startup.
Since the live clients need to know this feature is implemented, we had
to bump the lttng-live protocol version.

This fix should be backported to stable-2.4 as well.

Refs: #811

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
10 years agoFix: use biggest subbuffer size for snapshot max-size
David Goulet [Wed, 9 Jul 2014 19:24:04 +0000 (15:24 -0400)] 
Fix: use biggest subbuffer size for snapshot max-size

Instead of using the output max size divided by the total amount of
streams in the session, we find the largest subbuffer in the session's
channels. Using that value, we multiply it by the total amount of
streams which gives us the lower limit of the snapshot size. That is
enough to make sure that we can take the snapshot or not.

Once done, the max stream size possible used for the snapshot record is
the largest subbuffer size in the session. This is to make sure that
every channel can extract the same amount of data which ensure fairness
between each channel in the session.

Fixes #783

Acked-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: Possible memory leak when multiple config files are loaded
Jérémie Galarneau [Fri, 11 Jul 2014 19:22:18 +0000 (15:22 -0400)] 
Fix: Possible memory leak when multiple config files are loaded

Some configuration options could leak when initialized multiple times
from different configuration files and from the command line arguments.
The previous options are now freed' before being set.

Fixes #796

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: Clamp verbosity value read from config file
Jérémie Galarneau [Thu, 10 Jul 2014 21:41:08 +0000 (17:41 -0400)] 
Fix: Clamp verbosity value read from config file

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: Unchecked strdup return values in set_option
Jérémie Galarneau [Thu, 10 Jul 2014 21:04:19 +0000 (17:04 -0400)] 
Fix: Unchecked strdup return values in set_option

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: add a get HOME dir fallback to getpwuid
David Goulet [Thu, 10 Jul 2014 20:02:02 +0000 (16:02 -0400)] 
Fix: add a get HOME dir fallback to getpwuid

If the $HOME or $LTTNG_HOME is not defined, fallback on getpwuid(3) of
the process uid.

Fixes #815

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: signedness of the session live timer
David Goulet [Thu, 10 Jul 2014 19:45:02 +0000 (15:45 -0400)] 
Fix: signedness of the session live timer

Fixes #806

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: don't print channel name on enable JUL event
David Goulet [Thu, 10 Jul 2014 19:40:36 +0000 (15:40 -0400)] 
Fix: don't print channel name on enable JUL event

Fixes #802

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: logger name dropped from filter condition when loglevels are used
Jérémie Galarneau [Thu, 10 Jul 2014 18:24:59 +0000 (14:24 -0400)] 
Fix: logger name dropped from filter condition when loglevels are used

This fix ensures that the loglevel expression is appended to the filter
expression and does not overwrite the current one.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: refactor function that fixes memory leak also
David Goulet [Thu, 10 Jul 2014 17:04:24 +0000 (13:04 -0400)] 
Fix: refactor function that fixes memory leak also

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: memory leak in lttng_enable_event_with_exclusions
Jérémie Galarneau [Wed, 9 Jul 2014 22:20:03 +0000 (18:20 -0400)] 
Fix: memory leak in lttng_enable_event_with_exclusions

lttng_enable_event_with_exclusions leaks a filter expression when
automatically generated filter statements are used. This happens when
loglevel and logger name filtering are used when enabling JUL events.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: check malloc return value
Jérémie Galarneau [Fri, 4 Jul 2014 19:33:49 +0000 (15:33 -0400)] 
Fix: check malloc return value

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: static array larger than necessary
Jérémie Galarneau [Fri, 4 Jul 2014 19:28:42 +0000 (15:28 -0400)] 
Fix: static array larger than necessary

The longest string that can be returned should be 20 chars long, as per
the comment.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: add missing URCU_TLS to logging time variable
Martin Townsend [Wed, 9 Jul 2014 20:46:54 +0000 (16:46 -0400)] 
Fix: add missing URCU_TLS to logging time variable

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: auto load session in the auto/ directory
David Goulet [Thu, 26 Jun 2014 19:41:42 +0000 (15:41 -0400)] 
Fix: auto load session in the auto/ directory

The session daemon will now automatically load sessions from the auto/
directory in the session config path. Both system config path and home
config path are used. The session is only loaded if the UID of the
session file matches the UID of the session daemon (or root).

For that, a autoload parameter has been added to the
config_load_session() function to indicate that we want to auto load
sessions.

Fixes #812

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoUpdate version to v2.5.0-rc2
David Goulet [Fri, 27 Jun 2014 14:38:10 +0000 (10:38 -0400)] 
Update version to v2.5.0-rc2

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoTest: add JUL disable event tests
David Goulet [Wed, 18 Jun 2014 13:11:19 +0000 (09:11 -0400)] 
Test: add JUL disable event tests

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: disable JUL event on UST side
David Goulet [Tue, 17 Jun 2014 19:42:39 +0000 (15:42 -0400)] 
Fix: disable JUL event on UST side

With the new root logger patch in liblttng-ust-jul, we have to disable
the JUL logger on the UST tracer side for the multi session support.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: add test UST perf to extra dist
David Goulet [Fri, 27 Jun 2014 14:18:48 +0000 (10:18 -0400)] 
Fix: add test UST perf to extra dist

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: accept override flag even without a load path
David Goulet [Thu, 26 Jun 2014 17:56:13 +0000 (13:56 -0400)] 
Fix: accept override flag even without a load path

Part of the bug #807 have been fixed also by the previous commit.

Fixes #807

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: bad error code path when loading session
David Goulet [Thu, 26 Jun 2014 17:32:39 +0000 (13:32 -0400)] 
Fix: bad error code path when loading session

Fixes #810

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: set session in output mode if URL are set afterwards
David Goulet [Wed, 25 Jun 2014 20:35:54 +0000 (16:35 -0400)] 
Fix: set session in output mode if URL are set afterwards

Fixes #809

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: add a kernel context list to the channel
David Goulet [Wed, 25 Jun 2014 19:42:15 +0000 (15:42 -0400)] 
Fix: add a kernel context list to the channel

The internal state of the session daemon was recording only one context
per channel thus overwriting the previous one if multiple context were
added causing a memory leak.

This commit adds a list inside a kernel channel which keeps track of all
context added. It also fixes the save command that now saves all of
them.

Fixes #205

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: Add vpid, vppid and vtid info in add-context help
Francis Deslauriers [Thu, 19 Jun 2014 02:19:40 +0000 (22:19 -0400)] 
Fix: Add vpid, vppid and vtid info in add-context help

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: wrong behavior of save command when no session name is provided
Jonathan Rajotte Julien [Tue, 17 Jun 2014 19:59:41 +0000 (15:59 -0400)] 
Fix: wrong behavior of save command when no session name is provided

No session name and no option --all should default to --all.

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: missing context type string in save for ust context
Jonathan Rajotte Julien [Mon, 9 Jun 2014 19:45:39 +0000 (15:45 -0400)] 
Fix: missing context type string in save for ust context

Return string for LTTNG_UST_CONTEXT_PERF_THREAD_COUNTER was missing and
caused an error on save when a context of PERF_THREAD_COUNTER type was
present (Error: Invalid parameter).

Fixes #804

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: wrong casting of return value
Jonathan Rajotte Julien [Mon, 9 Jun 2014 15:40:36 +0000 (11:40 -0400)] 
Fix: wrong casting of return value

The function uri_parse_str_urls return a ssize_t and the return was
casted to a size_t. This caused the following error checking to fail as
-1 was interpreted as 18446744073709551615.

Fixes #803

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: add dependency to libcommon for python binding
Paul Woegerer [Thu, 5 Jun 2014 10:39:48 +0000 (12:39 +0200)] 
Fix: add dependency to libcommon for python binding

This patch adds the missing dependency to libcommon that contains the
definition of log_add_time.

Signed-off-by: Paul Woegerer <paul_woegerer@mentor.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: remove the default GIT_VERSION
Raphaël Beamonte [Tue, 3 Jun 2014 18:30:09 +0000 (14:30 -0400)] 
Fix: remove the default GIT_VERSION

This is to allow different version control other than git.

Tested-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoUpdate version to v2.5.0-rc1
David Goulet [Wed, 28 May 2014 15:21:36 +0000 (11:21 -0400)] 
Update version to v2.5.0-rc1

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoAdd missing test files to EXTRA_DIST
David Goulet [Wed, 28 May 2014 15:04:09 +0000 (11:04 -0400)] 
Add missing test files to EXTRA_DIST

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoAdd hidden attribute to some common functions
David Goulet [Wed, 28 May 2014 14:56:12 +0000 (10:56 -0400)] 
Add hidden attribute to some common functions

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoAdd the load session API call
David Goulet [Wed, 28 May 2014 14:52:16 +0000 (10:52 -0400)] 
Add the load session API call

Introduce lttng_load_session(attr) and some setter/getter for the
attribute object.

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoFix: alignment problems on targets not supporting unaligned access.
Fredrik Markström [Fri, 16 May 2014 01:10:07 +0000 (09:10 +0800)] 
Fix: alignment problems on targets not supporting unaligned access.

Accessing floats, doubles and 64 bit int at unaligned addresses is not
supported on all configurations of arm processors and if it is it's
emulated and slow. This patch replaces direct assignments with memcpy.

Signed-off-by: Fredrik Markström <fredrik.markstrom@gmail.com>
Signed-off-by: Roy Li <rongqing.li@windriver.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoAdd gen-ust-tracef binary to gitignore
David Goulet [Tue, 27 May 2014 20:34:01 +0000 (16:34 -0400)] 
Add gen-ust-tracef binary to gitignore

Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoImplement test_event_tracef
Mathieu Desnoyers [Tue, 27 May 2014 20:25:26 +0000 (16:25 -0400)] 
Implement test_event_tracef

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
10 years agoImplement tracef test application "gen-ust-tracef"
Mathieu Desnoyers [Tue, 27 May 2014 20:25:25 +0000 (16:25 -0400)] 
Implement tracef test application "gen-ust-tracef"

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
This page took 0.04453 seconds and 5 git commands to generate.