deliverable/lttng-tools.git
7 years agoChange trace_path to session_root_path and chunk_path
Julien Desfossez [Mon, 24 Jul 2017 20:01:30 +0000 (16:01 -0400)] 
Change trace_path to session_root_path and chunk_path

Prepare for the trace rotation feature where we need to store the root
path of the session and create a subdirectory for each chunk of trace.
For now, the chunk_path is \0, so the behaviour does not change.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoFix: path of snapshots with a relay and default URI
Julien Desfossez [Tue, 29 Aug 2017 18:52:59 +0000 (14:52 -0400)] 
Fix: path of snapshots with a relay and default URI

When recording a snapshot to a relay without custom URI (ex:
net://localhost vs net://localhost/custom), the snapshots end up being
stored in ~/lttng-traces/<hostname>/snapshot-XXX instead of being inside
the <session-name> folder like on local snapshots. We would expect the
path to be: ~/lttng-traces/<hostname>/<session-name>/snapshot-XXX

So there is a discrepancy between the local and remote behaviour. This
behaviour has been there since at least v2.6, maybe earlier.

Moreover, there is nothing that informs the user about the default
snapshot name, so it is not possible to know where a snapshot has been
stored.

After parsing the URI provided by the user, we now check if a custom
name was provided or copy the session name there. This is the same
operation performed in _lttng_create_session_ext.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoFix: wrong use of the relay_streams_sent in snapshot
Julien Desfossez [Wed, 23 Aug 2017 20:38:20 +0000 (16:38 -0400)] 
Fix: wrong use of the relay_streams_sent in snapshot

The relay_streams_sent message is only useful in live sessions and
should only be sent after all the streams of a channel have been sent.

Here we were sending this message every time we sent a stream to the
relay during a snapshot which makes no sense.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoFix: the return code of lttcomm_send_unix_sock is signed
Julien Desfossez [Wed, 23 Aug 2017 20:08:42 +0000 (16:08 -0400)] 
Fix: the return code of lttcomm_send_unix_sock is signed

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
Julien Desfossez [Mon, 7 Aug 2017 20:43:29 +0000 (16:43 -0400)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

7 years agoUpdate version to 2.11.0-pre
Jérémie Galarneau [Mon, 7 Aug 2017 20:07:53 +0000 (16:07 -0400)] 
Update version to 2.11.0-pre

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
Julien Desfossez [Mon, 7 Aug 2017 14:18:35 +0000 (10:18 -0400)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

7 years agoTypo: occured -> occurred
Michael Jeanson [Wed, 2 Aug 2017 18:26:18 +0000 (14:26 -0400)] 
Typo: occured -> occurred

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: ensure kernel context is in a list before trying to delete it
Jérémie Galarneau [Wed, 2 Aug 2017 20:49:44 +0000 (16:49 -0400)] 
Fix: ensure kernel context is in a list before trying to delete it

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoHarmonize return code conventions in context handling
Jérémie Galarneau [Wed, 2 Aug 2017 19:24:00 +0000 (15:24 -0400)] 
Harmonize return code conventions in context handling

7 years agoFix: uninitialized return value on error path
Mathieu Desnoyers [Wed, 2 Aug 2017 15:34:43 +0000 (11:34 -0400)] 
Fix: uninitialized return value on error path

Found by Coverity:

*** CID 1378810:  Uninitialized variables  (UNINIT)
/src/bin/lttng-sessiond/context.c: 73 in add_kctx_all_channels()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agolttng enable-channel: disallow --overwrite and --blocking-timeout
Philippe Proulx [Fri, 28 Jul 2017 20:36:48 +0000 (16:36 -0400)] 
lttng enable-channel: disallow --overwrite and --blocking-timeout

The overwrite mode has no impact on LTTng-UST when there's a set
blocking timeout.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agolttng-enable-channel(1): reword --blocking-timeout, document in description
Philippe Proulx [Fri, 28 Jul 2017 20:30:42 +0000 (16:30 -0400)] 
lttng-enable-channel(1): reword --blocking-timeout, document in description

Also change the synopsis so that you can specify --blocking-timeout,
--overwrite, or none, but not both.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agolttng enable-channel: --blocking-timeout opt.: use `inf` instead of -1
Philippe Proulx [Fri, 28 Jul 2017 19:48:32 +0000 (15:48 -0400)] 
lttng enable-channel: --blocking-timeout opt.: use `inf` instead of -1

It might be -1 for the API, but for a command-line interface used by
humans, `inf` is more meaningful than -1.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove unused internal structure
Julien Desfossez [Fri, 28 Jul 2017 18:15:40 +0000 (14:15 -0400)] 
Cleanup: remove unused internal structure

There is TODO to add content to lttcomm_relayd_update_sync_info
since 2012 (commit 173af62f4804133d4a7f45e34b6f72126f3eca5f),
the intent is really not clear and this is never going to
happen, let's remove it.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove unnecessary extern qualifier
Jérémie Galarneau [Tue, 1 Aug 2017 18:53:25 +0000 (14:53 -0400)] 
Cleanup: remove unnecessary extern qualifier

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: document the trigger API
Jérémie Galarneau [Tue, 1 Aug 2017 18:52:57 +0000 (14:52 -0400)] 
Docs: document the trigger API

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: document the notification API
Jérémie Galarneau [Tue, 1 Aug 2017 18:29:02 +0000 (14:29 -0400)] 
Docs: document the notification API

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: document the notification channel API
Jérémie Galarneau [Tue, 1 Aug 2017 18:23:43 +0000 (14:23 -0400)] 
Docs: document the notification channel API

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: document the evaluation API
Jérémie Galarneau [Tue, 1 Aug 2017 17:57:39 +0000 (13:57 -0400)] 
Docs: document the evaluation API

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: document the lttng_condition API
Jérémie Galarneau [Tue, 1 Aug 2017 16:25:57 +0000 (12:25 -0400)] 
Docs: document the lttng_condition API

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: document the lttng_buffer_usage condition API
Jérémie Galarneau [Mon, 31 Jul 2017 18:58:18 +0000 (14:58 -0400)] 
Docs: document the lttng_buffer_usage condition API

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: document the lttng_action_notify action type
Jérémie Galarneau [Mon, 31 Jul 2017 18:08:19 +0000 (14:08 -0400)] 
Docs: document the lttng_action_notify action type

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: document the lttng_action API
Jérémie Galarneau [Mon, 31 Jul 2017 18:07:59 +0000 (14:07 -0400)] 
Docs: document the lttng_action API

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: ambiguous ownership of kernel context by multiple channels
Jérémie Galarneau [Mon, 31 Jul 2017 21:51:35 +0000 (17:51 -0400)] 
Fix: ambiguous ownership of kernel context by multiple channels

A kernel context, when added to multiple channels, must be copied
before being added to individual channels. The current code
adds the same ltt_kernel_context structure to multiple kernel
channels which introduces a conceptual ambiguity in the ownership
of the context object.

Concretely, creating multiple kernel channels and adding a context
to all of them (by not specifying a channel name) causes the context
to be added to each channels' list of contexts, overwritting the
context's list node, and causing the channel context lists to become
corrupted. This results in crashes being observed during the
destruction of the session.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agolttng-enable-channel(1): move --output description to maintain A-Z ordering
Philippe Proulx [Mon, 31 Jul 2017 18:09:44 +0000 (14:09 -0400)] 
lttng-enable-channel(1): move --output description to maintain A-Z ordering

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agolttng-enable-channel(1): document --monitor-timer
Philippe Proulx [Mon, 31 Jul 2017 18:08:28 +0000 (14:08 -0400)] 
lttng-enable-channel(1): document --monitor-timer

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoPrettify channel listing
Jérémie Galarneau [Fri, 28 Jul 2017 21:00:07 +0000 (17:00 -0400)] 
Prettify channel listing

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoUse pipe instead of eventfd() for notification command queue
Jonathan Rajotte [Thu, 27 Jul 2017 22:39:45 +0000 (18:39 -0400)] 
Use pipe instead of eventfd() for notification command queue

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoRemove unused structure
Julien Desfossez [Fri, 28 Jul 2017 18:12:32 +0000 (14:12 -0400)] 
Remove unused structure

There is TODO to add content to this structure since 2012 (commit
173af62f4804133d4a7f45e34b6f72126f3eca5f), the intent is really not
clear and this is never going to happen, let's remove it.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
Julien Desfossez [Fri, 28 Jul 2017 18:11:59 +0000 (14:11 -0400)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

7 years agoCleanup: useless reset of ret to zero
Jonathan Rajotte [Wed, 26 Jul 2017 14:53:53 +0000 (10:53 -0400)] 
Cleanup: useless reset of ret to zero

ret is overwritten in the normal code flow.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: ret is never used on error_open code path
Jonathan Rajotte [Wed, 26 Jul 2017 14:52:15 +0000 (10:52 -0400)] 
Fix: ret is never used on error_open code path

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: use error code path instead of break when errors happen before execl
Jonathan Rajotte [Wed, 26 Jul 2017 14:29:17 +0000 (10:29 -0400)] 
Fix: use error code path instead of break when errors happen before execl

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: ignore useless check of execl() return value
Jonathan Rajotte [Tue, 25 Jul 2017 21:56:58 +0000 (17:56 -0400)] 
Cleanup: ignore useless check of execl() return value

execl only return if there is an error. errno is handled hence no need
to consider the return value which would always be -1.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: wrong variable assignment on error
Jonathan Rajotte [Tue, 25 Jul 2017 21:46:47 +0000 (17:46 -0400)] 
Fix: wrong variable assignment on error

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove dead increment of pointer
Jonathan Rajotte [Tue, 25 Jul 2017 21:43:58 +0000 (17:43 -0400)] 
Cleanup: remove dead increment of pointer

No further memcpy is performed no need to increment the pointer.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: missing error handling in use of print_tabs()
Jonathan Rajotte [Tue, 25 Jul 2017 21:20:45 +0000 (17:20 -0400)] 
Fix: missing error handling in use of print_tabs()

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: functions shall have a single exit point
Jonathan Rajotte [Tue, 25 Jul 2017 21:12:31 +0000 (17:12 -0400)] 
Cleanup: functions shall have a single exit point

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove dead assignment
Jonathan Rajotte [Tue, 25 Jul 2017 20:57:50 +0000 (16:57 -0400)] 
Cleanup: remove dead assignment

Only handle cases where the returned error is not EEXIST. ret is
overwritten anyway.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove dead assignment
Jonathan Rajotte [Tue, 25 Jul 2017 20:29:53 +0000 (16:29 -0400)] 
Cleanup: remove dead assignment

ret is not used when jumping to error_no_alloc.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove dead assignment
Jonathan Rajotte [Tue, 25 Jul 2017 20:26:25 +0000 (16:26 -0400)] 
Cleanup: remove dead assignment

Both calling sites do not use the return value and errors are already
managed inside the called function.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove dead assignment
Jonathan Rajotte [Tue, 25 Jul 2017 19:55:31 +0000 (15:55 -0400)] 
Cleanup: remove dead assignment

Artifact of refactor done in f8f3885cc52af9d3c951da78989d6f4a25270411

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove dead assignment
Jonathan Rajotte [Tue, 25 Jul 2017 19:51:34 +0000 (15:51 -0400)] 
Cleanup: remove dead assignment

ret is not used for further error propagation.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove dead assignment
Jonathan Rajotte [Tue, 25 Jul 2017 18:11:02 +0000 (14:11 -0400)] 
Cleanup: remove dead assignment

ret is overwritten no need to reset it.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove dead assignment
Jonathan Rajotte [Tue, 25 Jul 2017 18:07:30 +0000 (14:07 -0400)] 
Cleanup: remove dead assignment

ret is always overwritten hence assign a value here is not necessary.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove dead assignment
Jonathan Rajotte [Tue, 25 Jul 2017 18:05:17 +0000 (14:05 -0400)] 
Cleanup: remove dead assignment

ret is never used in error code path.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove dead assignment
Jonathan Rajotte [Tue, 25 Jul 2017 18:03:36 +0000 (14:03 -0400)] 
Cleanup: remove dead assignment

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: dead assignment
Jonathan Rajotte [Tue, 25 Jul 2017 18:01:48 +0000 (14:01 -0400)] 
Cleanup: dead assignment

ret is never used for error, use err instead.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: ret is used instead or err to set an error code
Jonathan Rajotte [Tue, 25 Jul 2017 15:31:02 +0000 (11:31 -0400)] 
Fix: ret is used instead or err to set an error code

Use err instead of ret. ret is never used for error reporting under
error label.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove dead assignment
Jonathan Rajotte [Tue, 25 Jul 2017 15:14:55 +0000 (11:14 -0400)] 
Cleanup: remove dead assignment

Artifact of refactoring done in f8f3885cc52af9d3c951da78989d6f4a25270411

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove dead assignment
Jonathan Rajotte [Tue, 25 Jul 2017 14:54:48 +0000 (10:54 -0400)] 
Cleanup: remove dead assignment

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: report error using fd instead of ret
Jonathan Rajotte [Tue, 25 Jul 2017 14:45:32 +0000 (10:45 -0400)] 
Fix: report error using fd instead of ret

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agolttng-enable-channel(1): reword and fix style of --blocking-timeout description
Philippe Proulx [Tue, 25 Jul 2017 01:42:49 +0000 (21:42 -0400)] 
lttng-enable-channel(1): reword and fix style of --blocking-timeout description

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: doc/man: use a single XSL file and match local names
Philippe Proulx [Tue, 25 Jul 2017 01:36:36 +0000 (21:36 -0400)] 
Fix: doc/man: use a single XSL file and match local names

Matching the local name instead of the full name, that is:

   *[local-name() = 'co']

instead of just `co` matches both the non-namespaced element and
the DocBook-namespaced element whether we're using the DocBook 4.5 or
DocBook 5.0 stylesheets.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoTests: rework select_poll_epoll test to improve verbosity on failure
Francis Deslauriers [Mon, 12 Jun 2017 16:13:23 +0000 (12:13 -0400)] 
Tests: rework select_poll_epoll test to improve verbosity on failure

Prints the tested values that caused a test failure to ease the
troubleshooting of unreliable tests.
Also, clean-up unused variables in multiple testcases.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoOnly print relevant session statistics on stop
Jérémie Galarneau [Fri, 28 Jul 2017 15:26:09 +0000 (11:26 -0400)] 
Only print relevant session statistics on stop

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: NULL passed to memcpy in error path
Jérémie Galarneau [Fri, 28 Jul 2017 14:59:30 +0000 (10:59 -0400)] 
Fix: NULL passed to memcpy in error path

CID 1378708:  Null pointer dereferences  (FORWARD_NULL)
Passing null pointer "data" to "memcpy", which dereferences it.

Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoOnly print relevant session statistics in channel listing
Jérémie Galarneau [Fri, 28 Jul 2017 14:42:46 +0000 (10:42 -0400)] 
Only print relevant session statistics in channel listing

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoUniformize the printing of units in session listing
Jérémie Galarneau [Thu, 27 Jul 2017 21:55:14 +0000 (17:55 -0400)] 
Uniformize the printing of units in session listing

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: lost packet accounting always lost on snapshot
Julien Desfossez [Tue, 25 Jul 2017 19:23:49 +0000 (15:23 -0400)] 
Fix: lost packet accounting always lost on snapshot

Because of the continue when we fail to get a subbuff, the lost_packet
count is always reset to 0 before we can account it in the channel. Now
we account it directly before the continue.

Reported-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: report error on session listing
Jonathan Rajotte [Fri, 21 Jul 2017 15:09:14 +0000 (11:09 -0400)] 
Fix: report error on session listing

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoTests: don't assume a 4K page size in test_notification
Jérémie Galarneau [Thu, 27 Jul 2017 20:48:44 +0000 (16:48 -0400)] 
Tests: don't assume a 4K page size in test_notification

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix live-comm: merge TCP socket write-write sequence in a single write
Jonathan Rajotte [Mon, 24 Jul 2017 20:07:00 +0000 (16:07 -0400)] 
Fix live-comm: merge TCP socket write-write sequence in a single write

The live protocol implementation is often sending content
on TCP sockets in two separate writes. One to send a command header,
and the second one sending the command's payload. This was presumably
done under the assumption that it would not result in two separate
TCP packets being sent on the network (or that it would not matter).

Delayed ACK-induced delays were observed [1] on the second write of the
"write header, write payload" sequence and result in problematic
latency build-ups for live clients connected to moderately/highly
active sessions.

Fundamentaly, this problem arises due to the combination of Nagle's
algorithm and the delayed ACK mechanism which make write-write-read
sequences on TCP sockets problematic as near-constant latency is
expected when clients can keep-up with the event production rate.

In such a write-write-read sequence, the second write is held up until
the first write is acknowledged (TCP ACK). The solution implemented
by this patch bundles the writes into a single one [2].

[1] https://github.com/tbricks/wireshark-lttng-plugin
    Basic Wireshark dissector for lttng-live by Anto Smyk from Itiviti
[2] https://lists.freebsd.org/pipermail/freebsd-net/2006-January/009527.html

Reported-by: Anton Smyk <anton.smyk@itiviti.com>
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: move notification thread documentation to header
Jérémie Galarneau [Wed, 26 Jul 2017 18:46:35 +0000 (14:46 -0400)] 
Docs: move notification thread documentation to header

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDocs: grammar fix in comment
Jérémie Galarneau [Wed, 26 Jul 2017 18:46:09 +0000 (14:46 -0400)] 
Docs: grammar fix in comment

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: evaluate condition/trigger on subscription
Jonathan Rajotte [Tue, 4 Jul 2017 18:58:43 +0000 (14:58 -0400)] 
Fix: evaluate condition/trigger on subscription

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoTest: Trigger conditions is evaluated on subscription
Jonathan Rajotte [Tue, 4 Jul 2017 18:58:42 +0000 (14:58 -0400)] 
Test: Trigger conditions is evaluated on subscription

It is expected that on subscription a trigger condition is evaluated and
the trigger fired if necessary. Currently evaluation is performed on
channel sampling and result in action only if the evaluation state flip.

This test hang if no evaluation is performed on notification client
subscription.

Ref #1102

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agosave/load: add blocking_timeout attribute to channel
Jonathan Rajotte [Thu, 6 Jul 2017 15:08:43 +0000 (11:08 -0400)] 
save/load: add blocking_timeout attribute to channel

Fixes #1119

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoIntroduce monitor_timer_interval to session configuration schema
Jonathan Rajotte [Thu, 6 Jul 2017 15:08:42 +0000 (11:08 -0400)] 
Introduce monitor_timer_interval to session configuration schema

Session configuration schema version is bumped to 2.10

Fixes #1099

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
Julien Desfossez [Mon, 24 Jul 2017 20:22:18 +0000 (16:22 -0400)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

7 years agoTest: Reduce scope of variables used in multi app notification test
Jonathan Rajotte [Tue, 4 Jul 2017 18:58:41 +0000 (14:58 -0400)] 
Test: Reduce scope of variables used in multi app notification test

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
Julien Desfossez [Tue, 27 Jun 2017 14:43:29 +0000 (10:43 -0400)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

7 years agoHide internal buffer-view symbols
Jérémie Galarneau [Wed, 21 Jun 2017 13:36:05 +0000 (09:36 -0400)] 
Hide internal buffer-view symbols

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoHide internal session configuration symbols
Jérémie Galarneau [Wed, 21 Jun 2017 13:35:47 +0000 (09:35 -0400)] 
Hide internal session configuration symbols

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoHide internal dynamic-buffer symbols
Jérémie Galarneau [Wed, 21 Jun 2017 13:35:29 +0000 (09:35 -0400)] 
Hide internal dynamic-buffer symbols

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoHide internal string-utils symbols
Jérémie Galarneau [Wed, 21 Jun 2017 13:35:12 +0000 (09:35 -0400)] 
Hide internal string-utils symbols

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoTypo: occured -> occurred
Michael Jeanson [Fri, 16 Jun 2017 18:09:21 +0000 (14:09 -0400)] 
Typo: occured -> occurred

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: join consumer timer thread
Mathieu Desnoyers [Fri, 16 Jun 2017 21:23:13 +0000 (17:23 -0400)] 
Fix: join consumer timer thread

Detaching the timer thread has the unfortunate side-effect of letting
the health management data structures be freed by main() while the timer
thread may still be using them (if, e.g., main() exits quickly).

Overcome this situation by tearing down and joining the timer thread.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: use CMM accessors for consumer_quit variable
Mathieu Desnoyers [Fri, 16 Jun 2017 21:23:12 +0000 (17:23 -0400)] 
Cleanup: use CMM accessors for consumer_quit variable

Use CMM_LOAD_SHARED and CMM_STORE_SHARED, which are strictly
equivalent to a volatile variable, in line with the rest of the
lttng-tools project.

Also move its declaration to a header, rather than having multiple
declarations in C files, now following our coding style.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: test_utils_expand_path passes NULL to sprintf
Jérémie Galarneau [Tue, 13 Jun 2017 18:50:05 +0000 (14:50 -0400)] 
Fix: test_utils_expand_path passes NULL to sprintf

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: reject triggers if they depend on an unavailable feature
Jérémie Galarneau [Tue, 13 Jun 2017 18:49:32 +0000 (14:49 -0400)] 
Fix: reject triggers if they depend on an unavailable feature

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: check lttng-modules ABI version for RING_BUFFER_SNAPSHOT_SAMPLE_POSITIONS support
Jonathan Rajotte [Mon, 15 May 2017 19:37:21 +0000 (15:37 -0400)] 
Fix: check lttng-modules ABI version for RING_BUFFER_SNAPSHOT_SAMPLE_POSITIONS support

The RING_BUFFER_SNAPSHOT_SAMPLE_POSITIONS was introduced in
lttng-modules ABI version 2.3. When interacting with a kernel tracer
with ABI versions < 2.3, pass zero as monitor_timer_interval to disable
the monitoring.

Warn during sessiond startup and channel enabling if not supported.

Fixes #1101

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: Send remove channel to notification thread only when necessary
Jonathan Rajotte [Tue, 16 May 2017 20:55:56 +0000 (16:55 -0400)] 
Fix: Send remove channel to notification thread only when necessary

v2: missing "channel" in commit title.

Keep the publishing state to the notification thread of the channel
object. Issue remove command if the channel was previously
published.

Fixes #1103

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: notification test: resources leak and return handling
Jonathan Rajotte [Fri, 2 Jun 2017 18:52:30 +0000 (14:52 -0400)] 
Fix: notification test: resources leak and return handling

Fixes CID #137591313759121375911 1375910 1375909 1375908

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: parse monitor timer parameter as an unsigned 64-bit integer
Jérémie Galarneau [Mon, 12 Jun 2017 21:56:01 +0000 (17:56 -0400)] 
Fix: parse monitor timer parameter as an unsigned 64-bit integer

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoIntroduce "--blocking-timeout" channel parameter
Mathieu Desnoyers [Sat, 27 May 2017 06:17:39 +0000 (08:17 +0200)] 
Introduce "--blocking-timeout" channel parameter

Introduce the blocking timeout channel parameter to control blocking
behavior for lttng-ust buffers. It only affects applications launched
with the LTTNG_UST_ALLOW_BLOCKING environment variable.

The blocking timeout parameter expects:

- 0 (default) which does not block,
- a timeout value in usec,
- -1 (block forever).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: lttng list of channels should return errors
Mathieu Desnoyers [Fri, 26 May 2017 16:14:19 +0000 (18:14 +0200)] 
Fix: lttng list of channels should return errors

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: discard event/lost packet counters
Mathieu Desnoyers [Fri, 26 May 2017 16:14:18 +0000 (18:14 +0200)] 
Fix: discard event/lost packet counters

For per-pid buffers, we need to sum the counters for each application.

For per-uid buffers, if no application has launched yet, it should not
be considered as an error (which stops iteration on all other channels),
but rather as values of 0.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: test: proper redirection of stderr to stdout
Jonathan Rajotte [Thu, 1 Jun 2017 22:16:46 +0000 (18:16 -0400)] 
Fix: test: proper redirection of stderr to stdout

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
Julien Desfossez [Fri, 9 Jun 2017 15:48:13 +0000 (11:48 -0400)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

7 years agoDocs: notification comment refers to a structure by its former name
Jérémie Galarneau [Tue, 6 Jun 2017 16:01:02 +0000 (12:01 -0400)] 
Docs: notification comment refers to a structure by its former name

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoFix: missing errno.h include in time.h compat header
Jérémie Galarneau [Fri, 2 Jun 2017 18:49:20 +0000 (14:49 -0400)] 
Fix: missing errno.h include in time.h compat header

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove stale file from .gitignore
Jérémie Galarneau [Thu, 1 Jun 2017 20:47:12 +0000 (16:47 -0400)] 
Cleanup: remove stale file from .gitignore

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoDisable binaries on platforms where they are not supported
Michael Jeanson [Wed, 24 May 2017 17:38:08 +0000 (13:38 -0400)] 
Disable binaries on platforms where they are not supported

They can still be enabled with the appropriate configure flag like
--enable-bin-lttng

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: add silent rules support for docs
Michael Jeanson [Fri, 12 May 2017 19:30:09 +0000 (15:30 -0400)] 
Cleanup: add silent rules support for docs

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: popt library detection
Michael Jeanson [Fri, 12 May 2017 16:07:40 +0000 (12:07 -0400)] 
Cleanup: popt library detection

Simplify popt detection code and use a variable to store the detected
lib instead of using the global LIBS variable.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove duplicated pthread detection code
Michael Jeanson [Thu, 11 May 2017 21:17:33 +0000 (17:17 -0400)] 
Cleanup: remove duplicated pthread detection code

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: remove unused m4/libxml.m4
Michael Jeanson [Thu, 11 May 2017 21:12:16 +0000 (17:12 -0400)] 
Cleanup: remove unused m4/libxml.m4

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
7 years agoCleanup: bison and flex detection
Michael Jeanson [Thu, 11 May 2017 20:50:56 +0000 (16:50 -0400)] 
Cleanup: bison and flex detection

The previous detection code was quite convoluted and required to have
two variables set to the same value to work. For example, the lexer in
autotools is configured through the LEX variable, even if we require a
specific implementation we have to use it and base our detection code on
it.

The situation is now :

  - the FLEX and BISON variables are now ignored.
  - the LEX and YACC variables need to be set if required like before.

Also some minor cleanups.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.044702 seconds and 5 git commands to generate.