lttng-tools.git
12 years agoFix: lttng UI exit value and error message
David Goulet [Tue, 20 Mar 2012 18:27:12 +0000 (14:27 -0400)] 
Fix: lttng UI exit value and error message

Change lttcomm error code starting value from 1000 to 10. This way, bash
can return the exact error code since 255 is the maximum.

Fix multiple warning, error and message output.

Some return code could still be not "standardize" but for stable it's
ok. Fixes can come later on.

(close #105)

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix: trace_ust_destroy_metadata should check for NULL pointer
Mathieu Desnoyers [Mon, 19 Mar 2012 22:15:50 +0000 (18:15 -0400)] 
Fix: trace_ust_destroy_metadata should check for NULL pointer

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: various memleaks
Mathieu Desnoyers [Mon, 19 Mar 2012 22:02:45 +0000 (18:02 -0400)] 
Fix: various memleaks

Thanks to valgrind.

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: hash table allocation out of order on error
David Goulet [Mon, 19 Mar 2012 21:16:28 +0000 (17:16 -0400)] 
Fix: hash table allocation out of order on error

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agofix: lttng_ht_destroy memleak
Mathieu Desnoyers [Mon, 19 Mar 2012 21:10:20 +0000 (17:10 -0400)] 
fix: lttng_ht_destroy memleak

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoUpdate version to v2.0.0-rc3
David Goulet [Fri, 16 Mar 2012 19:38:56 +0000 (15:38 -0400)] 
Update version to v2.0.0-rc3

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix missing headers for make dist
David Goulet [Fri, 16 Mar 2012 19:33:52 +0000 (15:33 -0400)] 
Fix missing headers for make dist

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix: install lttng-consumerd in lib/lttng/libexec/
Mathieu Desnoyers [Thu, 15 Mar 2012 18:30:43 +0000 (14:30 -0400)] 
Fix: install lttng-consumerd in lib/lttng/libexec/

This program is not meant to be executed by end-users: it is spawned
only by the session daemon.

Closes #46

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: Redefine MAP_STACK to 0 if not defined by the architecture
Avik Sil [Thu, 15 Mar 2012 12:22:02 +0000 (08:22 -0400)] 
Fix: Redefine MAP_STACK to 0 if not defined by the architecture

This patch fixes build error on architectures (e.g., armel, armhf) that
do not define MAP_STACK.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix consumer CPU hotplug support
David Goulet [Tue, 13 Mar 2012 21:14:17 +0000 (17:14 -0400)] 
Fix consumer CPU hotplug support

This is a quick fix to handle stream update on CPU hotplug. Please look
at #ref 168 for more information and explanation on the real fix.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix double PID registration race
David Goulet [Tue, 13 Mar 2012 15:13:25 +0000 (11:13 -0400)] 
Fix double PID registration race

Introduce a second hash table indexed by application socket which have
the exact same content as the hash table indexed by PID.

On unregister, we now use a direct lookup per socket instead of using
the key map between sock and PID. This prevents the PID-sock lookup race
when the unregister happens just after the replace and before the
close(fd).

We also use an add_replace call on application registration for the PID
hash table and kept the add_unique for the socket hash table.

(closes #7)

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoMake libcompat independent not to confuse automake
David Goulet [Tue, 13 Mar 2012 15:34:28 +0000 (11:34 -0400)] 
Make libcompat independent not to confuse automake

Moving libcompat.la to the compat/ subdirectory and building it before
every other libs.

(closes #101 #153)

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoClarify the license of lttng-ust-abi.h
Alexandre Montplaisir [Sat, 10 Mar 2012 21:59:00 +0000 (16:59 -0500)] 
Clarify the license of lttng-ust-abi.h

That file's license was not recognized by licensecheck. I suggest using
the MIT/X11 text which is quite similar, and is already used elsewhere
in the project (in Babeltrace).

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoLicense header fixes
Alexandre Montplaisir [Sat, 10 Mar 2012 21:58:59 +0000 (16:58 -0500)] 
License header fixes

Most of the source files had the wrong FSF address. Also reworded the
first paragraph so that licensecheck's regexes actually pick up the
version number.

I made sure lttng.h and lttng-ctl.c advertise LGPL-2.1. Every other file
touched in this patch was and remains under GPL2, please make sure this
is correct. (Some files related to the RCU hashtable are under
LGPL-2.1+, but their headers were already clean).

(closes #155)

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix wrong return value on consumer socket creation
David Goulet [Thu, 8 Mar 2012 23:10:38 +0000 (18:10 -0500)] 
Fix wrong return value on consumer socket creation

A failing call to mkdir() returned 0 instead of an error and was
creating a segfault later on since some memory was not initialized.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix: test for UST invalid channel parameters at channel creation
Mathieu Desnoyers [Thu, 8 Mar 2012 16:07:13 +0000 (11:07 -0500)] 
Fix: test for UST invalid channel parameters at channel creation

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: recvmsg should handle EINTR
Mathieu Desnoyers [Tue, 6 Mar 2012 23:16:12 +0000 (18:16 -0500)] 
Fix: recvmsg should handle EINTR

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix error.h non-static variables for liblttng-ctl
David Goulet [Tue, 6 Mar 2012 16:16:26 +0000 (11:16 -0500)] 
Fix error.h non-static variables for liblttng-ctl

Linking with liblttng-ctl made the variable opt_quiet and opt_verbose
undefined if nonexistent in the linked application.

Rename the variables adding the prefix lttng_* and declaring them in
liblttng-ctl as global variable. The user can now control the verbosity
of the library by simply setting them.

Future work will mostly add an API call to control verbosity.

(closes #151)

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix missing _GNU_SOURCE define
David Goulet [Tue, 6 Mar 2012 15:44:55 +0000 (10:44 -0500)] 
Fix missing _GNU_SOURCE define

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix: improve need root for kernel tracing error message
Mathieu Desnoyers [Tue, 6 Mar 2012 15:40:06 +0000 (10:40 -0500)] 
Fix: improve need root for kernel tracing error message

Reported-by: "Thibault, Daniel" <Daniel.Thibault@drdc-rddc.gc.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix start/stop lttng message error
David Goulet [Mon, 5 Mar 2012 14:56:40 +0000 (09:56 -0500)] 
Fix start/stop lttng message error

Add the already started/stopped error message and print a more
meaningful error on the command line.

(closes #47)

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Mon, 5 Mar 2012 14:27:50 +0000 (09:27 -0500)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

12 years agoUpdate version to v2.0.0-rc2
Mathieu Desnoyers [Fri, 2 Mar 2012 23:35:37 +0000 (18:35 -0500)] 
Update version to v2.0.0-rc2

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: meaningful error message
Mathieu Desnoyers [Fri, 2 Mar 2012 23:17:33 +0000 (18:17 -0500)] 
Fix: meaningful error message

Show a meaningful error message to users attempting to do kernel tracing
without root sessiond/tracing group creds.

Reported-by: "Brosseau, Yannick" <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: UST consumer need to iterate on streams, just change their key
Mathieu Desnoyers [Fri, 2 Mar 2012 22:26:10 +0000 (17:26 -0500)] 
Fix: UST consumer need to iterate on streams, just change their key

We need iteration to still be able to see the stream/channel, but not
lookups from sessiond query.

Ensure that teardown does not lookup by key.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: add missing rcu read lock across RCU HT iteration
Mathieu Desnoyers [Fri, 2 Mar 2012 21:56:13 +0000 (16:56 -0500)] 
Fix: add missing rcu read lock across RCU HT iteration

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: kernel session closes fd 0 after create
Mathieu Desnoyers [Fri, 2 Mar 2012 21:16:02 +0000 (16:16 -0500)] 
Fix: kernel session closes fd 0 after create

This fix the make check test for kernel session handling. We ensure that
all FDs that are unset are set to -1.

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: sendmsg EPIPE should be quiet by default (expected)
Mathieu Desnoyers [Fri, 2 Mar 2012 20:53:09 +0000 (15:53 -0500)] 
Fix: sendmsg EPIPE should be quiet by default (expected)

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: thread_registration_apps should set its local sock to -1 when passing it
Mathieu Desnoyers [Fri, 2 Mar 2012 20:45:11 +0000 (15:45 -0500)] 
Fix: thread_registration_apps should set its local sock to -1 when passing it

.. to another thread.

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: clock -> sock typo
Mathieu Desnoyers [Fri, 2 Mar 2012 20:20:45 +0000 (15:20 -0500)] 
Fix: clock -> sock typo

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Fri, 2 Mar 2012 20:19:52 +0000 (15:19 -0500)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

12 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Fri, 2 Mar 2012 20:18:33 +0000 (15:18 -0500)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

12 years agoFix: consumer race: should allow reuse of FD key
Mathieu Desnoyers [Fri, 2 Mar 2012 20:13:18 +0000 (15:13 -0500)] 
Fix: consumer race: should allow reuse of FD key

Issue was triggered by running "hello" UST test program in a loop while
tracing was active.

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Fri, 2 Mar 2012 20:00:16 +0000 (15:00 -0500)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

12 years agoFix: Use PERROR all across lttng-tools, never make it quiet
Mathieu Desnoyers [Fri, 2 Mar 2012 19:01:42 +0000 (14:01 -0500)] 
Fix: Use PERROR all across lttng-tools, never make it quiet

We never want to hide these errors, even in quiet mode. For those
"errors" that are expected and part of the normal operation (e.g. send
consumer channel: Socket operation on non-socket), we will have to
handle the return values and errno explicitly in the code.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: test all close return values in sessiond
Mathieu Desnoyers [Fri, 2 Mar 2012 18:10:11 +0000 (13:10 -0500)] 
Fix: test all close return values in sessiond

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: All perror turned into PERROR to show file and line number
Mathieu Desnoyers [Fri, 2 Mar 2012 18:03:38 +0000 (13:03 -0500)] 
Fix: All perror turned into PERROR to show file and line number

Needed to find error culprits.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: large audit of close() use in sessiond main.c
Mathieu Desnoyers [Fri, 2 Mar 2012 17:57:38 +0000 (12:57 -0500)] 
Fix: large audit of close() use in sessiond main.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: main.c client/apps sockets and kernel_trace_fd close(0)
Mathieu Desnoyers [Fri, 2 Mar 2012 17:10:32 +0000 (12:10 -0500)] 
Fix: main.c client/apps sockets and kernel_trace_fd close(0)

thread_registration_apps and thread_manage_clients threads are closing
sock == 0 in error handling path, which is an error.

They also may use kernel_tracer_fd at 0 value if no kernel tracer has
been found. cleanup() can close this 0 socket too, which should never
happen.

Set all these sockets as "-1" when unset.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: incorrect close of fd 0 for syscall kernel event destroy
Mathieu Desnoyers [Fri, 2 Mar 2012 16:54:13 +0000 (11:54 -0500)] 
Fix: incorrect close of fd 0 for syscall kernel event destroy

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: sessiond has incorrect missing 0 value in FD check
Mathieu Desnoyers [Fri, 2 Mar 2012 16:12:26 +0000 (11:12 -0500)] 
Fix: sessiond has incorrect missing 0 value in FD check

When run with daemon(), the 0 file descriptor can be re-used for
something else than stdout.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoMerge branch 'master' into compat-freebsd
David Goulet [Thu, 1 Mar 2012 18:04:18 +0000 (13:04 -0500)] 
Merge branch 'master' into compat-freebsd

12 years agoFix: sessiond app listening: use posix-compliant poll flags
Mathieu Desnoyers [Thu, 1 Mar 2012 04:34:11 +0000 (23:34 -0500)] 
Fix: sessiond app listening: use posix-compliant poll flags

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix: consumer printf type should match ssize_t (%zd)
Mathieu Desnoyers [Thu, 1 Mar 2012 03:33:17 +0000 (22:33 -0500)] 
Fix: consumer printf type should match ssize_t (%zd)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix: make ust consumer posix compliant for poll flags
Mathieu Desnoyers [Thu, 1 Mar 2012 03:30:17 +0000 (22:30 -0500)] 
Fix: make ust consumer posix compliant for poll flags

poll flags can have both POLLHUP and POLLIN set, which is not expected
by the consumer. Do not depend on this implementation-specific behavior.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix security permission on lttng run directory
David Goulet [Thu, 1 Mar 2012 15:36:06 +0000 (10:36 -0500)] 
Fix security permission on lttng run directory

Add execute flag for other (r+x) on the lttng run directory at
/var/run/lttng so instrumented application *not* in the tracing group
can register to the global session daemon running as root.

(refs #141)

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix: sessiond app listening: use posix-compliant poll flags
Mathieu Desnoyers [Thu, 1 Mar 2012 04:34:11 +0000 (23:34 -0500)] 
Fix: sessiond app listening: use posix-compliant poll flags

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: consumer printf type should match ssize_t (%zd)
Mathieu Desnoyers [Thu, 1 Mar 2012 03:33:17 +0000 (22:33 -0500)] 
Fix: consumer printf type should match ssize_t (%zd)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: make ust consumer posix compliant for poll flags
Mathieu Desnoyers [Thu, 1 Mar 2012 03:30:17 +0000 (22:30 -0500)] 
Fix: make ust consumer posix compliant for poll flags

poll flags can have both POLLHUP and POLLIN set, which is not expected
by the consumer. Do not depend on this implementation-specific behavior.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: Display right loglevel_type in error message
Raphaël Beamonte [Tue, 28 Feb 2012 18:29:18 +0000 (13:29 -0500)] 
Fix: Display right loglevel_type in error message

Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix documentation in lttng.h
Raphaël Beamonte [Mon, 27 Feb 2012 22:37:18 +0000 (17:37 -0500)] 
Fix documentation in lttng.h

Some functions in lttng.h are not aimed to be used only for kernel but
also for UST. This patch changes only the references made to 'kernel' to
make the documentation generic in the comments.

(closes #126)

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix: lttng UST and kernel consumer: fix ret vs errno mixup
Mathieu Desnoyers [Fri, 24 Feb 2012 19:41:49 +0000 (14:41 -0500)] 
Fix: lttng UST and kernel consumer: fix ret vs errno mixup

- errno should be set to -ret (not the opposite!)
  The main effect is that the perror errors were meaningless.

- errno should always be compared with positive values.
  This was also causing consumerd error handling mistakes.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix: restart consumerd and sessiond when interrupted in poll()
Mathieu Desnoyers [Fri, 24 Feb 2012 19:26:30 +0000 (14:26 -0500)] 
Fix: restart consumerd and sessiond when interrupted in poll()

When poll() is interrupted (e.g. by a debugger attaching), it should
restart instead of exiting with an error.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix: lttng UST and kernel consumer: fix ret vs errno mixup
Mathieu Desnoyers [Fri, 24 Feb 2012 19:41:49 +0000 (14:41 -0500)] 
Fix: lttng UST and kernel consumer: fix ret vs errno mixup

- errno should be set to -ret (not the opposite!)
  The main effect is that the perror errors were meaningless.

- errno should always be compared with positive values.
  This was also causing consumerd error handling mistakes.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: restart consumerd and sessiond when interrupted in poll()
Mathieu Desnoyers [Fri, 24 Feb 2012 19:26:30 +0000 (14:26 -0500)] 
Fix: restart consumerd and sessiond when interrupted in poll()

When poll() is interrupted (e.g. by a debugger attaching), it should
restart instead of exiting with an error.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoDebugger support: introduce LTTNG_DEBUG_NOCLONE env. var.
Mathieu Desnoyers [Fri, 24 Feb 2012 16:39:52 +0000 (11:39 -0500)] 
Debugger support: introduce LTTNG_DEBUG_NOCLONE env. var.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoMerge branch 'master' into compat-freebsd
User [Fri, 24 Feb 2012 03:48:56 +0000 (22:48 -0500)] 
Merge branch 'master' into compat-freebsd

12 years agoFix: handling bad channel when sending to consumer
David Goulet [Thu, 23 Feb 2012 22:30:41 +0000 (17:30 -0500)] 
Fix: handling bad channel when sending to consumer

If the channel object is NULL it means that it's not created on the
tracer.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix useless variable
David Goulet [Thu, 23 Feb 2012 22:19:29 +0000 (17:19 -0500)] 
Fix useless variable

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix add-context returned error
David Goulet [Thu, 23 Feb 2012 21:32:45 +0000 (16:32 -0500)] 
Fix add-context returned error

Commit closes #99

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agofix: add missing break in command handling
Mathieu Desnoyers [Thu, 23 Feb 2012 16:06:29 +0000 (11:06 -0500)] 
fix: add missing break in command handling

fix missing break in switch statement introduced in commit
2e09ba096b399ff18769cdd794c3946e54194491

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agofix: command handling: do not check domain for commands not requiring domain
Mathieu Desnoyers [Thu, 23 Feb 2012 16:02:00 +0000 (11:02 -0500)] 
fix: command handling: do not check domain for commands not requiring domain

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agofix: if tracing group does not exist, do not report a client error
Mathieu Desnoyers [Thu, 23 Feb 2012 15:41:45 +0000 (10:41 -0500)] 
fix: if tracing group does not exist, do not report a client error

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix: run_as error handling
Mathieu Desnoyers [Thu, 23 Feb 2012 15:09:09 +0000 (10:09 -0500)] 
Fix: run_as error handling

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFreeBSD port: lttng_clone_files should execute handler
Mathieu Desnoyers [Thu, 23 Feb 2012 16:14:40 +0000 (11:14 -0500)] 
FreeBSD port: lttng_clone_files should execute handler

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agofix: add missing break in command handling
Mathieu Desnoyers [Thu, 23 Feb 2012 16:06:29 +0000 (11:06 -0500)] 
fix: add missing break in command handling

fix missing break in switch statement introduced in commit
2e09ba096b399ff18769cdd794c3946e54194491

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agofix: command handling: do not check domain for commands not requiring domain
Mathieu Desnoyers [Thu, 23 Feb 2012 16:02:00 +0000 (11:02 -0500)] 
fix: command handling: do not check domain for commands not requiring domain

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agofix: if tracing group does not exist, do not report a client error
Mathieu Desnoyers [Thu, 23 Feb 2012 15:41:45 +0000 (10:41 -0500)] 
fix: if tracing group does not exist, do not report a client error

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agorunas: freebsd do not redefine MAP_STACK
Mathieu Desnoyers [Thu, 23 Feb 2012 15:33:56 +0000 (10:33 -0500)] 
runas: freebsd do not redefine MAP_STACK

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agofreebsd: do not use MAP_STACK
Mathieu Desnoyers [Thu, 23 Feb 2012 15:31:54 +0000 (10:31 -0500)] 
freebsd: do not use MAP_STACK

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agorunas: freebsd compat for mmap flags
Mathieu Desnoyers [Thu, 23 Feb 2012 15:12:05 +0000 (10:12 -0500)] 
runas: freebsd compat for mmap flags

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix: run_as error handling
Mathieu Desnoyers [Thu, 23 Feb 2012 15:09:09 +0000 (10:09 -0500)] 
Fix: run_as error handling

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agofreebsd creds: Add missing braces
Mathieu Desnoyers [Thu, 23 Feb 2012 15:02:59 +0000 (10:02 -0500)] 
freebsd creds: Add missing braces

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFreebsd creds: do not overwrite recv len
Mathieu Desnoyers [Thu, 23 Feb 2012 15:02:02 +0000 (10:02 -0500)] 
Freebsd creds: do not overwrite recv len

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoImplement FreeBSD credential support
Mathieu Desnoyers [Thu, 23 Feb 2012 14:57:52 +0000 (09:57 -0500)] 
Implement FreeBSD credential support

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agotests: use LDFLAGS instead of CFLAGS for libraries
Mathieu Desnoyers [Thu, 23 Feb 2012 14:49:04 +0000 (09:49 -0500)] 
tests: use LDFLAGS instead of CFLAGS for libraries

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFreebsd support: check for libc/libdl dlopen
Mathieu Desnoyers [Thu, 23 Feb 2012 13:01:42 +0000 (08:01 -0500)] 
Freebsd support: check for libc/libdl dlopen

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agobsd compat: add missing #elif -> #elif defined()
Mathieu Desnoyers [Thu, 23 Feb 2012 12:22:04 +0000 (07:22 -0500)] 
bsd compat: add missing #elif -> #elif defined()

Add a missing warning too.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agobsd compat headers: #elif -> #elif defined
Mathieu Desnoyers [Thu, 23 Feb 2012 12:19:33 +0000 (07:19 -0500)] 
bsd compat headers: #elif -> #elif defined

Also update warning messages.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agofreebsd: fchmod is not supported on posix shm
Mathieu Desnoyers [Thu, 23 Feb 2012 00:44:56 +0000 (19:44 -0500)] 
freebsd: fchmod is not supported on posix shm

It is OK not to the the fchmod. However, if UST apps start before
lttng-sessiond, they will have write access to the futex shm.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoImplement CLONE_FILES compat layer with rfork
Mathieu Desnoyers [Thu, 23 Feb 2012 00:26:47 +0000 (19:26 -0500)] 
Implement CLONE_FILES compat layer with rfork

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix usage note on -a
Julien Desfossez [Tue, 21 Feb 2012 20:33:07 +0000 (15:33 -0500)] 
Fix usage note on -a

This option also enable syscall tracing, just clarify it in doc.

Signed-off-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoMultiple fix for FreeBSD compat layer
David Goulet [Tue, 21 Feb 2012 22:45:50 +0000 (17:45 -0500)] 
Multiple fix for FreeBSD compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix consumer to handle compat layer
David Goulet [Tue, 21 Feb 2012 22:46:24 +0000 (17:46 -0500)] 
Fix consumer to handle compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix rest of the code to support compat layer
David Goulet [Tue, 21 Feb 2012 22:46:49 +0000 (17:46 -0500)] 
Fix rest of the code to support compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoAdd multiple FreeBSD compat layer
David Goulet [Tue, 21 Feb 2012 22:43:53 +0000 (17:43 -0500)] 
Add multiple FreeBSD compat layer

Adds clone, posix_fadvise and splice compatibility layer.

This commit ENOSYS those function for now and better implementation
will come in the future.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoAdd FreeBSD compat layer for splice and sync_file_range
David Goulet [Tue, 21 Feb 2012 20:36:59 +0000 (15:36 -0500)] 
Add FreeBSD compat layer for splice and sync_file_range

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoSupport XSI strerror_r in error.h
Mathieu Desnoyers [Tue, 21 Feb 2012 18:54:20 +0000 (13:54 -0500)] 
Support XSI strerror_r in error.h

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoAdd FreeBSD compat layer for socket.h
David Goulet [Tue, 21 Feb 2012 18:12:55 +0000 (13:12 -0500)] 
Add FreeBSD compat layer for socket.h

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoAdd FreeBSD compat layer for endian.h
David Goulet [Tue, 21 Feb 2012 18:11:47 +0000 (13:11 -0500)] 
Add FreeBSD compat layer for endian.h

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix FreeBSD support for rculfhash mmap
David Goulet [Tue, 21 Feb 2012 18:12:20 +0000 (13:12 -0500)] 
Fix FreeBSD support for rculfhash mmap

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoRevert FreeBSD compatibility layer
David Goulet [Wed, 22 Feb 2012 21:53:12 +0000 (16:53 -0500)] 
Revert FreeBSD compatibility layer

Move those commits to the compat-freebsd branch instead of master branch
which is currently between release canditate and stable and this compat
layer will NOT go into 2.0-stable.

Revert "Fix rest of the code to support compat layer"
This reverts commit a440509044c2828bf6dbfb05e8d9d6d0277ce1a4.

Revert "Fix consumer to handle compat layer"
This reverts commit fbb2c21aac1386b7752f6254b2bd0bf001fa0ac1.

Revert "Multiple fix for FreeBSD compat layer"
This reverts commit bcc5eeb02fcad910c4de961b040351dad31b6f9f.

Revert "Add multiple FreeBSD compat layer"
This reverts commit d50813007e79158828e8ee6e1b5444950bc90847.

Revert "Add FreeBSD compat layer for splice and sync_file_range"
This reverts commit 826a02a292d2bd409be87ea96ba2fccbccee76b1.

Revert "Support XSI strerror_r in error.h"
This reverts commit e672cc585c3d67ee80278e29b538a3aed65df825.

Revert "Add FreeBSD compat layer for socket.h"
This reverts commit ef50a575de02a28aa158d7ba34b3d20ea329751a.

Revert "Fix FreeBSD support for rculfhash mmap"
This reverts commit e21193ea4abf7d93112b8ad3144ba11484d623c6.

Revert "Add FreeBSD compat layer for endian.h"
This reverts commit ae9d96fe577c198df432102cde69a28e82cccc1b.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix: documented number of subbuffers is incorrect
Mathieu Desnoyers [Wed, 22 Feb 2012 01:18:33 +0000 (20:18 -0500)] 
Fix: documented number of subbuffers is incorrect

Reported-by: Tan Dung Le Tran <tan.dung.le.tran@ericsson.com>
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoDocument that num-subbuf and subbuf-size need to be power of 2
Mathieu Desnoyers [Wed, 22 Feb 2012 01:07:29 +0000 (20:07 -0500)] 
Document that num-subbuf and subbuf-size need to be power of 2

Reported-by: Tan Dung Le Tran <tan.dung.le.tran@ericsson.com>
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Tue, 21 Feb 2012 22:53:02 +0000 (17:53 -0500)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

12 years agoFix rest of the code to support compat layer
David Goulet [Tue, 21 Feb 2012 22:46:49 +0000 (17:46 -0500)] 
Fix rest of the code to support compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix consumer to handle compat layer
David Goulet [Tue, 21 Feb 2012 22:46:24 +0000 (17:46 -0500)] 
Fix consumer to handle compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoMultiple fix for FreeBSD compat layer
David Goulet [Tue, 21 Feb 2012 22:45:50 +0000 (17:45 -0500)] 
Multiple fix for FreeBSD compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoAdd multiple FreeBSD compat layer
David Goulet [Tue, 21 Feb 2012 22:43:53 +0000 (17:43 -0500)] 
Add multiple FreeBSD compat layer

Adds clone, posix_fadvise and splice compatibility layer.

This commit ENOSYS those function for now and better implementation
will come in the future.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoAdd FreeBSD compat layer for splice and sync_file_range
David Goulet [Tue, 21 Feb 2012 20:36:59 +0000 (15:36 -0500)] 
Add FreeBSD compat layer for splice and sync_file_range

Signed-off-by: David Goulet <dgoulet@efficios.com>
This page took 0.045017 seconds and 5 git commands to generate.