babeltrace.git
8 years agoTypo: configure.ac implemenation -> implementation
Jérémie Galarneau [Mon, 25 Jul 2016 19:16:18 +0000 (15:16 -0400)] 
Typo: configure.ac implemenation -> implementation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoconfigure: fix uuid support detection on static build
Samuel Martin [Wed, 1 Jun 2016 19:56:32 +0000 (21:56 +0200)] 
configure: fix uuid support detection on static build

This change adds uuid detection using pkg-config helper before falling
back on the standard AC_CHECK_LIB detection for platforms missing
pkg-config.

AC_CHECK_LIB function achieves its test by trying to link against the
requested library, without taking care of its dependency
requirements/flags that may differ between different targets.
Therefore, in case of static build, it can fail on the uuid detection
like [1], because the uuid's dependency flags (regarding gettext) are
missing.

Instead, using pkg-config to do the check will take care of getting and
setting all required flags.

This issue [1] has been triggered on Buildroot farms.

[1] http://autobuild.buildroot.net/results/43b/43b98ddf9eb44152ed9ac4a98d887af14831d8da/build-end.log

Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: don't assert on lib unload failure
Jérémie Galarneau [Sat, 23 Jul 2016 19:59:30 +0000 (15:59 -0400)] 
Fix: don't assert on lib unload failure

A library's load event might have been missed because of
discarded events. In this scenario, it is expected that its
mapping will not be found on unload.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoUse lib unload events to prune library mappings
Jérémie Galarneau [Sat, 23 Jul 2016 19:55:09 +0000 (15:55 -0400)] 
Use lib unload events to prune library mappings

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoRename handle_dlopen_event to handle_lib_load_event
Jérémie Galarneau [Sat, 23 Jul 2016 19:24:21 +0000 (15:24 -0400)] 
Rename handle_dlopen_event to handle_lib_load_event

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoUse lttng-ust's new load event to track library mappings
Jérémie Galarneau [Fri, 22 Jul 2016 15:41:35 +0000 (11:41 -0400)] 
Use lttng-ust's new load event to track library mappings

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: no substitution needed for multi-trace intersection test
Jérémie Galarneau [Tue, 7 Jun 2016 16:09:27 +0000 (12:09 -0400)] 
Tests: no substitution needed for multi-trace intersection test

The use of AC_CONFIG_FILES on with src == dest causes the source
file to be deleted on make distclean.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: dereference of NULL pointer on allocation failure
Jérémie Galarneau [Fri, 3 Jun 2016 11:21:29 +0000 (07:21 -0400)] 
Tests: dereference of NULL pointer on allocation failure

Reported by Coverity as:
CID 1354904 (#1 of 1): Dereference null return value (NULL_RETURNS)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: abort dwarf test on open() failure
Jérémie Galarneau [Fri, 3 Jun 2016 11:17:42 +0000 (07:17 -0400)] 
Tests: abort dwarf test on open() failure

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: lttng-live does not set a trace descriptor
Jérémie Galarneau [Thu, 2 Jun 2016 17:40:25 +0000 (13:40 -0400)] 
Fix: lttng-live does not set a trace descriptor

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: Unchecked return value in test_ctf_writer
Jérémie Galarneau [Tue, 31 May 2016 11:59:46 +0000 (07:59 -0400)] 
Tests: Unchecked return value in test_ctf_writer

Reported by Coverity as:
CID 1355342 (#1 of 1): Unchecked return value (CHECKED_RETURN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: unchecked return value in test_ctf_writer
Jérémie Galarneau [Tue, 31 May 2016 11:56:10 +0000 (07:56 -0400)] 
Tests: unchecked return value in test_ctf_writer

Reported by Coverity as:
CID 1355343 (#1 of 1): Unchecked return value (CHECKED_RETURN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: Add missing --merge LOG_DRIVER_FLAGS
Jérémie Galarneau [Tue, 31 May 2016 11:31:55 +0000 (07:31 -0400)] 
Tests: Add missing --merge LOG_DRIVER_FLAGS

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: strerror_r behavior is glibc specific
Michael Jeanson [Mon, 30 May 2016 20:39:02 +0000 (16:39 -0400)] 
Fix: strerror_r behavior is glibc specific

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agosys/param.h is required for MAXNAMLEN on musl libc
Michael Jeanson [Mon, 30 May 2016 20:39:01 +0000 (16:39 -0400)] 
sys/param.h is required for MAXNAMLEN on musl libc

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: unchecked return values in test_ctf_writer
Jérémie Galarneau [Mon, 30 May 2016 19:37:43 +0000 (15:37 -0400)] 
Tests: unchecked return values in test_ctf_writer

Reported by Coverity as:
CID 1351745: Unchecked return value (CHECKED_RETURN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: Unchecked return values in test_ctf_writer
Jérémie Galarneau [Mon, 30 May 2016 19:31:32 +0000 (15:31 -0400)] 
Tests: Unchecked return values in test_ctf_writer

Reported by Coverity as:
CID 1351744: Unchecked return value (CHECKED_RETURN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: unchecked return values in test_ctf_writer
Jérémie Galarneau [Mon, 30 May 2016 19:19:07 +0000 (15:19 -0400)] 
Tests: unchecked return values in test_ctf_writer

Reported by Coverity as:
CID 1351743 (#1 of 1): Unchecked return value (CHECKED_RETURN)
CID 1351740 (#1 of 1): Unchecked return value (CHECKED_RETURN)
CID 1351741 (#1 of 1): Unchecked return value (CHECKED_RETURN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: Unchecked return value in test_ctf_writer
Jérémie Galarneau [Mon, 30 May 2016 19:10:08 +0000 (15:10 -0400)] 
Tests: Unchecked return value in test_ctf_writer

Reported by Coverity as:
CID 1349725 (#1 of 1): Unchecked return value (CHECKED_RETURN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: undefined bit shift operation when printing octal numbers
Jérémie Galarneau [Mon, 30 May 2016 18:39:27 +0000 (14:39 -0400)] 
Fix: undefined bit shift operation when printing octal numbers

Reported by Coverity as:
CID 1355338 (#1 of 1): Bad bit shift operation (BAD_SHIFT)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: Wrong variable checked in bin_info_child_die_has_address
Jérémie Galarneau [Mon, 30 May 2016 14:22:45 +0000 (10:22 -0400)] 
Fix: Wrong variable checked in bin_info_child_die_has_address

"contains", which is an output pointer, is used instead of the
local boolean that is set by the call to
bt_dwarf_die_contains_addr.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: unchecked bt_ctf_field_type_set_alignment return value
Jérémie Galarneau [Mon, 30 May 2016 06:36:56 +0000 (02:36 -0400)] 
Fix: unchecked bt_ctf_field_type_set_alignment return value

Reported by Coverity as:
CID 1351742 (#1 of 1): Unchecked return value (CHECKED_RETURN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: unchecked return value of bt_ctf_field_type_variant_get_field
Jérémie Galarneau [Mon, 30 May 2016 06:31:18 +0000 (02:31 -0400)] 
Fix: unchecked return value of bt_ctf_field_type_variant_get_field

Reported by Coverity as:
CID 1351741 (#1 of 1): Unchecked return value (CHECKED_RETURN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: validate return value of bt_ctf_field_get_type_id
Jérémie Galarneau [Mon, 30 May 2016 06:26:04 +0000 (02:26 -0400)] 
Fix: validate return value of bt_ctf_field_get_type_id

Reported by Coverity as
CID 1351739 (#1 of 1): Unchecked return value (CHECKED_RETURN)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: Only close valid fds in is_valid_debug_file
Michael Jeanson [Tue, 17 May 2016 19:43:59 +0000 (15:43 -0400)] 
Fix: Only close valid fds in is_valid_debug_file

Fixes coverity #1354901 and #1354902

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: Free die_name in bin_info_lookup_cu_function_name
Michael Jeanson [Tue, 17 May 2016 19:21:44 +0000 (15:21 -0400)] 
Fix: Free die_name in bin_info_lookup_cu_function_name

Fixes coverity #1354905

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: Don't dereference null ptr in error path
Michael Jeanson [Tue, 17 May 2016 19:09:03 +0000 (15:09 -0400)] 
Fix: Don't dereference null ptr in error path

Fixes coverity #1355339

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoStandardise spelling of debug info
Antoine Busque [Thu, 19 May 2016 16:21:29 +0000 (12:21 -0400)] 
Standardise spelling of debug info

Debug info being short for debugging information is two separate
words. Therefore, the debuginfo spelling is erroneous. Variables and
defines throughout the code and build system should therefore use
'debug_info' or 'DEBUG_INFO', whereas command-line options and file
names should use the 'debug-info' form. In free form text
(i.e. comments and documentation), 'debug info' should be used, or the
long form 'debugging information'.

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: typo in --disable-debug-info in configure error message
Antoine Busque [Thu, 19 May 2016 15:50:06 +0000 (11:50 -0400)] 
Fix: typo in --disable-debug-info in configure error message

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoDocs: change --clock-raw to --clock-cycles
Jérémie Galarneau [Wed, 25 May 2016 13:37:39 +0000 (09:37 -0400)] 
Docs: change --clock-raw to --clock-cycles

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoDisplay binary location even if source and symbol lookups fail
Jérémie Galarneau [Fri, 13 May 2016 21:10:38 +0000 (17:10 -0400)] 
Display binary location even if source and symbol lookups fail

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoCopy bindings sources to build directory
Jérémie Galarneau [Fri, 13 May 2016 18:38:59 +0000 (14:38 -0400)] 
Copy bindings sources to build directory

The python bindings are made up of both source and generated files.
We copy the source files to the build directory so that the build
directory contains a valid python package for use in tests.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agobootstrap: Standardize on autoreconf -vi
Jérémie Galarneau [Thu, 12 May 2016 16:43:22 +0000 (12:43 -0400)] 
bootstrap: Standardize on autoreconf -vi

Don't overwrite already generated files.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoMove Python bindings to babeltrace subfolder
Jérémie Galarneau [Wed, 11 May 2016 19:47:35 +0000 (15:47 -0400)] 
Move Python bindings to babeltrace subfolder

This change reflects the arborescence used to install Babeltrace's
python bindings and allows Babeltrace's tests to use the normal
module name namespace.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: Multi-trace stream intersection test
Jérémie Galarneau [Wed, 11 May 2016 19:45:46 +0000 (15:45 -0400)] 
Tests: Multi-trace stream intersection test

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoChange behaviour of stream-intersection with multiple traces
Jérémie Galarneau [Wed, 11 May 2016 17:45:10 +0000 (13:45 -0400)] 
Change behaviour of stream-intersection with multiple traces

The stream-intersection currently results in the reading of
the intersection of every stream, in every trace of a Trace
Collection.

Since reading a TraceCollection returns the union of its traces,
the behaviour of this option is changed so that it returns the
union of each trace's individual "active" section, that is the
section for which all streams are active.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoPython bindings: PEP8 mandates two blank lines before class
Jérémie Galarneau [Wed, 11 May 2016 17:44:04 +0000 (13:44 -0400)] 
Python bindings: PEP8 mandates two blank lines before class

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: ctf-text: signed base 8, 16 printout
Mathieu Desnoyers [Fri, 6 May 2016 20:08:57 +0000 (16:08 -0400)] 
Fix: ctf-text: signed base 8, 16 printout

Base 16 signed integer printout is buggy for 64-bit length: a shift of
64-bit is undefined.

Change printout of base 8 signed integer to match what is done for
base 16.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: debug-info feature enable/disable
Mathieu Desnoyers [Fri, 6 May 2016 17:39:51 +0000 (13:39 -0400)] 
Fix: debug-info feature enable/disable

Explicitly enabling the debug-info feature should not disable the
feature.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: swapped libelf and libdw names in configure error message
Antoine Busque [Thu, 5 May 2016 15:50:24 +0000 (11:50 -0400)] 
Fix: swapped libelf and libdw names in configure error message

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoDon't use the .so extension on test assets
Michael Jeanson [Wed, 4 May 2016 18:36:19 +0000 (14:36 -0400)] 
Don't use the .so extension on test assets

Some packaging systems, such as dpkg-source in native mode used by
Debian's daily build system, will filter out files considered unclean
prior to the build. This behavior causes our test assets to be deleted
which, subsequently, fails the make check.

Since we do not require the .so extension and these files should be
treated as blobs, we rename them to "_so".

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: warnings on Solaris10
Michael Jeanson [Wed, 4 May 2016 17:02:49 +0000 (13:02 -0400)] 
Fix: warnings on Solaris10

Cast values to uint64_t before passing them to htobe64() because
the implementation on Solaris10 uses bitshifts and will complain
when passed 32bits values.

This fixes multiple warnings like:

lttng-live-comm.c:169:2: warning: left shift count >= width of type
  cmd.data_size = htobe64(sizeof(connect));

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoAdd missing generated tests to gitignore
Michael Jeanson [Wed, 4 May 2016 14:56:27 +0000 (10:56 -0400)] 
Add missing generated tests to gitignore

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: report error when lttng-live is provided with an IPv6 address
Jérémie Galarneau [Thu, 5 May 2016 15:43:45 +0000 (11:43 -0400)] 
Fix: report error when lttng-live is provided with an IPv6 address

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: invalid mix of ctf_type_id and bt_ctf_scope enums
Jérémie Galarneau [Tue, 3 May 2016 20:00:09 +0000 (16:00 -0400)] 
Fix: invalid mix of ctf_type_id and bt_ctf_scope enums

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: PATH_MAX requires limits.h on OS X and Solaris
Michael Jeanson [Tue, 3 May 2016 16:51:51 +0000 (12:51 -0400)] 
Fix: PATH_MAX requires limits.h on OS X and Solaris

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoStatic build fix: change link order of libtestcommon.la
Jérémie Galarneau [Tue, 3 May 2016 15:57:58 +0000 (11:57 -0400)] 
Static build fix: change link order of libtestcommon.la

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoClean-up: change space indentation to tabs
Jérémie Galarneau [Tue, 3 May 2016 03:59:13 +0000 (23:59 -0400)] 
Clean-up: change space indentation to tabs

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTest fix: clean trace files left behind by test_ctf_ir_ref
Jérémie Galarneau [Tue, 3 May 2016 03:57:34 +0000 (23:57 -0400)] 
Test fix: clean trace files left behind by test_ctf_ir_ref

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoClean-up: Missing space after cast operator
Jérémie Galarneau [Tue, 3 May 2016 02:59:33 +0000 (22:59 -0400)] 
Clean-up: Missing space after cast operator

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: overflow of signed integer results in undefined behaviour
Jérémie Galarneau [Tue, 3 May 2016 02:46:28 +0000 (22:46 -0400)] 
Fix: overflow of signed integer results in undefined behaviour

The expression "min_value = -((int64_t)1 << (size - 1))"

will result in a signed integer overflow when size is 64
((1ULL << 63) > LONG_MAX).

Note that larger sizes are unsupported and checked for in the setter.

Signed overflows result in undefined behaviour and llvm takes
advantage of this to optimize away the range check

"if (value < min_value || value > max_value) {"

Surprisingly, this was not catched by GCC, Coverity, scan-build or
cppcheck.

The fix consists in computing both bounds using an unsigned long long
type and, in the case of the lower bound, negating it (resulting in a
long long).

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: potential close() of uninitialized elf_fd
Jérémie Galarneau [Mon, 2 May 2016 20:27:58 +0000 (16:27 -0400)] 
Fix: potential close() of uninitialized elf_fd

elf_fd is uninitialized whenever bin is NULL.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoClean-up: add missing new line after end of function
Jérémie Galarneau [Mon, 2 May 2016 19:26:50 +0000 (15:26 -0400)] 
Clean-up: add missing new line after end of function

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoClean-up: remove extra newline in bin-info.c
Jérémie Galarneau [Mon, 2 May 2016 19:26:32 +0000 (15:26 -0400)] 
Clean-up: remove extra newline in bin-info.c

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoClean-up: fix comment style in bin-info.c
Jérémie Galarneau [Mon, 2 May 2016 19:26:08 +0000 (15:26 -0400)] 
Clean-up: fix comment style in bin-info.c

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoAdd tap-driver.sh from automake
Jérémie Galarneau [Fri, 29 Apr 2016 22:55:12 +0000 (18:55 -0400)] 
Add tap-driver.sh from automake

Solaris 11's automake does not include tap-driver.sh.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: skip certain bin-info tests on failure to prevent segfault
Antoine Busque [Fri, 29 Apr 2016 22:12:42 +0000 (18:12 -0400)] 
Tests: skip certain bin-info tests on failure to prevent segfault

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: strip ELF symbols from debuginfo-data executables with separate DWARF
Antoine Busque [Fri, 29 Apr 2016 22:13:39 +0000 (18:13 -0400)] 
Tests: strip ELF symbols from debuginfo-data executables with separate DWARF

Stripping the symbols prevents the framework from falling back to ELF
lookup should the separate DWARF files be missing, which would cause
tests to succeed when they should fail.

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoPython bindings: add has_intersection property to TraceCollection
Antoine Busque [Wed, 27 Apr 2016 16:40:30 +0000 (12:40 -0400)] 
Python bindings: add has_intersection property to TraceCollection

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoPython bindings: make intersect_mode read-only property
Antoine Busque [Wed, 27 Apr 2016 16:09:52 +0000 (12:09 -0400)] 
Python bindings: make intersect_mode read-only property

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: Add missing debuginfo files to dist
Michael Jeanson [Fri, 29 Apr 2016 21:05:31 +0000 (17:05 -0400)] 
Tests: Add missing debuginfo files to dist

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoUse tar-ustar format for dist
Michael Jeanson [Fri, 29 Apr 2016 20:58:14 +0000 (16:58 -0400)] 
Use tar-ustar format for dist

This is required to support file names longuer than 99 characters
when generating the dist tarball, which we require because of the
sphinx theme files in the python bindings documentation.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: Replace prove by autotools tap runner
Michael Jeanson [Fri, 29 Apr 2016 18:35:06 +0000 (14:35 -0400)] 
Tests: Replace prove by autotools tap runner

This patch removes the dependency on the prove perl script
to run the TAP test suite. It replaces it with the autotools
shell TAP driver that only requires a shell and awk.

Custom arguments can be passed to the test runner with
env variables as follow:

  env LOG_DRIVER_FLAGS='--comments --ignore-exit' \
      TESTS='foo.test baz.test' make -e check

This tap driver also creates a log file for each test that
can then be used by another system to build a test report.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoCleanup test scripts
Michael Jeanson [Thu, 28 Apr 2016 20:15:14 +0000 (16:15 -0400)] 
Cleanup test scripts

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: Don't clean test scripts
Michael Jeanson [Thu, 28 Apr 2016 16:57:03 +0000 (12:57 -0400)] 
Fix: Don't clean test scripts

Test scripts are generated by configure, not make. Therefore, we do
not want a make clean to remove them. Let automake handle dist and
clean.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: Make test_dwarf and test_bin_info tests work out-of-tree
Simon Marchi [Thu, 28 Apr 2016 16:43:37 +0000 (12:43 -0400)] 
Fix: Make test_dwarf and test_bin_info tests work out-of-tree

When building out of tree, these tests fail to find the test data.
This patch makes them (their _complete wrappers, actually) generated
by Autoconf, so the proper path to the test data (which is in the
source directory) can be written.

We can also get rid of SCRIPT_LIST and it's custom rules.

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoHandle test_ctf_writer_complete like the other tests scripts
Michael Jeanson [Thu, 28 Apr 2016 16:38:20 +0000 (12:38 -0400)] 
Handle test_ctf_writer_complete like the other tests scripts

Even if test_ctf_writer_complete doesn't require any substitutions,
handle it like the other test scripts which will be less error prone
and will allow to remove all the SCRIPT_LIST custom rules.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: let automake handle CLEAN and DIST
Simon Marchi [Thu, 28 Apr 2016 02:52:19 +0000 (22:52 -0400)] 
Fix: let automake handle CLEAN and DIST

Files test_seek_empty_packet and test_seek_big_trace are generated by
configuring, not by making.  Therefore, we do not want a make clean to
remove them.  Otherwise, doing...

  * make
  * make clean
  * make
  * make check

... fails.

Automake infers EXTRA_DIST and DISTCLEANFILES from AC_CONFIG_FILES.

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: Remove test_seek_empty_packet and test_seek_big_trace from SCRIPT_LIST
Simon Marchi [Thu, 28 Apr 2016 02:52:18 +0000 (22:52 -0400)] 
Fix: Remove test_seek_empty_packet and test_seek_big_trace from SCRIPT_LIST

Since these files are generated by autoconf, they shouldn't be included
in SCRIPT_LIST, which is the list of scripts to copy from the source
directory to the build directory.  This gets rid of these warnings when
building out of tree:

  cp: cannot stat '/home/simark/src/babeltrace/tests/lib/test_seek_big_trace': No such file or directory
  cp: cannot stat '/home/simark/src/babeltrace/tests/lib/test_seek_empty_packet': No such file or directory

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoconfigure: introduce new macro AX_LIB_ELFUTILS
Jérémie Galarneau [Thu, 28 Apr 2016 22:07:48 +0000 (18:07 -0400)] 
configure: introduce new macro AX_LIB_ELFUTILS

elfutils has only just started providing pkg-config metadata
which makes the current version check unreliable. This introduces
a new M4 macro which checks elfutils' version using the
_ELFUTILS_PREREQ macro (defined in elfutils/version.h).

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoDocs: fix typos in babeltrace-log(1) manpage
Antoine Busque [Wed, 27 Apr 2016 21:14:14 +0000 (17:14 -0400)] 
Docs: fix typos in babeltrace-log(1) manpage

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoDocs: update debuginfo doc
Antoine Busque [Wed, 27 Apr 2016 20:58:30 +0000 (16:58 -0400)] 
Docs: update debuginfo doc

Update the output format in the examples and document the new
--debug-info-target-prefix and --debug-info-full-path command line
options.

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoAdd configure report
Michael Jeanson [Sat, 23 Apr 2016 19:43:15 +0000 (15:43 -0400)] 
Add configure report

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoconfigure: check for elfutils (libelf and libdw) >= 0.154
Jérémie Galarneau [Thu, 28 Apr 2016 18:57:08 +0000 (14:57 -0400)] 
configure: check for elfutils (libelf and libdw) >= 0.154

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoSet the minimal version of elfutils to 0.154
Jérémie Galarneau [Thu, 28 Apr 2016 16:09:58 +0000 (12:09 -0400)] 
Set the minimal version of elfutils to 0.154

elfutils 0.154 is required since it is the first release to
include commit 5479725 (dwarf_highpc: Handle DW_AT_high_pc being
a constant offset from DW_AT_low_pc).

This is fix is required to read DwARF information produced by
"modern" (post-2012) GCCs which make use of this DWARF4
capability when generating position independant code. The binaries
provided as part of the test suite make use of this feature. Hence,
tests will fail with older elfutils versions.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoDoc: Add elfutils to README
Michael Jeanson [Sat, 23 Apr 2016 18:55:58 +0000 (14:55 -0400)] 
Doc: Add elfutils to README

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
8 years agoTypo: succesful* -> successful*
Jérémie Galarneau [Wed, 27 Apr 2016 21:11:08 +0000 (17:11 -0400)] 
Typo: succesful* -> successful*

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: return -1 on bin_info_lookup_dwarf_function_name failure
Jérémie Galarneau [Wed, 27 Apr 2016 19:21:00 +0000 (15:21 -0400)] 
Fix: return -1 on bin_info_lookup_dwarf_function_name failure

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoHarmonize spelling of debug-info
Jérémie Galarneau [Wed, 27 Apr 2016 19:01:15 +0000 (15:01 -0400)] 
Harmonize spelling of debug-info

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoWarning fix: pointer may be uninitialized if assertions are disabled
Jérémie Galarneau [Wed, 27 Apr 2016 16:09:18 +0000 (12:09 -0400)] 
Warning fix: pointer may be uninitialized if assertions are disabled

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoIndicate default debug-info build settings in configure help
Jérémie Galarneau [Wed, 27 Apr 2016 16:01:59 +0000 (12:01 -0400)] 
Indicate default debug-info build settings in configure help

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoDisable debuginfo by default on Solaris and OSX
Michael Jeanson [Sat, 23 Apr 2016 13:59:14 +0000 (09:59 -0400)] 
Disable debuginfo by default on Solaris and OSX

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoDocs: Add --debug-info-target-prefix to man page
Jérémie Galarneau [Fri, 22 Apr 2016 21:31:17 +0000 (17:31 -0400)] 
Docs: Add --debug-info-target-prefix to man page

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoAdd source and information to regenerate debuginfo-data
Antoine Busque [Fri, 22 Apr 2016 15:34:21 +0000 (11:34 -0400)] 
Add source and information to regenerate debuginfo-data

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoUse bool where possible in dwarf and bin-info
Antoine Busque [Thu, 21 Apr 2016 06:26:04 +0000 (02:26 -0400)] 
Use bool where possible in dwarf and bin-info

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoRename so-info to bin-info
Antoine Busque [Thu, 21 Apr 2016 05:55:10 +0000 (01:55 -0400)] 
Rename so-info to bin-info

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoUse printf_debug/verbose in so-info
Antoine Busque [Thu, 21 Apr 2016 05:02:27 +0000 (01:02 -0400)] 
Use printf_debug/verbose in so-info

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: update tests for new dwarf func name output
Antoine Busque [Wed, 20 Apr 2016 21:38:43 +0000 (17:38 -0400)] 
Fix: update tests for new dwarf func name output

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoUpdate debuginfo to match UST event rename
Antoine Busque [Wed, 20 Apr 2016 21:35:40 +0000 (17:35 -0400)] 
Update debuginfo to match UST event rename

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoUse g_build_path for DWARF build_id lookup
Antoine Busque [Wed, 20 Apr 2016 21:25:59 +0000 (17:25 -0400)] 
Use g_build_path for DWARF build_id lookup

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoAdd --debug-info-target-prefix
Antoine Busque [Tue, 19 Apr 2016 23:57:57 +0000 (19:57 -0400)] 
Add --debug-info-target-prefix

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoRefactor offset string printing out of ELF and DWARF lookups
Antoine Busque [Tue, 19 Apr 2016 19:24:45 +0000 (15:24 -0400)] 
Refactor offset string printing out of ELF and DWARF lookups

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoPrint offset relative to function when using DWARF
Antoine Busque [Tue, 19 Apr 2016 17:43:10 +0000 (13:43 -0400)] 
Print offset relative to function when using DWARF

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoPrint bin location first
Antoine Busque [Mon, 18 Apr 2016 22:34:11 +0000 (18:34 -0400)] 
Print bin location first

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoAdd binary location information
Antoine Busque [Mon, 18 Apr 2016 22:31:53 +0000 (18:31 -0400)] 
Add binary location information

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: prevent uninitialized use of elf_file
Antoine Busque [Mon, 18 Apr 2016 22:30:43 +0000 (18:30 -0400)] 
Fix: prevent uninitialized use of elf_file

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoOnly set so info ELF file when needed
Antoine Busque [Fri, 15 Apr 2016 21:39:24 +0000 (17:39 -0400)] 
Only set so info ELF file when needed

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoUse is_pic field instead of reading ELF header
Antoine Busque [Fri, 15 Apr 2016 20:54:18 +0000 (16:54 -0400)] 
Use is_pic field instead of reading ELF header

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoFix: make short_src_path from src_path
Antoine Busque [Mon, 18 Apr 2016 20:24:29 +0000 (16:24 -0400)] 
Fix: make short_src_path from src_path

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoTests: clean generated tests scripts
Jérémie Galarneau [Wed, 20 Apr 2016 21:15:20 +0000 (17:15 -0400)] 
Tests: clean generated tests scripts

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.041687 seconds and 4 git commands to generate.