Julien Desfossez [Fri, 29 Sep 2017 20:07:52 +0000 (16:07 -0400)] 
fix: compare position safely even in case of overflow
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Fri, 29 Sep 2017 19:35:50 +0000 (15:35 -0400)]
fix rotate pending on relay
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Fri, 29 Sep 2017 16:25:17 +0000 (12:25 -0400)]
fix sampling positions after the put_next + fix data_rotate_pipe handling
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Thu, 28 Sep 2017 20:26:42 +0000 (16:26 -0400)]
wip rotate consumer pipe
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Thu, 28 Sep 2017 17:47:05 +0000 (13:47 -0400)]
fix rotate pending notif with session id
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Wed, 27 Sep 2017 19:58:26 +0000 (15:58 -0400)]
fix locking for rotate timer vs session destroy
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Tue, 26 Sep 2017 16:53:29 +0000 (12:53 -0400)]
append rotate count in temporary folder
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Tue, 26 Sep 2017 16:52:59 +0000 (12:52 -0400)]
data pending returns true when rotate is pending
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Tue, 26 Sep 2017 16:52:42 +0000 (12:52 -0400)]
set session active before enabling the timers
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Thu, 21 Sep 2017 21:03:20 +0000 (17:03 -0400)]
rotate timer working
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Tue, 19 Sep 2017 18:38:31 +0000 (14:38 -0400)]
rotate timer ready, need UI/API
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Mon, 18 Sep 2017 15:58:33 +0000 (11:58 -0400)]
config for pending timer + rate limiting
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Fri, 15 Sep 2017 21:39:57 +0000 (17:39 -0400)]
rotate pending on the relay working
just need to find a default value
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Fri, 15 Sep 2017 19:37:57 +0000 (15:37 -0400)]
stop timer thread
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Fri, 15 Sep 2017 18:26:43 +0000 (14:26 -0400)]
timer thread in progress
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Mon, 11 Sep 2017 20:21:01 +0000 (16:21 -0400)]
rotate pending working on the relay
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Fri, 8 Sep 2017 19:06:55 +0000 (15:06 -0400)]
send the rotate pending to the relay
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Thu, 7 Sep 2017 18:13:44 +0000 (14:13 -0400)]
working for metadata on the relay
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Wed, 6 Sep 2017 20:30:27 +0000 (16:30 -0400)]
start to handle async rotation on the relay + basics for remote rotate_pending
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Mon, 7 Aug 2017 20:39:03 +0000 (16:39 -0400)]
Send domain with streams to the relay
For session rotation, the relay needs to know if the session contains
kernel and/or ust channels, so we now send the domain with each stream
and store it in the relay_session.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Tue, 5 Sep 2017 18:19:21 +0000 (14:19 -0400)]
quick fixes
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Fri, 1 Sep 2017 19:29:49 +0000 (15:29 -0400)]
fixed metadata regen + indexes, it is working
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Fri, 1 Sep 2017 19:12:49 +0000 (15:12 -0400)]
rename works on the relay
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Thu, 31 Aug 2017 15:58:34 +0000 (11:58 -0400)]
rotating on the relay
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Wed, 30 Aug 2017 22:14:58 +0000 (18:14 -0400)]
relayd_rotate_stream basics in place
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Wed, 30 Aug 2017 20:22:19 +0000 (16:22 -0400)]
correct path sent to the consumer even with a relay
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Fri, 25 Aug 2017 20:04:22 +0000 (16:04 -0400)]
tmp
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Thu, 24 Aug 2017 21:42:10 +0000 (17:42 -0400)]
check if the stream is ready for rotation between get_next and put_next
This will allow to send the extended data header to the relay and rotate
as soon as the current packet is written to the trace file.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Wed, 23 Aug 2017 20:35:32 +0000 (16:35 -0400)]
no need to keep the channel lock during stream rotation
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Tue, 22 Aug 2017 21:05:14 +0000 (17:05 -0400)]
handle empty sessions
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Tue, 22 Aug 2017 18:54:23 +0000 (14:54 -0400)]
move the rename code at the end of the rotation
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Wed, 16 Aug 2017 19:48:16 +0000 (15:48 -0400)]
Move mkdir/rename code to the consumer
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Fri, 28 Jul 2017 15:54:38 +0000 (11:54 -0400)]
fix
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Wed, 26 Jul 2017 20:01:04 +0000 (16:01 -0400)]
post-rotation cleanup
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Wed, 26 Jul 2017 18:54:59 +0000 (14:54 -0400)]
refactor: put in common all consumer code
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Wed, 26 Jul 2017 16:16:09 +0000 (12:16 -0400)]
re-dump metadata cache at the right place
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Fri, 31 Mar 2017 20:21:58 +0000 (16:21 -0400)]
Basic structure for the rotate command
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Tue, 25 Jul 2017 21:07:06 +0000 (17:07 -0400)]
Support for the metadata cache dump kernel command
This command allows the consumer daemon to reset the read position of
the metadata cache to 0. That way, it can be read again. This is used by
the session rotation feature to get a new copy of what was in the
metadata cache without regenerating it and re-sampling the offset from
epoch.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Tue, 25 Jul 2017 18:13:00 +0000 (14:13 -0400)]
Common code to wakeup the metadata pipe
We need to be able to wakeup the metadata thread when the rotation of a
metadata stream is complete.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Mon, 28 Aug 2017 19:36:49 +0000 (15:36 -0400)]
Cleanup subdir for CONSUMER_DST_NET
The subdir in the consumer_output structure is supposed to be the
domain-specific sub-directory (/kernel or /ust), but currently we
prepend <hostname>/<session-name> to this subdir for sessions that use a
relay.
Here, we introduce the dst.net.base_dir to store the
<hostname>/<session-name> in the consumer_output and keep subdir
only for the domain-specific data.
This is useful for session rotation where we need to insert the
chunk-name between the session-name and the domain-specific folder.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Mon, 24 Jul 2017 20:01:30 +0000 (16:01 -0400)]
Change trace_path to session_root_path and chunk_path
Prepare for the trace rotation feature where we need to store the root
path of the session and create a subdirectory for each chunk of trace.
For now, the chunk_path is \0, so the behaviour does not change.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Tue, 29 Aug 2017 18:52:59 +0000 (14:52 -0400)]
Fix: path of snapshots with a relay and default URI
When recording a snapshot to a relay without custom URI (ex:
net://localhost vs net://localhost/custom), the snapshots end up being
stored in ~/lttng-traces/<hostname>/snapshot-XXX instead of being inside
the <session-name> folder like on local snapshots. We would expect the
path to be: ~/lttng-traces/<hostname>/<session-name>/snapshot-XXX
So there is a discrepancy between the local and remote behaviour. This
behaviour has been there since at least v2.6, maybe earlier.
Moreover, there is nothing that informs the user about the default
snapshot name, so it is not possible to know where a snapshot has been
stored.
After parsing the URI provided by the user, we now check if a custom
name was provided or copy the session name there. This is the same
operation performed in _lttng_create_session_ext.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Wed, 23 Aug 2017 20:38:20 +0000 (16:38 -0400)]
Fix: wrong use of the relay_streams_sent in snapshot
The relay_streams_sent message is only useful in live sessions and
should only be sent after all the streams of a channel have been sent.
Here we were sending this message every time we sent a stream to the
relay during a snapshot which makes no sense.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Wed, 23 Aug 2017 20:08:42 +0000 (16:08 -0400)]
Fix: the return code of lttcomm_send_unix_sock is signed
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Mon, 7 Aug 2017 20:43:29 +0000 (16:43 -0400)]
Merge branch 'master' of git://git.lttng.org/lttng-tools
Jérémie Galarneau [Mon, 7 Aug 2017 20:07:53 +0000 (16:07 -0400)] 
Update version to 2.11.0-pre
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Mon, 7 Aug 2017 14:18:35 +0000 (10:18 -0400)]
Merge branch 'master' of git://git.lttng.org/lttng-tools
Michael Jeanson [Wed, 2 Aug 2017 18:26:18 +0000 (14:26 -0400)] 
Typo: occured -> occurred
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 2 Aug 2017 20:49:44 +0000 (16:49 -0400)]
Fix: ensure kernel context is in a list before trying to delete it
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 2 Aug 2017 19:24:00 +0000 (15:24 -0400)]
Harmonize return code conventions in context handling
Mathieu Desnoyers [Wed, 2 Aug 2017 15:34:43 +0000 (11:34 -0400)] 
Fix: uninitialized return value on error path
Found by Coverity:
*** CID
1378810: Uninitialized variables (UNINIT)
/src/bin/lttng-sessiond/context.c: 73 in add_kctx_all_channels()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Fri, 28 Jul 2017 20:36:48 +0000 (16:36 -0400)] 
lttng enable-channel: disallow --overwrite and --blocking-timeout
The overwrite mode has no impact on LTTng-UST when there's a set
blocking timeout.
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Fri, 28 Jul 2017 20:30:42 +0000 (16:30 -0400)]
lttng-enable-channel(1): reword --blocking-timeout, document in description
Also change the synopsis so that you can specify --blocking-timeout,
--overwrite, or none, but not both.
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Fri, 28 Jul 2017 19:48:32 +0000 (15:48 -0400)]
lttng enable-channel: --blocking-timeout opt.: use `inf` instead of -1
It might be -1 for the API, but for a command-line interface used by
humans, `inf` is more meaningful than -1.
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Fri, 28 Jul 2017 18:15:40 +0000 (14:15 -0400)]
Cleanup: remove unused internal structure
There is TODO to add content to lttcomm_relayd_update_sync_info
since 2012 (commit
173af62f4804133d4a7f45e34b6f72126f3eca5f),
the intent is really not clear and this is never going to
happen, let's remove it.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 1 Aug 2017 18:53:25 +0000 (14:53 -0400)]
Cleanup: remove unnecessary extern qualifier
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 1 Aug 2017 18:52:57 +0000 (14:52 -0400)]
Docs: document the trigger API
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 1 Aug 2017 18:29:02 +0000 (14:29 -0400)]
Docs: document the notification API
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 1 Aug 2017 18:23:43 +0000 (14:23 -0400)]
Docs: document the notification channel API
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 1 Aug 2017 17:57:39 +0000 (13:57 -0400)]
Docs: document the evaluation API
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 1 Aug 2017 16:25:57 +0000 (12:25 -0400)]
Docs: document the lttng_condition API
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 31 Jul 2017 18:58:18 +0000 (14:58 -0400)]
Docs: document the lttng_buffer_usage condition API
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 31 Jul 2017 18:08:19 +0000 (14:08 -0400)]
Docs: document the lttng_action_notify action type
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 31 Jul 2017 18:07:59 +0000 (14:07 -0400)]
Docs: document the lttng_action API
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 31 Jul 2017 21:51:35 +0000 (17:51 -0400)]
Fix: ambiguous ownership of kernel context by multiple channels
A kernel context, when added to multiple channels, must be copied
before being added to individual channels. The current code
adds the same ltt_kernel_context structure to multiple kernel
channels which introduces a conceptual ambiguity in the ownership
of the context object.
Concretely, creating multiple kernel channels and adding a context
to all of them (by not specifying a channel name) causes the context
to be added to each channels' list of contexts, overwritting the
context's list node, and causing the channel context lists to become
corrupted. This results in crashes being observed during the
destruction of the session.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Mon, 31 Jul 2017 18:09:44 +0000 (14:09 -0400)]
lttng-enable-channel(1): move --output description to maintain A-Z ordering
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Mon, 31 Jul 2017 18:08:28 +0000 (14:08 -0400)]
lttng-enable-channel(1): document --monitor-timer
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 28 Jul 2017 21:00:07 +0000 (17:00 -0400)]
Prettify channel listing
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 27 Jul 2017 22:39:45 +0000 (18:39 -0400)] 
Use pipe instead of eventfd() for notification command queue
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Fri, 28 Jul 2017 18:12:32 +0000 (14:12 -0400)]
Remove unused structure
There is TODO to add content to this structure since 2012 (commit
173af62f4804133d4a7f45e34b6f72126f3eca5f), the intent is really not
clear and this is never going to happen, let's remove it.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Fri, 28 Jul 2017 18:11:59 +0000 (14:11 -0400)]
Merge branch 'master' of git://git.lttng.org/lttng-tools
Jonathan Rajotte [Wed, 26 Jul 2017 14:53:53 +0000 (10:53 -0400)]
Cleanup: useless reset of ret to zero
ret is overwritten in the normal code flow.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Wed, 26 Jul 2017 14:52:15 +0000 (10:52 -0400)]
Fix: ret is never used on error_open code path
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Wed, 26 Jul 2017 14:29:17 +0000 (10:29 -0400)]
Fix: use error code path instead of break when errors happen before execl
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 21:56:58 +0000 (17:56 -0400)]
Cleanup: ignore useless check of execl() return value
execl only return if there is an error. errno is handled hence no need
to consider the return value which would always be -1.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 21:46:47 +0000 (17:46 -0400)]
Fix: wrong variable assignment on error
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 21:43:58 +0000 (17:43 -0400)]
Cleanup: remove dead increment of pointer
No further memcpy is performed no need to increment the pointer.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 21:20:45 +0000 (17:20 -0400)]
Fix: missing error handling in use of print_tabs()
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 21:12:31 +0000 (17:12 -0400)]
Cleanup: functions shall have a single exit point
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 20:57:50 +0000 (16:57 -0400)]
Cleanup: remove dead assignment
Only handle cases where the returned error is not EEXIST. ret is
overwritten anyway.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 20:29:53 +0000 (16:29 -0400)]
Cleanup: remove dead assignment
ret is not used when jumping to error_no_alloc.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 20:26:25 +0000 (16:26 -0400)]
Cleanup: remove dead assignment
Both calling sites do not use the return value and errors are already
managed inside the called function.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 19:55:31 +0000 (15:55 -0400)]
Cleanup: remove dead assignment
Artifact of refactor done in
f8f3885cc52af9d3c951da78989d6f4a25270411
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 19:51:34 +0000 (15:51 -0400)]
Cleanup: remove dead assignment
ret is not used for further error propagation.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 18:11:02 +0000 (14:11 -0400)]
Cleanup: remove dead assignment
ret is overwritten no need to reset it.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 18:07:30 +0000 (14:07 -0400)]
Cleanup: remove dead assignment
ret is always overwritten hence assign a value here is not necessary.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 18:05:17 +0000 (14:05 -0400)]
Cleanup: remove dead assignment
ret is never used in error code path.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 18:03:36 +0000 (14:03 -0400)]
Cleanup: remove dead assignment
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 18:01:48 +0000 (14:01 -0400)]
Cleanup: dead assignment
ret is never used for error, use err instead.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 15:31:02 +0000 (11:31 -0400)]
Fix: ret is used instead or err to set an error code
Use err instead of ret. ret is never used for error reporting under
error label.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 15:14:55 +0000 (11:14 -0400)]
Cleanup: remove dead assignment
Artifact of refactoring done in
f8f3885cc52af9d3c951da78989d6f4a25270411
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 14:54:48 +0000 (10:54 -0400)]
Cleanup: remove dead assignment
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 25 Jul 2017 14:45:32 +0000 (10:45 -0400)]
Fix: report error using fd instead of ret
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Tue, 25 Jul 2017 01:42:49 +0000 (21:42 -0400)]
lttng-enable-channel(1): reword and fix style of --blocking-timeout description
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Tue, 25 Jul 2017 01:36:36 +0000 (21:36 -0400)]
Fix: doc/man: use a single XSL file and match local names
Matching the local name instead of the full name, that is:
*[local-name() = 'co']
instead of just `co` matches both the non-namespaced element and
the DocBook-namespaced element whether we're using the DocBook 4.5 or
DocBook 5.0 stylesheets.
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Francis Deslauriers [Mon, 12 Jun 2017 16:13:23 +0000 (12:13 -0400)] 
Tests: rework select_poll_epoll test to improve verbosity on failure
Prints the tested values that caused a test failure to ease the
troubleshooting of unreliable tests.
Also, clean-up unused variables in multiple testcases.
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 28 Jul 2017 15:26:09 +0000 (11:26 -0400)]
Only print relevant session statistics on stop
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 28 Jul 2017 14:59:30 +0000 (10:59 -0400)]
Fix: NULL passed to memcpy in error path
CID
1378708: Null pointer dereferences (FORWARD_NULL)
Passing null pointer "data" to "memcpy", which dereferences it.
Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 28 Jul 2017 14:42:46 +0000 (10:42 -0400)]
Only print relevant session statistics in channel listing
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 27 Jul 2017 21:55:14 +0000 (17:55 -0400)]
Uniformize the printing of units in session listing
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.051617 seconds and 5 git commands to generate.
projects / lttng-tools.git / log
