TMF: Update the target platforms

Setting target platform in the most recent kepler caused problems because
some plugin references were updated. This patch fixes it.

Change-Id: Ie9fc5911a4104654d7e0022dd28c878a97311017
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/21282
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

tmf: Move creation of timer to init method instead of constructor

By the doing this, the timer is not running when creating trace
instances for validation.

Also, cancel timer when trace is disposed.

Change-Id: I4269ddb1faba771c039649d92f2e1477076668c8
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21138
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI

Fix building tmf/lttng help plugins using Luna platform

The ant tasks from Mylyn moved so the classpath needed
to be updated.

Change-Id: I92b7b96a3225712a80332f84ad6e589298eda710
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21214
Tested-by: Hudson CI
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
IP-Clean: Alexander Kurtakov <akurtako@redhat.com>
Tested-by: Alexander Kurtakov <akurtako@redhat.com>

tmf: Fix reading HTNodes while the tree is being built

A race condition could occur if a node would receive a query
after closeThisNode() was called, but before it was finished
writing itself to disk (in writeSelf()). It would result in
BufferUnderflowException's.

The important part of this patch is moving the "isDone" from
closeThisNode() to the end of writeSelf().

Also renamed the flag to isOnDisk, to reflect better what it
represents. It wouldn't even need to be written to the file,
but since a change in the file format is due soon-ish, might
as well change it all at the same time.

Change-Id: Ib22e3d56538057c7b3fd6655d32597b524fd8b28
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20984
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Cleanup TmfEventProvider

* Move the fDataQueue, as well as the whole concept of queue size, to
  the test stub. it was only used by that.
* Make some protected fields private.
* Change the ArrayList of pending requests to a linked list. We never
  access a specific index directly, and insertions are faster in a
  linked list.
* Remove fireRequest() from the interface, it should only be used
  internally.
* Remove queueBackgroundRequest(), it's not used anymore (this also
  removes the need for the dispatchRequest() method).

Change-Id: Ie9d2706f90d0afec1b01a35f2684c00eb83217fe
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20911
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Make TransientState really re-entrant

Wrap all reading and writing methods under a reader-writer lock.
This will allow much better consistency when querying a state
system while it is being built.

It was also required to rework the hasInfoAbout() method. Since the
state of the TransientState can change between two method invocations,
it was prone to race conditions. Now it will return the interval it
had at the time, if there is one.

Change-Id: I1a34e410eea1a02288c5388d1983e9c16ce56f0f
Reviewed-on: https://git.eclipse.org/r/21019
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Dispose analysis modules when the trace is disposed

There was a dispose() method in the StateSystemAnalysisModule, but
it came from HistoryBuilder, and was about disposing the state provider
only (which we do once the event request is complete, since we will not
need to insert more events in it). It had nothing to do with
ITmfComponent.dispose().

Add a "real" dipose method to the state system module, which disposes
the state system that was built, if any. And then also call that dispose
from TmfTrace.dispose().

This way the analysis module should:
- Correctly deregister from the TmfSignalManager, to be eligible for
  garbage collection.
- Dispose the statesystem object it contains, correctly closing any
  backend files.

Change-Id: I5836009f7172ab4ef9a41e22b5dbc0ef2fccbe4e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21072

tmf: Bug 426468: Wrong filter label provider in Control Flow view

Change-Id: I328db35ffdcb8f872a3277eb309472fd311aab97
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/21005
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

rcp: Add missing swtchart to RCP

Change-Id: Ic24fa1f8c53ba6aa94b2c08290aebff6e82fc5d3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21066
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Synchronize interval accesses in InMemoryBackend

Should fix concurrency issues when doing construction + queries
simultaneously on an InMemoryBackend.

Change-Id: Ie6339d1c1e58f72991be7f594f9361943b2fb051
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21074
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Add a waitForInitialization() to the state system module

With this, views and other components can be notified when the
underlying state system is instantiated and ready to be queried.

Change-Id: I0802d95b3311b1124803b55b3c5dd617e26afa48
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21069
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Enforce non-null state sytem backends

We now have a NullBackend for when we want a state system that
discards past intervals.

Change-Id: I8e62412ceac3c72c104cb512adb40b85b1ce9ce9
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21018
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Enable the CTF-testsuite tests

But blacklist those we know we don't currently pass. At least this
allows us to run the ones we *do* pass in CI.

Change-Id: I020d9f1ddfa5537c6f65c5f497c080541e4fb1ba
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20983
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Change to timer based coalescing of background requests

Coalescing of foreground requests are still based on signal
synchronization using start and end sync signal. Foreground requests
are meant for short and higher priority requests and need to be
processed right away.

Change-Id: Iae0cf886e4c932b1620a13057a9e1242702e2089
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20824
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

TMF: Add XML state provider analysis module and XML utilities

This patch adds an analysis module for an XML-defined state system. It does not
actually build the state system, the details will come in another patch.

It also contains the [stripped-down] XML schema definition and the methods to
read an XML file and validate it.

Change-Id: I2a3d322f96742d995912700d223e2ecb9e07d8f5
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/19914
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Don't use deprecated elements in poms.

Get rid of the "[WARNING] Parameter tasks is deprecated, use target
instead" from the build.

Change-Id: I69b3eac788f13dab3f20cb11e8c372833c03ba72
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/20925
Tested-by: Hudson CI

tmf: Fix usage of readNode() method in HistoryTree

Small fix to 726106b, the optimization to not look into the branch
in memory (when looking for a HTNode) should only be done when we
know the node is not in memory. The general case should use the
method from HistoryTree itself.

Change-Id: I3ce114f7f84f14f2dc892c400ab6aa768bab18fc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20902
Tested-by: Hudson CI

tmf: Don't return -1 for interval end times in the TransientState

This might make sense locally to this class, but no other component
anywhere uses -1 for an end time value. Plus it breaks the contract
checked at construction that the end time should always be > the start
time.

Instead of returning a dummy -1, return the latest known end time. This
is just as "wrong", but eventually we could augment to API to indicate
if it read a real interval or a current state.

Change-Id: Ia9a23f990dce3301c721996e75219bc34ed1164f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20903
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Use a foreground request for partial history checkpoints

This will ensure the checkpoint request does not get coalesced with
the "real" state history building request, as this would lead to
a deadlock.

Change-Id: I69f6ab52a75a3344a60869ac2b11332581afddd3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20836
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI

tmf: Change IAnalysisModule.getOutputs to return an Iterable

instead of a List, there is nothing that forces storing the
outputs as a list.

Change-Id: Id0a7105a3e2cce118cc0d48558a85ed2f5f85b0e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20777
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: fix coalesced request handling with one request

... and request with certain time stamp and certain number of events
requested. This will read less events than requested events.

This patch contains fix and test for it

Change-Id: I4a88308bccf858f9f8d112b8602cf80f02db06eb
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20771
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Tmf: Port the LTTng Kernel state system to an analysis module

And update the views accordingly.

Change-Id: I90975b5772db24a784d99d2d0232f6f76a8e5e03
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/19432
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Remove redundant CtfTmfEvent.getEventName() method

ITmfEvent.getType().getName() does the same thing, and is in the
interface.

Change-Id: Ia19b190cda820863955504bf980139a17e1a7ded
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20770
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI

tmf: Send relevant signals in a separate thread

This reverts commit be7fc7f31ae52da752bf021e828b9992ebfc44e4.
Instead the TmfTraceUpdatedSignal is sent using the
broadcastAsync() method of the TmfComponent in the case
that the trace index already exists. This ensures that the
the TmfTraceRangeUpdatedSignal is handled by all signal
handlers before handling TmfTraceUpdateSignal.

Also, the TmfTraceRangeUpdated signal is sent using the
broadcastAsync() method instead of spawning an own thread.

Change-Id: Idfb6660da90cbe7f21db8d838e2f151c008756a0
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20591
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add asynchronous way of broadcasting signals

For that the signal manager queues signals and executes them in order
of arrival in a separate thread.

Unit tests were added for the signal manager.

Change-Id: If3957bcdcc30dec3f25804586c6ee5aa10a102a1
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20590
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

[TMF] Optimize TimeGraphControl.drawState() method.

Gain on Linux after optimization is about 25%.
Note that it changes a bit the way events are displayed.

Change-Id: I0ff437c0d4ba832de73d6deb04c381015393617d
Signed-off-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Reviewed-on: https://git.eclipse.org/r/20415
Tested-by: Hudson CI

TMF: Add abstract XY line chart viewer on top of SWT chart

* Provides a viewer for line charts. With this viewer, all series will use
the same X axis data.
* It automatically creates series as values are provided for a key.
* A tooltip shows the values for each series at the selected x position.
* Series can also be manually added and the returned series can be modified,
so while "line chart" is the default representation, it can be used in other
ways.

Change-Id: I90b63e1dc87a1dbd49d37ff99fb22e04eecad2be
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/20342
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

[TMF] add public getters for fields used in TimeGraphControl.drawState

TimeGraphControl.drawState() is protected, and therefore can be overridden.
Unfortunately, this method uses two private fields: fEventColorMap and
fTimeGraphProvider. Therefore, in order to be able to override this method,
these two fields must have accessible getters.

Change-Id: Ia82d422f33b8a8c205b761104340b4d293fae33a
Signed-off-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Reviewed-on: https://git.eclipse.org/r/20424
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Add a ITmfStateSystem.waitUntilBuilt() method with timeout

This allows callers to "unblock" after a specified delay has elapsed.
Extremely simple to implement, as CountDownLatch already has a method
to do exactly this!

Change-Id: I1029729e8197b0f69af6072f4563145badeb3048
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20678
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI

tmf: Split ITmfStateSystem.waitUntilBuilt() in separate methods

Decouple the return value of waitUntilBuilt() in a new isCancelled()
method, so that it can be checked independently.

This is because we are planning to add a new waitUntilBuilt(long) method
with a timeout, and that one will have to return a boolean to indicate
if it returned due to the thing being built, or due to the timeout.

We will still want to check for the cancellation state afterwards.
Furthermore, it would be very confusing if both methods (with and without
the timeout) returned a boolean that meant different things.

Change-Id: If7a954d2368d55c99e30e31e17e39b39bca5f432
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20677
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI

TMF: Add Analysis API documentation

Change-Id: Ia8dfc072073555d4f969ec811c07c420fe3a60af
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/20125
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Lttng: smoke test

This is a sample of how to make a test using SWTBOT.
It should be a useful stepping stone to gain test
case coverage and control what we're reading.

The test features:
* opening a trace
* navigation in a trace
* testing lttng kernel perspective

What would be nice to have:
* closing a trace
* test views more thoroughly
* all the other functional test on all the trace types!

Change-Id: I2cb6b7a7f5a78206dfa8429f4e0111249ae9d933
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18154

tmf: Work around SWTBot test hang in the presence of GTK3

With GTK3, the SWTBot test hangs as soon as a Display.syncExec
is called on the swtbot thread (non-UI) which seems like a bug
in SWT. For now, GTK3 can be disabled by setting the SWT_GTK3
environment variable to 0. Note that for Kepler GTK2 is still
used by default so this is not a problem.

Change-Id: I4a5026f616ab032d95e90e4ad80cea665d552d3c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20407
Tested-by: Hudson CI

tmf: Add proper API to statesystem.backends.historytree

Change-Id: If860d2ba73cb001eb72dedb95c3982604b4c1b8e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19885
Tested-by: Hudson CI

tmf: Deprecate TmfStateSystemFactory and HistoryBuilder

State systems should be built from the analysis module now.

Change-Id: I4230c6514e4f0810108c65364fc66f0aa71d20bd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20466
Tested-by: Hudson CI

tmf: add TmfTimestampFormat tests

test 07, 007, 0.07, .007, 0.007, 0.00000007 ...
Basic regression tests for the parser

Change-Id: I458828d3ae8c74214b2281d95ac1bb51c44eb40f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20447
Tested-by: Hudson CI

ctf: Reformat and remove debugs in the CTF-Grammar

This is mostly a grammar reformatting.
My plan is to change some rules in the grammar.
I prefer to land the reformatting before playing with the grammar.

The 'debug_print' is useless in the grammar.
Antlr (and antlrworks) provides a really good debugger for debugging
this kind of grammar.

Change-Id: I6e590a168d2e5ff4502c36ea2fd8523b723d4399
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19483
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Add additional check for callsites

Change-Id: I41b4dfb24290a71ec33e4a57469dcf3e7739a481
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20074
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

lttng: remove unnecessary slashes in session path for remote import

Bug 425082

Change-Id: Ie94e3d7125ce7ce1dc1ef2ab85a0d76738a67dae
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20377
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add missing UI test arg for SWTBot on Mac

Change-Id: I4a66d932ef93b24028d62117d620709d9b37f024
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20522
Tested-by: Hudson CI

tmf: Fix parsing bugs in TmfTimestampFormat

- Fix bug when parsing a string with no sub-second delimiter
- Fix bug when parsing when the pattern has no sub-second delimiter
- Fix bug when parsing a string starting with a period without seconds
- Fix bug when formatting Long.MIN_VALUE
- Simplify code by letting base class only format the date/time pattern
- Improve and correct Javadoc comments

Change-Id: I2d5bcde62cc8f173c1340e84decbd9d770fc723f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/20520
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI

tmf: Add proper public methods to internal.tmf.core.statesystem

Those are already in internal packages, so they will not be API methods,
but by making them public, it makes it possible to access them directly for
unit testing.

Change-Id: I320317302ed6d6ccfc414d3666d2b657c1cd3207
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19884
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf RCP: Rename extracted folder of the trace viewer

It's good to have the directory named similarly to the archive.

Change-Id: I2654990b43025aadeba0e9f11fb483e5e039efd1
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20406
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

TMF: Add o.e.l.tmf.analysis.xml.[core|ui] to TMF feature

Change-Id: Ia53a49b162de2b0649721f158b24b746a2e93d6c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/20132
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Use state system analysis module instead of factory in tests

Change-Id: I2bb988f4476b71a48bedc71d8c3c4a8f87a61ea9
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19867
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Merge HistoryBuilder into the state system analysis module

The state system analysis module acts as kind of a state system
factory. There is no need to have a separate TmfStateSystemFactory
and HistoryBuilder class anymore.

Merging the history builder functionality into the state system
analysis module also allows for better handling of requests to
analyze the trace. Now it's possible to cancel the analysis job.

Later on, when all state systems (e.g. statistic state systems) are
built using the state system analysis module, the TmfStateSystemFactory
and HistoryBuilder can be removed.

Change-Id: Ibb52b20b6fdb16b665ad318cda04cf92d19ccf72
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19441
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Inherit null annotations

Maven does not do the "@NonNull -> unannotated" conversion automatically,
so it pretty much requires this setting to be enabled.

Change-Id: Ia99faebcaa127552dd5926d010d7cd2bad082d29
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20309
Tested-by: Hudson CI

Unify naming and bump releng-site version.

Change-Id: I98445db9d2c8ab6e3eaa018c169b010516021779
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/20440
Tested-by: Hudson CI

TMF: Add possibility to overwrite the path of the workspace root

By setting the environment variable TRACING_RCP_ROOT on the command line,
it uses this path as the workspace root instead of the default user home
directory.

Change-Id: I3cadec5b162e1dac99c4b5b9f30308a21c351f50
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/20400
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Tmf: Add the concept of module source to the Analysis API

This allows for other ways to define analysis modules than having to describe
them in the plugin.xml file.  For example, an XML file can be the source of an
analysis module.

The source itself needs to be described in the plugin.xml, using another
element of the analysis extension point.

Each module source will typically have its matching helper class to create the
instance of a module when required and to be able to access available modules
for different trace types before the trace is instantiated.

A default implementation of the IAnalysisModuleSource interface and its helper
are provided for the modules advertised through the extension point: the
TmfAnalysisModuleSourceConfigElement and TmfAnalysisModuleHelperConfigElement.

Change-Id: Ia2c7142704aa6b2a326bba9d2bf0734954427b7e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/19433
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Fix JDT Null annotations bug occuring in Luna builds.

The JDT compiler fails when a method implemented from an interface whose
class is tagged with @NonNullByDefault, redefines @NonNull on the
parameter. It seems the interface itself must redundantly define
@NonNull for the condition to get carried over.

Change-Id: I8663c0ba9994466f1cb9f56b1746a59051b4c8ef

tmf: Fix NPE in TmfTraceType when refreshing custom trace types

Since custom trace types are dynamic, TmfTraceType is constantly
refreshing the list of custom trace types whenever the available trace
types are requested.

Before reloading the list, the current custom trace types are removed
from the list. Because this refresh can occur concurrently in different
threads, a NullPointerException can occur.

This patch ensures that the custom parser list is only populated once at
initialization. The list is then modified dynamically as custom parsers
are created, edited or removed.

The list of custom trace types therefore no longer needs to be refreshed
when getting the available trace types.

Change-Id: I08bd0c351b0f573fe36e0fa7fd1aad62de81f1e5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/20093
Tested-by: Hudson CI

tmf: Tweak ITmfStateSystemAnalysisModule

- Decouple it from TmfStateSystemAnalysisModule, rename it to
  ITmfAnalysisModuleWithStateSystems. An analysis module could
  expose state systems independently of using the abstract class
  or not.

- Change the Map return to separate methods. I'm not very happy
  about getStateSystemId(), but the State System Explorer currently
  needs it. Ideally, the ID could be stored in the state system itself,
  so that this method would not be needed.

Change-Id: I1fcf20384c00b47578309451691f59fd0f438053
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20247
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: add abstract bar chart viewer on top using swt chart

It also adds a special histogram tooltip provider as well as an
example implementation (New Histogram view) that uses the swt chart
framework.

Change-Id: I03890eaf7a79ef7d9a48c23b26c49dca9544ea50
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20085
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: add dragging support with middle mouse button

This will update the current time window based on the new range.

Change-Id: If0f796d61c73d82294c832dacf9458e645e7b7ab
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20217
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: add simple tooltip provider for swt charts

Change-Id: Iaddea6d160fac65f781863b7f07a797cdbb3c072
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20156
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: add mouse wheel zoom to swt charts

Change-Id: I3e53e76b98423c0ca938a530eb33358627f9852b
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20083
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: add mouse drag zoom provider for swt charts

Change-Id: Id9fb2b32f37953890f288c90c2f908d5d8b396dc
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20082
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: add mouse selection provider for swt charts

Change-Id: Ibe73dfdea14354c149ae411e09f1f39a4a7a6220
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20081
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

TMF: Fix a bug in UI when refreshing analysis elements under traces

As it was, each time we would get the available analysis of a trace, it was
constructing new objects and those objects were not the same as the trace
element's children.

Also, while implementing the XML analysis source, the analysis were not
refreshed when the trace didn't already have children.

This patch uses the refreshChildren method to refresh analysis and outputs and
makes new objects are not constructed every time.

Change-Id: Ia33f7e20fea918a76bb341b808d074d3b1e130f2
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/20004
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI

tmf: Refactor resource change listener in project model

- Move resource change listener from every project element to the
project registry

- Create project in a WorkspaceModifyOperation to combine the many
resource change events into one.

- Only refresh the projects affected by the resource change event

- Update the model in the current thread on refresh

- Move the refresh from the project element to the base model element

- Refreshing the model children moved from the navigator content
provider to each specific model element

- Change getChildren from navigator content provider to simply return
the children list, that is now updated separately (as described above)

- Remove project from the registry when it is deleted

- Modify project registry to populate the model when getting a project
element for the first time

- Remove various unnecessary refresh of the model accordingly

- Do all modifications from the rename trace handler in a single
workspace modify operation

- Refresh all affected projects in the select trace type handler

Change-Id: I7e080e6b10617786a715e3cb39bf297b79168998
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19882
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: add abstract view and viewer classes for generation of SWT charts

Change-Id: I2d83280a63574727ceaf567db501119a7e0b2909
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20080
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Ensure order of trace updated and trace range updated signals

When the trace index already exists and doesn't need to be build
from scratch the signal TmfTraceUpdatedSignal is sent once in the
method buildIndex() of the TmfCheckpointIndexer. However, buildIndex()
is called from the signal handler of class TmfTrace for the
signal TmfTraceRangeUpdatedSignal. That causes that signal
TmfTraceUpdatedSignal is sent before TmfTraceRangeUpdatedSignal
is processed by all other signal handlers. This causes problems
for example in the Histogram view where the trace end time is not
set correctly because this wrong order of signal handling.

This patch fixes that problem by wrapping the sending of signal
TmfTraceUpdatedSignal in a TmfEventRequest which is only dispatched
by the TmfEventProvider (=TmfTrace) after the first signal
(TmfTraceRangeUpdatedSignal) is processed by all signal handlers.

Change-Id: I96dfdb4cc678722ff5b48a8881c67f5a8c11ff36
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20216
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Update drag&drop guide for unknown trace type icon

Change-Id: Ibbdc22c69c2a84edfe6bdbb84a407547b9dc6303
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20235
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Remove some unused images in help

Change-Id: I80555f91d737f8e007f89128f04abcf5215b25a9
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20225
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tracing RCP: Build with Java 7

Change-Id: I6135dccd6d0dce2182c839b9241b68a3d1705881
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20230
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

gdbtrace: Build with Java 7

Change-Id: I411bdd3cdc5ca6335fb8b8bfb95f8927f6235523
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20228
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Move to Java 7 and fix warnings

Change-Id: Ic9a2ea7c526baee118adc5cd5c1c6a9566139fcb
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20229
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: Move CTF plugins to Java 7 and fix warnings

Change-Id: I08e566e382f6c03d0bda05948dc391424aa9abfe
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20227
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Update swtbot tests to use Java 7

Change-Id: Iee44b29888663b49211600a8fd1e770ce5e8d8a3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20091
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: fix test failures due execution timeouts

The timeout deadline used to be calculated using integer instead of
long so that an overflow occurred and the actual deadline was much
shorter than intended.

Change-Id: Ia506f821f7c150ec8f96f47c50c1d683661a1dd7
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20224
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI

ctf: Add missing @since to previous patch

Change-Id: I8904a8df33397eaad653237b3e9ae0980a3d9bf6
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: fix occasional API error in tmf.ui.tests

Fix error about indirect reference to IPropertySource2

Change-Id: I52dd628639fcd88c4740f1228fd8ae8ca643bfff
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20219
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: move getStreams to an iterable.

This is an example of how to break the internals access.

Keep separate the "get/set/iterate" over an internals data-structure.

Change-Id: Id79b4eeedd3636de142d3317cbb1b1ae6fe2f50a
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19933
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

TMF: Added a method in UI tests to delay main thread until trace is opened

In o.e.l.tmf.ui.tests, the main thread often need to be put to sleep while a
trace element is being opened. The sleep time was put to 500 ms because that's
what showed best results. But sometimes, unit tests fail because it takes a bit
more than that. Instead of putting longer delays, we loop a certain number of
times until the trace is opened or after a certain timeout.

Change-Id: I662d951115eacbb3fa5b17cfe534a8e5c2a85eb4
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/20018
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

Introduce UI plug-in for examples based on tmf and lttng

Change-Id: I860bc1055448eed48f563939a872669a03ea8244
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20079
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: clean up pointer parsing in iostructgen

Change-Id: I03217fbb3900a771a53938df1e91d555461bf0c1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20070
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI

tmf: Switch tmf.core to Java 7 + fix warnings

Change-Id: I32fb093edb6bf70fdbe9a5ad1a9c8239a1e9ed05
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19927
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: batch import wizard smoke test

This is a sample of how to make a test using SWTBOT.
It should be a useful stepping stone to gain test
case coverage and control what we're reading.

The test features:
* a kernel trace generator
* importing a trace
* opening a trace
* navigation in a trace
* testing tracing perspective

What would be nice to have:
* closing a trace
* all the other functional test on all the trace types!

Please note that SWTBot needs to run on a non-UI thread.
https://wiki.eclipse.org/SWTBot/FAQ#Why_do_tests_run_on_a_non-UI_thread.3F
After the code was changed to run on a non-UI thread, it
was possible to remove many workarounds which made the code leaner and
easier to maintain. The UI code not handled by SWTBot still needs to run
in a UI thread, PlatformUI.getWorkbench() for example.

Change-Id: I91e258ed5fb7735287da303d518314460839547b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13780
Tested-by: Hudson CI

tmf: remove setting of anti-aliasing in histogram

The setting of anti-aliasing in histogram paintContro() is triggering
another redraw of the histogram. This endless redraw will make
the UI unresponsive. It seems only to happen on some Linux versions.
Until we figured-out the root cause it's better to remove the setting
of anti-aliasing.

Change-Id: I38b6f5062869a4ecaa32ad03d9883736d9475cec
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20006
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI

TMF: Moved the ProjectModelTestData in o.e.l.tmf.ui.tests to a shared folder

This test project can be used by tests from other ui plugins

Change-Id: Ida725bc10c9785c9d269995784d43551559f6353
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/20013
Tested-by: Hudson CI

tmf: Switch tmf.analysis.* to Java 7

No code to update yet.

Change-Id: I5cbacc515e8f9cf13dee90e30220e6590f111adb
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19931
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Switch tmf.ui.tests to Java 7 + fix warnings

Change-Id: I9acdba36689fa95d422a96606663e936d6fcd1ca
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19930
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Switch tmf.ui to Java 7 + fix warnings

Change-Id: I1fd5700aa5f37e6c279752374ab6c1bcf2633d20
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19929
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Switch tmf.core.tests to Java 7 + fix warnings

Change-Id: I1c048d7c15015e6eff0c3382cb6e15e9cc8de31a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19928
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix incorrect histogram state when concurrently cleared during drag

- Reset the offset when drag zoom interrupted by clear

- Update selection when drag selection interrupted by clear

- Fix overflow in min and max offset calculation

Change-Id: I6eea70d713d4b46e75d254b9374631623c023600
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19605
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI

lttng: Fix maven tests on Mac

Cocoa requires the Display to be created on the main thread
so -XstartOnFirstThread needs to be specified in the VM args.
Also use -Dorg.eclipse.swt.internal.carbon.smallFonts to make it
consistent with the fonts in the SDK.

Change-Id: If695baab41a35165f2cdc1120f088b5d6ba61354
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19888
Tested-by: Hudson CI

ctf: Add unittests for the CTF Lexer and Parser.

This is a first draft of unittests for the CTF Lexer and Parser.
The coverage of these tests is still incomplete. More unittests
are to come.

Some tests are commented and need to fix the grammars.
The plan is to fix them in future commits to limits the
amount of refactoring.

Change-Id: I2d8e06560314ef22710985915b726a74974bbb1c
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19485
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: simplify trace environment lookup

Environment is an immutable data structure.
Wrap it into an unmodifiable collection.

Change-Id: I29ab6d4671eae2c9efd59412f80186a10b9b4952
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19622
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Update Callstack View documentation

Add information about the Import Mapping File action, and document
the process for LTTng-UST traces.

Change-Id: I2db3c7e8021ed99bd7af9cbc7ed6a38fe06233b0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19845
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Enable the finish button when default target project is selected

The previous fix for the batch import "target project" page introduces
a default selection but the user still has to click on the list again
to enable the finish button.

Change-Id: I492cc1ff115d6208aa577a721f04d96ebd2a4e2c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19881
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Select a target project by default in batch import

Select the first list item by default in the last page of
the batch import (project selection). On Mac, no item is
selected by default. Since an item is now selected by default,
I changed the behavior of the page's message so that is only
displays an error when nothing is selected. Also, the Eclipse
UI guideline specifies that a page at initialization shouldn't
display an error, see
http://www.eclipse.org/articles/Article-UI-Guidelines/Contents.html#Wizards

Change-Id: I770fb9151f3c74a35dbf2d4e94db08f1301817cb
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19822
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: modify data-structure in CTF-Trace holding streams.

CTF allows multiple events to have the same ID as long as
they are not part of the same stream.

Thus, a unique event is represented by <stream-id, event-id>
and not only by event-id.

In this case, the CTF-Trace contains multiple streams
but maps all event-id into the same map (without stream-id).

Back-references are always a bad design.
In a future patch-set, the plan is to remove
CTF-Trace from CTF-Stream.

Change-Id: If5fc50d8541b152938a96447087d88c78e35e959
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19619
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Handle threads in statedump events

In the statedump of a kernel thread (tid), we used to only check the
'ppid' field to get the paren thread. This works only for *processes*,
not for threads.

For threads we should use the 'pid' field to indicate which is the
parent TID.

Thanks to David Goulet for pointing this out!

Change-Id: I6b309d671ce43958ca9c0b43c5912877dca14e38
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19728
Tested-by: Hudson CI
Reviewed-by: Florian Wininger <florian.wininger@polymtl.ca>

lttng: Add SWTChart to target defintions

Change-Id: Idd7728afa8293d236e74729b1d12ff5b67d5f0ee
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19732
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: Generate synthetic trace in test traces folder instead of temp dir

I was having problems with the synthetic trace now that the Luna branch
is merged into master because the index files got generated into the
synthetic trace folder and the folder would not get deleted on exit
because of that. Then the next test run, the trace would not get
generated because the folder already exists. I think it makes sense to
move the trace to the test traces folder and only generate it once.

Change-Id: I03e815c50e22adf2d5355856b8031cc7a8b4c9b1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19680
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

tmf: Avoid HistoryTree to expose its internal HT_IO node.

The HT_IO node is an abstraction of the file accesses for
a tree node. It should not be exposed to others classes.
The history tree must act as a proxy for requests to HT_IO.
This will ease modifications and maintenance of HT_IO.

HT_IO node should not keep a back reference to the HistoryTree.
This is a bad design. HT_IO node needs to know about HTConfig
to perform its tasks.

The HT_IO class contains method to read from disk.
The concept of a LastBranch is related to the HistoryTree.

Thus, readFromMemory is the same than calling

  HistoryTree.readNode(...)

and readFromDisk is the same than calling

  HT_IO.readNode(...)

Each layer is reponsible of its own caching mechanism.

Change-Id: Ia835a03efa321cdefd170de002833e044d144ee0
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19557
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Update @since annotations for 3.0

Change-Id: I53ec925b49cb24485f0fbaf2c6441b2914f1e452
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19458
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

lttng: Re-enable API tracking

This reverts commit 26595e5ced3af74051513822158484e57315aa16
(and adds API errors to the new tmf.analysis.xml.* plugins).

Change-Id: Id3d93a594bdbadb8973698df26a5683b1d02c71e
Reviewed-on: https://git.eclipse.org/r/19457
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: Remove a backward dependency into StreamInput to CTF-Trace.

This dependency is useless.
In fact, the creation of the indexes seems also to be useless.
I didn't find any use of it.

I think the notion of StreamPacketInputIndex should be an class
only use by StreamInput.

Change-Id: I7dc236a64ad9c8a33e0d0f2b701d8794ef3f9226
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19650
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>