doc: Rename documentation external tool builders

Rename those that referred to linuxtools instead of tracecompass, and
rename the others just to be consistent.

Change-Id: I10c00eea70c3a8c72f96ab58dacda3219461e046
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43197
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

TMF: Have IAnalysisModule#setTrace return boolean instead of throw exception

In an eventual future where the appliesToTraceType will be deprecated, in favor
of using analysis requirements, the setTrace method returns a boolean to
express whether or not the trace was successfully set.

Consequence of this: the helpers can now explicitly return null if the trace
was not set correctly and the callers of the IAnalysisModuleHelper#newModule
must check nullness of the module.

Change-Id: Idb06b4a3b1741d345a3e3412feee84a98aa1fed0
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/41568
Reviewed-by: Hudson CI

TMF: Specify if an analysis applies differently to an experiment

Add a 'apply_experiment' to analysis extension for analysis who have different
results for experiments containing their trace types than for the individual
traces. The result of the experiment analysis is more than the aggregation of
the traces' analyses.

Change-Id: I18122a26bb680fb2b240c98a4757f1bcce71b525
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/38446
Reviewed-by: Hudson CI

TMF: Cache average char width to speed up control flow drawing.

Before this fix, calls to gc.getFontMetrics() represented more
than 40% of the time required to draw the control flow for some
traces
(http://secretaire.dorsal.polymtl.ca/~fdoray/tracing/screenshots/getFontMetrics.png)

With this fix, the method is called only once. Navigation is
much more fluid for traces that contain a lot of state changes.

This fix should also be applied to other similar presentation
providers.

Change-Id: I5dd7815f9ee52e24d6467250fea4e0859be202f6
Signed-off-by: Francois Doray <fdoray.eclipse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43182
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

ctf: remove CtfTmfTimestamp.

It does everything TmfNanoTimestamp does but not as well.

Change-Id: Ifba86f402fe0d7a26f7550ca30297108fcd8b753
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43265
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add message to state system exceptions

Change-Id: Ic8e75aed32690dae72ba2f907d1fc8ebc170de1e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/41977
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Fix references to linuxtools in comments, examples and unused code

Change-Id: I5b548aee558fe9e9499d1116796a0b4d9fab2b77
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43198
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Fix activator plug-in IDs

Make sure PLUGIN_ID constants match the manifest plug-in ID.

Remove duplicate GDB core plug-in activator.

Fix plug-in unit tests.

Change-Id: I078e4493da3e1dcb5ee95bff0e8f1a9456fadb1f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43193
Reviewed-by: Hudson CI

rcp: Rename plugin.xml element ids for Trace Compass

Rename some menu and separator ids for uniqueness and consistency

Change-Id: I278d7eb1df59e52bc1d18e1446851b424057a941
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43196
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Fix feature provider in feature.properties

Change-Id: Iecff5881e8978dc830b99d3824c4aec291369818
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43195
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Fix excluded documentation plugin ids in pom.xml

Change-Id: I1a4c427c0fb49b60004d75a5c1b48be0e7ce791c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43194
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Mark TmfTraceUtils @NonNullByDefault

Change-Id: I5121586872f26e8ed3f3f790611a91d51b3f9b28
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41856
Reviewed-by: Hudson CI

tmf: TmfTraceManager improvements

Since the #getCurrentContext() can change at any time, but the
trace context object itself is immutable, it's safer to expose
the context rather than individual getters.

Many views gather all available timestamps in the following fashion
(assuming here we "expand" the calls to getCurrentContext()):

  selectionStart = tm.getCurrentContext().getSelectionStart();
  selectionEnd   = tm.getCurrentContext().getSelectionEnd();
  windowStart    = tm.getCurrentContext().getWindowRange().getStart();
  windowEnd      = tm.getCurrentContext().getWindowRange().getEnd();
  ...

If the context changes mid-way during these calls, the gathered time
ranges will be inconsistent. It'd be safer to extract the context
locally first.

Also updated the TmfTraceContext to return a TimeRange for the current
selection (it used to be a single timestamp, now we support a range).
This required updating the tests.

Change-Id: Ia44dc7157a2b98f320dcd92fd3856148dac4f47b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41986
Reviewed-by: Hudson CI

Fix performance tests by changing derby dependency to derby.core

eclipse.test.performance now depends on apache.derby.core instead of
apache.derby so we need to update our targets.

Change-Id: I7dfd86ac52346f08ca7585f91a9a7a8a2a8a6d8d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43340
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Upgrade maven plugin versions

Also add a few missing versions.
I used this command to check for updates:
mvn versions:display-plugin-updates -Djava.net.useSystemProxies | grep "\\->" | sort | uniq

Change-Id: Iffafb504054a9ec0abdfc756218309bc51da4b4c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42935
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

tmf: Remove extraneous constructors from TmfTimeRange

Now that time ranges are immutable, they have no need for a copy
constructor, you can just re-use the previous instance.

Change-Id: I70d0c5a24ffcd1b2081fda47a18eb3068671521d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41985

TMF: Add some non null annotations to TmfTimeRange

And all the required changes and extra annotations to fix all the warnings

Change-Id: Ic6f58052550f5f4fcca119ecf6c6d3e2e16d3631
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41240
Reviewed-by: Hudson CI

lttng: Fix internal package visibility

Fixes an error when a test class refers to an internal core class in a Javadoc comment.

Change-Id: I89ac5b4ce10b7347c3e37afb033799ff52cf2a77
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43192
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix class names in extension point schemas

Change-Id: Id41c74e10fba954901a1d131202cbddd9f986395
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43191
Reviewed-by: Hudson CI

tmf: Fix assertion messages in AbstractPerspectiveChecker

Change-Id: I5efa32ea36f0ccc821edba4af6244b7e4c99ad37
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43116
Reviewed-by: Hudson CI

Bug 460386 clear SWTBot loggers before adding one

Change-Id: I51f3ed2fb2b5f4c68aea94634250c7526ed801af
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42245
Reviewed-by: Hudson CI

Move CTFTraceCallsitePerformance test to performance tests

Instrument it with Performance Meters.

Change-Id: Ibde3a72b96abc052fea8e357b0dcf915412e23d5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36780
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

Fix build against latest 4.5

This works around the new warnings but we might want to just drop support
for Eclipse 4.4 since CDT is not supporting it anyway.

Change-Id: Ia6afe62e97048d53ad03adafa590fddcc091ead3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43266
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

ctf: Don't throw runtime exceptions on invalid IntegerDeclaration attributes

Instead of an IllegalArgumentException, we can check earlier in IOStructGen
if the arguments we are about to pass are valid, along with the other
existing checks.

While at it, remove the check to forbid signed integers to have a size greater
than 1. 1-bit-signed is a valid representation, see Bug 457951.

Change-Id: Idb26e362973104e709b1d613783077ab56b41b94
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43173
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Add @Since to StateValues

I am expecting more of these patches in the next week

Change-Id: Ia7467bdedd1c9b7b53ace8dc2e9512ecb520b170
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43203
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

os.linux: Add a new WAIT_UNKNOWN state

The WAIT state resulting from the statedump events should be
handled slightly differently from, for example, the WAIT state
of a process being scheduled out at a sched_switch.

In the first case, we do not have any information in the trace
about *what* the process is actually waiting on. So it would
be interesting to differentiate it from a real WAIT_BLOCKED,
for which the user can follow the chain of dependencies.

With this patch, the statedump events set the processes to a new
WAIT_UNKNOWN state (and only if there is no prior status set),
different from the WAIT_BLOCKED used for active processes.

This should help a bit with the "everything-is-yellow" syndrome
that plagues your average CFV.

Thanks to Julien Desfossez for this suggestion.

Change-Id: I7d7bb1bfc1d314c822df5ee04bd8b33c6a0c7d36
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/42722
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

os.linux: Cleanup definition interfaces

"public static final" is implied for variables defined in
interfaces, so none of these keywords are needed.

Change-Id: If1964702cc57925e3b886714880745614d0ccf99
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/42721
Reviewed-by: Hudson CI

tmf.ctf: Do not expose CtfIteratorManager publicly

The recent re-enabling of the API tools shows us that CtfTmfTrace
exposes the CtfIteratorManager type - which is internal - publicly.

We now get a hodgepodge of iterator methods in CtfTmfTrace, but
this is more or less unavoidable due to current constrains:
CTFTrace, CtfIterator and CtfIterator are internal, so cannot
be exposed publicly.

Change-Id: I2acf4727e78be238c149f2f93a8cf7bc19713f8e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43120
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Add new @since 1.0 annotations

The API tool is a bit peculiar as to when it decides to run...
It's possible that some more annotations are needed.

Change-Id: If49b70cf359055f5531533b3f167981a0b15dffe
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43119
Reviewed-by: Hudson CI

Add API tool nature and builder to all code plugins

Now that we have a release (0.1.0) we can use as an API baseline,
we can re-enable in the API tooling in the master branch.

Change-Id: Ie187f365118d1891244c661698fe451af90c3a19
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43118
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Remove all existing @since annotations

Those are based off Linux Tools version numbers, so they need to
be removed before we can introduce new ones based on the Trace
Compass versions.

Change-Id: Ia0ea5eeb597f4cf5a3e6f10ee074e0621888bdee
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43117
Reviewed-by: Hudson CI

Update NullAnnotations for remote core

Change-Id: I796c68dfd9bdb304e5abf0f402b56b6e54068bca
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43126
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Explicitely add @NonNull to inherited parameters

Change-Id: I3fb5cc13bbc1d549579cf331db2a539241ada8ae
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43123
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ss: Move ownership of the SSID to the backend

Since the backend is the "deepest" element in the
state-system-stack, we normally have to create it first. And
to avoid back-references, other elements do not have access
to those above them.

The concept of State System ID however can be useful for any
component in the stack. For this reason, it's more convenient
to save it in the backend, where all components can access it.

Change-Id: I5dab7e358eccf7dee52ac7e5d2f8400e130d5161
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/42858
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

Upgrade jdt.annotation to 4.4

Change-Id: I29eb8f7fdaab38da3dc9bb80e8cda9833951e456
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43096
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Update copyright years of RCP branding and product

Change-Id: Ic14a933b147f23755fc6b0a6f1d8bb80c69b8327
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43019
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf-remote: bug 460842: update LTTng control preferences changes guide

Change-Id: I3fc3cdc4b69414c33714986ee31ed09ea23ed8bd
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42690
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf-remote: Bug 460842: introduce ICommandInput and implementation

Relevant references were updated and necessary null annotations added.

Change-Id: I30cd0c6ad0277ba50a0e65fb78bbe7effeea8e43
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42583
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf-remote: Bug 460842: change ICommandResult to use Lists

Change-Id: Icd11421a0081cd86031459476aca89bf46c27fe1
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42582
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf-remote: Bug 460842: clean-up ICommandShell and ICommandResult APIs

Change-Id: I0fe8cc51d6eb395c27c6387e7141e2caaa64c278
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42539
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Update text trace unit tests

Change-Id: I88084b23a5dfd2f9d8147fc372dc17742af359c6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/42584
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: reduce complexity of equals() methods in tmf.core

Update equals() of TmfExperimentLocation, TmfLostEvent, TmfCallsite,
CustomEvent, CustomTxtTraceContext and TraceValidationHelper

Change-Id: Iae90fcb77c1d33fe5220269c27cf4dadfc094dc6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42840

ctf: reduce complexity in VariantDeclaration equals

Change-Id: I2b05afc385b66855ee136248452b3ebebe62b8a8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42839
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: reduce complexity in CTFCallsite's equals

Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Change-Id: Ib76f8c3ae809b102c8b52bbec1bd8b4313d53c11
Reviewed-on: https://git.eclipse.org/r/42822
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf.ctf: reduce complexity in equals

Change-Id: If4f021760899c5886b8ee8bbef7fffe863dd1a39
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42841
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf.ui: reduce complexity in FileAndName equals

Change-Id: Ib7567ab3a1cad3d7bc0f907c08a4db8923f98538
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42842
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

common: add equalsNullable

check if two objects are null or equals().

Change-Id: Ic1e3266e84e88aece077ab45c20b995199125f70
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42821
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf-remote: Bug 460842: clean-up RemoteSystemProxy API

Change-Id: Iaac555117a8d0099d4d5e8ab712c9ff72c322bcd
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42538
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Bug 460842: Introduce tmf remote plug-ins and feature

Change-Id: Ia14b367b48cf59d2e41dee1a17ce055b8e3e0d9a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42537
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: move CtfReaderException to the ctf.core top-level package

Change-Id: Ica4bcd91299b349f129319986e420e4187df0eef
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42819
Reviewed-by: Hudson CI

tmf: Fix merge conflict in cfe2f40: Remove deprecated and unused methods

Change-Id: I82a8c18fdc644cb23a20b5b6b0560ba317563018
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/42827
Reviewed-by: Hudson CI

tmf: Allow TextTraceEventContent to add new fields

This allows the content to be built progressively without having to
specify the field names at construction.

Change-Id: I44495a99bd36f5ddf4537fb66421e5a949c950b5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/42579
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

tmf: Add factory method with help text in TmfContentFieldAspect

This convenience method makes is much more easier and cleaner to create
the aspect list for a trace.

Change-Id: If7addc9f2b5221689331fccf8e1980b97daf5b76
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/42447
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: make metadata propagate file not found exception

Change-Id: Ifb5766f947d33f29d96e87f496dd8273762fa483
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42817
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

os.linux: Add support for thread priorities in the KernelStateProvider

This change tracks a threads priority in the KernelStateProvider. The
KernelThreadInformationProvider provides a new access method returning a
threads priority at a given timestamp.

Change-Id: I4911a75151f45b995ea2000d485d309e4b57313e
Signed-off-by: Christian Mansky <christian.mansky@gmx.at>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/42152
Reviewed-by: Hudson CI

ss: Enable StateSystemUtils tests

Also fix an incorrect test case and add a few more.

Change-Id: Ifa61814bc6d5b5e4395d072305e30f04a3a9b31a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/42707
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Fix NullPointerException during RCP startup

Change-Id: I49c7b490593088add311d073633e8ce6c943100a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42692
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Bug 460736 - Fix signing in the presence of packed jars

The pack200b plugin was executing before pack200a when sign-update-site profile
was active. The solution is to explicitly specify the pack200b to be after
pack200a in the profile.

Change-Id: I8e7a0d528e601dc8ca205b3a71d4fdb676081dfe
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42709
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

StateSystem: make isHistoryBackendBuilt have a getter and setter

Change-Id: Id53b72a4ef611dac4c7b915b67a9e14e4a2a5f1c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36818
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Update XML test traces to use long's instead of int's

The "prev_prio" and "next_prio" fields of CTF traces (as a matter
of a fact, *all* CTF integer fields) are interpreted as long's by
the CTF parser. To keep this consistent in the state providers,
update the XML test traces to use longs for these fields.

Change-Id: I3e2cf4793925ac769c5e1cf099ff51686779bed3
Signed-off-by: Christian Mansky <christian.mansky@gmx.at>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/42250
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Use a relative path for the FunctionNameMapper test file

This will allow the test to work when run from another Eclipse
plugin, for example when using the "alltests" runners.

Change-Id: I7fe8dcb5b675c5c6da160af7a4c78064041ef3cd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/42249
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Remove a quark literal in a test

Not very clear what "attribute #233" refers to, we should retrieve
the quark using the attribute path instead. This will keep the test
working if the number of attributes ever changes.

Change-Id: Ie97bc6468ac43529b5b78998f603a18773cd4b02
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/42248
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Bug 457287: Standardize feature names and descriptions

Change-Id: I86c3b992815a8dea696d68e4428bc056814bd478
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42327
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Change Linux Tools to Trace Compass in unchanged plugin.properties files

Change-Id: Ie0c6ad1e5699243df97b74862c1c61a09ba78ec4
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42559
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

Remove update site reference in all feature.xml files

Change-Id: I55cfbd1590b46f33395ce185c61a04d3696a96e3
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42542
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix time graph bounds reset on refresh and ignoring child entries

Calling refresh() or setInput() should not reset the bounds if they have
been set to specific values by the user.

When determining bounds based on the input time graph entries, only the
root entries were considered. All roots and their recursive children
should be considered.

The value SWT.DEFAULT can now be used as a time bound to indicate that
the bound should be set according to the input time graph entries. For
any other value the bound will be fixed and unaffected by the input.

This setting can be applied independently for each bound.

The distinction between user-specified and actual bounds is made clearer
in the API Javadoc.

Change-Id: Ia79d35d41ed08cf7475807f9d352b1931196e5d5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/42330
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Fix inconsistent tree item expansion in TimeGraphCombo

When refresh() is called, the tree viewer expanded all items but the
time graph viewer expanded to the auto-expand level. The tree viewer now
also expands to the auto-expand level.

When an entry filter is applied, the tree viewer expanded all items but
the time graph viewer expanded to the auto-expand level. The time graph
viewer now also expands all items.

Change-Id: Ied0d42d54a2a2b027e879db0d6f960854314eebe
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/42155
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Add list methods for trace package elements

Change-Id: I84043147a73880367e692cdefdc08f6e3d0ed75a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/42345
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng control: update to the remote API v2

Change-Id: Iedc8e9beb252a92065d51e795ba85b209e458264
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42160
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

tmf: Bug 460032: Fix concurrent update of XML presentation provider

Change-Id: Ie5dbbd7ddaa9737048ecdee4d383e43d094f0681
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41943
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Fix a few 'command' typos

Change-Id: I43b93bd5033b7b10172f7c26a29c9a454f72ed88
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41447
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

swtbot: add skeleton of sequence diagram test.

Change-Id: I4dc572323d6a89502340e855228a7f00861faf35
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41741
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

tmf: alphabetically sort experiment traces in project model

This ensures that they are always handled the same order
(e.g. Histogram)

Change-Id: Id80f4988d80e537127cde82d37e7f443b7c944d1
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41924
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Provide packed jars in update site

This is recommended to use in eclipse p2 repositories to reduce bandwidth.

If we need to provide a zip of the update site in the future, we should
consider the workaround done by CDT to reduce the zip size, see
https://git.eclipse.org/r/#/c/39624/

References:
https://wiki.eclipse.org/Tycho/Pack200
https://wiki.eclipse.org/SimRel/Simultaneous_Release_Requirements#Provide_optimized_p2_repository_.28partially_tested.29
http://build.eclipse.org/simrel/mars/reporeports/reports/pack200data.txt

Change-Id: I80de8ccaf96c6741db890e079c590ea101e88a9d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41114
Reviewed-by: Hudson CI

lttng: Fix virtual machine experiment name

Make the default constructor use an empty name, which allows for the
super implementation to later override with the experiment element name.

Change-Id: I9236d20d40ba73336997150dce406e05243f4c0c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/41972
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Dispose wrapped trace in TmfXmlTraceStub

Change-Id: Ie30e1675a95edee83b691866cd4dec772768ffe1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/41970
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Bug 459493: TmfTimestampFormat doesn't parse extra spaces correctly

Change-Id: I632348edd64ac31fdafaa5ae7bd2e84ea3abb2bb
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/41945
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Bug 459835 - Fix starting the RCP from outside a shell with --open and ~ (home)

Change-Id: I89cff22648726cb7150f9e11844923df37208d5c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41785
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Add some missing about.html in bin.includes

Change-Id: I8d8d3f1298884abe67c6d350c271f33ceb4d04db
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41107
Reviewed-by: Hudson CI

Use Luna eclipse.remote to fix build

The API in eclipse.remote has changed significantly in Mars so our code doesn't
compile anymore. Since this is not a trivial fix, we will use the Luna version
until we make it work with the Mars version.

Change-Id: I8f1e77d8610e511d8b46802766cd60b8dc9f36ad
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41958
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Remove targets older than 4.4

We haven't supported targets older than 4.4 for a while now (one compile
error). Also, I don't think many people use them to track down platform
regressions.

Change-Id: Ic5183ab33b57ecd2c26d9d974cc90d92e4dbb9e4
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41363
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Bug 455414: Make bookmarks file immediately hidden at creation

Change-Id: Ic07f73ba61a668215532315b7e42bf4bb955a2dd
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/41853
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

TMF: Synchronize traces in an Eclipse job

This way, we can see the progress of the trace synchronization and cancel the
job if desired.

Change-Id: Ie77b9173be5bb4f7f08cf9e1aacca1210e05535d
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/39079
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

TMF: Fix performance issue in the filter dialog of the time graph view

This patch improves the performance of opening the filter dialog
of the time graph view. The dialog can take many minutes to open
with traces that contain 10 000+ threads, because of an O(n²)
algorithm to associate threads with their parent. With this change,
it takes about 8 seconds to open the dialog.

Change-Id: Ib4f4c41583705041a3df9d7ca26d2f883ffd9a43
Signed-off-by: Mathieu Cote <mathieu.cote@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/41789
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Tmf: Simplify trace synchronization by removing the network concept

Because when matching events from traces, conceptually, it is always a
"network" synchronization, whether the events are actual network events or
something else. The magic happens in the match event definition anyway.

Change-Id: I3d2903bb5669c0d650287a4a8b27b32a377a75e5
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/39076
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix updating of 'Event in selection' statistics (Bug 459571)

Change-Id: I1ec247ddde1256ee324f84d2743916a2b488eff1
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41538
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

doc: Document event aspects in the Dev Guide

Change-Id: I498a29311a8951bd60651cecccf20c8d49fbc648
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41471
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

doc: Updates to the first section of the Dev Guide

* Move the Nexus-lite example at the end of the section. Typically
  you exlain things first, then show an example, not the other way
  around.
* Apparantly the Nexus code itself was never merged in the tree.
  Remove the references to this code (hopefully the contents of
  the doc is still useful by itself).
* Wrap non-list text to 80 columns. Makes the text files and git
  diffs easier to read.

Change-Id: I790f8087a792ed66fae8f2d9511bf76d448ffbed
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41470
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: fix 'Link with Editor' for experiments and dir traces (Bug 459672)

Change-Id: I38cbbf99f85b9bbca7396f8376d84213a0d32ed7
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41636
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

TMF: Make the ITmfEvent#getTimestamp() return NonNull

And all the required NonNull annotations to fix all the warnings

Change-Id: If064c2ca2da96bbeb6c143f48e5b965e34b91314
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/41239
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

TMF: Add some NonNull annotations to ITmfTimestampTransform

And all the necessary NonNull annotations that this little change
requires

Change-Id: I4da75d6d936f0f1adbd3e5b27ca6182711557841
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/41238
Reviewed-by: Hudson CI

ctf: Add the symbol-mapping file of the cyg-profile trace

This file contains the output of 'nm' that was run on the binary
that was used to take the "glxgears-cyg-profile(-fast)" traces.

Change-Id: Ie889d9dc1a9ce359b451d3160c8938de6eb0c421
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41775
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Small updates to FunctionNameMapper

Make the class final w/ private constructor.

Use ImmutableMap instead of Collections.unmodifiableMap
(can't use an ImmutableMap.Builder though, because there will
be duplicate keys in what we read from the files).

Pre-compile the regex to remove leading zeroes.

Change-Id: I94a5d5b4c5aabd5357e52bf8c062c46ec8c2305b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41689
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

tmf: Add unit test for FunctionNameMapper

Change-Id: I54f8e407e67942d7d88b7947c5298b6046c0b72e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41688
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

tmf: Don't import uneeded entries in FunctionNameMapper

Lines from a 'nm' output file that represent non-static symbols
(so for which we don't have adresses) would create an entry in
the function map with an empty string as address.

This is because String.split(" ") would split the series of spaces
at the beginning of the line into many sub-strings. Simply doing
String.trim() first avoids that.

In practice it did not matter much because no entry in the view would
use the empty string key. Still, it's cleaner to fix it.

Change-Id: I4a3ac452aedd8d8cf4ff85db982ccd2c9fdf5693
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41687
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

tmf: Move FunctionNameMapper (for the Callstack View) to the core plugin

This also moves the dependency on cdt.core from tmf.ui to tmf.core.

Change-Id: Iefb44b7af16e281ec290115e66482ed3fbe84cc2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41686
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

Remove workaround in pom.xml's for a bug fixed 8 years ago

It's so old that the bug tracker does not even exist anymore...

Change-Id: I434b558eaf0b713da244a1d7a7384ddd793dd175
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41691
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Don't open trace files with validation confidence 0 (Bug 436444)

... and only one valid applicable trace type is available.

Change-Id: Id6494df2bf78d1be079ef12e729d6a869c81d260
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41566
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

[GDB Trace] Add 'Content' column back to events table (Bug 459711)

Change-Id: I2bca9e171d2abd7f6de13ea9c041f1c6a52d6d2a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41667
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

btf: Bug 459367: NumberFormatException when trying to open invalid file

Change-Id: I7bb0a3f147839cb04467036f0e8ca4b03d8a9b12
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/41473
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>