git.efficios.com Git - deliverable/tracecompass.git/log

releng: Fix ProjectExplorerTracesFolderTest

The generated clashing LTTng traces in TestDirectoryStructureUtil are
changed to have a duration of 1001 ns (not 1000 ns) for 1001 events.

This prevents the time delta between events from flooring down to 0 ns,
which causes all events and all packet begin and end times to be equal.

There is probably another bug in the CTF reader that seeks to the
incorrect packet when there are multiple packets with the same begin and
end times.

Change-Id: Icea44a26f9b4913c2bee7d0bddae575a7263b58f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/95961
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

segStore on disk: Fix boundaries for child lookup

Change-Id: I098c412edc8050dcabf9ec01d2b50208fbb89acb
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/95206
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

Revert "tmf.ui.swtbot: disable RawTextEditorTest#readTrace"

This reverts commit 03ec84392e7bf66cadb1c15b52369bba19a43aa4.

Change-Id: I01912a8171b6cf27ddbffdd0146f5a3d2ba90e0a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/95941
Reviewed-by: Hudson CI

Introduce an API to download and import traces from HTTP/HTTPS

This patch contains two parts:
- A class to download a file from HTTP links
- An import operation that use the download helper to import the
dowloaded traces in the workspace

Change-Id: I1b588b113e352630760a9cab0dfbfd0052368b29
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/94940
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf.ui.swtbot: Fix missing @Override in SWTBotSash.getBounds()

The parent now implements this method.

Temporarily disable failing checks in ProjectExplorerTracesFolderTest.

Change-Id: I4a60bfa5bafdc07eda2f840fdbda0c0b45a4661d
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/95815
Reviewed-by: Hudson CI

tmf.ui: Update JUL log points in time graph view

This will allow to analyze the command flow from the user interaction to
the views being updated with the new TraceCompassLogUtils API.

Change-Id: Ifa500032f060e8325dbcc3a9dd00c48ead706c59
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/93742
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

timing: Add a generic statistics table view

Change-Id: Ia199415d1b292fdf2175827ad687f1d41d7b7ff5
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/82285
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.core/ui: Move some logic of the symbol provider to core

This moves the Symbol provider to core. Special care must be taken to
ensure that the preference page is available if required.

Moves callstack symbol providers to core interfaces.

Makes flamegraph use symbol aspect.

Most changes are internal, so this does not affect the API much.
Also, now CallgraphAnalysis can be in Core.

Change-Id: Ie4c37b670f599fad8fb74e08b458c0db65bb312c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/95118
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.ui.swtbot: disable RawTextEditorTest#readTrace

Until we can figure out what is breaking the build disable this test.

Change-Id: I9428b2412934146fc1238adda067419aee5af876
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/95494
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Fix @NonNull annotation errors

Change-Id: Ide9dffbd1a0a416e832853b6d29737590e5c292c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/95415
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

xml: Move XmlUtils#getElementInFile to TmfXmlUtils

Change-Id: Icb71bc9f15f7b09ff556d579ca407574e6ff9ac3
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/92279
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

critical path: Fix condition that caused infinite loop

Change-Id: Ic52e2c8849fd00e543e47fe1d8ee4a87afd23ef3
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/95316
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI

xml: Move xml strings and schemas to public packages

Since the XML is now extendable, external plugins may need to make use
of those values, so they are now part of the API. As for the schema,
though not mandatory to run correctly, it makes it obvious that they
can be used by external plugins.

Also, a TmfXmlUtils class has been added to the API and the
getChildElements method from XmlUtils has been moved there.

Change-Id: If1a98badcf52cbbafe77699d0cf6c6e9df3b47c8
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/92276
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI

tmf.core: instrument checkpoint indexer

This shows how many events were read.

Change-Id: Iaf1e58f0d7a504e69e45d3d5040847670c79859f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/86559
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: Split ISymbolProvider into core and UI parts

The ISymbolProvider interface and related classes were all living in the UI
plugin only because of the preference page option, which is a UI-only
construct. This limitation was known since the inception of the symbol
provider, with the intent of eventually correctly splitting it into
core and UI components. This patch partially fullfills that.

Future work:

* Make symbol providers in core.

Change-Id: I64696929fcd8f47ba34b6a7b48d5e814faca7616
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/95115
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

releng: Don't use Guava references that will be removed in Guava 21.0

By doing that, it will be possible to use the same master build on
Neon and Oxygen.

com.google.common.base.Objects.ToStringHelper will be removed and
is replaced by apache.commons.lang3.builder.ToStringBuilder.

Change-Id: I646f6ae904c0541e2ebc15aa4276f7af9f99fbdd
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/95008
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

common.core: Add Counter events

These events can be used to fill line charts.

Change-Id: I223f3329d4f4d3d04fa365146ed5f7267f9a6d80
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93666
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: fix strike-through of analyses that can't be executed

Change-Id: I83db6e38616c54fa8b8537b055bee8819f39ac3e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/95032
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

timing.core/ui: make flamegraphs aggregate threads by default

If you have a flow of data with several threads using a scatter/
gather pattern, the flamegraph aggregates it to show the global
picture of all the threads.

To switch from the per-thread (default) to aggregate (classic) mode
and back, click on the drop-down menu and go to "Content Presentation".

Change-Id: I1fab0e09278d029302129071af31b1d809810b0a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93589
Reviewed-by: Hudson CI

segStore: rename SegmentStore performance tests correctly

The package had not been renamed correctly after moving from
analysis.timing to segmentstore plug-in.

Change-Id: I82b8d6c1bf835cbc96c333f9c3330b19ece29a0c
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/87051
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Extract getDistinctColor() method to Utils

It can be now used by other classes.

Change-Id: I9e868799a4da131cd9b94bd89b480ffba37e85a4
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/95006
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf.ui: Log analysis schedule/execute lifecycle.

This shows the use of flow scope event.

Change-Id: I7b6ea3c0be77c9b7f3b5b0abbcc043f44a4fec70
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/86391
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

tmf.core: Add logging to Request executor.

Change-Id: If204199f0bb5190b3bd9cea1d5f885d56686c7ce
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/86081
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

charts: Add swtbot plugin and utility class

Creates the o.e.t.charts.ui.swtbot.tests plugin and add chart utils
class to be used by other swtbot tests who will create custom charts

Change-Id: I942786338c5178f5ca67f4c63299fb056cb5ff1a
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91932
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Support nested experiments in core

This patch adds support for experiments within experiments in the core
plug-in. It is not yet possible to create nested experiments with the
Project Explorer UI, but this patch adds support for nested experiments
that can be created by plug-in extensions programmatically.

The method TmfTraceManager.getTraceSet() is now recursive and returns
only the leaf traces of a given experiment.

The method TmfTraceManager.getTraceSetWithExperiment() is now recursive
and returns all child experiments and traces of a given experiment,
including itself.

The method TmfTrace.traceOpened() now executes (e.g. analyses) when the
trace being opened is any parent of the trace instance.

Change-Id: I2afd97cd482e6724dfaf2d0eb687cbe81de2790c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/94773
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

segStore: getIntersectingElements performance tweaks.

Use binarySearch from (Lazy)ArrayList to correctly dimension
the returned ArrayList, resizing such large arrays happens
frequently during insertion and is costly.

Also stop copying elements into a new arraylist prior
to sorting if the returned Iterable is already a new
instance of arraylist.

Optimize TreeMapStore by reducing it to a single instance
of TreeMultiMap and using its ordered properties
efficiently to return intersecting Segments.

Benchmark results below, best if viewed in a spreadsheet:
SegmentStore Test Before (ms) After (ms) Gains (%)
LazyArrayList Fuzzy Iterate sorted by start 220 171 22.2727272727273
LazyArrayList Fuzzy Iterate sorted by end 45 27 40
LazyArrayList Fuzzy Iterate sorted by length 40 23 42.5
LazyArrayList Random Iterate sorted by start 382 289 24.3455497382199
LazyArrayList Random Iterate sorted by end 127 73 42.5196850393701
LazyArrayList Random Iterate sorted by length 119 71 40.3361344537815
Treemap store Ordered Insertion 1640 669 59.2073170731707
Treemap store Fuzzy Insertion 902 403 55.3215077605322
Treemap store Fuzzy Iterate sorted by start 1610 187 88.3850931677019
Treemap store Fuzzy Iterate sorted by end 1570 164 89.5541401273885
Treemap store Fuzzy Iterate sorted by length 1030 125 87.8640776699029
Treemap store Random Insertion 3960 898 77.3232323232323
Treemap store Random Iterate sorted by start 2890 299 89.6539792387543
Treemap store Random Iterate sorted by end 2460 299 87.8455284552846
Treemap store Random Iterate sorted by length 1550 275 82.258064516129
Treemap store Fuzzy First Insertion 923 196 78.7648970747562
Treemap store Fuzzy First Iteration 66 20 69.6969696969697
Treemap store Fuzzy Second Insertion 929 210 77.3950484391819
Treemap store Fuzzy Second Iteration 95 34 64.2105263157895
Treemap store Random First Insertion 3670 384 89.5367847411444
Treemap store Random First Iteration 265 25 90.5660377358491
Treemap store Random Second Insertion 4590 521 88.6492374727669
Treemap store Random Second Iteration 423 56 86.7612293144208

Change-Id: I3ae2191b74f4f2170f44f45a139b866753b2441a
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/86334
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

swtbot: Add new utility methods

Add these SWTBotUtils methods:

- SWTBotUtils.getBoundsToDisplay()

- SWTBotUtils.pressShortcut()

- SWTBotUtils.applyTimeGraphFilter()

- ImageHelper.waitForNewImage()

Change-Id: Ie30ac505726bc6e75223e19426960fb53c007fee
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/94495
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

xml: Add support for processing extended schemas

This adds an element to the XSD extension point to specify a class to parse
the extended schema elements. When creating helpers, those classes will
be called to provide the right analysis module helper that will create
the analysis module when necessary.

Change-Id: Ib31650c8d10f22842236935a52a7ace3c184b485
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/92114
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

xml: Make the schema extendable

This patch adds an element to the tmfxml sequence that can be used to
add new element types to the XML.

It also adds an extension point for plugins to add additional XSD files
that can be used to validate XML with the new types.

The approach is validated by unit tests

Change-Id: I2c71d1b49affa1fa7df41cc9bd67db24af40e9a7
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/92113
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf: Fix experiment trace time range in Project Explorer

When the supplementary files are deleted, the start and end times stored
in the corresponding TmfTraceElement are reset. However this does not
affect the trace element instances of the same trace that can be present
under an experiment element. These instances keep their own start and
end times that could be obsolete.

The navigator label provider should simply always use the corresponding
trace element under the traces folder for trace elements under
experiments.

Change-Id: Ia7f13aab77d7b565a374a339a6c2e9b2c6347978
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/94604
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

releng: Add hamcrest to the target file

Add Hamcrest to the target file in order to get rid of the dependency
issue with mockito/eclipse.test

Change-Id: Icad392bf5b374c09fde1c62dce4ff2414ef1d7ad
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/94408
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

ctf: Fix NullPointerException in CtfTmfTrace.getCallsite()

The event declaration list can contain null elements.

Also, a callsite at exactly the same ip as the requested ip should be
considered valid.

Change-Id: I645e57cda89e9b6b8677f53094e389b5a0c0664c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/94598
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

segStore: Add unit test for history tree segment store

Change-Id: I6ebd58ea6f117511525a49d55faa46370dace365
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/86112
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

segStore: Add a history tree segment store

Change-Id: I9bf5cfffa7aa15aa6048b30f2e17446406aba891
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/75358
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

datastore: Add a Predicate for children node header

This adds the possibility to filter children nodes by their header data
from a Predicate on the intervals. There is a new method in the tree and
node to transform a Predicate on the interval to a Predicate on the core
node data. Each tree and node implementations are responsible for their
own data.

Change-Id: Ibe44b089a8d25e3f4b53718570372c96e150c1ed
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/89120
Reviewed-by: Loic Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-by: Hudson CI

lami.test: Add stub analyzes and share the package

This will allow other lami packages to use the same stub analyzes.

Also remove a few null warnings by adding assertNotNull before using the
value.

Change-Id: I5e149060a5ad45181fca32e17376eb4e7a74782e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91931
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

charts: Make IDataChartProvider public

It is quite straightforward and keeping it internal.provisional is more
trouble than it's worth since only internal classes in other plugins may
use it without API problems.

Change-Id: Id91d62c9709a9bba9a9b5aad8f0ac18891a89666
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/92520
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.core: Build a TmfAnalysisException from any type of Throwable.

Change-Id: I6b92592ff5092b2941259dcf8958a20a79fd974c
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/94242
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix BufferedRandomAccessFile

The method read(byte[]) was not overloaded and therefore reading
natively at the real file pointer, which could be different than the
buffered file pointer set at the last seek or read. The method now reads
from the buffer.

The write methods were not overloaded, and had the same issues. The real
file pointer is now synched with the buffered file pointer before the
write, and the buffered file pointer is synched with the real file
pointer after the write.

When repeatedly seeking backwards and reading, the buffer was
invalidated and filled at every iteration. The file will now position
itself to read ahead by half of the buffer size when seeking backwards.
This will improve the chance to benefit from the read buffer.

Unit tests are added.

Change-Id: If9662844818f1500f8d403b1120083892e788188
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/93840
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

settings: Remove unused problem filters

Change-Id: I6f5e0c80472eef411f445c7de687ede00b66bd0e
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/94303
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

releng: Update tracecompass features version to 3.0.0

Change-Id: Ib5a8735f2b280ef164654ecd8166b52f8e9328a9
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/94176
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

linux.ui: add a centralized registry of event styles.

This ensures that a state in the Control Flow view and the Resources
view will always be the same color. Also allows localizable help text.

Change-Id: I17cf2ad0e3bda0e254a1ee6d12df0aa96177647a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/85091
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: Fix abstract time graph view end bound

Some abstract time graph view implementations set the end time bound of
the view to the state system end time + 1. This was to be able to see
the last state in the case that the last event in the trace resulted in
a state change (the time graph event begins at end time and has a
duration of 1).

However the TmfTraceManager does not allow the window range to exceed
the trace bounds. So when the view window range was changed to show the
view end bound, it immediately snapped back to the trace end time. This
can be seen by double-clicking on the time graph scale to show the full
range, or by zooming in and scrolling all the way to the end.

This effect also prevents the view from zooming out of a 1 ns window
range at the trace end time.

The end time bound can be set to the state system end time directly. The
final state can still be seen, selected and hovered for its tool tip,
although it has a 1 pixel width.

Change-Id: I6e65fc2f960c54af0c53e4725dba334ba30fe827
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/93649
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix time graph scale ticks and grid lines

The time graph control depends on the time graph scale to get the tick
list of x-coordinates to use them to draw vertical grid lines. The tick
list is computed when the time graph scale is painted.

It appears that the order in which these two controls are painted is not
guaranteed. Therefore time graph control can sometimes paint grid lines
using the previous time range's tick list. With AbstractTimeGraphView
this usually gets fixed after a short delay when the zoom thread
triggers another repaint at the same window range, but not always.

This tick list in the time graph scale is no longer cached, and is
always recalculated from the current window range when requested by the
time graph control.

Another issue is that the last grid line disappears when its
corresponding tick label does not have room to draw completely. It is
now always drawn, and the tick label is simply truncated.

The calculation of the number of tick label digits for the CALENDAR time
format is fixed. It was too large and inconsistent, which could cause
grid lines to be unnecessarily far apart.

The digit width is cached so that it can be used outside of the time
graph scale's paint event.

Change-Id: Iaaa1caae8328d469700a7ad8aee726795b356930
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/93620
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Fix some tests with Eclipse 4.7

In Preferences, the OK label changed to "Apply and Close"

Change-Id: Icfddee53a45a895a6df82edd650a5d31c2124e5f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/94261
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

releng: Update target file for Neon.3

Change-Id: Ie34424bafeac522d71619cbd2d46100bcedfc121
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/94175
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

releng: Fix invalid since tag in several files

Change-Id: I2c61ca0faa7676861f9b1bb6419ec1a418a3ed7d
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/94171
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

releng: Add baseline target definition for release 2.3.0

Also update the oomph setup for that.

Change-Id: I3251ec01d3daf1b3e19e899fa0134c8ca11f207e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93796
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

lttng: Remove procname from callstack requirements

The analysis does not need the procname and it adds some overhead in a trace
with a lot of function calls. Though procname makes it prettier, it should not
prevent a user from seeing the callstack of a perfectly workable trace.

Change-Id: I3603b52f8559c40b86193d954ab94d9e65dc9bce
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/87449
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.ui: handle enabled/disabled trace types in the Filters View

Change-Id: Ia3b1849ba5e45b1ef6fcf2b7225b604dea2c1b44
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93989
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

doc: Add documentation for trace type preference page

Change-Id: Iedd2a354117b64e4843f5f774ddc44d46069f24d
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93244
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf.ui: Add SWTBot test for trace type preferences page

Change-Id: I66c293de7c9c02fa90b637048c5e452048f43fc4
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93237
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf.ui: Add trace type preference page for trace type filtering

This patch adds a preference page to activate selected trace types. User
can only see those activated trace types when he will use the 'Select
Trace Type...' command as well as for trace import and only activated
trace types will be considered for auto-detection. Experiment types are
not taken into account.

Change-Id: Iecd6c481d6cca3adc1d7e510580c55803d9413ee
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/92508
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf.ui: Add waitUntil#Predicate to WaitUtils

This patch adds a waitUntil() method with a predicate for SWTBot test

Change-Id: I98b33e9a84b309eb251783b2678006866be48c76
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93738
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf.ui: Fix import of ctf dependency into tmf.ui

dependency was introduced in https://git.eclipse.org/r/92386

Change-Id: I0015b1dd19d99fdd57bc161ed7c756303131837b
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/94005
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.core: implement readEnd for CustomXmlTrace

Change-Id: Ic4f6f7f829c503beeb0201e4be3dd4b189cc8169
Signed-off-by: Loïc Prieur-Drevon <loic.prieur.drevon@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93623
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.core: implement readEnd for CustomTxtTrace

Change-Id: Ieaf32d6dc66e0ae9ad0e293687a1e2882c0506ce
Signed-off-by: Loïc Prieur-Drevon <loic.prieur.drevon@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93622
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bug 506660: Fix zoom out from 1 ns window range in time graph

Make sure that zooming out from 1 ns window range is possible with the
Zoom Out tool bar button.

Fix double to long rounding error when zooming out.

Make the 'focused' time (selection if visible, center of previous window
range otherwise) centered in the new window range when zooming out from
1 ns window range.

Keep the selection as 'focused' time when it is exactly one of the
previous window range bounds.

Snap the window range to the time bounds when zooming out of range.

Change-Id: I4501d178acf1c1383caecc95d5bf2b3ec534e602
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/93066
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.ui: Update JUL log points in common X line charts

This will allow to analyze the command flow from the user interaction to
the views being updated with the new TraceCompassLogUtils API.

Change-Id: I640061e6a8eb3c19b17ee4a7025acd52aab47cd7
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/93743
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common: Fix NPE in log arguments

Loggers should NEVER throw exceptions

Change-Id: I39f7ffd18735c6ee2919b76afaec1e1616702c30
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/93809
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.ui: Show a trace's time range in the project explorer

This helps when working on experiments with several traces
to know the trace's time range without needing to display
it completely

Change-Id: I38cb9d2cac545d0b9062eda3301244996ee1feb1
Signed-off-by: Loic Prieur-Drevon <loic.prieur.drevon@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/92386
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

common: Fix LoggerTest on Windows

\r was making it in the stored messages. It can be ignored.

Change-Id: I1e79a876e8cc5b610b8bccee234648dbe16bbf19
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93761
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf.core: add StateSystemAnalysisModule log point

Change-Id: I5ba890533d6c6149c5bd3c4fbec72493abcaa0a3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/86080
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

common: Use a builder for FlowScopeLog

The 3 available constructors for the FlowScopeLog class are hard to
differentiate because of the Object... parameter. It is error-prone, so
we use a builder instead to make clear which constructor is being
called.

Change-Id: I377f77353b3c0df2e7cbc2c0b8f326e894171f10
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/93650
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.ctf: Add unscaled time getter

This allows getting the unscaled timestamp without
rounding errors.

Change-Id: I5b09dd2211169e553a37997c9f5b0cf8581667af
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93339
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

common.core: Introduce logger utils

This patch begins to bring notions or a defined trace format.

It provides a "blessed" way of formatting data to have analyses work
out of the box. It also provides an easy and robust way of
instrumenting without having to worry about details like
TIDs and time stamps.

The usage is reminiscent of LTTng's tracepoint API, in that
the user must supply a list of arguments in the end alternating
between key and value. It is easier to list them this way rather
than forcing a Map, however, this may throw some illegal argument
exceptions.

There are four reference implementations available:

* Scoped logging for durations

This is a try-with-resources logger that makes call stack and
call graph analysis much easier to perform.

* Flow logs for durations and inter-threads relations

This is a try-with resources logger that makes call stack and
call graph analysis much easier to perform, but also shows
inter-thread dependencies.

* Object lifecycle tracking

This allows the tracking of Objects that have notions of "disposing"

* Asynchronous message support

This allows a standardized way to track message passing as well as
asynchronouse operations.

Features missing:

* Marker events.
* Counter events
* Sampling Events

This changes the loglevel of the state system logs, as more information
is stored, it needs more bandwitdth.

Change-Id: I8320fa4246b33442fe44e3ce3935a824cd28feac
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/85633
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

tmf: Fix Marker Set action handling

When changing the active marker set, it didn't update the marker sources
when the opened trace is an experiment. The action only updated the
marker sources from the opened traces, but the marker sets were created
on each trace in the experiment's trace set, for the default
implementation of AbstractTimeGraphView.getTracesToBuild().

It wouldn't be good enough to update the traces using
TmfTraceManager.getTraceSet(), since we don't know the implementation of
getTracesToBuild() for each view. Also, calling
TmfTraceAdapterManager.getAdapters() on each opened trace could actually
create new adapter instances that weren't yet needed.

Instead the ConfigurableMarkerEventSource instances should handle the
TmfMarkerEventSourceUpdatedSignal, and reconfigure themselves.

Also, since the Marker Set menu items are radio, selecting a new marker
set first executes the action on the menu item that is being unchecked.
The action now only executes for the menu item that is being checked.

Change-Id: Ic8fd21b930ec29e8a619cbcedea712d4b7ee4d86
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/93463
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Support X11 colors in marker configuration file

Change-Id: I72bf7a3492e9325dfb914cac56cc6f4cd3d88972
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/92210
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add X11 color registry

This adds a map of color name strings to RGB color values. It will allow
users to identify colors by name in dialogs, configuration files, etc.

Change-Id: I492292acfd864ebad418049e584c617c525f6106
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/92209
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix a few exceptions that could happen when closing

Change-Id: Ibe66165b06a9687a1f4044585bc87db3e2afd8a7
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93569
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.core: Allow analyses to be used directly from a class

SetTrace no longer throws an NPE if there is no extension registry.

Change-Id: If82c3e1e0ba880e1a9007aa5b22572eec5440df8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93554
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

releng: update staging target for oxygen M6 builds

Change-Id: I6e91674c063d52c8d730d5fca43829cb1555fdeb
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93124
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf: Simplify SelectElementTypeContributionItem

The class TmfTraceType already manages the list of available trace
types, including experiment types and custom trace types. Its list of
trace type helpers can be used to build the menu items.

The unused command parameters BUNDLE and ICON are removed.

Note that menu items will now be grouped by category name instead of
category id. If two different category id used the same name, they will
now be merged instead of showing two sub-menus with the same name.

The items in a category sub-menu will be sorted alphabetically.

Change-Id: I411e88ad34db66d4ec3d32d8e4e6390ca66b6c6a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/93446
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: fix @since annotations

Fix some issues in CtfTmfTrace and TmfTrace

Change-Id: I7d2c87e060bbaeb59ff7ff2fb0d1bff8b3e04f99
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93337
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

releng: update 4.6/4.5 targets to use neon/mars EMF version

Change-Id: I57eda6b2a685027095b475bc87950a778097c031
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93145
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

timing.swtbot: add flamegraph doubleclick on row test

Change-Id: I1a9cfb265b0f84a717b48197b6b5848d85ba0333
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/84044
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

lttng: Fix a test on Windows with file not being able to be deleted

The synthetic trace was being regenerated while it was already opened.
So it was being used in a "nested way" in the test. The test was just
trying to reopen the trace using the path so pass the path instead which
does not try to delete/regenerate the trace.

Change-Id: If510d366f08a9f8895e667efe370bf9c70edcc5e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93033
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Bug 506095: Fix NullPointerException in XML views

When the XML Time Graph View or XML XY Chart View is opened from the
Window > Show View > Other... menu, it does not have a secondaryId. This
should not cause an exception, and the view should remain blank.

Additionally, the view should then not wait for the viewInfo name to be
set, it will never happen and the build job or line chart update thread
remains stuck forever. As a consequence, the viewInfo should be
initialized before creating the view controls.

Change-Id: I0d21cbcc02505bd5d83b7fb4335bf780943fe136
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/92736
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

Revert "ctf: Remove the callsite support"

This reverts commit 73511e6797ae5d1ef5669997e21788033d1b2eee.

The keyword callsite is part of the CTF specification. Dropping support
for it was a misstep.

Change-Id: I9b4c4842c1b2333acabac072d4a35fe224cfec5a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83898
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

lami.ui: Remove previous lami charts

Only the custom charts are now used for lami

Change-Id: I6d5cda15916b32dc89e116965da63445fb2ceaa3
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/90217
Reviewed-by: Hudson CI

lami.ui: Replace LAMI charts with custom charts

This patch makes the LAMI analyses use the new chart
plugin instead of their own charts.

Change-Id: Ic0bf607a68b7057b365ae2f40bb40f96895cfbaf
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/78012
Reviewed-by: Hudson CI

lami: Implement a custom chart data provider

This patch adds a data model for a LAMI analysis. It also implements a data
provider into the result table.

This allows the creation of custom charts using the tmf.chart plugin

Change-Id: I1375c81c6e99538d4b2e86afb517c4014b0a8a98
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/76899
Reviewed-by: Hudson CI

xml: bug 513074 fix time graph view for events of size 1

This changes the boundaries used to get event data for XML time graph
views. Events that are the last ones and of size 1 are now displayed.

Change-Id: I04d3ead5a723ddaf03282f9f438a418662ad3404
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/92277
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf.ui: Test the markers set

SWTBot test for Markers Set

Change-Id: Ic8f595d83336ce88b9c915500d7b68c409d92957
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91736
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Update user guide for configurable marker sets

Change-Id: I5a56a94dff211627db8d4e7f0ac4bd2783cdf9c2
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/90318
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add unit tests for configurable marker event source

Change-Id: Ibed108fb6b625163c7a2181d43fa9ad28add9781
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/90317
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add XSD validation for marker configuration file

Change-Id: Id673d01fc65919cb8776dfaec2d8a15ceb2ae214
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/90316
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Support traces providing cycle conversion

The interface ICyclesConverter is added, and the configurable marker
event source will use it to calculate periods and offsets when the unit
is 'cycles' if the trace provides an adapter for it.

CtfTmfTrace is updated to implement this new interface.

Change-Id: I6cda33a880365f0bcc2d1d808f2164781e4f788c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/84822
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Support traces providing periodic marker reference

The interface IMarkerReferenceProvider is added, and the configurable
marker event source will use it to determine the reference if the trace
provides an adapter for it.

The periodic marker configuration supports a 'referenceid' attribute
which is provided to the trace adapter.

Change-Id: Ib6feee645c58d9d6f63fa07df9a65fdce8c5597a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/84820
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Make TmfTrace implement IAdaptable

This is useful to be able to use adapter interface for traces, either by
direct implementation or by registering an adapter factory.

Change-Id: Iec23a2e3025771966f3467c56843711698b03331
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/84819
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add configurable marker event source

Change-Id: I1c8f9b2ebc833063d8fa7b9b4a469b722b8bb41c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/83645
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add method to filter-out periodic markers by index

The method isApplicable(long index) can be overridden to filter-out
markers by index, by returning false. The default implementation returns
true, filtering-out nothing.

Change-Id: Ib37043facf10aef4369f1a3701d94b975c68c9e5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/83644
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add method to get marker list for all categories at once

This can be useful for marker event sources that provide multiple
categories and for which it is easier to compute all the markers at the
same time.

Change-Id: I5efcfe4444f70ef879fb6a33aa4e28b844d08095
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/83643
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix Mars build

In Eclipse 4.5, StructuredViewer had
public void setFilters(ViewerFilter[] filters)
It became in 4.6
public void setFilters(ViewerFilter... filters)

So passing an array of ViewerFilter will work for both.

Change-Id: I1f3e188a78f1b738f9d41bbc05f692141f02b1bb
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/92392
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

xml: Use java.nio.Path instead or o.e.core.runtime

This is what is was meant to be from the start, but a wrong import went
unnoticed.

Change-Id: Iecf4794c9ed9e59a83ebd5e92af9b7ef7ef72b12
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/92112
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

lttng: bug 513013: fix invalid thread access

Change-Id: I019497d3cc776b8872c6600bd7c3aa4a5d331c3e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/92204
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI

releng: Use baseline target file instead of zip for Oomph

Instead of having to create a zip and pointing to it, use the
existing .target file. This requires to resolve the target first
then set it, as suggested here:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=500097#c7

Change-Id: I4e7b7d9b8ea8b013e24ba8c0ef760066c86251a2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77201
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>