tmf: Fix ArrayIndexOutOfBoundsException in Batch import on Mac

Bug: 420693

Change-Id: Ifad8934a4c85bf7885a7c7c20cb99d179c6898a3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17868
Tested-by: Hudson CI

tmf: Use a common method to get opened tmf projects

Change-Id: I2caf2ef68ab336c1263e2b2bd883648cde081fa5
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17867
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix SD unit tests with GTK3

Using a very recent Eclipse integration build (which now uses the GTK3 SWT
backend), two of the Sequence Diagram unit tests fail because of invalid
parameter values.

This patch fixes the test by clamping the height/width area values to 1.
Exceptions can then only be thrown for run-time problems (like getDisplay()
returning null), so we let those go as runtime exceptions.

Change-Id: Idccbb3490e6a0ed9dc83c1f7582c61251ec09142
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/17857
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 420220: TimerThread leak

Change-Id: I5d82dc669dd6f1a4023072e18fe775d5a3414f9d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/17707
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng-rcp: remove unnecessary maven nature of branding project

Change-Id: If039938f8bc6fcefd31048f3958ede114a69cb2a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17852
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Use long[] instead of List<Long> in CTF integer-array fields

Fixes a warning with Eclipse 4.4, as it doesn't like unchecked conversions
from non-generics types (here Object) to a type with generics.

Change-Id: I7645b61aebea8e76642572c8ad02d37abb1552d6
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/17549
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

lttng: fix property display of function probe event Bug 419454

Change-Id: I4355b74e53c0241acf7f314477c7ea1695b91e21
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17745
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

[TMF] Don't enable OK button in delete supp files dialog unless something is selected

Bug: 420332

Change-Id: I66b4ab6e5b6529251db4657bf8ab21646e59de2d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17748
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

[LTTng] Fix BufferOverflowException batch importing LTTng UST trace

Bug: 420203

Change-Id: Id0d793b39ad28c80fd04d61bcd2646b419656e9e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17699
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

[TMF] NPE in BatchImportTraceWizard.recurse

Put the absolute path of the file in the map to make it consistent with
how we query the map.

Bug: 420132

Change-Id: Id995ab06e31e0dd9b01c2c31f4d929f6b75aa944
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17676

[TMF] Don't swallow exception in Batch import "startUpdateTask"

One of the tasks in Batch import swallows exceptions making it much more
difficult to figure out what went wrong. Another one was being printed
to standard output.

Change-Id: Ife9c61dee1e57db4af11986739b712ca43c1f7c9
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17675
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Drop the get-traces.sh script

We have a get-traces.xml Ant script already, which is slightly more
portable. No need to keep two redundant scripts in sync.

Change-Id: Ic17334d1309e8e822b1c7a545cfda35b985fe5e4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17548

lttng-rcp: Use tar.gz on Mac, it is supported by default

Change-Id: Id7a224cf842d721e7804b34a627c3930bf986808
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17601
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

Add ... to Configure min max because it's a dialog

Change-Id: I789ab46612905c6ddbd52196cc87b6095c640094
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17320
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng-rcp: create separate RCP branding feature

Having a separated branding feature makes it easier to build
other RCP products based on the LTTng tracing RCP using own
product definition and branding.

Also update the LTTng releng to provide the RCP feature on the
LTTng update site.

Change-Id: Id265e3f2e71247c55ed1590aedecca6d312b3bbb
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/16647
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Split the statistics in two separate providers

Use separate state providers and backends (and so, two separate .ht files)
to store the statistics information. This will make it easier to eventually
swtich the event-types provider to a partial history backend - two one-liners
basically (or do we say one two-liner?)

Change-Id: If11956af12795a406f42c05b2cd67f82867850da
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11458
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tracing rcp: Press F1 to get help

Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Change-Id: Ie5a150637e3e20e614fe31f8e4ecf8913afb7abf
Reviewed-on: https://git.eclipse.org/r/17473
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: Take alignment into consideration for Strings too

The alignment was not taken into consideration at all when reading
strings. It seemed to work so far for standardly-aligned fields, but
it stopped being the case with funky alignments.

This seems to fix bug #419536.

Change-Id: I4bbcb4dff2e8b68f0d86557d84b158131a9945d7
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/17438
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Log errors when events cannot be read

This lets the user have a way of knowing something when wrong when
reading the trace, instead of silently gobbling the exception.

Change-Id: I8aef2cddde147a95075e9935aafc62e993a9cdcd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/17437
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI

Fix Float reading in CTF traces

Ensure that the BitBuffer's potision is aligned properly with respect
to the FloatDeclaration's alignment constraints before reading the
value.

Reference bug #419536

Change-Id: Ia0e5aadb7baa7899cbddaded1bfe593ea734e89c
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Reviewed-on: https://git.eclipse.org/r/17432
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: Clamp float and integer declaration alignments to 1

Alignments < 1 don't make much sense, so make sure the stored value is
always at least 1. StructDeclaration was doing this check, but Integer
and FloatDeclaration were not.

Change-Id: Iedb42a6fdda8706b7e8f522df10f67f2145bbba2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/17434
Tested-by: Hudson CI
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Add unit tests for lost event statistics

Dropped the core.statistics messages file, use the string defined
in the CTF plugin for lost event names (it shouldn't really be
externalized).

Change-Id: I7f6a3ecb7b3be5c7a665a44a8c2882d3bb42419f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/16664
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

tmf: Dipose traces in CtfTmfTestTrace

Automatically dispose existing traces in CtfTmfTestTrace. This ensures
much more consistent behavior between tests. This required fixing some
tests that did bad assumptions.

Change-Id: I962044e741bd1e12505761d3d4257c0d76cfc5e4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/17137
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Don't use .deleteOnExit() in unit tests

deleteOnExit() guarantees the file will be deleted *when the JVM exits*.
However, in most cases with unit tests, you want to clean up at the end
of the test, and not wait until the whole test run is over. This gives
more consistent behavior when running different tests in a different order.

So instead use a simple .delete() in @AfterClass methods.

Change-Id: I07f277dbe85b66659ca66c996b232cd64bb6868f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/17136
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

[TMF] Remove TmfStringLocation

TmfStringLocation is not used except in tests and since we expect all checkpoints
to be of the same fixed size, it doesn't really make sense to keep this class around anymore.

Change-Id: I870c72fe6a26dd15cec7249393221cc9907bc340
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17047
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

[TMF] Handle custom traces in TmfTraceType in a more consistent way

Instead of storing the custom trace types by human readable name, store them by traceId like the other trace types.
The trace Id is the canonical name + the definition name. This makes it consistent with TmfTraceElement.getTraceType.
Also, consolidate code that can reuse TmfTraceType.setTraceType.

Change-Id: Iac81c8d4fdf18eb83a84052c4c47d70d94cd64d5
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/16977
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Re-add null annotations to tmf.core.statevalue

Revert the revert in 9885a77c775e59e8ad72d5cc4495f4d1fea1c964.

Current master doesn't compile with Eclipse < 3.8 anymore, so since
this is our new oldest-supported version, we can put the null
annotations back in (those also require >= 3.8 to even compile).

Since the package is only needed at compilation and not at runtime,
it should not be added to the dependencies in MANIFEST.MF, but to
the build.properties file. As indicated in
http://help.eclipse.org/kepler/index.jsp?topic=%2Forg.eclipse.jdt.doc.user%2Ftasks%2Ftask-using_null_annotations.htm

Change-Id: I96a8bfd8f43296cf4eee196d0e44641f2822153c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/16527
Tested-by: Hudson CI
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

[TMF] Fix current API errors for version 2.2

Change-Id: I1267e65ee6805431dbb97f5072afc4e5978c06a9
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/16978
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Bug 416316 - New > Tracing Project appears in unrelated perspectives

Only enable the wizard in tracing related perspectives.

Change-Id: If448514e7edcadde723abe9ca6c53848dc3fb467
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/16730
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

tmf : Update the histogram to handle lost events correctly

Add a checkbox to toggle displaying the lost events
Display the lost events' bars in the histogram

Change-Id: Iba72f479455cadc4150efadf695f943a6572f3d2
Signed-off-by: Jean-Christian Kouamé <kadjo.gwandy.jean-christian.kouame@ericsson.com>
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15555

lttng: Add snapshot support - LTTng Tools v2.3

Support for commands
- lttng create <session> --snapshot OPTIONS
- lttng snapshot list-output
- lttng snapshot record

Not supported
- lttng snapshot del-output
- lttng snapshot add-output
- lttng snapshot record OPTIONS

Change-Id: Id8b8a6bc487c0fe792ffe74981f42dbc1d42a81c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/16644
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

tmf: Fix in-memory backend to use a TreeSet insead of a list

The query performance is superior and it handles receiving different
attributes with different end times out of order. (within the spec)

Change-Id: Iba72f479455facedecacaadf695f943a6572f3d2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/16816
Tested-by: Hudson CI

Tmf: Rework test trace stub for non-ctf traces

Change-Id: Ica47ed67824ea77d975c683fd0794ef6e6840d35
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/16423
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Add .DS_Store to gitignore

This file is a hidden file created on Mac that contains extra folder information and should be ignored.

Change-Id: I4cb5cc410ada33fb6d6090a8ab0ff842ca4b3844
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/16573
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Add unit tests for lost events in CTF traces

Adds a small UST trace with lost events to the test traces.

Change-Id: Ibe4ff49e665879d1472084aa0fdc461c2b80f872
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/16144
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Bug 417036 - [TMF] Legacy import: Trace type is not set after importing custom trace

Change-Id: I1db889718bf5985b6b0e3ae6395dd958a399ef6e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/16342
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng-rcp: Fix installation problem from p2 update site

Change-Id: I5d719bf68d2c2c140474fc59bdb3c79c2ce8c9cf
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/16114
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Bug 416665 - Fix Delete Supplementary Files not showing in menu

Change-Id: I07f7911413de0861804d43e115fc7b2c4220e703
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/16169
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add copyright headers to tests

Change-Id:I3ec67a7a3ea32ee3264d5910592486cd522058c8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/16012
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Rework test trace classes

Currently, test traces are accessed using array indices, which is simple
but scales very badly. It's also very confusing when writing a new trace
and wanting to decided which test trace to use.

Rework the test trace classes by replacing them with enum's that do the
same thing. Unfortunately, you cannot extend enums, so duplication of the
names is needed, but everything else is centralized in one place.

Change-Id: I6e598048531682428c1142c18d1760c21de5aeac
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/16143
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

tmf: Move statevalue unboxing method implementations to the base classes

Made the default methods in TmfStateValue always throw exceptions.
Implementations can then override those for the types they support. Also
added some messages to the unboxing exceptions, to help when debugging.

Tweaked IntegerStateValue's so that they can be unboxed into a long,
since this will always be safe. The opposite however is not permitted.

Change-Id: I492a53e8daf1141c8aefa1c0ad1f005af8e77c30
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/16294
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Add target platforms for Eclipse 3.8, 4.2, 4.3 and staging (4.4)

Change-Id: Ieccda11821094229414af01505ffdb1d269b1fe7
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15906
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

Bug 416578 - [TMF] Select/Deselect All buttons in delete supplementary files

Change-Id: I47db7273801dd829807b63aa99044521892163cf
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/16146
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Bug 416574 - Fix NPE when deleting supplementary files in experiment

Change-Id: I7ba4577b8cdfe64af000589ff0e354ea3aa8f05b
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/16139
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 416187: Multiple editors opened with same trace name

Change-Id: Ic411244d74202208f1f7505ca09795e88915050b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/16014
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 416167: Buggy trace freezes UI when restored at start time

Change-Id: I48ab2f7d32542daaa054861c3eaaac9142754b94
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/16013
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 415707: Trace already opened should not be re-opened

Change-Id: I661e2d5fc27e456aa47e91bb6edeafd51d027e59
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15983
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Update statistics providers to handle TmfLostEvents

We do not want to count the "lost" events in the events total,
but it's interesting to show them like any other event type.

refs bug #408373.

Change-Id: I70956a78a2fb150fe47f259b4136332f705ef147
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14519
Tested-by: Hudson CI
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Use "meta events" for lost events (bug 408373)

Instead of sending one event object for every single event reported as
lost in a CTF trace, only send one CTFEvent indicating how many events
were lost, in which time range.

On the TMF (ctfadaptor) side, we add a new CtfTmfLostEvent class to
wrap those. This way, only one entry shows up in the Events table,
indicating how many events were lost at that point in the trace.

Change-Id: I0c70ec2d5fc77134b67426d053a4d2353e710ab8
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Signed-off-by: Jean-Christian Kouamé <kadjo.gwandy.jean-christian.kouame@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/15491
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Bug 416062: Control Flow arrows don't follow through idle state

Change-Id: Ib42709cf5ad4aafff96091690d9f2c7477772cde
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15939
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

all-tests: Run with less dependencies.

Instead of relying on sdk.[ide|feature] run the tests with
platform.[ide|feature]. There shouldn't be any difference for the tests
as what the sdk adds is the source bundles which are not used by the
tests. This should have some minimal effect to reduce our already way
too long build time.

Change-Id: I57bbc8c5ccb6e0a4575224134e184e13ae581b8f

releng: Update maven plugins used.

* tycho 0.18 -> 0.18.1
* jacoco-maven-plugin 0.6.2 -> 0.6.3
* maven-site-plugin 3.2 -> 3.3
* maven-project-info-reports-plugin 2.6 -> 2.7
* maven-javadoc-plugin 2.9 -> 2.9.1
* maven-antrun-plugin 1.2 ->1.7

Change-Id: I938a1081f25caeccaeec1bdcad770cd8e2ceadfb
Reviewed-on: https://git.eclipse.org/r/15910
Tested-by: Hudson CI
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
IP-Clean: Alexander Kurtakov <akurtako@redhat.com>
Tested-by: Alexander Kurtakov <akurtako@redhat.com>

Update parent poms to 2.2.0-SNAPSHOT

- update top pom.xml to properly default Kepler
- update SystemTap feature and ide plug-ins to 2.1.0

Change-Id: I5eeba68b42cf9601f523c822d7dd1a414ece762c
Reviewed-on: https://git.eclipse.org/r/15916
Tested-by: Hudson CI
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
IP-Clean: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>

lttng: Update User Guide for time graph arrows

Change-Id: I54cebd26dfc8f9f130d35fc3d842e17e57aab440
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15865
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI

tmf: update developer guide for time range selection

Change-Id: I33e2bf0003f6c8db6c0aada689bef6ba75fee7e6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15888
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix for bug 415795: IndexOutOfBoundsException in time graph combo

Change-Id: I8e89eaf0b86b40039a320ba98192198415e5d540
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15821
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

TMF: Add tmf.ui unit tests for project model

Change-Id: I4524bf0cdc472815d8e9ddf2049469bbaca1b291
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/15518
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

TMF: Add a getTrace() method to TmfTraceElement

This will return the corresponding opened and instantiated trace from the
trace manager.

Change-Id: Ief78119ee4d75906c881ce2347a420d50b072399
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/15480
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

lttng: fix NPE in channel dialog without kernel tracer (bug 415617)

It also fixes the enablement and selection of the per PID/UID
buffer buttons for the case a kernel tracer is not available.

Change-Id: I01ce496914c70f5330beab478c0ce4528cf8df59
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15754
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: select loglevel by default for UST events (bug 415589)

Change-Id: Ib949b855224070e9060fecee31931b3a7eefa0f2
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15719
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: fix empty string handling in dialogs (bug 415580)

Change-Id: I9839ec7d8238556809cad48a39e44d72736c4544
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15713
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

[lttng] fix for NPE when creating a tracing session (bug 415571)

Change-Id: I1676c120680a3afb9b9952f6990c0663a76be1d4
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15700
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix missing @since annotation in TmfTraceType

Change-Id: I779247fd226c031aa6f683255de92096a6c5f3b5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15740
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: fix JUnit tests failures introduced by commit 44908fc1

Change-Id: I3b9e71360e53c4e1f3df2a8d78d53b3a240b50b2
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15682
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: update enable channel for UST buffer type

- Update implementation as preparation for LTTng Tools 2.3 which
has a different default buffer type for UST.
- Add JUnit test
- Update user guide

Change-Id: I42901637579015366eb6f09a71c9e9540e1c86ef
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15424
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Fix Resources view event list

With the fix to the event iterator (42acdc2), it is no longer required
to add 'null' events in the zoomed event list for all empty ranges to
hide underlying events in the full range event list. This simplifies the
building of event list in the Resources view.

If required, 'null' events are added at the start or end of the list to
properly identify the time range that the list represents.

Adds an interface to TimeEvent to split an event while keeping it's
class type and value.

Some trace specific fields are moved out of the generic TimeGraphEntry.

Change-Id: I6b3058227e64e456601b40fa2ea6c0afe3886f14
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/14326
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: import bug fix

fixed an error using the api introduced with "file->open"

Change-Id: I9c9ef366f43708ec826642f106047dc0dd088f21
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15652
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI

lttng: improve import from control view (bug 412337)

- Import dialog selects by default all traces
- Import dialog selects default project with name Remote. It will
be created if needed.
- For Kernel traces trace type "LTTng Kernel" will be set
- For UST trace trace type "Generic CTF Trace" will be set
- Trace name in project will be constructed with information about
session, kernel or ust, ust buffer type (UID or PID) etc by
concatenating the names of directories within a session.
- For network traces now the Batch Import Trace Wizard will be opened
instead of the legacy trace import wizard

Change-Id: Ife7c57868d2a4f2b5cbc6b1b6461a677b3998ea8
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15543
Tested-by: Hudson CI

tmf: Fix Call Stack view event list

With the fix to the event iterator (42acdc2), it is no longer required
to add 'null' events in the zoomed event list to hide underlying events
in the full range event list. This simplifies the building of event list
in the Call Stack view.

If required, 'null' events are added at the start or end of the list to
properly identify the time range that the list represents.

Change-Id: I90ab8f91cc6991472a9ea5196a8e5cbee5a55565
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/14599
Tested-by: Hudson CI

tmf: Fix StringIndexOutOfBoundsException in time graph

The Utils.formatNs method is fixed to not throw an exception when the
parameter is Long.MIN_VALUE.

The TimeGraphViewer is modified to ensure the time range variables are
kept to 0 when there is no valid time range set (including when the
requested time range is invalid as in [+inf,-inf]). The range is
prevented from going out of bounds due to adjustment for the minimum
time interval.

The TimeGraphControl is modified to disable mouse time selection and
status line updates when the time range is 0.

Change-Id: I62dfe520913d160dac37526f1c02396c34f67830
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15614
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Fix some warnings when compiling with 4.4 targetting 4.3.

Change-Id: Ic6268a479c5e720ce9f59867973d20611b1b10f3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15514
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Tmf: Benchmark for the request scheduler

The benchmark has three tests. The first one is the latency (time
between the creation of the request and the beginning of its execution).
The second one is the average waiting time for a request. The last one
is the total completion time.

Change-Id: Icc8cb47111221aaefb871faab97bb49c8bdf0b03
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/14520
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Set API builder settings as project settings

This is pretty much the same as the default project settings, but
if somebody somehow changed the settings for their workspace, they
will at least get the one we expect for the plugins here.

Change-Id: I77a371123e4eff73e70bba4a4e4404c2f19ebe10
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/15450
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Ctf: add removeIterator() to prevent OutOfMemory exception (Bug 414998)

Change-Id: I0a42a1b4d7eb14b37bc97471dba1b4aae44d2f4c
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15487
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Fix ArrayIndexOutOfBoundsException in time graph control

Change-Id: I4da4146e47f969c788cfe0096c3ca4ece891fa6e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15436
Tested-by: Hudson CI

tmf: Add follow arrow forward and backward actions to time graph

Also add these actions to the Control Flow view local tool bar.

Change-Id: Ied39dfb813f4dfd4ec7822754978283cbbcf6335
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15388
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Make sure the request scheduler threads end gracefully

Upon disposing a trace, the timer thread for the request executor
was not being stopped. While this was not a problem for normal Eclipse
usage, it becomes a problem when trying to run headless methods in the
tree that use the request scheduler: since some user threads were still
running, the JVM would not close and stay there waiting forever.

Additionally, mark the timer thread as a daemon thread. This is a safeguard
in case a trace is never disposed. This will let the JVM shutdown correctly
even if there are any of those threads still running.

As per the Thread.setDaemon() Javadoc:
  Marks this thread as either a daemon thread or a user thread. The Java
  Virtual Machine exits when the only threads running are all daemon threads.

Change-Id: I04e628cfd444ee86293f262017c948642619f661
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/15387
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add time graph viewer option to AbstractTimeView

The AbstractTimeView is modified to add the possibility to be used with
a time graph viewer only, when the time graph combo and tree viewer are
not needed.

The Resources view is also updated to use the time graph viewer option.

Change-Id: I95b557070c9fb412649d56428ae314731ec165aa
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15022
Tested-by: Hudson CI

lttng: Add arrows in Control Flow view

Show arrows to follow CPU execution in Control Flow view.

Implement a Hide Arrows toggle action to the time graph control.

Change-Id: Ic6e5020f8a7895e482bda9e45c8333dde79e7022
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15147
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: Don't change event table selection on right-click

When right-clicking on a item that is within the selection range, the
selection should not be changed to the clicked item. This would prevent
any context menu actions from operating on a selection range.

Change-Id: I3eb06471a3dd80cc3683fcdc965fd36a67ce86a8
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15298
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng rcp: add tracing rcp "file->open" buttons

there are two buttons added:
* File-> Open Trace File...
* File-> Open Trace Directory...

The traces will be opened into the default directory and
automatically select the trace type. If the trace viewer is
ambiguous, it will pop-up a window to help.

The trace is then opened.

The reason that we have open file and open directory is since
some traces are directories.

Also, the code path of regular trace file opening has been re-routed
through this patch to unify code.

Change-Id: I28df30745bf47b64ce0ab0f15a8d425fef4dd91a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13863
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: improve validation for custom parsers

text: is the file a file, readable and have at least 1 byte of data.
xml: validate the xml. Added some XML validation tests.

Change-Id: If2144f15abb564156f8a84cfcdee9497a6f418cd
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/14997
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Make time graph combo item heights dynamically linked

The height of items in the time graph control are dynamically linked to
the height of their corresponding tree items. This ensures alignment
when tree items have different heights due to custom fonts or images.

Change-Id: I84a2394f6d5673bec1af9a2858cc0a31a76f2753
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15107
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Adjust the file name of the RCP archives

Add the build date/time to the file name and remove the SNAPSHOT part
of the version number for (and only for) tracing.rcp.product. This will
be used as the versioning for builds made from the Git tree.

Also added the location of the archive files to the README.

Change-Id: I5a2e24fb1f82b0de05f36168bbbbeffec919e250
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/15109
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

TMF: Add utility class for common UI functionalities

The displayErrorMsg(...) function has been moved to this class to avoid having
to rewrite it in every class needing it.

Change-Id: Icea4be2af3fbb5312417c92de7f24b235e1cf675
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/15144
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Consider compilation warnings to be errors in tmf.core

Now that we have eliminated all compiler warnings in the code,
we could turn on "-Werror" to make sure no new warnings are
introduced (Hudson CI would fail building any Gerrit patch that
has warnings).

NLS warnings remain as warnings, so that they can be suppressed
in Messages or constants classes.

"rawtype" and "unchecked" warnings for generic types remain as
warnings. Fixing some of those would require an API break.
Additionally, one of those warnings would require a major refactoring
of the ITmfLocation's, so this might remain as-is for the forseeable
future.

Finally, "Unecessary thrown exception" had to remain as a warning
because of TmfTrace.buildStateSystem(). The fix would require an API
break (but this is already fixed in the 3.0 branch, see commit e27acc1).

Change-Id: I810762a82ed4d0da2241ae943b1da1c2e96888d0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14998
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Consider compilation warnings to be errors in tmf.ui

Now that we have eliminated all compiler warnings in the code,
we could turn on "-Werror" to make sure no new warnings are
introduced (Hudson CI would fail building any Gerrit patch that
has warnings).

NLS warnings remain as warnings, so that they can be suppressed in
Messages or constants classes.

This patch landed one week too late to prevent deprecation warnings
from entering the code... so usage of deprecated methods methods remain
as warnings in tmf.ui.

Change-Id: I9bea653ef2cef3435273647e6de249076a64478a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14207
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Consider compilation warnings to be errors

Now that we have eliminated all compiler warnings in the code,
we could turn on "-Werror" to make sure no new warnings are
introduced (Hudson CI would fail building any Gerrit patch that
has warnings).

Only the NLS warnings remain as warnings, so that they can be
suppressed in Messages or constants classes.

Change-Id: I53394af9add34f3757f726ab773d445c92d8523e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14206
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: Update project compiler settings

Now that we have eliminated all compiler warnings in the code,
we could turn on "-Werror" to make sure no new warnings are
introduced (Hudson CI would fail building any Gerrit patch that
has warnings).

NLS warnings remain as warnings, so that they can be
suppressed in Messages or constants classes.

This only applies to ctf.core and ctf.core.tests. For ctf.parser,
since Maven also looks at generated code, we have relaxed the settings
to ignore any error/warning coming from the generated Antlr code,
over which we have no control.

Change-Id: I31422d54af59bd96f75d2c2ff130a58c8e9ad5f6
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14205
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Partially revert 9017d8.

Plugin/Feature versions cannot change major version number on a
non-major release. Revert all plugins that went from 1.0.0 to 2.1.0.

Change-Id: Id3ff0976c381cb92e3d58a0128a24c5838def8ae
Reviewed-on: https://git.eclipse.org/r/15069
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: change root folder name of RCP to traceviewer

Change-Id: Ia0865358429211196780490a95a207bbfae9e1fc
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15169
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Only build the RCP on architectures that matter in 2013

Drop the Solaris and PowerPC builds. This leaves us with:
- Windows 32/64
- Linux 32/64
- Mac 64 (Cocoa)

Change-Id: Ie6af27a1c75bb6a7bfcdad6b328d66cb06dc8d92
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/15150
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Use TmfNanoTimestamp instead of CtfTmfTimestamp

Change-Id: Ia996c87c1504be4cdc31943cc69d2fd980da85ea
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15046
Tested-by: Hudson CI

TMF: Add vertical events (links) to time graph view

Add a new interface ILinkEvent and class TimeLinkEvent, for events that occur
between two entries instead of in one entry only.
Add the getLinkList method to AbstractTimeGraphView to get the links for a
given zoom level and other methods to propagate those changes to the time graph
control

Change-Id: I5be30c4a27a10645a57ebfc13b4d1c71a55e06bd
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/15105
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix formatting of negative time stamp values

Change-Id: I3a3313d2477507dd0380c77bdee4aa3de5fe49bd
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15026
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Add a README file with build instructions

Users might want to build the RCP version manually, and the commands
are not documented anywhere yet.

Change-Id: I45f61a1c80fdc081941f2e2c980fd704f7621cf9
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14942
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add TmfNanoTimestamp

Change-Id: Iff7693286f0968fc6da03de7e796e390f9b8241d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/14900
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

LTTng: Show the buffer type in the domain property view

Change-Id: I518cdb438c2e2fc6a853fe0e012c3776e41e4459
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15017
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: Fix buffer overflow traces from crashing batch import

Buffer overflows are caused here by synthetic traces that aim to
behave maliciously. The parser already handles these attacks, but
the BufferOverflowException will cause the batch import trace wizard
to stop scanning. This fix catches buffer overflows in the validation
and warns that the error is serious.

Change-Id: Ie9156cfaac0944763e3d1dc798c42f1d64753560
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/14088
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add missing plugin.xml to build.properties

plugin.xml was added in 8714534.

Change-Id: I2eb74a9c4d6fd8809b1c38779a1c80cae1645dd3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14897
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>