Bernd Hufmann [Thu, 5 Dec 2013 15:57:22 +0000 (10:57 -0500)] 
tmf: Merge HistoryBuilder into the state system analysis module
The state system analysis module acts as kind of a state system
factory. There is no need to have a separate TmfStateSystemFactory
and HistoryBuilder class anymore.
Merging the history builder functionality into the state system
analysis module also allows for better handling of requests to
analyze the trace. Now it's possible to cancel the analysis job.
Later on, when all state systems (e.g. statistic state systems) are
built using the state system analysis module, the TmfStateSystemFactory
and HistoryBuilder can be removed.
Change-Id: Ibb52b20b6fdb16b665ad318cda04cf92d19ccf72
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19441
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Mon, 6 Jan 2014 21:35:39 +0000 (16:35 -0500)] 
lttng: Inherit null annotations
Maven does not do the "@NonNull -> unannotated" conversion automatically,
so it pretty much requires this setting to be enabled.
Change-Id: Ia99faebcaa127552dd5926d010d7cd2bad082d29
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20309
Tested-by: Hudson CI
Alexander Kurtakov [Thu, 9 Jan 2014 13:57:56 +0000 (15:57 +0200)] 
Unify naming and bump releng-site version.
Change-Id: I98445db9d2c8ab6e3eaa018c169b010516021779
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/20440
Tested-by: Hudson CI
Geneviève Bastien [Wed, 8 Jan 2014 19:20:45 +0000 (14:20 -0500)] 
TMF: Add possibility to overwrite the path of the workspace root
By setting the environment variable TRACING_RCP_ROOT on the command line,
it uses this path as the workspace root instead of the default user home
directory.
Change-Id: I3cadec5b162e1dac99c4b5b9f30308a21c351f50
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/20400
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Geneviève Bastien [Wed, 30 Oct 2013 16:33:07 +0000 (12:33 -0400)]
Tmf: Add the concept of module source to the Analysis API
This allows for other ways to define analysis modules than having to describe
them in the plugin.xml file. For example, an XML file can be the source of an
analysis module.
The source itself needs to be described in the plugin.xml, using another
element of the analysis extension point.
Each module source will typically have its matching helper class to create the
instance of a module when required and to be able to access available modules
for different trace types before the trace is instantiated.
A default implementation of the IAnalysisModuleSource interface and its helper
are provided for the modules advertised through the extension point: the
TmfAnalysisModuleSourceConfigElement and TmfAnalysisModuleHelperConfigElement.
Change-Id: Ia2c7142704aa6b2a326bba9d2bf0734954427b7e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/19433
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Roland Grunberg [Wed, 8 Jan 2014 17:11:05 +0000 (12:11 -0500)] 
Fix JDT Null annotations bug occuring in Luna builds.
The JDT compiler fails when a method implemented from an interface whose
class is tagged with @NonNullByDefault, redefines @NonNull on the
parameter. It seems the interface itself must redundantly define
@NonNull for the condition to get carried over.
Change-Id: I8663c0ba9994466f1cb9f56b1746a59051b4c8ef
Patrick Tasse [Thu, 19 Dec 2013 23:25:30 +0000 (18:25 -0500)] 
tmf: Fix NPE in TmfTraceType when refreshing custom trace types
Since custom trace types are dynamic, TmfTraceType is constantly
refreshing the list of custom trace types whenever the available trace
types are requested.
Before reloading the list, the current custom trace types are removed
from the list. Because this refresh can occur concurrently in different
threads, a NullPointerException can occur.
This patch ensures that the custom parser list is only populated once at
initialization. The list is then modified dynamically as custom parsers
are created, edited or removed.
The list of custom trace types therefore no longer needs to be refreshed
when getting the available trace types.
Change-Id: I08bd0c351b0f573fe36e0fa7fd1aad62de81f1e5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/20093
Tested-by: Hudson CI
Alexandre Montplaisir [Mon, 6 Jan 2014 20:12:42 +0000 (15:12 -0500)]
tmf: Tweak ITmfStateSystemAnalysisModule
- Decouple it from TmfStateSystemAnalysisModule, rename it to
ITmfAnalysisModuleWithStateSystems. An analysis module could
expose state systems independently of using the abstract class
or not.
- Change the Map return to separate methods. I'm not very happy
about getStateSystemId(), but the State System Explorer currently
needs it. Ideally, the ID could be stored in the state system itself,
so that this method would not be needed.
Change-Id: I1fcf20384c00b47578309451691f59fd0f438053
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20247
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Bernd Hufmann [Thu, 19 Dec 2013 20:19:46 +0000 (15:19 -0500)]
tmf: add abstract bar chart viewer on top using swt chart
It also adds a special histogram tooltip provider as well as an
example implementation (New Histogram view) that uses the swt chart
framework.
Change-Id: I03890eaf7a79ef7d9a48c23b26c49dca9544ea50
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20085
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Thu, 2 Jan 2014 15:50:55 +0000 (10:50 -0500)]
tmf: add dragging support with middle mouse button
This will update the current time window based on the new range.
Change-Id: If0f796d61c73d82294c832dacf9458e645e7b7ab
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20217
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Thu, 19 Dec 2013 19:41:20 +0000 (14:41 -0500)]
tmf: add simple tooltip provider for swt charts
Change-Id: Iaddea6d160fac65f781863b7f07a797cdbb3c072
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20156
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Thu, 19 Dec 2013 19:31:33 +0000 (14:31 -0500)]
tmf: add mouse wheel zoom to swt charts
Change-Id: I3e53e76b98423c0ca938a530eb33358627f9852b
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20083
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Thu, 19 Dec 2013 18:56:28 +0000 (13:56 -0500)]
tmf: add mouse drag zoom provider for swt charts
Change-Id: Id9fb2b32f37953890f288c90c2f908d5d8b396dc
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20082
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Thu, 19 Dec 2013 18:42:15 +0000 (13:42 -0500)]
tmf: add mouse selection provider for swt charts
Change-Id: Ibe73dfdea14354c149ae411e09f1f39a4a7a6220
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20081
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Geneviève Bastien [Tue, 17 Dec 2013 20:16:46 +0000 (15:16 -0500)]
TMF: Fix a bug in UI when refreshing analysis elements under traces
As it was, each time we would get the available analysis of a trace, it was
constructing new objects and those objects were not the same as the trace
element's children.
Also, while implementing the XML analysis source, the analysis were not
refreshed when the trace didn't already have children.
This patch uses the refreshChildren method to refresh analysis and outputs and
makes new objects are not constructed every time.
Change-Id: Ia33f7e20fea918a76bb341b808d074d3b1e130f2
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/20004
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Patrick Tasse [Mon, 16 Dec 2013 22:03:42 +0000 (17:03 -0500)]
tmf: Refactor resource change listener in project model
- Move resource change listener from every project element to the
project registry
- Create project in a WorkspaceModifyOperation to combine the many
resource change events into one.
- Only refresh the projects affected by the resource change event
- Update the model in the current thread on refresh
- Move the refresh from the project element to the base model element
- Refreshing the model children moved from the navigator content
provider to each specific model element
- Change getChildren from navigator content provider to simply return
the children list, that is now updated separately (as described above)
- Remove project from the registry when it is deleted
- Modify project registry to populate the model when getting a project
element for the first time
- Remove various unnecessary refresh of the model accordingly
- Do all modifications from the rename trace handler in a single
workspace modify operation
- Refresh all affected projects in the select trace type handler
Change-Id: I7e080e6b10617786a715e3cb39bf297b79168998
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19882
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Bernd Hufmann [Thu, 19 Dec 2013 12:10:54 +0000 (07:10 -0500)]
tmf: add abstract view and viewer classes for generation of SWT charts
Change-Id: I2d83280a63574727ceaf567db501119a7e0b2909
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20080
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Thu, 2 Jan 2014 14:05:41 +0000 (09:05 -0500)]
tmf: Ensure order of trace updated and trace range updated signals
When the trace index already exists and doesn't need to be build
from scratch the signal TmfTraceUpdatedSignal is sent once in the
method buildIndex() of the TmfCheckpointIndexer. However, buildIndex()
is called from the signal handler of class TmfTrace for the
signal TmfTraceRangeUpdatedSignal. That causes that signal
TmfTraceUpdatedSignal is sent before TmfTraceRangeUpdatedSignal
is processed by all other signal handlers. This causes problems
for example in the Histogram view where the trace end time is not
set correctly because this wrong order of signal handling.
This patch fixes that problem by wrapping the sending of signal
TmfTraceUpdatedSignal in a TmfEventRequest which is only dispatched
by the TmfEventProvider (=TmfTrace) after the first signal
(TmfTraceRangeUpdatedSignal) is processed by all signal handlers.
Change-Id: I96dfdb4cc678722ff5b48a8881c67f5a8c11ff36
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20216
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Fri, 3 Jan 2014 14:05:43 +0000 (09:05 -0500)]
lttng: Update drag&drop guide for unknown trace type icon
Change-Id: Ibbdc22c69c2a84edfe6bdbb84a407547b9dc6303
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20235
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Thu, 2 Jan 2014 20:22:59 +0000 (15:22 -0500)] 
lttng: Remove some unused images in help
Change-Id: I80555f91d737f8e007f89128f04abcf5215b25a9
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20225
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Thu, 2 Jan 2014 21:35:55 +0000 (16:35 -0500)]
tracing RCP: Build with Java 7
Change-Id: I6135dccd6d0dce2182c839b9241b68a3d1705881
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20230
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Thu, 2 Jan 2014 20:35:20 +0000 (15:35 -0500)]
gdbtrace: Build with Java 7
Change-Id: I411bdd3cdc5ca6335fb8b8bfb95f8927f6235523
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20228
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Thu, 2 Jan 2014 21:27:51 +0000 (16:27 -0500)]
lttng: Move to Java 7 and fix warnings
Change-Id: Ic9a2ea7c526baee118adc5cd5c1c6a9566139fcb
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20229
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Thu, 2 Jan 2014 20:30:31 +0000 (15:30 -0500)]
ctf: Move CTF plugins to Java 7 and fix warnings
Change-Id: I08e566e382f6c03d0bda05948dc391424aa9abfe
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/20227
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Thu, 19 Dec 2013 21:28:20 +0000 (16:28 -0500)] 
tmf: Update swtbot tests to use Java 7
Change-Id: Iee44b29888663b49211600a8fd1e770ce5e8d8a3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20091
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Thu, 2 Jan 2014 19:58:45 +0000 (14:58 -0500)]
tmf: fix test failures due execution timeouts
The timeout deadline used to be calculated using integer instead of
long so that an overflow occurred and the actual deadline was much
shorter than intended.
Change-Id: Ia506f821f7c150ec8f96f47c50c1d683661a1dd7
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20224
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Thu, 2 Jan 2014 20:07:46 +0000 (15:07 -0500)]
ctf: Add missing @since to previous patch
Change-Id: I8904a8df33397eaad653237b3e9ae0980a3d9bf6
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Bernd Hufmann [Thu, 2 Jan 2014 16:42:55 +0000 (11:42 -0500)]
tmf: fix occasional API error in tmf.ui.tests
Fix error about indirect reference to IPropertySource2
Change-Id: I52dd628639fcd88c4740f1228fd8ae8ca643bfff
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20219
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Etienne Bergeron [Wed, 18 Dec 2013 03:18:31 +0000 (22:18 -0500)] 
ctf: move getStreams to an iterable.
This is an example of how to break the internals access.
Keep separate the "get/set/iterate" over an internals data-structure.
Change-Id: Id79b4eeedd3636de142d3317cbb1b1ae6fe2f50a
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19933
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Wed, 18 Dec 2013 21:50:45 +0000 (16:50 -0500)]
TMF: Added a method in UI tests to delay main thread until trace is opened
In o.e.l.tmf.ui.tests, the main thread often need to be put to sleep while a
trace element is being opened. The sleep time was put to 500 ms because that's
what showed best results. But sometimes, unit tests fail because it takes a bit
more than that. Instead of putting longer delays, we loop a certain number of
times until the trace is opened or after a certain timeout.
Change-Id: I662d951115eacbb3fa5b17cfe534a8e5c2a85eb4
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/20018
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Wed, 18 Dec 2013 20:48:04 +0000 (15:48 -0500)]
Introduce UI plug-in for examples based on tmf and lttng
Change-Id: I860bc1055448eed48f563939a872669a03ea8244
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20079
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Wed, 4 Dec 2013 20:59:32 +0000 (15:59 -0500)]
ctf: clean up pointer parsing in iostructgen
Change-Id: I03217fbb3900a771a53938df1e91d555461bf0c1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20070
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI
Alexandre Montplaisir [Tue, 17 Dec 2013 21:44:44 +0000 (16:44 -0500)]
tmf: Switch tmf.core to Java 7 + fix warnings
Change-Id: I32fb093edb6bf70fdbe9a5ad1a9c8239a1e9ed05
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19927
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Wed, 6 Nov 2013 20:12:37 +0000 (15:12 -0500)]
tmf: batch import wizard smoke test
This is a sample of how to make a test using SWTBOT.
It should be a useful stepping stone to gain test
case coverage and control what we're reading.
The test features:
* a kernel trace generator
* importing a trace
* opening a trace
* navigation in a trace
* testing tracing perspective
What would be nice to have:
* closing a trace
* all the other functional test on all the trace types!
Please note that SWTBot needs to run on a non-UI thread.
https://wiki.eclipse.org/SWTBot/FAQ#Why_do_tests_run_on_a_non-UI_thread.3F
After the code was changed to run on a non-UI thread, it
was possible to remove many workarounds which made the code leaner and
easier to maintain. The UI code not handled by SWTBot still needs to run
in a UI thread, PlatformUI.getWorkbench() for example.
Change-Id: I91e258ed5fb7735287da303d518314460839547b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13780
Tested-by: Hudson CI
Bernd Hufmann [Wed, 18 Dec 2013 19:43:38 +0000 (14:43 -0500)]
tmf: remove setting of anti-aliasing in histogram
The setting of anti-aliasing in histogram paintContro() is triggering
another redraw of the histogram. This endless redraw will make
the UI unresponsive. It seems only to happen on some Linux versions.
Until we figured-out the root cause it's better to remove the setting
of anti-aliasing.
Change-Id: I38b6f5062869a4ecaa32ad03d9883736d9475cec
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20006
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Geneviève Bastien [Wed, 18 Dec 2013 20:45:02 +0000 (15:45 -0500)]
TMF: Moved the ProjectModelTestData in o.e.l.tmf.ui.tests to a shared folder
This test project can be used by tests from other ui plugins
Change-Id: Ida725bc10c9785c9d269995784d43551559f6353
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/20013
Tested-by: Hudson CI
Alexandre Montplaisir [Tue, 17 Dec 2013 23:22:36 +0000 (18:22 -0500)]
tmf: Switch tmf.analysis.* to Java 7
No code to update yet.
Change-Id: I5cbacc515e8f9cf13dee90e30220e6590f111adb
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19931
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 17 Dec 2013 23:16:35 +0000 (18:16 -0500)]
tmf: Switch tmf.ui.tests to Java 7 + fix warnings
Change-Id: I9acdba36689fa95d422a96606663e936d6fcd1ca
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19930
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 17 Dec 2013 23:08:56 +0000 (18:08 -0500)]
tmf: Switch tmf.ui to Java 7 + fix warnings
Change-Id: I1fd5700aa5f37e6c279752374ab6c1bcf2633d20
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19929
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 17 Dec 2013 21:57:52 +0000 (16:57 -0500)]
tmf: Switch tmf.core.tests to Java 7 + fix warnings
Change-Id: I1c048d7c15015e6eff0c3382cb6e15e9cc8de31a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19928
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Tue, 10 Dec 2013 17:06:32 +0000 (12:06 -0500)]
tmf: Fix incorrect histogram state when concurrently cleared during drag
- Reset the offset when drag zoom interrupted by clear
- Update selection when drag selection interrupted by clear
- Fix overflow in min and max offset calculation
Change-Id: I6eea70d713d4b46e75d254b9374631623c023600
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19605
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Marc-Andre Laperle [Mon, 16 Dec 2013 22:06:03 +0000 (17:06 -0500)]
lttng: Fix maven tests on Mac
Cocoa requires the Display to be created on the main thread
so -XstartOnFirstThread needs to be specified in the VM args.
Also use -Dorg.eclipse.swt.internal.carbon.smallFonts to make it
consistent with the fonts in the SDK.
Change-Id: If695baab41a35165f2cdc1120f088b5d6ba61354
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19888
Tested-by: Hudson CI
Etienne Bergeron [Sun, 8 Dec 2013 05:05:50 +0000 (00:05 -0500)]
ctf: Add unittests for the CTF Lexer and Parser.
This is a first draft of unittests for the CTF Lexer and Parser.
The coverage of these tests is still incomplete. More unittests
are to come.
Some tests are commented and need to fix the grammars.
The plan is to fix them in future commits to limits the
amount of refactoring.
Change-Id: I2d8e06560314ef22710985915b726a74974bbb1c
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19485
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Etienne Bergeron [Tue, 10 Dec 2013 21:37:12 +0000 (16:37 -0500)]
ctf: simplify trace environment lookup
Environment is an immutable data structure.
Wrap it into an unmodifiable collection.
Change-Id: I29ab6d4671eae2c9efd59412f80186a10b9b4952
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19622
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Sat, 14 Dec 2013 00:10:11 +0000 (19:10 -0500)]
lttng: Update Callstack View documentation
Add information about the Import Mapping File action, and document
the process for LTTng-UST traces.
Change-Id: I2db3c7e8021ed99bd7af9cbc7ed6a38fe06233b0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19845
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Mon, 16 Dec 2013 22:03:07 +0000 (17:03 -0500)]
tmf: Enable the finish button when default target project is selected
The previous fix for the batch import "target project" page introduces
a default selection but the user still has to click on the list again
to enable the finish button.
Change-Id: I492cc1ff115d6208aa577a721f04d96ebd2a4e2c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19881
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Sat, 14 Dec 2013 01:41:47 +0000 (20:41 -0500)]
tmf: Select a target project by default in batch import
Select the first list item by default in the last page of
the batch import (project selection). On Mac, no item is
selected by default. Since an item is now selected by default,
I changed the behavior of the page's message so that is only
displays an error when nothing is selected. Also, the Eclipse
UI guideline specifies that a page at initialization shouldn't
display an error, see
http://www.eclipse.org/articles/Article-UI-Guidelines/Contents.html#Wizards
Change-Id: I770fb9151f3c74a35dbf2d4e94db08f1301817cb
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19822
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Etienne Bergeron [Tue, 10 Dec 2013 21:19:50 +0000 (16:19 -0500)]
ctf: modify data-structure in CTF-Trace holding streams.
CTF allows multiple events to have the same ID as long as
they are not part of the same stream.
Thus, a unique event is represented by <stream-id, event-id>
and not only by event-id.
In this case, the CTF-Trace contains multiple streams
but maps all event-id into the same map (without stream-id).
Back-references are always a bad design.
In a future patch-set, the plan is to remove
CTF-Trace from CTF-Stream.
Change-Id: If5fc50d8541b152938a96447087d88c78e35e959
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19619
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 12 Dec 2013 19:49:03 +0000 (14:49 -0500)]
lttng: Handle threads in statedump events
In the statedump of a kernel thread (tid), we used to only check the
'ppid' field to get the paren thread. This works only for *processes*,
not for threads.
For threads we should use the 'pid' field to indicate which is the
parent TID.
Thanks to David Goulet for pointing this out!
Change-Id: I6b309d671ce43958ca9c0b43c5912877dca14e38
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19728
Tested-by: Hudson CI
Reviewed-by: Florian Wininger <florian.wininger@polymtl.ca>
Marc-Andre Laperle [Thu, 12 Dec 2013 21:09:06 +0000 (16:09 -0500)]
lttng: Add SWTChart to target defintions
Change-Id: Idd7728afa8293d236e74729b1d12ff5b67d5f0ee
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19732
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Thu, 12 Dec 2013 06:26:53 +0000 (01:26 -0500)]
ctf: Generate synthetic trace in test traces folder instead of temp dir
I was having problems with the synthetic trace now that the Luna branch
is merged into master because the index files got generated into the
synthetic trace folder and the folder would not get deleted on exit
because of that. Then the next test run, the trace would not get
generated because the folder already exists. I think it makes sense to
move the trace to the test traces folder and only generate it once.
Change-Id: I03e815c50e22adf2d5355856b8031cc7a8b4c9b1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19680
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Etienne Bergeron [Tue, 10 Dec 2013 01:59:32 +0000 (20:59 -0500)]
tmf: Avoid HistoryTree to expose its internal HT_IO node.
The HT_IO node is an abstraction of the file accesses for
a tree node. It should not be exposed to others classes.
The history tree must act as a proxy for requests to HT_IO.
This will ease modifications and maintenance of HT_IO.
HT_IO node should not keep a back reference to the HistoryTree.
This is a bad design. HT_IO node needs to know about HTConfig
to perform its tasks.
The HT_IO class contains method to read from disk.
The concept of a LastBranch is related to the HistoryTree.
Thus, readFromMemory is the same than calling
HistoryTree.readNode(...)
and readFromDisk is the same than calling
HT_IO.readNode(...)
Each layer is reponsible of its own caching mechanism.
Change-Id: Ia835a03efa321cdefd170de002833e044d144ee0
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19557
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 6 Dec 2013 19:33:11 +0000 (14:33 -0500)]
lttng: Update @since annotations for 3.0
Change-Id: I53ec925b49cb24485f0fbaf2c6441b2914f1e452
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19458
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Thu, 5 Dec 2013 21:43:30 +0000 (16:43 -0500)]
lttng: Re-enable API tracking
This reverts commit
26595e5ced3af74051513822158484e57315aa16
(and adds API errors to the new tmf.analysis.xml.* plugins).
Change-Id: Id3d93a594bdbadb8973698df26a5683b1d02c71e
Reviewed-on: https://git.eclipse.org/r/19457
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Etienne Bergeron [Wed, 11 Dec 2013 14:45:17 +0000 (09:45 -0500)]
ctf: Remove a backward dependency into StreamInput to CTF-Trace.
This dependency is useless.
In fact, the creation of the indexes seems also to be useless.
I didn't find any use of it.
I think the notion of StreamPacketInputIndex should be an class
only use by StreamInput.
Change-Id: I7dc236a64ad9c8a33e0d0f2b701d8794ef3f9226
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19650
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Etienne Bergeron [Tue, 10 Dec 2013 14:53:26 +0000 (09:53 -0500)]
ctf: tiny code refactoring in the metadata.
This pathch-set is a tiny cleanup before more refactoring.
The metadata are data and the "parsing/decoding/../" and
any actions on those data should be isolated in "internals"
and only accessors exposed to the user should be visible.
Patches to come soon.
Change-Id: Ie197726e16e0373e9a312b22ca9116968463990f
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19585
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Etienne Bergeron [Tue, 10 Dec 2013 02:12:21 +0000 (21:12 -0500)]
tmf: Remove back-reference from HT-Node to HT-Tree
The HT-Node needs to know about the layout of the node (size, n-child)
but not about the tree in which it belongs to. Any back reference
is typically a bad design. It complicated unittests and maintenance.
HT-Tree ---> HTNode--\
\ \
\---------------------> HTConfig
This patch-set is one of multiples to refactor the HT-Tree API.
The API refactoring will lead us to a easier algorithmic refactoring.
Change-Id: Ifa11cec6a89b9b1c698e0a2b2b18ac5ec70a7db0
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19555
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Etienne Bergeron [Wed, 11 Dec 2013 15:18:24 +0000 (10:18 -0500)]
ctf: isolate the abstraction of memory map byte-buffer.
The concept of the memory map mechanism should not be exposed
outside the StreamInput. This is internal to StreamInput.
The API should exposed : give me a byte buffer (I don't care how).
Change-Id: I832d2776845a07173f4ef7cb47fd9c75c7db73bf
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19652
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Etienne Bergeron [Tue, 10 Dec 2013 15:32:40 +0000 (10:32 -0500)]
ctf: avoid array creation to iterate through scope types.
The array creation is useless in this case.
It come from the exposed API of the scope which expose an "Array"
instead of an "Set".
The collection is not important to iterate through.
Change-Id: Ica313c1cbb4d58529389fe15dfd71f153a11b00b
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19591
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Etienne Bergeron [Tue, 10 Dec 2013 06:09:43 +0000 (01:09 -0500)]
tmf: Code cleanup in the history tree
The method preOrderPrint wasn't thread safe because it was using
a "global" field. This is not a big issue, but it's cleaner this
way.
I did a cleanup pass on this file.
Change-Id: I6255be52d3b2a8f84ef95a093578e10489c234eb
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19560
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Etienne Bergeron [Thu, 5 Dec 2013 19:51:59 +0000 (14:51 -0500)]
ctf: Some little refactoring in the ctf lexer.
Mostly only moving rules aroung to ease the reading.
The rule to match c++-like comment do not need to
take care of '\r'. It's a caractere like the others,
and the comment will be tuncante to the '\n'.
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Change-Id: I7fdb6dbd05729c6502ee987dec47b3cfd65806bc
Reviewed-on: https://git.eclipse.org/r/19411
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Wed, 4 Dec 2013 14:01:34 +0000 (09:01 -0500)]
ctf: better enum and variant verification
Check if enums are valid integers
Check if variants are not using unspecified tags
Check for variant tags recursively
Check for out of range variants
Check for non-intersection between variant and tag
Change-Id: Idd6a98673d8bb3b0a7a1649893a2e21f230a1bcc
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19410
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Alexandre Montplaisir [Tue, 26 Nov 2013 18:56:29 +0000 (13:56 -0500)]
tmf: Bring Java 7-specific errors back down to warnings
If we were to switch to Java 7 today, thousands of *errors* would
show up because of the 1.7-specific project settings set to generate
errors. Tone them down to warnings, until they are actually fixed.
Change-Id: I65720d2e3ea3849d5450e2677e25710ff2833909
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/18932
Alexandre Montplaisir [Wed, 27 Nov 2013 18:20:25 +0000 (13:20 -0500)]
lttng: Add the 4.3 JDT annotations to the 4.2 and 3.8 targets
Since we know that this is not a runtime dependency, we can safely
add it to the target definitions, so the code actually compiles when
we're using these targets.
Change-Id: I8fd8540ac4e9cd3cc4ae94290bd4b2a3ecbf0a22
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/18990
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Wed, 4 Dec 2013 22:04:59 +0000 (17:04 -0500)]
tmf: Fix concurrency issues in histogram view
- Make sure signals sent to itself with the signal throttler are
executed in the UI thread, so that Histogram.clear() doesn't
concurrently set fScaledData to null
- Clear the drag state when Histogram.clear() is called so that
subsequent mouse operations don't need to protect from clear during drag
- Prevent the trace updated signal from constantly resetting the
histogram range so that trace indexing doesn't interfere with drag move
and drag zoom
- Fix time range in full trace histogram being offset incorrectly when
new trace events cause the scale to change during dragging
- Fix mouse wheel zoom out snapped to current zoom start time in time
range histogram when trace updated
Change-Id: I1c6e71d9c7f26dec93192768e99306fdbb978dd1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19341
Patrick Tasse [Wed, 4 Dec 2013 18:29:10 +0000 (13:29 -0500)]
tmf: Fix mouse actions disabled when no visible events in histogram
Change conditions from zero events to empty time window to detect unused
histogram and disable mouse actions.
Also removes some unnecessary checks.
Change-Id: I761473005d6b004101741c535e8ec98a2bc0870f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19324
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Etienne Bergeron [Tue, 3 Dec 2013 11:47:51 +0000 (06:47 -0500)]
ctf: simplify getMinValue/getMaxValue computation.
The BigNumber divide is useless in this case.
Change-Id: Ibec0c081430b93ff4873db3bf9de3a2eece76f29
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19416
Tested-by: Hudson CI
Matthew Khouzam [Tue, 3 Dec 2013 21:42:52 +0000 (16:42 -0500)]
ctf: more restrictive parameters accepted as sequence lengths
The parser now only accepts unsigned integer variables as valid sequence lengths.
This patch also changes the API of DeclarationScope to be more clearly named.
Change-Id: I70cc6022ad99d1340f3c5a30546e489d2428832e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19403
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Alexandre Montplaisir [Thu, 5 Dec 2013 22:16:32 +0000 (17:16 -0500)]
tmf: Add a TODO the the HTNode cache size
At Florian's request.
Change-Id: Ifbe9fc2e2ce878789716ecf4854c2dd6f1a6be66
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Etienne Bergeron [Thu, 5 Dec 2013 00:26:33 +0000 (19:26 -0500)]
tmf: Add a HTNode cache to decrease the number of disk access
On startup, a cache of 256 entries give this ratio:
7778/8000 [97.23%]
After running a while:
42375/42600 [99.47%]
Change-Id: Icf2f6af3c9f40d4532196b18a87f2aa728341a58
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/19408
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Etienne Bergeron [Fri, 29 Nov 2013 18:24:04 +0000 (13:24 -0500)]
tmf: Implement a cache of TmfStateValue
This patch provides a caching implementation in the TmfStateValue factory.
TmfStateValue are immutable and can be shared.
By changing the size of the cache, we observed this cache ratio.
size hit total ratio
2 count:
7369956/
15551000 [0.
4739216770625683]
4 count:
11742495/
15530000 [0.
7561168705730843]
8 count:
14622383/
15545000 [0.
9406486330009649]
16 count:
15007948/
15552000 [0.
965017232510288]
32 count:
15372868/
15543000 [0.
9890541079585665]
64 count:
15432506/
15523000 [0.
9941703279005347]
128 count:
15488720/
15534000 [0.
9970851036436205]
Which seems to be an excellent ratio for a really small cache.
The same idea is used with Integer.valueOf(...).
Change-Id: I3701b900035d83b19531101ab60e7292899d8cef
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19030
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Geneviève Bastien [Wed, 6 Nov 2013 18:43:38 +0000 (13:43 -0500)]
TMF: Add new XML analysis project
Empty project where the data-driven XML analysis will be added
Change-Id: I3fc3c1ab468c601127451990bbb87dc26881f547
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/18583
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Etienne Bergeron [Wed, 4 Dec 2013 21:03:13 +0000 (16:03 -0500)]
ctf: Re-indent the CTF grammar to ease reading.
This patch-set does not change any rules.
I tried to apply the same Java indent rules.
A few rules are still badly indented.
I don't get why you keep all enter/exit debugging in the grammar.
You have antlr option to do this:
-trace have all rules call traceIn/traceOut.
-traceParser have parser rules call traceIn/traceOut.
-traceLexer have lexer rules call traceIn/traceOut.
-traceTreeParser have tree walker rules call traceIn/traceOut.
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Change-Id: I5077cdc23fe8c76fb17fd6ce0569bdd66d2e9ad7
Reviewed-on: https://git.eclipse.org/r/19334
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Geneviève Bastien [Fri, 29 Nov 2013 14:14:05 +0000 (09:14 -0500)]
TMF: Bug 422846, trace resource is refreshed after analysis
Change-Id: I2c9301eb5f6eb18139e0af475ad639429b6126bd
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/19116
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Etienne Bergeron [Wed, 4 Dec 2013 16:18:26 +0000 (11:18 -0500)]
ctf: fix a misleading comment on string alignment.
Signed-off-by: etienne.bergeron@gmail.com <etienne.bergeron@gmail.com>
Change-Id: I4efeaf273c8695a0aa8f72ba57592dd8d0e8b649
Reviewed-on: https://git.eclipse.org/r/19320
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Wed, 4 Dec 2013 18:37:49 +0000 (13:37 -0500)]
Merge branch 'master' into lttng-luna
Bernd Hufmann [Tue, 3 Dec 2013 20:36:09 +0000 (15:36 -0500)]
tmf: Fix NullPointerExeptions in Histogram view
These NPEs happens when clicking or dragging the mouse in the
histogram windows before any data is available in the scaled data
instance.
Change-Id: I57efdb03cd53e2198580fa6c0ed047fc2dc4c3ac
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19268
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexander Kurtakov [Wed, 4 Dec 2013 14:04:35 +0000 (16:04 +0200)]
Bump build system to build 3.0.0.
Subprojects parent poms are losing their versions as they are always the
same as the parent pom version and thus only introduce noise.
Change-Id: I6388f33c5e68d8c061cf57c7c09612817e189e30
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/19310
Tested-by: Hudson CI
Francois Doray [Mon, 2 Dec 2013 06:06:35 +0000 (01:06 -0500)] 
ctf: Add support for arrays or any type.
A null pointer exception occured for events that contained an array
of something else than "int". For example, an array of struct:
fields := struct {
...
struct {
string arg_name;
string arg_value;
} arguments[4];
};
With this fix, all arrays of CTF types are supported.
Sample output in the "Properties" view: http://i.imgur.com/31tqbgG.png
Change-Id: I3f2be314d1fd2bda8c95b208d018227477572fa8
Signed-off-by: François Doray <fdoray.eclipse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19029
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Francois Doray [Mon, 2 Dec 2013 05:28:19 +0000 (00:28 -0500)]
ctf: Make CtfTmfEventFieldTest easier to maintain.
Before this patch, a test event was created by filling a buffer with 0x02
bytes. Then, 0x00 bytes were added at magic positions to terminate the
strings used in the tests. That made the code hard to read and maintain. In
particular, it was hard to add new values in the test event without breaking
the null-terminated strings. It was also hard to understand, for example, that
0x02020202 is the float 9.
551467814359616E-38.
With this patch, values in the right format are added explicitly to the test
event. It's easier to understand the tests and to add values for new tests.
Change-Id: I5d482442a10f09627b3ed2b32a9a8cc68c0f5cdc
Signed-off-by: Francois Doray <fdoray.eclipse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19192
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Etienne Bergeron [Wed, 27 Nov 2013 05:37:40 +0000 (00:37 -0500)]
tmf: fix multiples coding style issues.
There is no behavior change in this patch.
Change-Id: I892fe351754363768210ba4bd333e39e339533ca
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19242
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Etienne Bergeron [Tue, 3 Dec 2013 09:20:12 +0000 (04:20 -0500)]
ctf: Hide internal functionalities of StringDefinition.
The StringDefinition should not expose its internal data structures.
The StringBuffer is a temporary buffer used by read. Nothing outside
the 'read' method should ever play with this object.
Change-Id: I2edda57f9208f4d1a56a3aa619545f803ea4278d
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19235
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Matthew Khouzam [Tue, 3 Dec 2013 21:41:41 +0000 (16:41 -0500)]
ctf: Improve int decoding in IOStructGen
Now handles "0x10" and "010" better, by using Long.decode() instead of
Long.parseLong().
Change-Id: I25d9cd239063674d52a73f00b3f4af90e1ddff33
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19272
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Matthew Khouzam [Wed, 27 Nov 2013 22:18:54 +0000 (17:18 -0500)]
ctf: support traces with no content but a packet size
Change-Id: I979e3826580db246263cfcb219ee7f9cba968922
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19023
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Patrick Tasse [Tue, 3 Dec 2013 19:22:48 +0000 (14:22 -0500)]
tmf: Fix Linux drawing weirdness in Histogram
- Set anti-aliasing to off when drawing histogram bars because it's on
by default in Linux
- Change order of drawing histogram bars and draw one pixel too far
because Linux doesn't draw last pixel of a line
- Clamp rounded rectangle arc size to rectangle width because Linux
doesn't
Change-Id: I574c80ecf15cda8655b3fbb8b34b80fd0f5a6d0c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19263
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Etienne Bergeron [Tue, 3 Dec 2013 10:00:04 +0000 (05:00 -0500)]
ctf: avoid temporary array creation when parsing CTF-Array.
The temporary List<long> is useless and the conversion function too.
Change-Id: I42bb50536deb1529998287fd9dae34c5f009c194
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19240
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Mon, 2 Dec 2013 20:52:26 +0000 (15:52 -0500)]
ctf: Succeed at failing on OOME in tests
There is a test that fails with an OutOfMemoryError. This catches the
failure and thus makes the test succeed at failing.
Change-Id: If4b1a14bf135da3fae9f356631440acede56673c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19001
Tested-by: Hudson CI
Matthew Khouzam [Wed, 27 Nov 2013 23:00:56 +0000 (18:00 -0500)]
ctf: Fix out of bounds positioning of the bitbuffer
rename private fields to follow fNameHere style
Change-Id: Ie579863b352a99e70cc9c1887d647aaa6018c9d4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19024
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Marc-Andre Laperle [Thu, 28 Nov 2013 22:41:46 +0000 (17:41 -0500)]
tmf: Update documentation for Open File, legacy import removal
Change-Id: Ib2c636e0e75ab8923a12728bec12260bd051ce7d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19090
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Etienne Bergeron [Sat, 30 Nov 2013 05:16:54 +0000 (00:16 -0500)]
ctf: Fix decoding of an invalid packet id type.
When an event id is not present, it is assumed to be zero.
Otherwise, it must be a _valid_ integer.
The current implementation accepts a "struct" as an id and map to the event id zero.
This fix throw an exception on an invalid id.
Change-Id: Iff6f6bd0173048dd3fb9b00f564948d7ebd55f4f
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19166
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Matthew Khouzam [Fri, 29 Nov 2013 23:06:11 +0000 (18:06 -0500)]
ctf: improve code clarity by merging if
Change-Id: I8ca0351762d36a5e25ba861e9fbc90ed14f5620a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19160
Alexandre Montplaisir [Fri, 29 Nov 2013 23:48:52 +0000 (18:48 -0500)]
ctf: Cleanup BitBufferIntTest
Update Javadoc, use correct order for (expected, actual) in asserts,
remove unneeded variables, etc. Hopefully they'll start looking less
like copy-pasted CodePro stubs.
Change-Id: Ie73748217201e93f9101a7c74928022857b93153
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19161
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Wed, 27 Nov 2013 20:06:07 +0000 (15:06 -0500)]
ctf: remove false positive in the case of cross-packet events
Change-Id: I8ba4d1edee641aa52c03c2f7742f672700b3282f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19006
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Wed, 27 Nov 2013 20:48:19 +0000 (15:48 -0500)]
ctf: make float use readlong for 64 bit floats
Change-Id: I15dd34cd4a5068894155bac33a8ada58d35fcfca
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19015
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Marc-Andre Laperle [Tue, 19 Nov 2013 01:23:49 +0000 (20:23 -0500)]
tmf: Import trace package without manifest
Change-Id: I4e97dcc25734b6a5a91ffb35bfa38a94246b4b85
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18591
Marc-Andre Laperle [Thu, 14 Nov 2013 23:42:44 +0000 (18:42 -0500)]
tmf: Import and export multiple traces in a package
Change-Id: I935a1fcf76518bcad02940f8cc687389dae89673
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18533
Etienne Bergeron [Sat, 30 Nov 2013 06:37:04 +0000 (01:37 -0500)]
ctf: Remove unused alignment comparison
This code just do nothing.
What was the original purpose?
Change-Id: I0bf24dcdf5cb607c1af0a3326dbab60d51c6fbd4
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19167
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Etienne Bergeron [Fri, 29 Nov 2013 05:04:02 +0000 (00:04 -0500)]
tmf: Fix a method name typo in CtfTmfTrace.
There is not behavior change in this patch.
Change-Id: Ib1c043ca13528e7b307275f3728ffab14ca2ac1a
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19092
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Matthew Khouzam [Wed, 27 Nov 2013 18:56:30 +0000 (13:56 -0500)]
ctf: Fix Integer 33-63 bit handling
Thanks Etienne Bergeron for the initial patch.
Change-Id: I388280ef111fe3fd50729780f13e984cbf648886
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18909
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Fri, 29 Nov 2013 21:45:21 +0000 (16:45 -0500)]
tmf: Update Javadoc in CtfIterator
And removed the clone() method, it wasn't used and clone() is bad.
Change-Id: Ib82eb78a50fe4ad1a0836cb98f99f4cc0da9606a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19155
Tested-by: Hudson CI
This page took 0.046986 seconds and 5 git commands to generate.
projects / deliverable / tracecompass.git / log
