tmf: Use OSString for the supplementary files folder property

On Windows, getLocationURI().getPath() returns a string that
starts with "/C:/...". This does not get parsed correctly by
utilities like java.nio.file.Path.

Using getLocation().toOSString() instead solves this problem.

Change-Id: I7c5d6d43cd21fd9c0021105884f61fb32bd133d5
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47932
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix XY viewer first pixel value and NaN when pixel range is 0

Change-Id: Ib73197ded6885bec9f84b4fde37b094f7feaf14a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/48004
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: fix performance issue with fighting optimisations

The struct flatener will effectively override the byte array optimisation,
this fix will not flatten byte arrays.

Change-Id: I74d76261cc178bd4ab3fac16f749495a481ebfd3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36954
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

doc: Minor corrections to Generic State System section

Change-Id: I9af4dd3c27f30f6e4ed478b7d6be9498f67674be
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45676
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Update for latest org.eclipse.remote API

IRemoteConnectionType#getCapabilities was removed, and replaced
with more direct capability-querying methods.

Change-Id: I5b14ab63320c2c0949d0d89a60fa7a2850f66bf3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/48106
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: remove field list from constructor of StructDefinition

This makes no sense to have as structs have the field list internally.
Moreover this leads to more complicated and error prone struct initialization.
It also hides potential bugs in the tests. As highlighted in CTFEventDefinitionTest

Change-Id: I25bf18bf9be23fb2af17f52de9cf677bea1b4833
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47992
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

tmf: Update mouse drag for xy charts to work with time aligmment

Change-Id: I6d94c4922bddae43ff9bcee3dfea118c7be446cf
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47957
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Update calculation of offset and available width in XY chart

During window range updates the window start and end time of the
xy chart viewer used to be inconsistent with the corresponding
x-Series values. This lead to incorrect values when calculating
the point offset and available width for the time alignment during
the period of inconsistency. With this patch the offset and width
is calculated using the first and last time in the x-Series array.

Change-Id: I70eee0c08777c4b6797e2d6bbc41dd19fff05f64
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47944
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

lttng: Disable spuriously failing Partial State System tests

The partial state system is in very bad shape and not used at all.
Until some energy is put into improving its implementation and
testing, it should not be depended upon.

To make matters worse, one of its tests is failing randomly on
Hudson. Since it is not in a supported state at the moment, I
suggest disabling these tests until we improve the PSS.

Change-Id: I592598670b2f2a122c8f638b264502a48dae177c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47991
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: replace Defintion with IDefinition in IDefinitionScope

Change-Id: I06a73afd3a97633f4355828be0c10cf0dd7ad2e0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46461
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

tmf: Fix calculation of time axis offset

Calculate the time axis offset based on the control sizes instead of
using the sash weight ratios which can introduce small rounding errors.

Change-Id: Iff8deabd45981913e5209b9d2d4f33b922a5d6d4
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47923
Reviewed-by: Hudson CI

tmf: Fix calculation of sash weights in performAlign

This ensures that the sash width is taken into account when calculating
the sash weights when trying to align to a specific offset.

There can still be some drifting by 1 pixel, but this is caused by
integer trimming in the computations inside SashForm and SashLayout.

Change-Id: I742dc99e90e3eb4c9f95b1bac3da286f3187af3e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47884
Reviewed-by: Hudson CI

lttng: Make sure that time alignment signal is sent in CPU Usage view

Change-Id: I5efa35104ba3cc3112cc82c5afd4b50632deb883
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47886
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Don't subtract of 1 when getting the pixel coordinate from xAxis

For small time ranges this subtraction caused invalid coordinates which
lead to invalid time alignment when zooming in to very small time range

Also, make sure that getPixelCoordinate is only called when Y-values
are abailable when calculating the the point area offset.

Change-Id: Iaa623a406a91ac94e681bf610169892ee8149555
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47885
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix calculation of available alignment width in TimeGraphCombo

Before the fix the vertical scroll bar was not considered when
calculating the avalible alignment width.

To observe the impact of the incorrect aligment value open just
HistogramView and ControlFlowView for a kernel trace without the fix.
Then the right margin of the Histogram view is not correct.

Change-Id: Ia54e2c3f03fcc22def4706b778518353515c7897
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47852
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Set window start and end time of TmfTimeViewer in one method.

Now both values have to be set at the same time instead of calling
2 set methods.

Change-Id: I8b76dfdf9d6d5c4d4e00b440b8ae493307e5bd7e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47812
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Set selection begin and end time of TmfTimeViewer in one method.

Now both values have to be set at the same time instead of calling
2 set methods.

Change-Id: I66d7e564609d83cba7f85bcad3649c39e34cc0eb
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47762
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Set selection end time when opening XY chart views

Change-Id: I7b283f4492c00bc0a0fc6e716bd78aacf2751a4a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47760
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Update default weight for the SashForm in time-aligned views

Change-Id: Ie345adad7836116e38a18d4b08d6ab1071e298cc
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47759
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.core: Iterate over values or entries in a map iterator

Change-Id: Ia1ca10bc9bc0af48167417071585dd91c5bc2def
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46790
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

Tmf.Ui: fix Multithreaded correctness - Call to static DateFormat

The problem has been very well explained here:
http://fahdshariff.blogspot.ca/2010/08/dateformat-with-multiple-threads.html
As this code may be used in multi-threaded environments, not making it thread
safe will result in sporadically mangled dates. This patch fixes it by
synchronizing each access with the list of all items. More performance would
be had by using a threadlocal scheme where setting the timezone resets the
structure, but the legibility of the class would greatly suffer.

Change-Id: If8e9b118b3db15a2a0c088d4ebb2fa7c20839885
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46792
Reviewed-by: Hudson CI

lttng: Remove unnecessary String object creation

Change-Id: I984c3218ebe2cff37b5596f53c2bb2d642f1bfd4
Signed-off-by: Alexis Cabana-Loriaux <alex021994@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47353
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

gdbtrace: Change instantiation of Integer argument

Change-Id: Ib0bf057a4fd858271da1ea332e7ce94c3df72493
Signed-off-by: Alexis Cabana-Loriaux <alex021994@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47318
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Remove nullcheck before an instanceof

Change-Id: Ia1f5b9d7c77046bb6baa7c8950dbe8acd000ab5e
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47504
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Use equals and equalsNullable method instead of ==

Change-Id: I3dcc6c0a60f88b0ffcf92dd6f3d17a831403dbb8
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47535
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

pcap: Replace a null-check by a NonNullUtils function in ConversionHelper

Change-Id: I41aaaa5bdcd7cbe849dcfc096350c91663763ac4
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47226
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Remove redundant null check by marking generateSessionConfig() @NonNull

Change-Id: I96e6536b44d45c0bf02fb675f14c86bfd016644e
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47227
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Remove repeated conditional test

Change-Id: Ia77d9ed5463e790a4526625e8f111946c470d891
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47537
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Bump target sequence number to pick up Mars M7

Change-Id: Iab76273eb5573cac436da167f9b404b1b6472a0d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47663
Reviewed-by: Hudson CI

tmf: Adjust xAxis range after mouse drag operation in XY chart viewer

This will provide correct values for x-Axis alignment.

Change-Id: Ic98423582b6c361f1fefc79e837dc919aaaad038
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47178
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Align the time-axis for time range histogram

Change-Id: Ie1dfb34e9ffdbe881bb477622398dce44546529d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47077
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

tmf: Allow shift key to extend selection in time graph

- Extend the selection range when shift key is pressed while pressing
left or right keys.
- Extend the selection range when shift key is pressed while running the
next event, previous event, follow arrow fwd, follow arrow bwd actions.
- Update status line when the above actions modify the selection.
- Make sure the selection end time is visible when modifying the
selection range.
- Show status line when time graph control has focus with mouse outside
of the control bounds, but without displaying the cursor time.
- Highlight the selected state at the selection end time instead of the
selection start time.
- Remove the margin factor that made 'ensure visible' change the time
range when the selection was near the left or right margin.

Change-Id: Iee1dbbbc56e052de1a48bc638355e0c7dc126c2a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47381
Reviewed-by: Hudson CI

tmf: Allow negative time range selection

This patch allows the selection end time to be lower than the selection
start time, better representing the user selection.

It will help to correctly update the end boundary using atomic
operations (keyboard or button) that extend a selection to the left of
the selection start.

The status line message delta is updated to allow a negative value.

Change-Id: I5228441cb049487783d4b0fdcba7ef766077677f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47380

tmf.ui: add percent of selection to timechart view

This allows us to know how much time is being used by one entry in a timechart.
Applies to Control flow view, resource view and the call stack view

Change-Id: If7052553473ca53929aafaba7fc5831883e4e087
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46271
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Add sash for time range histogram and time controls

Change-Id: I127751cc998e56cd47afae7922099e2861028e61
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47075
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.ui: make histogram use entire range of plot area

This feature will help view alignment but has an issue with beat
aliasing due to sampling periods not being harmonics.

Change-Id: Iff033f90f68e0614a9f56a402400b9385108107d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46593
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix time scale not visible at first in Control Flow view (GTK3)

Bug 466791
Change-Id: Ide2431eb9a48f5430e04f53bd3d76c28c03577d3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47505
Reviewed-by: Hudson CI

ctf: Provide a Maven property to specify a ctf-testsuite commit to use

Instead of automatically pulling all changes from ctf-testsuite,
which may break our builds unexpectedly, we'll define a commit
to use in the plugin's pom.xml.

We can regularly update this pointer to pull in newer versions
of the test suite.

The property can also be overridden on the command-line, for
example using:

  mvn clean verify -DctfTestSuiteCommit=master

will use ctf-testsuite's master branch.

Change-Id: I06b8e11f12fec16d9c011f0f2a80b083fcadd8de
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47554
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Synchronize initialization methods of static fields

Change-Id: Iedc625fb00e3f9745c03f3bea233c12bc5b9ca26
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47355
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix bad width value when timegraph views are smaller than time axis offset

Change-Id: I2e2a4361e0ce1fb1857e4f0be7e781c56ead438c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47485
Reviewed-by: Hudson CI

tmf: Fix regression of XML analysis combined with custom text parser not working

bug: 466641
Change-Id: I9c6ea6014e6f25f73e52ed182b6abc2ab2394a17
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47382
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Allow mixing unspecified stream IDs with ID 0

If an event does not specify a stream ID, we will assign it to
stream with ID 0. This means they will be put in the same stream
as the events specifically defining stream 0.

A corrolary is that if a stream does not specify it's id, it too
is assigned to 0.

However, the trace must not define any stream IDs other than 0.

This behaviour matches the one of Babeltrace.

Change-Id: I0628acaa8566dde0a3659fe56d5a8e903c6feb26
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45687
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Remove 2 redundant nullcheck in TmfEventsTable by using local copy

Change-Id: I5e0fb8f084afa7ef07f573c877fb2b8b24af0493
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47224
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix status line not updating if trace editor is reused

The status line showing the delta of the selection range was not
updating if the trace editor was opened using a bookmark or was restored
following a restart of Eclipse.

Change-Id: I826b21209cfa329d5df99f077e9f3342950eae74
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47379
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

histogram: reflow comments

Change-Id: I79e439e5bb03c4e35d3985b20a810f50714922e7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47399
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.ui: reflow events table

Change-Id: Ia36fd20caa4f1f38d34de2299f1a58dbe537b639
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47448
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Align the time-axis for MemoryUsageView, XmlXYView (TmfChartViews)

Change-Id: I22480ae2d4adc3b223a68dd9a859b2a3fb2b32c8
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46819
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Align the time-axis for the CPU usage view

Change-Id: I4eef728afc1092ee0fe9b340af97bf4345aa2d2b
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46811
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Align the time-axis of time chart views

This patch introduces a logic for time-axis alignment across view. The
time chart based views use this new mechanism as a first implementation.

Change-Id: I31a05b686c8028b8f3e0643afa7aa540c9165cdf
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46810
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Remove capital letter in package name

Rename lttng2.control.core.relayd.lttngviewerCommands to
.commands. Package names should not contain capital letters.

Change-Id: I250f9a72b2ea966e0c3e3e6568d87cab5a77dc9e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46378
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Remove unneed null checks

A recent JDT update seems to have extended the null flow analysis
to consider the case where assigning an Integer from an int makes
it effectively non-null.

This points out that we were doing some redundant null checks.

Change-Id: Ie222b519f02e45584ae4f47381025fd28a8f6423
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46967
Reviewed-by: Hudson CI

Remove the Eclipse 4.4 target file

A recent change in org.eclipse.remote.core requires Eclipse 4.5.
As such, Trace Compass now also requires 4.5.

Change-Id: I8a71bc98123a7137a75cfcc4f20a8dfd21fde4a1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47369
Reviewed-by: Hudson CI

common: Add a test for BufferedBlockingQueue's iterator contents

Also changed the test string to something more easily debuggable.

Change-Id: I760574b01e77709b5238e5e5ea019981fa79d45f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47116
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.ui: Remove AOOBE in GraphNode when given an empty list

Change-Id: Ic870af87fe73fd4a9b9eceb3f818aaaabde21ac2
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47201
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common: Fix flaky BufferedBlockingQueue test

The test testing concurrent insertion/removals/iterations
incorrectly assumed that all elements send to the queue would
show up in the iterator.

This is a known limitation of BBQ's iterator(), and is documented
in its Javadoc. The elements present in the queue at the time the
iterator is created will be either seen by the iterator OR consumed
by the consumer.

We cannot assume anything with regards to the iterator's contents.
A separate (sequential) test for the iterator's contents will be
provied.

Change-Id: I3d281ca1ad4a81e69f02363b52942990424dd57c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47115
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

os.linux: Re-organize the KernelAnalysisModule

Bring the KernelAnalysis up to speed with regards to naming
conventions and public/internal separation:

- Rename KernelAnalysis to KernelAnalysisModule
- Move KernelStateProvider to internal package
- Move KernelStateProviderTest from lttng2 to os.linux plugin
- Remove direct references to KernelStateProvider in
  lttng2.kernel.core.tests, extend the analysis module instead
- Expose the internal package to the test plugin

Change-Id: I8a7baaacdc8a31c033e0fd8ae1650f34fd5232ae
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46373
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.core: move AbstractTmfStateProvider to new BufferedBlockingQueue

This yeilds a performance boost, especially on slower io systems.

Change-Id: I04dd89d2237c80bd07c00514fd83f0d4f31e13dc
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46279
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ss: Move ThreadedHistoryTreeBackend to new BufferedBlockingQueue

This should yield a significant performance boost on state system generation.
Especially on slower IO devices.

Change-Id: Ie414270194e9622be7106dc6c0b9ccc7050f49aa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46215
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common: Add test suite for the BufferedBlockingQueue

Change-Id: Ibc27385a75faeb47586443530fb68fe848979946
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46206
Reviewed-by: Hudson CI

common: Introduce a generic BufferedBlockingQueue

The BufferedBlockingQueue (nicknamed "BBQ") is a wrapper around
a standard ArrayBlockingQueue, which accumulates elements in a
separate Collection before putting them in the actual Queue.
This allows a producing and a consuming threads to not block each
other as much when they are producing and consuming at the same
time.

An identified use case is the ThreadedHistoryTreeProvider, and
perhaps eventually the AbstractTmfStateProvider too.

Change-Id: I010547d7914c4c377bf1c85f4f830bff0aa8740f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46148
Reviewed-by: Hudson CI

Upgrade eclipse-jarsigner-plugin to 1.1.2-SNAPSHOT to fix build failures

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=464947

Change-Id: I684d7bcc278a14ae5d1467c0574567804cd96ac1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46929
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: clean up CTFStreamOutputWriter.java

Merge if statements
Preserve exceptions
Throw exception on deletion failure as the trace would be unreadable

Change-Id: I77f23e5bca82be26b831a38ea5add385586e20f5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46831
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.ui: fix modifier order in TmfCommonXLineChartViewer

Change-Id: I050bcec1eac37a56b535085da278840437bb3160
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46832
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.ctf.ui: test invalid trace validation (Bug 464329)

Change-Id: I28fd7b41ff4777e43dbdcbfd013020f8a256fe87
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46685
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

tmf.ui: make trace errors use JFace MessageDialogs

Change-Id: I244c437f874a5b0caf6c2e38997fea384433f598
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46716
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix value of time offset in XY chart viewer being wrong for a while

Right after calling setWindowStartTime/setWindowEndTime, the value of
getTimeOffset was wrong until setTimeOffset was called later, in a data
building thread for example.

Since the time offset is deduced from the start time (startTime - 1), we can
remove this field and setter. This means that the time offset will always be
consistent with the start time. Similarly, the window duration can be deduced
(startTime - endTime) therefore we can remove this setting and field as well.

An example of how this bug can manifest itself is inside a resize listener.
If both windowStartTime and timeOffset are used to calculate the position of a
value on the chart, since the timeOffset can be inconsistent, the position
would be wrong.

Change-Id: If59a9d2c0dfc24245949f8ba693dd89e6498820f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46591
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: introduce a CTF writer for copying packets of an input CTF trace

Change-Id: I0cb39fba1b28d6a6e816c2278fe1d6d859b7a797
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45832
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Remove RSE-specific workaround utility class

This class provided workarounds for an RSE-related bug.
Since we do not use RSE anymore, this class is now unused.

Change-Id: Ia206ca869faece7611cdffcce01233b2004ce9d9
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46379
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Update package and file names in lttng2.ust.core

Harmonize the naming of the the UST memory analysis files and
packages.

Also renamed the "core.trace.callstack" package to just
"core.callstack". It is not specific to the trace package, and
its not an analysis module either (the Callstack is a public
TMF concept).

Change-Id: I0f2d085801a522f62bba09ae623f55043af24a03
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46374
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: simplify logic for CTF validation

Change-Id: I2282dd6865adc78af423395ee776a9a749e96734
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46433
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: add unit tests for CtfTmfTrace.validate() method (Bug 464329)

Change-Id: I2fcb5e4260159603e08a0597fc7ec723dc2b3b16
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46351
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: disable failing test for newly added trace in ctf-testsuite

Disable it till it's fixed.

Change-Id: I8d31f54bbe9cb3cf75f2636ac532db04bafc0f28
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46376
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf.core: add populate indexes and fix seek last event

Add much needed documentation to goToLastEvent. It is
not as trivial as one would think.

Change-Id: Ia2834df70f583430afc1a7046993809c9262a690
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45689
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf.core: introducing ICTFPacketDescriptor

This is the interface of the "StreamInputPacketIndexEntry".
The documentation is also slightly expanded.

Change-Id: Ic02762ab90c0bf69766c7bcf90ddd2207e7e12f6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45929
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

CTF: Enhance CTF validation for invalid CTF traces (Bug 464329)

The CTF validation has been updated to do first a weak validation
to determine if the directory is actually a CTF trace. After that
a full validation is done. If the full validation fails and the
weak validation was successful a TraceValidationStatus with
severity warning and confidence of 1 is returned.

The automatic trace type detection has been updated so that the
special case above is acounted for.

With these updates the trace is imported as CTF trace however, the
use is notified that with a proper error message in case the full
validation failed.

Change-Id: Ia9b798b34c7af122d3b7684e91b114b38b656cef
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46202
Reviewed-by: Hudson CI

ctf: rename CTFReaderException to CTFException

CTFIOExceptions are now only thrown by *Readers and not types or other

Change-Id: Id352ef121d3c94b4004e6c5fbe70c282bd131261
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46134
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Revert "ss: accelerate state system creation by 25% by coalescing intervals"

This reverts commit 2ce551cccdac4096d3efd910f11e3fabe3c51856.
The commit is causing incoherent interval exceptions. A rework should be available soon.

Change-Id: I2e0d091d81e032b0f2e6ee65251a7c58b6320db4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46120
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: update ITmfEvent.getType().getName() to be getName()

This could yield a performance boost
Also, substitute TmfUml2dSyncLoader's getType().toString()
with getName() as it is being used to get the event name

Change-Id: Ide3cb3f0a97f86d99f2e358f608dac107c730bef
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45675
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

linux: make kernelstateprovider use getName()

Change-Id: Ia454a3ffc1bba461430c1fb6e0440bd0610083a2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45673
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.core: add getName to ITmfEvent

It seems to be used a lot so getType().getName() is a bit too much
indirection, it also allows lazy loading of the type.

Change-Id: I2126a3d6406eeb72324fa771bcdff382361a3dfd
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45672
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

ss: accelerate state system creation by 25% by coalescing intervals

The state system threaded back end sends one interval at a time to
a blocking queue to be written to disk. This patch makes it send several
intervals at a time, meaning we have several times less context switches
and several times less blocked threads.

Change-Id: I5cf26da2f1593749245bb6cf5c6f3c5ed65f00e0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45603
Reviewed-by: Hudson CI
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Make remote CommandShellTest run on Mac

The tests are skipped if the platform is not Linux but they can run on Mac.

Change-Id: Idcface3299f44e32c232d0ae5939d5cf5b703b3f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45772
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Fix tmf.remote.core tests not running

Change-Id: If8f2c477322bc0dabd2f4bff1ef59cb136ea7192
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45771
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ss: Bug 454057: Use serialization to write the list of attributes to disk

Simplify the writing of the Attribute Tree to disk by using the
fact that ArrayList is Serializable.

This makes the file format less portable, but the previous method
used String.getBytes(), which is also JVM-dependant. A proper
inter-operable (and more efficient) format could be implemented
at some point once the need arises.

Change-Id: I8622b0975852ed3e022a210dbd720eb4d0fe90f4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/45682
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf.ui: make methods called by constructor private

Change-Id: I3b25e96e726a52ab48705a8a4819c1a30aedfc0a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45462
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

ss: Bug 464174: HTNode interval list is not sorted

Change-Id: Ibbd3e86bf529a284177860a3c1fd39ffbb554ad1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45477
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

swtbot: Update tests for event table highlight color preference

Change-Id: I7ca0889f6a31eda911ea7e0a313123e6341ba097
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45179
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

doc: Update user guide for event table highlight color preference

Change-Id: I4f337827c8457ee8b9c22a2878d6975acd0f21aa
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45178
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Add color preference for event table search and filter highlight

The color settings can be changed in Window > Preferences > General >
Appearance > Colors and Fonts > Tracing.

Change-Id: I3bda3530657797cf434e86a7e6055a64066a4e51
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45177
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Bump target sequence numbers to pick up new API changes from o.e.remote

Change-Id: I6210c4c26e045ae9ef6d68d187a85528ab2c6d61
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45423
Reviewed-by: Hudson CI

Add setup file for Oomph

This patch adds a setup file for Oomph. To test it:
1. Start the Oomph installer (https://wiki.eclipse.org/Eclipse_Oomph_Installer)
2. At the package selection, click the Advanced Mode button in the top-right
corner
3. Select Eclipse IDE for Eclipse Committers. Click next.
4. Select Eclipse.org
5. Click on the '+' button in the top-right corner, browse file system for
TraceCompass.setup.
6. Double-click on Trace Compass in the tree. Click next.
7. Enter installation folder name, workspace name. Click Next, Finish.

This should install and start a new Eclipse installation with the Trace Compass
code ready to be worked on. Once this patch is merged, the setup will be added
to Eclipse catalog so that the user doesn't have to browse for the file.

Change-Id: I3b52508531d604dc9b493b6b7d2386a617ba54c1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41099
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

inport/export: fix synchronization bug.

We were synchronizing on a boolean, and changing the boolean later, this is not
a desirable practice.

Change-Id: I168d9c1e238205a2f3150bd5977a45e544e1d4df
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45387
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

import/export: remove ResourceTreeAndListGroup

Change-Id: Ib8925710f1f7e51fc328f9d84fa7d1884f6a0eef
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45290
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Tweak some NonNull to work around bug 436486

The compilation could fail in some scenarios.

Change-Id: I3cd9e497f1ae8caf88684b793e6dc1b2696f688f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45393
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

general: avoid iterating over a keySet then get()ing the key.

This will ensure a higher performance access time even if the map is
switched for a tree or other map.

Change-Id: Ib1c6d5d35ea6d65d03fd5f324fa7ea4ab22285ab
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45239
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

pcap: address some redundant nullchecks in packets

Change-Id: I0855239ff5b567951be9189d8c6167d6f62d03fa
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45233
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf remote: Decouple connection creation from JSchConnection

The o.e.remote API used to not provide an API to store username,
host and port programmatically without using internal APIs of
the JSchConnection implementation. Now, o.e.remote API has been updated
to provide a generic API to set this values independent of the
actual implementation (see Bug on PTP 463468).

This patch is to update TMF remote to use the generic API.

Change-Id: Ib7ddd64d64f000e9c9e3de99e9f40afcbe10df8e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45328
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

import/export: replace | with || allowing short circuiting if in extension check

Change-Id: I1a446c92b289843dd6f1e88b0e3eb51080fd5085
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45229
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

pcap.ui: replace hashmap iteration over key with entryset iteration

This is a performance helper and also reduces the amount of gets in the
hashmap

Change-Id: I4df95b7e2172ff839073e7a716f065213fb2d718
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45174
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

pcap: use NonNullUtils.equalsNullable in packet equals

Change-Id: Ie1e96a72b378d3ad2f9b3f90000acf201bd4a2c2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45173
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>