Marc-Andre Laperle [Wed, 29 Apr 2015 18:28:27 +0000 (14:28 -0400)] 
tmf: Align the time-axis of time chart views
This patch introduces a logic for time-axis alignment across view. The
time chart based views use this new mechanism as a first implementation.
Change-Id: I31a05b686c8028b8f3e0643afa7aa540c9165cdf
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46810
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Thu, 23 Apr 2015 19:25:06 +0000 (15:25 -0400)] 
lttng: Remove capital letter in package name
Rename lttng2.control.core.relayd.lttngviewerCommands to
.commands. Package names should not contain capital letters.
Change-Id: I250f9a72b2ea966e0c3e3e6568d87cab5a77dc9e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46378
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Fri, 1 May 2015 22:02:23 +0000 (18:02 -0400)]
Remove unneed null checks
A recent JDT update seems to have extended the null flow analysis
to consider the case where assigning an Integer from an int makes
it effectively non-null.
This points out that we were doing some redundant null checks.
Change-Id: Ie222b519f02e45584ae4f47381025fd28a8f6423
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46967
Reviewed-by: Hudson CI
Alexandre Montplaisir [Wed, 6 May 2015 19:34:54 +0000 (15:34 -0400)]
Remove the Eclipse 4.4 target file
A recent change in org.eclipse.remote.core requires Eclipse 4.5.
As such, Trace Compass now also requires 4.5.
Change-Id: I8a71bc98123a7137a75cfcc4f20a8dfd21fde4a1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47369
Reviewed-by: Hudson CI
Alexandre Montplaisir [Tue, 5 May 2015 02:56:48 +0000 (22:56 -0400)]
common: Add a test for BufferedBlockingQueue's iterator contents
Also changed the test string to something more easily debuggable.
Change-Id: I760574b01e77709b5238e5e5ea019981fa79d45f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47116
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
France Lapointe Nguyen [Tue, 5 May 2015 17:49:57 +0000 (13:49 -0400)] 
tmf.ui: Remove AOOBE in GraphNode when given an empty list
Change-Id: Ic870af87fe73fd4a9b9eceb3f818aaaabde21ac2
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47201
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 5 May 2015 02:32:00 +0000 (22:32 -0400)]
common: Fix flaky BufferedBlockingQueue test
The test testing concurrent insertion/removals/iterations
incorrectly assumed that all elements send to the queue would
show up in the iterator.
This is a known limitation of BBQ's iterator(), and is documented
in its Javadoc. The elements present in the queue at the time the
iterator is created will be either seen by the iterator OR consumed
by the consumer.
We cannot assume anything with regards to the iterator's contents.
A separate (sequential) test for the iterator's contents will be
provied.
Change-Id: I3d281ca1ad4a81e69f02363b52942990424dd57c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47115
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 23 Apr 2015 17:25:19 +0000 (13:25 -0400)]
os.linux: Re-organize the KernelAnalysisModule
Bring the KernelAnalysis up to speed with regards to naming
conventions and public/internal separation:
- Rename KernelAnalysis to KernelAnalysisModule
- Move KernelStateProvider to internal package
- Move KernelStateProviderTest from lttng2 to os.linux plugin
- Remove direct references to KernelStateProvider in
lttng2.kernel.core.tests, extend the analysis module instead
- Expose the internal package to the test plugin
Change-Id: I8a7baaacdc8a31c033e0fd8ae1650f34fd5232ae
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46373
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 22 Apr 2015 18:37:58 +0000 (14:37 -0400)] 
tmf.core: move AbstractTmfStateProvider to new BufferedBlockingQueue
This yeilds a performance boost, especially on slower io systems.
Change-Id: I04dd89d2237c80bd07c00514fd83f0d4f31e13dc
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46279
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Tue, 21 Apr 2015 22:27:34 +0000 (18:27 -0400)]
ss: Move ThreadedHistoryTreeBackend to new BufferedBlockingQueue
This should yield a significant performance boost on state system generation.
Especially on slower IO devices.
Change-Id: Ie414270194e9622be7106dc6c0b9ccc7050f49aa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46215
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Tue, 21 Apr 2015 18:36:43 +0000 (14:36 -0400)]
common: Add test suite for the BufferedBlockingQueue
Change-Id: Ibc27385a75faeb47586443530fb68fe848979946
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46206
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 21 Apr 2015 02:08:05 +0000 (22:08 -0400)]
common: Introduce a generic BufferedBlockingQueue
The BufferedBlockingQueue (nicknamed "BBQ") is a wrapper around
a standard ArrayBlockingQueue, which accumulates elements in a
separate Collection before putting them in the actual Queue.
This allows a producing and a consuming threads to not block each
other as much when they are producing and consuming at the same
time.
An identified use case is the ThreadedHistoryTreeProvider, and
perhaps eventually the AbstractTmfStateProvider too.
Change-Id: I010547d7914c4c377bf1c85f4f830bff0aa8740f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46148
Reviewed-by: Hudson CI
Marc-Andre Laperle [Thu, 30 Apr 2015 17:16:15 +0000 (13:16 -0400)]
Upgrade eclipse-jarsigner-plugin to 1.1.2-SNAPSHOT to fix build failures
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=464947
Change-Id: I684d7bcc278a14ae5d1467c0574567804cd96ac1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46929
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Thu, 30 Apr 2015 00:59:07 +0000 (20:59 -0400)]
ctf: clean up CTFStreamOutputWriter.java
Merge if statements
Preserve exceptions
Throw exception on deletion failure as the trace would be unreadable
Change-Id: I77f23e5bca82be26b831a38ea5add385586e20f5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46831
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Thu, 30 Apr 2015 01:13:35 +0000 (21:13 -0400)]
tmf.ui: fix modifier order in TmfCommonXLineChartViewer
Change-Id: I050bcec1eac37a56b535085da278840437bb3160
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46832
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Tue, 28 Apr 2015 14:13:37 +0000 (10:13 -0400)]
tmf.ctf.ui: test invalid trace validation (Bug 464329)
Change-Id: I28fd7b41ff4777e43dbdcbfd013020f8a256fe87
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46685
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 28 Apr 2015 20:39:32 +0000 (16:39 -0400)]
tmf.ui: make trace errors use JFace MessageDialogs
Change-Id: I244c437f874a5b0caf6c2e38997fea384433f598
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46716
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Mon, 27 Apr 2015 19:00:08 +0000 (15:00 -0400)]
tmf: Fix value of time offset in XY chart viewer being wrong for a while
Right after calling setWindowStartTime/setWindowEndTime, the value of
getTimeOffset was wrong until setTimeOffset was called later, in a data
building thread for example.
Since the time offset is deduced from the start time (startTime - 1), we can
remove this field and setter. This means that the time offset will always be
consistent with the start time. Similarly, the window duration can be deduced
(startTime - endTime) therefore we can remove this setting and field as well.
An example of how this bug can manifest itself is inside a resize listener.
If both windowStartTime and timeOffset are used to calculate the position of a
value on the chart, since the timeOffset can be inconsistent, the position
would be wrong.
Change-Id: If59a9d2c0dfc24245949f8ba693dd89e6498820f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46591
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Mon, 13 Apr 2015 18:24:38 +0000 (14:24 -0400)] 
ctf: introduce a CTF writer for copying packets of an input CTF trace
Change-Id: I0cb39fba1b28d6a6e816c2278fe1d6d859b7a797
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45832
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 23 Apr 2015 19:36:07 +0000 (15:36 -0400)]
lttng: Remove RSE-specific workaround utility class
This class provided workarounds for an RSE-related bug.
Since we do not use RSE anymore, this class is now unused.
Change-Id: Ia206ca869faece7611cdffcce01233b2004ce9d9
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46379
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Thu, 23 Apr 2015 17:34:11 +0000 (13:34 -0400)]
lttng: Update package and file names in lttng2.ust.core
Harmonize the naming of the the UST memory analysis files and
packages.
Also renamed the "core.trace.callstack" package to just
"core.callstack". It is not specific to the trace package, and
its not an analysis module either (the Callstack is a public
TMF concept).
Change-Id: I0f2d085801a522f62bba09ae623f55043af24a03
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46374
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Fri, 24 Apr 2015 13:26:16 +0000 (09:26 -0400)]
ctf: simplify logic for CTF validation
Change-Id: I2282dd6865adc78af423395ee776a9a749e96734
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46433
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Thu, 23 Apr 2015 15:06:26 +0000 (11:06 -0400)]
ctf: add unit tests for CtfTmfTrace.validate() method (Bug 464329)
Change-Id: I2fcb5e4260159603e08a0597fc7ec723dc2b3b16
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46351
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Thu, 23 Apr 2015 18:13:49 +0000 (14:13 -0400)]
ctf: disable failing test for newly added trace in ctf-testsuite
Disable it till it's fixed.
Change-Id: I8d31f54bbe9cb3cf75f2636ac532db04bafc0f28
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46376
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Sat, 11 Apr 2015 03:31:51 +0000 (23:31 -0400)]
ctf.core: add populate indexes and fix seek last event
Add much needed documentation to goToLastEvent. It is
not as trivial as one would think.
Change-Id: Ia2834df70f583430afc1a7046993809c9262a690
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45689
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Thu, 16 Apr 2015 03:03:11 +0000 (23:03 -0400)]
ctf.core: introducing ICTFPacketDescriptor
This is the interface of the "StreamInputPacketIndexEntry".
The documentation is also slightly expanded.
Change-Id: Ic02762ab90c0bf69766c7bcf90ddd2207e7e12f6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45929
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 21 Apr 2015 19:59:56 +0000 (15:59 -0400)]
CTF: Enhance CTF validation for invalid CTF traces (Bug 464329)
The CTF validation has been updated to do first a weak validation
to determine if the directory is actually a CTF trace. After that
a full validation is done. If the full validation fails and the
weak validation was successful a TraceValidationStatus with
severity warning and confidence of 1 is returned.
The automatic trace type detection has been updated so that the
special case above is acounted for.
With these updates the trace is imported as CTF trace however, the
use is notified that with a proper error message in case the full
validation failed.
Change-Id: Ia9b798b34c7af122d3b7684e91b114b38b656cef
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46202
Reviewed-by: Hudson CI
Matthew Khouzam [Mon, 20 Apr 2015 22:30:57 +0000 (18:30 -0400)]
ctf: rename CTFReaderException to CTFException
CTFIOExceptions are now only thrown by *Readers and not types or other
Change-Id: Id352ef121d3c94b4004e6c5fbe70c282bd131261
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46134
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Mon, 20 Apr 2015 18:19:24 +0000 (14:19 -0400)]
Revert "ss: accelerate state system creation by 25% by coalescing intervals"
This reverts commit
2ce551cccdac4096d3efd910f11e3fabe3c51856.
The commit is causing incoherent interval exceptions. A rework should be available soon.
Change-Id: I2e0d091d81e032b0f2e6ee65251a7c58b6320db4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46120
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Fri, 10 Apr 2015 17:25:21 +0000 (13:25 -0400)]
tmf: update ITmfEvent.getType().getName() to be getName()
This could yield a performance boost
Also, substitute TmfUml2dSyncLoader's getType().toString()
with getName() as it is being used to get the event name
Change-Id: Ide3cb3f0a97f86d99f2e358f608dac107c730bef
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45675
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Fri, 10 Apr 2015 17:07:00 +0000 (13:07 -0400)]
linux: make kernelstateprovider use getName()
Change-Id: Ia454a3ffc1bba461430c1fb6e0440bd0610083a2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45673
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Fri, 10 Apr 2015 17:01:12 +0000 (13:01 -0400)]
tmf.core: add getName to ITmfEvent
It seems to be used a lot so getType().getName() is a bit too much
indirection, it also allows lazy loading of the type.
Change-Id: I2126a3d6406eeb72324fa771bcdff382361a3dfd
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45672
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Matthew Khouzam [Fri, 10 Apr 2015 17:15:46 +0000 (13:15 -0400)]
ss: accelerate state system creation by 25% by coalescing intervals
The state system threaded back end sends one interval at a time to
a blocking queue to be written to disk. This patch makes it send several
intervals at a time, meaning we have several times less context switches
and several times less blocked threads.
Change-Id: I5cf26da2f1593749245bb6cf5c6f3c5ed65f00e0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45603
Reviewed-by: Hudson CI
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Marc-Andre Laperle [Mon, 13 Apr 2015 18:33:09 +0000 (14:33 -0400)]
Make remote CommandShellTest run on Mac
The tests are skipped if the platform is not Linux but they can run on Mac.
Change-Id: Idcface3299f44e32c232d0ae5939d5cf5b703b3f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45772
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Mon, 13 Apr 2015 18:32:04 +0000 (14:32 -0400)]
Fix tmf.remote.core tests not running
Change-Id: If8f2c477322bc0dabd2f4bff1ef59cb136ea7192
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45771
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Fri, 10 Apr 2015 20:20:11 +0000 (16:20 -0400)]
ss: Bug 454057: Use serialization to write the list of attributes to disk
Simplify the writing of the Attribute Tree to disk by using the
fact that ArrayList is Serializable.
This makes the file format less portable, but the previous method
used String.getBytes(), which is also JVM-dependant. A proper
inter-operable (and more efficient) format could be implemented
at some point once the need arises.
Change-Id: I8622b0975852ed3e022a210dbd720eb4d0fe90f4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/45682
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Wed, 8 Apr 2015 14:05:58 +0000 (10:05 -0400)]
tmf.ui: make methods called by constructor private
Change-Id: I3b25e96e726a52ab48705a8a4819c1a30aedfc0a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45462
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Wed, 8 Apr 2015 14:49:29 +0000 (10:49 -0400)] 
ss: Bug 464174: HTNode interval list is not sorted
Change-Id: Ibbd3e86bf529a284177860a3c1fd39ffbb554ad1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45477
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Thu, 2 Apr 2015 21:38:03 +0000 (17:38 -0400)]
swtbot: Update tests for event table highlight color preference
Change-Id: I7ca0889f6a31eda911ea7e0a313123e6341ba097
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45179
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Thu, 2 Apr 2015 20:46:46 +0000 (16:46 -0400)]
doc: Update user guide for event table highlight color preference
Change-Id: I4f337827c8457ee8b9c22a2878d6975acd0f21aa
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45178
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Thu, 2 Apr 2015 20:42:56 +0000 (16:42 -0400)]
tmf: Add color preference for event table search and filter highlight
The color settings can be changed in Window > Preferences > General >
Appearance > Colors and Fonts > Tracing.
Change-Id: I3bda3530657797cf434e86a7e6055a64066a4e51
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45177
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Tue, 7 Apr 2015 21:22:55 +0000 (17:22 -0400)]
Bump target sequence numbers to pick up new API changes from o.e.remote
Change-Id: I6210c4c26e045ae9ef6d68d187a85528ab2c6d61
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45423
Reviewed-by: Hudson CI
Marc-Andre Laperle [Wed, 4 Feb 2015 18:54:53 +0000 (13:54 -0500)]
Add setup file for Oomph
This patch adds a setup file for Oomph. To test it:
1. Start the Oomph installer (https://wiki.eclipse.org/Eclipse_Oomph_Installer)
2. At the package selection, click the Advanced Mode button in the top-right
corner
3. Select Eclipse IDE for Eclipse Committers. Click next.
4. Select Eclipse.org
5. Click on the '+' button in the top-right corner, browse file system for
TraceCompass.setup.
6. Double-click on Trace Compass in the tree. Click next.
7. Enter installation folder name, workspace name. Click Next, Finish.
This should install and start a new Eclipse installation with the Trace Compass
code ready to be worked on. Once this patch is merged, the setup will be added
to Eclipse catalog so that the user doesn't have to browse for the file.
Change-Id: I3b52508531d604dc9b493b6b7d2386a617ba54c1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41099
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Tue, 7 Apr 2015 14:56:00 +0000 (10:56 -0400)]
inport/export: fix synchronization bug.
We were synchronizing on a boolean, and changing the boolean later, this is not
a desirable practice.
Change-Id: I168d9c1e238205a2f3150bd5977a45e544e1d4df
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45387
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Tue, 7 Apr 2015 14:48:39 +0000 (10:48 -0400)]
import/export: remove ResourceTreeAndListGroup
Change-Id: Ib8925710f1f7e51fc328f9d84fa7d1884f6a0eef
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45290
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Mon, 6 Apr 2015 20:17:38 +0000 (16:17 -0400)]
Tweak some NonNull to work around bug 436486
The compilation could fail in some scenarios.
Change-Id: I3cd9e497f1ae8caf88684b793e6dc1b2696f688f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45393
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Fri, 3 Apr 2015 15:01:38 +0000 (11:01 -0400)]
general: avoid iterating over a keySet then get()ing the key.
This will ensure a higher performance access time even if the map is
switched for a tree or other map.
Change-Id: Ib1c6d5d35ea6d65d03fd5f324fa7ea4ab22285ab
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45239
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Fri, 3 Apr 2015 13:54:32 +0000 (09:54 -0400)]
pcap: address some redundant nullchecks in packets
Change-Id: I0855239ff5b567951be9189d8c6167d6f62d03fa
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45233
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Mon, 6 Apr 2015 13:39:56 +0000 (09:39 -0400)]
tmf remote: Decouple connection creation from JSchConnection
The o.e.remote API used to not provide an API to store username,
host and port programmatically without using internal APIs of
the JSchConnection implementation. Now, o.e.remote API has been updated
to provide a generic API to set this values independent of the
actual implementation (see Bug on PTP 463468).
This patch is to update TMF remote to use the generic API.
Change-Id: Ib7ddd64d64f000e9c9e3de99e9f40afcbe10df8e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45328
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Fri, 3 Apr 2015 13:45:14 +0000 (09:45 -0400)]
import/export: replace | with || allowing short circuiting if in extension check
Change-Id: I1a446c92b289843dd6f1e88b0e3eb51080fd5085
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45229
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Thu, 2 Apr 2015 19:44:48 +0000 (15:44 -0400)]
pcap.ui: replace hashmap iteration over key with entryset iteration
This is a performance helper and also reduces the amount of gets in the
hashmap
Change-Id: I4df95b7e2172ff839073e7a716f065213fb2d718
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45174
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Thu, 2 Apr 2015 19:35:47 +0000 (15:35 -0400)]
pcap: use NonNullUtils.equalsNullable in packet equals
Change-Id: Ie1e96a72b378d3ad2f9b3f90000acf201bd4a2c2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45173
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Marc-Andre Laperle [Thu, 26 Mar 2015 19:09:11 +0000 (15:09 -0400)]
Add property to control GTK version used in SWTBot tests
This will allow test builds for GTK3.
Change-Id: I70bed507ce47fc8cc907df84a252b0fde195b77d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44709
Reviewed-by: Hudson CI
Marc-Andre Laperle [Wed, 1 Apr 2015 17:41:40 +0000 (13:41 -0400)]
tmf: Add user documentation about importing archives from directories
Change-Id: I5088ff39349eb7e5be969ac2c3d833f86e713ae3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45054
Marc-Andre Laperle [Wed, 1 Apr 2015 04:53:56 +0000 (00:53 -0400)]
tmf: SWTBot tests for importing archives from directories and archives
Change-Id: I47b16520e3c91f3cf21af2c91fdcfeedd8dec1e6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44966
Reviewed-by: Hudson CI
Marc-Andre Laperle [Wed, 1 Apr 2015 04:52:54 +0000 (00:52 -0400)]
tmf: Support importing archives from directories and archives (nested
archives)
This features complements the existing import wizard so that the
archives present in the selected source (directory or archive) get
extracted automatically.
Change-Id: Ia30ca927c4634e092e674b8d36b1d3846d4061b6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44965
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Thu, 2 Apr 2015 14:09:08 +0000 (10:09 -0400)]
tmf: Remove use of CtfTmfTrace instance during CTF trace validation
This prevents unnecessary stuff from happening, such as creating an
indexer and its files.
It also makes sure all validations from the super class are executed.
Change-Id: I76823a12727f4a4a82d8969b6730bfd30570d369
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45143
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Wed, 1 Apr 2015 18:40:37 +0000 (14:40 -0400)]
tmf: Use default checkpoint indexer in TmfTrace empty constructor
The default checkpoint indexer uses a TmfMemoryIndex.
This prevents TmfTraceType from creating unnecessary empty index files
for every trace type instance, and actual traces from creating index
files that become obsolete as soon as initTrace() is called.
Change-Id: I40c407d68ce9d6cd6f9c7f736ca5fa33b9c41b37
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45057
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Fri, 20 Mar 2015 16:14:22 +0000 (12:14 -0400)]
ctf: remove StreamInputPacketReader string literals
Also remove overridable methods from constructor
Change-Id: I8ecbbb0fc46b7fd3d98462669e746279cf0872d1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44266
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Wed, 1 Apr 2015 18:21:12 +0000 (14:21 -0400)]
fix modifier order
Now comply with "private static final Type typeName"
Change-Id: I63341b31bce02348b9fb799ebd4b4752fe542142
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45056
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Wed, 1 Apr 2015 17:36:00 +0000 (13:36 -0400)]
fix modifier order in TmfWorkspaceModifiyOperation.java
Change-Id: Ib9b8337ac1bf3f7294b62a9e441fb01042a9e33e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45052
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Wed, 1 Apr 2015 17:34:42 +0000 (13:34 -0400)]
fix modifier order in TracePropertyTester
Change-Id: Ife2341be4f78423a497da5aae2d65a83042acb7c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45051
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 1 Apr 2015 17:33:27 +0000 (13:33 -0400)]
fix modifier order in TmfSignalTracer
Change-Id: I8b15c83782686eb5b19ee48496783d05ba0d4712
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45050
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 1 Apr 2015 17:32:17 +0000 (13:32 -0400)]
fix modifier order in CustomTxtTraceDefinition.java
Change-Id: I2c8d6550afd977251e7ff61610e1fba0cea8cbb8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45049
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 1 Apr 2015 17:30:57 +0000 (13:30 -0400)]
fix modifier order in TmfCallsite
Change-Id: I9b3587fad9ffebdd4ef84987f1da895ab057d532
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45048
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 1 Apr 2015 17:29:48 +0000 (13:29 -0400)]
fix modifier order in TmfEventField.java
Change-Id: I4b1003e38884221a3c8f4db9f56c01de6637a4f7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45047
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Tue, 31 Mar 2015 20:58:07 +0000 (16:58 -0400)]
ctf: remove deprecated code from CTFStreamInputPacketReader.java
Change-Id: I39b8b1c1ba614cf5b21c391972c14442e38d3f32
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44954
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 31 Mar 2015 20:53:21 +0000 (16:53 -0400)]
ctf: remove unused constructor in StructDefinition
Change-Id: I1b4ff80dbc604621b23ebf6f4aef57ccf8f5f8b7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44952
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 31 Mar 2015 20:57:43 +0000 (16:57 -0400)]
ctf: remove deprecated code from CTFStream.java
Change-Id: Ic7078009387d4c3297d53e4a56ac4dda1bf57020
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44953
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Wed, 1 Apr 2015 17:28:35 +0000 (13:28 -0400)]
fix modifier order in AbstractFileCheckpointCollection.java
Change-Id: I0018331bff7e91187e6fc54efc7fadfb94b6c707
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45046
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 31 Mar 2015 16:53:52 +0000 (12:53 -0400)]
dev guide: add section for TMF remote API
Change-Id: I60acb456aa39d034d987138b3d3c2b41de9b0a7d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44937
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Tue, 31 Mar 2015 18:46:21 +0000 (14:46 -0400)]
tmf remote: Fix connection handling for explicitely opened connections
It turns our that call to remoteConnection.isOpen() sends a
connection changed event with type closed. This will overwrite
the flag to false that keeps track whether the connection was
opened explicitely.
Also, when calling disconnect() on the RemoteSystemProxy only
close the connection if it was not explicitely opened.
Change-Id: Idce1cf9515c01667ce2e4d49a30d8296a8a7977d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44946
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Tue, 31 Mar 2015 21:52:52 +0000 (17:52 -0400)]
doc: Update user guide for event table font preferences
Change-Id: I20d73190d63418e59d4249ea78a1591bad07a3bf
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44957
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Tue, 31 Mar 2015 21:46:37 +0000 (17:46 -0400)]
doc: Update user guide for persistent trace editor column order
Change-Id: Ic71532c71c7573707e69b5abed3f28fa93850b4e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44956
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Tue, 31 Mar 2015 21:37:32 +0000 (17:37 -0400)]
doc: Update user guide for search and filter highlighting
Change-Id: Idce262d7efc713bd889ab3fd56a2da41a342b2c9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44955
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Thu, 26 Mar 2015 15:53:51 +0000 (11:53 -0400)]
Ctf: remove circular initialization issue in LexicalScope
Introduce ILexicalScope, an interface to make a scope.
May introduce performance regression, to be monitored
Change-Id: I1c0838e8190a665db8a2aaf99e974348d4f98da4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44607
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Tue, 31 Mar 2015 00:11:34 +0000 (20:11 -0400)]
tmf remote: consolidate remote connection access methods
Change-Id: I9abd058d37f71d6df5e9774a11a09f750e22f363
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44882
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Patrick Tasse [Fri, 27 Mar 2015 22:54:19 +0000 (18:54 -0400)]
swtbot: Fix TestTraceOffsetting
The keystroke for enter key is fixed.
The test waits for project element to exist before opening trace.
The test waits for the trace editor to be opened or closed.
The old event table is disposed after reopening the trace and cannot be
reused. The new trace editor and its event table must be used.
The test now checks correctly that the timestamp is actually offset.
Change-Id: I069b406698207f2ca7d08f4ca87dcf0d45a4385e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44791
Reviewed-by: Hudson CI
Patrick Tasse [Fri, 27 Mar 2015 21:58:37 +0000 (17:58 -0400)]
swtbot: Fix FontEventEditorTest to close Preferences dialog
Change-Id: Ia54844dbee7d0cd2926ec856b233aed8068b8338
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44790
Reviewed-by: Hudson CI
Patrick Tasse [Fri, 27 Mar 2015 21:44:24 +0000 (17:44 -0400)]
swtbot: Fix FilterColorEditorTest failure in Windows
Due to antialiasing, the pixels that become of the highlighting color
were not all of the background color before the highlighting.
Change-Id: I91cad37ec4f882385d563488f8ceec737393739c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44789
Reviewed-by: Hudson CI
Patrick Tasse [Fri, 27 Mar 2015 21:50:58 +0000 (17:50 -0400)]
swtbot: Fix SWTBotUtils instability
Tracing project elements that have a label with a count suffix (e.g.
trace folders) can have the count updated in the middle of a test by a
resource change event. Methods to get those tree items should be able to
handle this atomically.
Methods that need a project tree item now wait until it is available.
The method openEditor() now waits for the editor to be opened.
Change-Id: I4c2540fcc8a947ca4f61de66372968b11b10df7c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44788
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Mon, 30 Mar 2015 20:36:03 +0000 (16:36 -0400)]
tmf remote: clean up RemoteSystemProxy class
Remove pass-through methods to IRemoteConnection instance. Users
can get the connection from the proxy and act directly on it.
This avoids duplication of methods.
Change-Id: I0cdd8a9ceb698ebdb6f7404f07d449e5bdaa7bee
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44877
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Mon, 30 Mar 2015 19:34:53 +0000 (15:34 -0400)]
tmf remote: change implementation getProcessBuilder of RemoteSystemProxy
Change-Id: I1c5ebc88620950595522fbf149f9032356818226
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44870
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Mon, 30 Mar 2015 19:10:12 +0000 (15:10 -0400)]
tmf-remote: use dispose instead of disconnect for a fetch connection
This ensures that the connection stays up if it connection had
been establieshed before the fetching of log procedure.
Change-Id: I056a6c2632a2b9dc33fbe7504c48889e98567dc3
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44869
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Mon, 30 Mar 2015 19:08:31 +0000 (15:08 -0400)]
tmf remote: update and rename RemoteSystemProxyFactory
Change-Id: I4cdfd96fb75a213638be8c7fd733bf49c67173e1
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44868
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Mon, 30 Mar 2015 16:32:46 +0000 (12:32 -0400)]
doc: User guide update for remote fetching feature
Change-Id: I38459b1083a7b035c2c244c91d4a1556f92d0f7b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44863
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Fri, 27 Mar 2015 17:36:14 +0000 (13:36 -0400)]
tmf remote: comply with naming convention
Change-Id: I7fa35d7bc443ccac196123f7f2c0061060ba36c0
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44826
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Fri, 27 Mar 2015 17:34:01 +0000 (13:34 -0400)]
tmf remote: remove code duplication
Change-Id: Id8ab4d7f328a45130d5fe69a758c27da31181e7a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44777
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Fri, 27 Mar 2015 16:46:00 +0000 (12:46 -0400)]
tmf remote: use System.arraycopy instead of manually coppy array.
Change-Id: If697e6208f1abd387a8678a3c7f30561dc6f62d5
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44775
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 27 Mar 2015 15:32:20 +0000 (11:32 -0400)]
tmf remote: collapse if-statement in preference page
Change-Id: I1938160a044d9e7560dfee75772a64418ee3b01e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44774
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 27 Mar 2015 15:16:14 +0000 (11:16 -0400)]
tmf remote: comply with naming convention in RemoteSystemProxyFactory
Change-Id: I164204b2849272a777cf05291bd0fbf9137b3c61
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44772
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 27 Mar 2015 15:27:09 +0000 (11:27 -0400)]
tmf remote: fix modifier order warnings
Change-Id: Ifa919b9e6f3a76947718447f0f4d3bc40d6e4317
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44773
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 27 Mar 2015 15:11:55 +0000 (11:11 -0400)]
tmf-remote: Add java doc to messages
Change-Id: Idca9609b93aacd0dc38ec575ecefb21cdab87c07
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44771
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 27 Mar 2015 14:39:50 +0000 (10:39 -0400)]
tmf-remote: fix dead variable storage warning in preference page
Change-Id: Ia075cdc566d19ef38a246147d620d0717e4b4791
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44770
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 27 Mar 2015 14:28:00 +0000 (10:28 -0400)]
tmf-remote: fix dead variable storage warning
Change-Id: I32e815d954b4c2e83c01e6317f34d9af5cce46c6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44769
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Mon, 23 Mar 2015 20:23:04 +0000 (16:23 -0400)]
tmf remote: Allow plugin customization for alternative profile location
Change-Id: Iec0f44f5a2ddd85d20cb8bb1e8f808939afb6280
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44531
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Marc-Andre Laperle [Mon, 23 Mar 2015 16:45:30 +0000 (12:45 -0400)]
tmf remote: Bug 460847: SWTBot tests for remote fetching of traces
Change-Id: I562080bf651f8ccbbfccd711fc4eb3d0a6e71993
Signed-off-by: Marc-Andre Laperle <Marc-Andre.Laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44529
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Marc-Andre Laperle [Mon, 23 Mar 2015 19:16:37 +0000 (15:16 -0400)]
tmf remote: Bug 460847: Add Junits for XML reader/writer of remote fetch
Change-Id: If1789368077c103eb88d6ec96668502da431f60b
Signed-off-by: Marc-Andre Laperle <Marc-Andre.Laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44530
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 24 Mar 2015 13:26:00 +0000 (09:26 -0400)]
swtbot: check syntax highlighting with filter bar
This test will take a screen grab of the cell being highlighted
and compare it before and after highlighting.
Change-Id: Iae5fe05cc965b19aa5dec775c26e1b637901982b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44540
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Wed, 25 Mar 2015 19:58:57 +0000 (15:58 -0400)]
swtbot: Introducing ImageHelper
The ImageHelper is a way to compare screenshots quickly and efficiently.
It has many helpers made to aid in comparisson. Each pixel is queried as
an RGB, the image can give the following info:
* its dimensions and place in the screen
* its pixels
* all the pixel values of a query (for sampling)
* a row of the image
* a column of the image
Change-Id: Id7a4c168cad18448a4d0d5c14ef395e05b6f018b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44635
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
This page took 0.048527 seconds and 5 git commands to generate.
projects / deliverable / tracecompass.git / log
