From 91deb4e1a0b0f91fc1b05de5aeb90593dc543b47 Mon Sep 17 00:00:00 2001 From: Matthew Khouzam Date: Thu, 7 Jan 2016 15:40:04 -0500 Subject: [PATCH] analysis: make statistics view use a more legible format statistics will now display times using units and 3 significant decimals as opposed to the way they were displayed before (unitless left-aligned nanoseconds) Change-Id: I35cfeeb7d038ac2b9f52f3648c3e4337a6ec279c Signed-off-by: Matthew Khouzam Reviewed-on: https://git.eclipse.org/r/63787 Reviewed-by: Hudson CI Reviewed-by: Bernd Hufmann Tested-by: Bernd Hufmann --- .../statistics/AbstractSegmentStoreStatisticsViewer.java | 6 +++--- .../timing/ui/views/segmentstore/statistics/Messages.java | 2 ++ .../ui/views/segmentstore/statistics/messages.properties | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/statistics/AbstractSegmentStoreStatisticsViewer.java b/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/statistics/AbstractSegmentStoreStatisticsViewer.java index a2a308211d..d0d2911ed2 100644 --- a/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/statistics/AbstractSegmentStoreStatisticsViewer.java +++ b/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/statistics/AbstractSegmentStoreStatisticsViewer.java @@ -13,15 +13,15 @@ package org.eclipse.tracecompass.internal.analysis.timing.ui.views.segmentstore. import static org.eclipse.tracecompass.common.core.NonNullUtils.checkNotNull; -import java.text.NumberFormat; +import java.text.Format; import java.util.ArrayList; import java.util.List; -import java.util.Locale; import org.eclipse.jdt.annotation.Nullable; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jface.viewers.ViewerComparator; import org.eclipse.swt.widgets.Composite; +import org.eclipse.tracecompass.analysis.timing.ui.views.segmentstore.SubSecondTimeWithUnitFormat; import org.eclipse.tracecompass.internal.analysis.timing.core.segmentstore.statistics.SegmentStoreStatistics; import org.eclipse.tracecompass.internal.analysis.timing.ui.Activator; import org.eclipse.tracecompass.tmf.core.analysis.TmfAbstractAnalysisModule; @@ -40,7 +40,7 @@ import org.eclipse.tracecompass.tmf.ui.viewers.tree.TmfTreeViewerEntry; */ public abstract class AbstractSegmentStoreStatisticsViewer extends AbstractTmfTreeViewer { - private static final NumberFormat FORMATTER = checkNotNull(NumberFormat.getNumberInstance(Locale.getDefault())); + private static final Format FORMATTER = new SubSecondTimeWithUnitFormat(); @Nullable private TmfAbstractAnalysisModule fModule; diff --git a/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/statistics/Messages.java b/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/statistics/Messages.java index 679882ae04..1494f4b70a 100644 --- a/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/statistics/Messages.java +++ b/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/statistics/Messages.java @@ -32,6 +32,8 @@ public class Messages extends NLS { public static String SegmentStoreStatistics_MaxLabel; /** Name of average column */ public static String SegmentStoreStatistics_AverageLabel; + /** Name of average column */ + public static String SegmentStoreStatisticsViewer_StandardDeviation; static { // initialize resource bundle diff --git a/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/statistics/messages.properties b/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/statistics/messages.properties index 817018c850..61c5df5f20 100644 --- a/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/statistics/messages.properties +++ b/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/statistics/messages.properties @@ -13,4 +13,4 @@ SegmentStoreStatistics_LevelLabel=Level SegmentStoreStatistics_Statistics_MinLabel=Minimum SegmentStoreStatistics_MaxLabel=Maximum SegmentStoreStatistics_AverageLabel=Average - \ No newline at end of file +SegmentStoreStatisticsViewer_StandardDeviation=Standard Deviation \ No newline at end of file -- 2.34.1