From f02806be1ff3d25fdf4d9e06ced33c4b138458aa Mon Sep 17 00:00:00 2001 From: claziss Date: Mon, 23 Jul 2018 11:09:43 +0200 Subject: [PATCH] [ARC] Fix case-sensitivity for extension instructions. In ARC assembler, we accept case insensitive mnemonics, but this was not the case for extension instruction, fix it and add a test. gas/ Claudiu Zissulescu * config/tc-arc.c (tokenize_extinsn): Convert to lower case the name of extension instructions. * testsuite/gas/arc/textinsn_case.d: New file. * testsuite/gas/arc/textinsn_case.s: Likewise. --- gas/ChangeLog | 7 +++++++ gas/config/tc-arc.c | 4 ++++ gas/testsuite/gas/arc/textinsn_case.d | 9 +++++++++ gas/testsuite/gas/arc/textinsn_case.s | 6 ++++++ 4 files changed, 26 insertions(+) create mode 100644 gas/testsuite/gas/arc/textinsn_case.d create mode 100644 gas/testsuite/gas/arc/textinsn_case.s diff --git a/gas/ChangeLog b/gas/ChangeLog index 5df35569f9..dbaa02d9e1 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,10 @@ +2018-07-23 Claudiu Zissulescu + + * config/tc-arc.c (tokenize_extinsn): Convert to lower case the + name of extension instructions. + * testsuite/gas/arc/textinsn_case.d: New file. + * testsuite/gas/arc/textinsn_case.s: Likewise. + 2018-07-22 H.J. Lu * config/tc-i386.c (build_vex_prefix): Determine vector diff --git a/gas/config/tc-arc.c b/gas/config/tc-arc.c index cd90fdf56d..a1ce34d24d 100644 --- a/gas/config/tc-arc.c +++ b/gas/config/tc-arc.c @@ -4369,6 +4369,10 @@ tokenize_extinsn (extInstruction_t *einsn) insn_name = xstrdup (p); restore_line_pointer (c); + /* Convert to lower case. */ + for (p = insn_name; *p; ++p) + *p = TOLOWER (*p); + /* 2nd: get major opcode. */ if (*input_line_pointer != ',') { diff --git a/gas/testsuite/gas/arc/textinsn_case.d b/gas/testsuite/gas/arc/textinsn_case.d new file mode 100644 index 0000000000..f7ef91f4ef --- /dev/null +++ b/gas/testsuite/gas/arc/textinsn_case.d @@ -0,0 +1,9 @@ +#objdump: -d + +.*: +file format .*arc.* + + +Disassembly of section .text: + +[0-9a-f]+ : +\s+[0-9a-f]+:\s+3a25 00c1\s+aes_qroundf\s+r1,r2,r3 diff --git a/gas/testsuite/gas/arc/textinsn_case.s b/gas/testsuite/gas/arc/textinsn_case.s new file mode 100644 index 0000000000..4d04968c61 --- /dev/null +++ b/gas/testsuite/gas/arc/textinsn_case.s @@ -0,0 +1,6 @@ + .cpu em + .extInstruction aes_qRoundF, 7, 0x25, SUFFIX_COND, SYNTAX_3OP + + .text +test: + aes_qRoundF r1,r2,r3 -- 2.34.1