From 8f86ae1a18417e575f510d1aa7b6df2524256464 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Fri, 15 May 2020 22:17:40 -0400 Subject: [PATCH] gdb: remove unnecessary struct typedef in sparc64-tdep.c When building with clang 11, I get: CXX sparc64-tdep.o /home/smarchi/src/binutils-gdb/gdb/sparc64-tdep.c:89:15: error: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage] typedef struct ^ adi_stat_t /home/smarchi/src/binutils-gdb/gdb/sparc64-tdep.c:103:16: note: type is not C-compatible due to this default member initializer int tag_fd = 0; ^ /home/smarchi/src/binutils-gdb/gdb/sparc64-tdep.c:111:3: note: type is given name 'adi_stat_t' for linkage purposes by this typedef declaration } adi_stat_t; ^ The typedef is not needed in C++ anyway, just remove them. gdb/ChangeLog: * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct). (sparc64_adi_info): Likewise. --- gdb/ChangeLog | 5 +++++ gdb/sparc64-tdep.c | 8 ++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 7b19973118..0e8e47d8d2 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-05-15 Simon Marchi + + * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct). + (sparc64_adi_info): Likewise. + 2020-05-15 Tom Tromey * symtab.c (lookup_language_this, lookup_symbol_aux): Use diff --git a/gdb/sparc64-tdep.c b/gdb/sparc64-tdep.c index 39ba455e6f..ce323c704d 100644 --- a/gdb/sparc64-tdep.c +++ b/gdb/sparc64-tdep.c @@ -86,7 +86,7 @@ static struct cmd_list_element *sparc64adilist = NULL; /* ADI stat settings. */ -typedef struct +struct adi_stat_t { /* The ADI block size. */ unsigned long blksize; @@ -108,11 +108,11 @@ typedef struct /* ADI is available. */ bool is_avail = false; -} adi_stat_t; +}; /* Per-process ADI stat info. */ -typedef struct sparc64_adi_info +struct sparc64_adi_info { sparc64_adi_info (pid_t pid_) : pid (pid_) @@ -124,7 +124,7 @@ typedef struct sparc64_adi_info /* The ADI stat. */ adi_stat_t stat = {}; -} sparc64_adi_info; +}; static std::forward_list adi_proc_list; -- 2.34.1