From aff689d36d66dd45a59008f3778d3d22e3cfcb9b Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sat, 21 Apr 2018 12:00:29 -0600 Subject: [PATCH] Add -Wduplicated-cond This adds -Wduplicated-cond to warnings.m4. This caught one bug. I tried adding -Wduplicated-branches as well, but it results in some spurious failures from code like this in cgen.h: #define CGEN_ATTR_TYPE(n) \ struct { unsigned int bool_; \ CGEN_ATTR_VALUE_TYPE nonbool[(n) ? (n) : 1]; } This will trigger a warning if passed n==1, which seems like a perfectly valid thing to do; and there were other issues like this as well. ChangeLog 2018-05-07 Tom Tromey * configure: Rebuild. * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond. gdbserver/ChangeLog 2018-05-07 Tom Tromey * configure: Rebuild. --- gdb/ChangeLog | 5 +++++ gdb/configure | 3 ++- gdb/gdbserver/ChangeLog | 4 ++++ gdb/gdbserver/configure | 3 ++- gdb/warning.m4 | 3 ++- 5 files changed, 15 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 89c55f6d0c..2c32f9464c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-05-07 Tom Tromey + + * configure: Rebuild. + * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond. + 2018-05-07 Tom Tromey PR tdep/20362: diff --git a/gdb/configure b/gdb/configure index 96dd9fa732..0eec780bd1 100755 --- a/gdb/configure +++ b/gdb/configure @@ -15367,7 +15367,8 @@ build_warnings="-Wall -Wpointer-arith \ -Wno-mismatched-tags \ -Wno-error=deprecated-register \ -Wsuggest-override \ --Wimplicit-fallthrough" +-Wimplicit-fallthrough \ +-Wduplicated-cond" case "${host}" in *-*-mingw32*) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index f1dd1ddc97..74613598a2 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2018-05-07 Tom Tromey + + * configure: Rebuild. + 2018-05-04 Tom Tromey * configure: Rebuild. diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure index 919ed31665..ac61ba3543 100755 --- a/gdb/gdbserver/configure +++ b/gdb/gdbserver/configure @@ -7174,7 +7174,8 @@ build_warnings="-Wall -Wpointer-arith \ -Wno-mismatched-tags \ -Wno-error=deprecated-register \ -Wsuggest-override \ --Wimplicit-fallthrough" +-Wimplicit-fallthrough \ +-Wduplicated-cond" case "${host}" in *-*-mingw32*) diff --git a/gdb/warning.m4 b/gdb/warning.m4 index 1cc3c68398..cb23472ec6 100644 --- a/gdb/warning.m4 +++ b/gdb/warning.m4 @@ -44,7 +44,8 @@ build_warnings="-Wall -Wpointer-arith \ -Wno-mismatched-tags \ -Wno-error=deprecated-register \ -Wsuggest-override \ --Wimplicit-fallthrough" +-Wimplicit-fallthrough \ +-Wduplicated-cond" case "${host}" in *-*-mingw32*) -- 2.34.1