From 6c761d9c9c9271145dccec5103e8fdc4fde64e9d Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sat, 13 Sep 2008 23:37:05 +0000 Subject: [PATCH] * varobj.c (varobj_set_display_format): Use xfree. * tracepoint.c (stringify_collection_list): Use xfree. * remote-fileio.c (remote_fileio_reset): Use xfree. * mipsread.c (read_alphacoff_dynamic_symtab): Use xfree. * dfp.c (decimal_from_floating): Use xfree, xstrprintf. Don't use asprintf. * cp-support.c (mangled_name_to_comp): Use xfree. --- gdb/ChangeLog | 10 ++++++++++ gdb/cp-support.c | 2 +- gdb/dfp.c | 8 ++------ gdb/mipsread.c | 8 ++++---- gdb/remote-fileio.c | 2 +- gdb/tracepoint.c | 2 +- gdb/varobj.c | 2 +- 7 files changed, 20 insertions(+), 14 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index bd96697d68..897c3acf14 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,13 @@ +2008-09-13 Tom Tromey + + * varobj.c (varobj_set_display_format): Use xfree. + * tracepoint.c (stringify_collection_list): Use xfree. + * remote-fileio.c (remote_fileio_reset): Use xfree. + * mipsread.c (read_alphacoff_dynamic_symtab): Use xfree. + * dfp.c (decimal_from_floating): Use xfree, xstrprintf. Don't use + asprintf. + * cp-support.c (mangled_name_to_comp): Use xfree. + 2008-09-13 Joel Brobecker * ada-lang.c (remove_extra_symbols): Remove stub symbols if diff --git a/gdb/cp-support.c b/gdb/cp-support.c index df48f6021d..f50d8fd443 100644 --- a/gdb/cp-support.c +++ b/gdb/cp-support.c @@ -167,7 +167,7 @@ mangled_name_to_comp (const char *mangled_name, int options, if (ret == NULL) { - free (demangled_name); + xfree (demangled_name); return NULL; } diff --git a/gdb/dfp.c b/gdb/dfp.c index 9816d272e8..bbaf9aa6c5 100644 --- a/gdb/dfp.c +++ b/gdb/dfp.c @@ -235,16 +235,12 @@ void decimal_from_floating (struct value *from, gdb_byte *to, int len) { char *buffer; - int ret; - ret = asprintf (&buffer, "%.30" DOUBLEST_PRINT_FORMAT, - value_as_double (from)); - if (ret < 0) - error (_("Error in memory allocation for conversion to decimal float.")); + buffer = xstrprintf ("%.30" DOUBLEST_PRINT_FORMAT, value_as_double (from)); decimal_from_string (to, len, buffer); - free (buffer); + xfree (buffer); } /* Converts a decimal float of LEN bytes to a double value. */ diff --git a/gdb/mipsread.c b/gdb/mipsread.c index fdd8634472..1e88f81502 100644 --- a/gdb/mipsread.c +++ b/gdb/mipsread.c @@ -217,13 +217,13 @@ read_alphacoff_dynamic_symtab (struct section_offsets *section_offsets, dyninfo_secsize = bfd_get_section_size (si.dyninfo_sect); got_secsize = bfd_get_section_size (si.got_sect); sym_secptr = xmalloc (sym_secsize); - cleanups = make_cleanup (free, sym_secptr); + cleanups = make_cleanup (xfree, sym_secptr); str_secptr = xmalloc (str_secsize); - make_cleanup (free, str_secptr); + make_cleanup (xfree, str_secptr); dyninfo_secptr = xmalloc (dyninfo_secsize); - make_cleanup (free, dyninfo_secptr); + make_cleanup (xfree, dyninfo_secptr); got_secptr = xmalloc (got_secsize); - make_cleanup (free, got_secptr); + make_cleanup (xfree, got_secptr); if (!bfd_get_section_contents (abfd, si.sym_sect, sym_secptr, (file_ptr) 0, sym_secsize)) diff --git a/gdb/remote-fileio.c b/gdb/remote-fileio.c index 93665c9fb4..05a78becda 100644 --- a/gdb/remote-fileio.c +++ b/gdb/remote-fileio.c @@ -1398,7 +1398,7 @@ remote_fileio_reset (void) } if (remote_fio_data.fd_map) { - free (remote_fio_data.fd_map); + xfree (remote_fio_data.fd_map); remote_fio_data.fd_map = NULL; remote_fio_data.fd_map_size = 0; } diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c index 690eba3104..4f5c56a66a 100644 --- a/gdb/tracepoint.c +++ b/gdb/tracepoint.c @@ -1452,7 +1452,7 @@ stringify_collection_list (struct collection_list *list, char *string) if (ndx == 0) { - free (str_list); + xfree (str_list); return NULL; } else diff --git a/gdb/varobj.c b/gdb/varobj.c index 35d876ff09..5b44eef0d8 100644 --- a/gdb/varobj.c +++ b/gdb/varobj.c @@ -693,7 +693,7 @@ varobj_set_display_format (struct varobj *var, if (varobj_value_is_changeable_p (var) && var->value && !value_lazy (var->value)) { - free (var->print_value); + xfree (var->print_value); var->print_value = value_get_print_value (var->value, var->format); } -- 2.34.1