From 0c9070b30af40e837ae05cdbaf6f486690fffaf8 Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Tue, 12 Jun 2012 14:02:15 +0000 Subject: [PATCH] gdb/gdbserver: * linux-low.c (linux_set_resume_request): Simplify predicate. Add comment. * server.c (handle_v_cont): Extend comment. --- gdb/gdbserver/ChangeLog | 7 +++++++ gdb/gdbserver/linux-low.c | 9 +++++---- gdb/gdbserver/server.c | 4 ++-- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index a64e8a29c8..588568344d 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,10 @@ +2012-06-12 Yao Qi + Pedro Alves + + * linux-low.c (linux_set_resume_request): Simplify predicate. Add + comment. + * server.c (handle_v_cont): Extend comment. + 2012-06-11 Yao Qi * linux-low.c (linux_attach): Add 'static'. diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index 3e88c42405..3d116fd46a 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -3339,10 +3339,11 @@ linux_set_resume_request (struct inferior_list_entry *entry, void *arg) ptid_t ptid = r->resume[ndx].thread; if (ptid_equal (ptid, minus_one_ptid) || ptid_equal (ptid, entry->id) - || (ptid_is_pid (ptid) - && (ptid_get_pid (ptid) == pid_of (lwp))) - || (ptid_get_lwp (ptid) == -1 - && (ptid_get_pid (ptid) == pid_of (lwp)))) + /* Handle both 'pPID' and 'pPID.-1' as meaning 'all threads + of PID'. */ + || (ptid_get_pid (ptid) == pid_of (lwp) + && (ptid_is_pid (ptid) + || ptid_get_lwp (ptid) == -1))) { if (r->resume[ndx].kind == resume_stop && thread->last_resume_kind == resume_stop) diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c index 9fd550b097..96aa54b8fa 100644 --- a/gdb/gdbserver/server.c +++ b/gdb/gdbserver/server.c @@ -1974,8 +1974,8 @@ handle_v_cont (char *own_buf) /* `cont_thread' is still used in occasional places in the backend, to implement single-thread scheduler-locking. Doesn't make sense - to set it if we see a stop request, or any form of wildcard - vCont. */ + to set it if we see a stop request, or a wildcard action (one + with '-1' (all threads), or 'pPID.-1' (all threads of PID)). */ if (n == 1 && !(ptid_equal (resume_info[0].thread, minus_one_ptid) || ptid_get_lwp (resume_info[0].thread) == -1) -- 2.34.1