From c273b20f14fb111346bf00e4f7bdf0c9e655908b Mon Sep 17 00:00:00 2001 From: Jim Blandy Date: Tue, 7 Dec 2004 20:21:32 +0000 Subject: [PATCH] * remote.c (remote_threads_info, remote_current_thread): Use strtoul to parse thread ID numbers. --- gdb/ChangeLog | 5 +++++ gdb/remote.c | 15 +++++++++++++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6cf5b2904f..c6e208ca16 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2004-12-07 Jim Blandy + + * remote.c (remote_threads_info, remote_current_thread): Use + strtoul to parse thread ID numbers. + 2004-12-07 Mark Kettenis * inf-ttrace.c: Include "gdbthread.h". diff --git a/gdb/remote.c b/gdb/remote.c index c88a13c8da..8f7a181e11 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -1735,7 +1735,12 @@ remote_current_thread (ptid_t oldpid) putpkt ("qC"); getpkt (buf, (rs->remote_packet_size), 0); if (buf[0] == 'Q' && buf[1] == 'C') - return pid_to_ptid (strtol (&buf[2], NULL, 16)); + /* Use strtoul here, so we'll correctly parse values whose highest + bit is set. The protocol carries them as a simple series of + hex digits; in the absence of a sign, strtol will see such + values as positive numbers out of range for signed 'long', and + return LONG_MAX to indicate an overflow. */ + return pid_to_ptid (strtoul (&buf[2], NULL, 16)); else return oldpid; } @@ -1782,7 +1787,13 @@ remote_threads_info (void) { do { - tid = strtol (bufp, &bufp, 16); + /* Use strtoul here, so we'll correctly parse values + whose highest bit is set. The protocol carries + them as a simple series of hex digits; in the + absence of a sign, strtol will see such values as + positive numbers out of range for signed 'long', + and return LONG_MAX to indicate an overflow. */ + tid = strtoul (bufp, &bufp, 16); if (tid != 0 && !in_thread_list (pid_to_ptid (tid))) add_thread (pid_to_ptid (tid)); } -- 2.34.1