From 203217665139943a4f0d1797b9a5f913b3acf184 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Sun, 3 Jan 2016 01:29:03 -0500 Subject: [PATCH] libiberty: dupargv: rewrite to use xstrdup This func is basically open coding the xstrdup function, so gut it and use it directly. --- libiberty/ChangeLog | 4 ++++ libiberty/argv.c | 6 +----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog index aa598f277b..ba1e0a51c3 100644 --- a/libiberty/ChangeLog +++ b/libiberty/ChangeLog @@ -1,3 +1,7 @@ +2016-01-05 Mike Frysinger + + * argv.c (dupargv): Replace strlen/xmalloc/strcpy with xstrdup. + 2015-12-28 Patrick Palka * crc32.c: In the documentation, don't refer to GDB's diff --git a/libiberty/argv.c b/libiberty/argv.c index f2727e8de9..5c3dd70b04 100644 --- a/libiberty/argv.c +++ b/libiberty/argv.c @@ -76,11 +76,7 @@ dupargv (char **argv) /* the strings */ for (argc = 0; argv[argc] != NULL; argc++) - { - int len = strlen (argv[argc]); - copy[argc] = (char *) xmalloc (len + 1); - strcpy (copy[argc], argv[argc]); - } + copy[argc] = xstrdup (argv[argc]); copy[argc] = NULL; return copy; } -- 2.34.1