From a6c5c2676fe9fee8d7388b32ebf5d00f5e014537 Mon Sep 17 00:00:00 2001 From: Matthew Khouzam Date: Tue, 27 Oct 2015 15:55:13 -0400 Subject: [PATCH] lttng: make FileOffsetMapper try-with-resources in #getOutputFromCommand Change-Id: I8c1dc1e1f81ddd4c4f442af11f91450d73142741 Signed-off-by: Matthew Khouzam Reviewed-on: https://git.eclipse.org/r/59055 Reviewed-by: Hudson CI --- .../ust/core/analysis/debuginfo/FileOffsetMapper.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/FileOffsetMapper.java b/lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/FileOffsetMapper.java index 9bbe9ccccc..5acb66c8a9 100644 --- a/lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/FileOffsetMapper.java +++ b/lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/FileOffsetMapper.java @@ -93,12 +93,12 @@ public final class FileOffsetMapper { builder.redirectErrorStream(true); Process p = builder.start(); - BufferedReader br = new BufferedReader(new InputStreamReader(p.getInputStream())); - int ret = p.waitFor(); - List lines = br.lines().collect(Collectors.toList()); - - return (ret == 0 ? lines : null); + try (BufferedReader br = new BufferedReader(new InputStreamReader(p.getInputStream()));) { + int ret = p.waitFor(); + List lines = br.lines().collect(Collectors.toList()); + return (ret == 0 ? lines : null); + } } catch (IOException | InterruptedException e) { return null; } -- 2.34.1