From 00c15db6f5612119ed0502463c8abb74abed63ce Mon Sep 17 00:00:00 2001 From: Matthew Khouzam Date: Thu, 21 Jan 2016 23:15:36 -0500 Subject: [PATCH] vm: change private method to take a List instead of ArrayList Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" The purpose of the Java Collections API is to provide a well defined hierarchy of interfaces in order to hide implementation details. Implementing classes must be used to instantiate new collections, but the result of an instantiation should ideally be stored in a variable whose type is a Java Collection interface. Change-Id: I380287ab4b425167e6378f1b0c4d9aa1af4a8b02 Signed-off-by: Matthew Khouzam Reviewed-on: https://git.eclipse.org/r/64943 Reviewed-by: Hudson CI Reviewed-by: Marc-Andre Laperle Tested-by: Marc-Andre Laperle --- .../lttng2/kernel/ui/views/vm/vcpuview/VirtualMachineView.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lttng/org.eclipse.tracecompass.lttng2.kernel.ui/src/org/eclipse/tracecompass/internal/lttng2/kernel/ui/views/vm/vcpuview/VirtualMachineView.java b/lttng/org.eclipse.tracecompass.lttng2.kernel.ui/src/org/eclipse/tracecompass/internal/lttng2/kernel/ui/views/vm/vcpuview/VirtualMachineView.java index d496efc681..abc44a3479 100644 --- a/lttng/org.eclipse.tracecompass.lttng2.kernel.ui/src/org/eclipse/tracecompass/internal/lttng2/kernel/ui/views/vm/vcpuview/VirtualMachineView.java +++ b/lttng/org.eclipse.tracecompass.lttng2.kernel.ui/src/org/eclipse/tracecompass/internal/lttng2/kernel/ui/views/vm/vcpuview/VirtualMachineView.java @@ -293,7 +293,7 @@ public class VirtualMachineView extends AbstractTimeGraphView { } - private void buildEntryEventLists(ArrayList<@NonNull VirtualMachineViewEntry> entryList, ITmfStateSystem ssq, long startTime, long endTime, IProgressMonitor monitor) { + private void buildEntryEventLists(List<@NonNull VirtualMachineViewEntry> entryList, ITmfStateSystem ssq, long startTime, long endTime, IProgressMonitor monitor) { for (VirtualMachineViewEntry entry : entryList) { if (monitor.isCanceled()) { return; -- 2.34.1