From 2ea1a07a0a6a15a55df28eeefddf71a4ac47e17d Mon Sep 17 00:00:00 2001 From: Sandra Loosemore Date: Thu, 29 Aug 2019 14:48:05 -0700 Subject: [PATCH] Run argv0-symlink.exp only on native target and local host. This testcase was originally for PR gdb/15415, a problem with the "run" command expanding symlinks in the name of the program being run. It does not correctly distinguish between files on build, host, and target, and it is not clear if it would be testing anything useful in configurations where "run" is not being used. 2019-08-29 Sandra Loosemore * gdb.base/argv0-symlink.exp: Run only on native target and local host. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/argv0-symlink.exp | 17 +++++++++++++++++ 2 files changed, 22 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index b1dc7df4bb..e0991e091a 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2019-08-29 Sandra Loosemore + + * gdb.base/argv0-symlink.exp: Run only on native target + and local host. + 2019-08-29 Tom de Vries * gdb.fortran/info-types.exp: Fix gdb_test regexp to allow more diff --git a/gdb/testsuite/gdb.base/argv0-symlink.exp b/gdb/testsuite/gdb.base/argv0-symlink.exp index cce6ca613d..33301bd7c3 100644 --- a/gdb/testsuite/gdb.base/argv0-symlink.exp +++ b/gdb/testsuite/gdb.base/argv0-symlink.exp @@ -13,6 +13,23 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . +# This testcase was originally for PR gdb/15415, a problem with the "run" +# command expanding symlinks in the name of the program being run. +# This test uses pathnames on build to create symbolic links on host and +# expects the test program running on target to see those symbolic links. +# Therefore, it can't work reliably on anything other than configurations +# where build/host/target are all the same. + +if { ![isnative] } { + unsupported "argv0-symlink.exp not supported on non-native target" + return -1 +} + +if { [is_remote host] } { + unsupported "argv0-symlink.exp not supported on remote host" + return -1 +} + standard_testfile set has_argv0 [gdb_has_argv0] -- 2.34.1