From 3f2cef4945a916e3b566010340bbc70cfe927916 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Thu, 10 Jan 2019 18:58:18 +0000 Subject: [PATCH] gdb/or1k: Use default gdbarch methods where possible Make use of the default gdbarch method gdbarch_dummy_id where possible. I have not tested this change but, by inspecting the code, I believe the default methods are equivalent to the code being deleted. This commit leaves or1k_unwind_sp and or1k_unwind_pc in place. These functions do match the default methods except that they add additional debugging code. In order to preserve the debug I have left these functions unchanged. gdb/ChangeLog: * or1k-tdep.c (or1k_dummy_id): Delete. (or1k_gdbarch_init): Don't register deleted function with gdbarch. --- gdb/ChangeLog | 5 +++++ gdb/or1k-tdep.c | 9 --------- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a730d5f711..5eb9715c94 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-04-23 Andrew Burgess + + * or1k-tdep.c (or1k_dummy_id): Delete. + (or1k_gdbarch_init): Don't register deleted function with gdbarch. + 2019-04-23 Andrew Burgess * nios2-tdep.c (nios2_dummy_id): Delete. diff --git a/gdb/or1k-tdep.c b/gdb/or1k-tdep.c index 13e130c6fd..8f6f6e1960 100644 --- a/gdb/or1k-tdep.c +++ b/gdb/or1k-tdep.c @@ -789,14 +789,6 @@ or1k_push_dummy_call (struct gdbarch *gdbarch, struct value *function, return sp; } -/* Implement the dummy_id gdbarch method. */ - -static struct frame_id -or1k_dummy_id (struct gdbarch *gdbarch, struct frame_info *this_frame) -{ - return frame_id_build (get_frame_sp (this_frame), - get_frame_pc (this_frame)); -} /* Support functions for frame handling. */ @@ -1184,7 +1176,6 @@ or1k_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) set_gdbarch_call_dummy_location (gdbarch, ON_STACK); set_gdbarch_push_dummy_code (gdbarch, or1k_push_dummy_code); set_gdbarch_push_dummy_call (gdbarch, or1k_push_dummy_call); - set_gdbarch_dummy_id (gdbarch, or1k_dummy_id); /* Frame unwinders. Use DWARF debug info if available, otherwise use our own unwinder. */ -- 2.34.1