From 4ea09c106de258952e9adc452e2c1d3e7a49c14d Mon Sep 17 00:00:00 2001 From: Peter Schauer Date: Fri, 8 Mar 2002 17:19:39 +0000 Subject: [PATCH] * stabsread.c (read_member_functions): Fix is_stub test for static member functions, improve comment. --- gdb/ChangeLog | 5 +++++ gdb/stabsread.c | 31 ++++++++++++++++++++++++------- 2 files changed, 29 insertions(+), 7 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index f811bb9353..fbf9dd0753 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2002-03-08 Peter Schauer + + * stabsread.c (read_member_functions): Fix is_stub test for + static member functions, improve comment. + 2002-03-07 Richard Earnshaw * remote-rdi.c (myprint): Replace 'PTR' with 'void *'. diff --git a/gdb/stabsread.c b/gdb/stabsread.c index 5b11546753..bb969dbe78 100644 --- a/gdb/stabsread.c +++ b/gdb/stabsread.c @@ -3287,13 +3287,30 @@ read_member_functions (struct field_info *fip, char **pp, struct type *type, } case '?': /* static member function. */ - new_sublist->fn_field.voffset = VOFFSET_STATIC; - if (strncmp (new_sublist->fn_field.physname, - main_fn_name, strlen (main_fn_name))) - { - new_sublist->fn_field.is_stub = 1; - } - break; + { + int slen = strlen (main_fn_name); + + new_sublist->fn_field.voffset = VOFFSET_STATIC; + + /* For static member functions, we can't tell if they + are stubbed, as they are put out as functions, and not as + methods. + GCC v2 emits the fully mangled name if + dbxout.c:flag_minimal_debug is not set, so we have to + detect a fully mangled physname here and set is_stub + accordingly. Fully mangled physnames in v2 start with + the member function name, followed by two underscores. + GCC v3 currently always emits stubbed member functions, + but with fully mangled physnames, which start with _Z. */ + if (!(strncmp (new_sublist->fn_field.physname, + main_fn_name, slen) == 0 + && new_sublist->fn_field.physname[slen] == '_' + && new_sublist->fn_field.physname[slen + 1] == '_')) + { + new_sublist->fn_field.is_stub = 1; + } + break; + } default: /* error */ -- 2.34.1