From 567d309569b188e21e132f7d6cdfdbc4f89a1a1c Mon Sep 17 00:00:00 2001 From: Patrick Tasse Date: Wed, 23 Sep 2015 14:01:39 -0400 Subject: [PATCH] tmf: Bug 478216: Incorrect text highlighting in event table due to tabs Use GC.textExtent() instead of GC.stringExtent() to calculate the matching text background highlight x-coordinates, as this method supports tab expansion. Change-Id: I98cfdc7e46e7f10086882650f941fc099544f898 Signed-off-by: Patrick Tasse Reviewed-on: https://git.eclipse.org/r/56554 Reviewed-by: Hudson CI Reviewed-by: Bernd Hufmann Tested-by: Bernd Hufmann --- .../tracecompass/tmf/ui/viewers/events/TmfEventsTable.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java index dd7e3177f4..23aabf2ef8 100644 --- a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java +++ b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java @@ -745,8 +745,8 @@ public class TmfEventsTable extends TmfComponent implements IGotoMarker, IColorS if (styleRange.data.equals(event.index)) { int startIndex = styleRange.start; int endIndex = startIndex + styleRange.length; - int startX = gc.stringExtent(text.substring(0, startIndex)).x; - int endX = gc.stringExtent(text.substring(0, endIndex)).x; + int startX = gc.textExtent(text.substring(0, startIndex)).x; + int endX = gc.textExtent(text.substring(0, endIndex)).x; gc.setBackground(styleRange.background); gc.fillRectangle(textBounds.x + startX, textBounds.y, (endX - startX), textBounds.height); } -- 2.34.1