From 5e9e105f92f031c4bde048f24994799daebaa25e Mon Sep 17 00:00:00 2001 From: Michael Snyder Date: Tue, 1 Mar 2011 23:42:44 +0000 Subject: [PATCH] 2011-03-01 Michael Snyder * cli/cli-dump.c (restore_binary_file): Validate ftell return value. --- gdb/ChangeLog | 2 ++ gdb/cli/cli-dump.c | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 9259a5ede4..53b05e939f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,7 @@ 2011-03-01 Michael Snyder + * cli/cli-dump.c (restore_binary_file): Validate ftell return value. + * ada-lang.c (ada_make_symbol_completion_list): Replace malloc with xmalloc. diff --git a/gdb/cli/cli-dump.c b/gdb/cli/cli-dump.c index e288ee6860..4bba10c35b 100644 --- a/gdb/cli/cli-dump.c +++ b/gdb/cli/cli-dump.c @@ -511,7 +511,11 @@ restore_binary_file (char *filename, struct callback_data *data) /* Get the file size for reading. */ if (fseek (file, 0, SEEK_END) == 0) - len = ftell (file); + { + len = ftell (file); + if (len < 0) + perror_with_name (filename); + } else perror_with_name (filename); -- 2.34.1