From 842806cb6f1c321666dd086a79a0fdfbd35497ed Mon Sep 17 00:00:00 2001 From: Tankut Baris Aktemur Date: Thu, 5 Mar 2020 15:59:22 +0100 Subject: [PATCH] gdb, gdbserver, gdbsupport: add .gitattributes files Create .gitattributes files in gdb/, gdbserver/, and gdbsupport/. The files specify cpp-style diffs for .h and .c files. This is particularly helpful if a class in a header file is modified. For instance, if the `stop_requested` field of `thread_info` in gdb/gdbthread.h is modified, we get the following diff with 'git diff' (using git version 2.17.1): @@ -379,7 +379,7 @@ public: struct target_waitstatus pending_follow; /* True if this thread has been explicitly requested to stop. */ - int stop_requested = 0; + bool stop_requested = 0; /* The initiating frame of a nexting operation, used for deciding which exceptions to intercept. If it is null_frame_id no Note that the context of the change shows up as 'public:'; not so useful. With the .gitattributes file, we get: @@ -379,7 +379,7 @@ class thread_info : public refcounted_object struct target_waitstatus pending_follow; /* True if this thread has been explicitly requested to stop. */ - int stop_requested = 0; + bool stop_requested = 0; /* The initiating frame of a nexting operation, used for deciding which exceptions to intercept. If it is null_frame_id no The context is successfully shown as 'class thread_info'. This patch creates a .gitattributes file per each of gdb, gdbserver, and gdbsupport folders. An alternative would be to define the attributes in the root folder -- this would impact all the top-level folders, though. I opted for the more conservative approach. gdb/ChangeLog: 2020-03-05 Tankut Baris Aktemur * .gitattributes: New file. gdbserver/ChangeLog: 2020-03-05 Tankut Baris Aktemur * .gitattributes: New file. gdbsupport/ChangeLog: 2020-03-05 Tankut Baris Aktemur * .gitattributes: New file. --- gdb/.gitattributes | 7 +++++++ gdb/ChangeLog | 4 ++++ gdbserver/.gitattributes | 6 ++++++ gdbserver/ChangeLog | 4 ++++ gdbsupport/.gitattributes | 6 ++++++ gdbsupport/ChangeLog | 4 ++++ 6 files changed, 31 insertions(+) create mode 100644 gdb/.gitattributes create mode 100644 gdbserver/.gitattributes create mode 100644 gdbsupport/.gitattributes diff --git a/gdb/.gitattributes b/gdb/.gitattributes new file mode 100644 index 0000000000..8acadb9813 --- /dev/null +++ b/gdb/.gitattributes @@ -0,0 +1,7 @@ +# -*- conf -*- + +# Use cpp-style diffs for .h and .c files. This is useful +# if you modify classes defined in those files. + +*.h diff=cpp +*.c diff=cpp diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 22e500c1b3..d8c44d80e4 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2020-03-05 Tankut Baris Aktemur + + * .gitattributes: New file. + 2020-03-04 Tom Tromey * symmisc.c (print_symbol_bcache_statistics) diff --git a/gdbserver/.gitattributes b/gdbserver/.gitattributes new file mode 100644 index 0000000000..6df2574659 --- /dev/null +++ b/gdbserver/.gitattributes @@ -0,0 +1,6 @@ +# -*- conf -*- + +# Use cpp-style diffs for .h files. This is useful +# if you modify classes defined in a header file. + +*.h diff=cpp diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog index 7a5a3b7a03..4e44a763cc 100644 --- a/gdbserver/ChangeLog +++ b/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2020-03-05 Tankut Baris Aktemur + + * .gitattributes: New file. + 2020-03-02 Andrew Burgess * remote-utils.cc (prepare_resume_reply): Add ability to convert T diff --git a/gdbsupport/.gitattributes b/gdbsupport/.gitattributes new file mode 100644 index 0000000000..6df2574659 --- /dev/null +++ b/gdbsupport/.gitattributes @@ -0,0 +1,6 @@ +# -*- conf -*- + +# Use cpp-style diffs for .h files. This is useful +# if you modify classes defined in a header file. + +*.h diff=cpp diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog index 033be86b18..c47bb4ebbb 100644 --- a/gdbsupport/ChangeLog +++ b/gdbsupport/ChangeLog @@ -1,3 +1,7 @@ +2020-03-05 Tankut Baris Aktemur + + * .gitattributes: New file. + 2020-03-03 Simon Marchi * Makefile.in: Re-generate. -- 2.34.1