From 9dbc0f9afa9ec456ce2300d47a46d8db55e4a331 Mon Sep 17 00:00:00 2001 From: Alexandre Montplaisir Date: Mon, 2 May 2016 18:21:37 -0400 Subject: [PATCH 1/1] tmf: Add a method to indicate if a ODA is user-defined This will be useful in diffentiating what analyses are considered "built-in" and which ones were added manually by the user. For example, some operations might be prevented by the manager (like deleting non-user-defined analyses). Or a different icon could be used for them. Change-Id: I887291f0b754c26cb8aca1e758b1741cb7152f52 Signed-off-by: Alexandre Montplaisir Signed-off-by: Philippe Proulx Reviewed-on: https://git.eclipse.org/r/71930 Reviewed-by: Patrick Tasse Tested-by: Patrick Tasse --- .../stubs/analysis/ondemand/OnDemandAnalysisStub.java | 5 +++++ .../tmf/core/analysis/ondemand/IOnDemandAnalysis.java | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/tmf/org.eclipse.tracecompass.tmf.core.tests/stubs/org/eclipse/tracecompass/tmf/tests/stubs/analysis/ondemand/OnDemandAnalysisStub.java b/tmf/org.eclipse.tracecompass.tmf.core.tests/stubs/org/eclipse/tracecompass/tmf/tests/stubs/analysis/ondemand/OnDemandAnalysisStub.java index 52f20ecbfb..613da1b773 100644 --- a/tmf/org.eclipse.tracecompass.tmf.core.tests/stubs/org/eclipse/tracecompass/tmf/tests/stubs/analysis/ondemand/OnDemandAnalysisStub.java +++ b/tmf/org.eclipse.tracecompass.tmf.core.tests/stubs/org/eclipse/tracecompass/tmf/tests/stubs/analysis/ondemand/OnDemandAnalysisStub.java @@ -50,4 +50,9 @@ public class OnDemandAnalysisStub implements IOnDemandAnalysis { /* Do nothing */ return new Object(); } + + @Override + public boolean isUserDefined() { + return false; + } } diff --git a/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/analysis/ondemand/IOnDemandAnalysis.java b/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/analysis/ondemand/IOnDemandAnalysis.java index 58ef0fd496..2d21f1d4e1 100644 --- a/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/analysis/ondemand/IOnDemandAnalysis.java +++ b/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/analysis/ondemand/IOnDemandAnalysis.java @@ -33,6 +33,14 @@ public interface IOnDemandAnalysis { */ String getName(); + /** + * Returns whether or not this analysis is defined by a user, as opposed to + * being built into Trace Compass (or an extension plugin). + * + * @return true if this analysis is defined by a user + */ + boolean isUserDefined(); + /** * Determine if the current analysis can run on the given trace. * -- 2.34.1