From a7ebfdff175130dfb655331680743071d636e7bd Mon Sep 17 00:00:00 2001 From: Matthew Khouzam Date: Wed, 6 Jan 2016 10:30:09 -0500 Subject: [PATCH] analysis: no longer call overridable methods from constructors Change-Id: I6b8e639f04e42ac840a114690a6ddbc639c5873c Signed-off-by: Matthew Khouzam Reviewed-on: https://git.eclipse.org/r/63650 Reviewed-by: Hudson CI Reviewed-by: Marc-Andre Laperle Tested-by: Marc-Andre Laperle --- .../ui/views/segmentstore/density/MouseDragZoomProvider.java | 4 ++-- .../ui/views/segmentstore/density/MouseSelectionProvider.java | 4 ++-- .../ui/views/segmentstore/density/SimpleTooltipProvider.java | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/density/MouseDragZoomProvider.java b/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/density/MouseDragZoomProvider.java index 9001d9b384..97f2a4ef31 100644 --- a/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/density/MouseDragZoomProvider.java +++ b/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/density/MouseDragZoomProvider.java @@ -49,14 +49,14 @@ public class MouseDragZoomProvider extends BaseMouseProvider implements MouseLis } @Override - public void register() { + public final void register() { getChart().getPlotArea().addMouseListener(this); getChart().getPlotArea().addMouseMoveListener(this); ((IPlotArea) getChart().getPlotArea()).addCustomPaintListener(this); } @Override - public void deregister() { + public final void deregister() { if (!getChart().isDisposed()) { getChart().getPlotArea().removeMouseListener(this); getChart().getPlotArea().removeMouseMoveListener(this); diff --git a/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/density/MouseSelectionProvider.java b/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/density/MouseSelectionProvider.java index 8bc611bdbb..bc756e2f55 100644 --- a/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/density/MouseSelectionProvider.java +++ b/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/density/MouseSelectionProvider.java @@ -52,14 +52,14 @@ public class MouseSelectionProvider extends BaseMouseProvider implements MouseLi } @Override - public void register() { + public final void register() { getChart().getPlotArea().addMouseListener(this); getChart().getPlotArea().addMouseMoveListener(this); ((IPlotArea) getChart().getPlotArea()).addCustomPaintListener(this); } @Override - public void deregister() { + public final void deregister() { if (!getChart().isDisposed()) { getChart().getPlotArea().removeMouseListener(this); getChart().getPlotArea().removeMouseMoveListener(this); diff --git a/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/density/SimpleTooltipProvider.java b/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/density/SimpleTooltipProvider.java index f42c0af9a6..62a6f020dd 100644 --- a/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/density/SimpleTooltipProvider.java +++ b/analysis/org.eclipse.tracecompass.analysis.timing.ui/src/org/eclipse/tracecompass/internal/analysis/timing/ui/views/segmentstore/density/SimpleTooltipProvider.java @@ -44,12 +44,12 @@ public class SimpleTooltipProvider extends BaseMouseProvider implements MouseTra } @Override - public void register() { + public final void register() { getChart().getPlotArea().addMouseTrackListener(this); } @Override - public void deregister() { + public final void deregister() { if (!getChart().isDisposed()) { getChart().getPlotArea().removeMouseTrackListener(this); } -- 2.39.5