From b9b3106bcde18204a6b850d626af682376c7f3c1 Mon Sep 17 00:00:00 2001 From: Bernd Hufmann Date: Mon, 26 Oct 2015 09:46:37 -0400 Subject: [PATCH] analysis: Register latency statistics view as analysis output and remove action from context sensitive menu of latency table Change-Id: I806b87ac2088adff18e69836f847f1353c5153e5 Signed-off-by: Bernd Hufmann Reviewed-on: https://git.eclipse.org/r/58932 Reviewed-by: Matthew Khouzam Tested-by: Matthew Khouzam Reviewed-by: Hudson CI Reviewed-by: Bernd Hufmann --- .../plugin.xml | 8 +++++ .../ui/views/latency/LatencyTableViewer.java | 29 ------------------- 2 files changed, 8 insertions(+), 29 deletions(-) diff --git a/analysis/org.eclipse.tracecompass.analysis.os.linux.ui/plugin.xml b/analysis/org.eclipse.tracecompass.analysis.os.linux.ui/plugin.xml index 18c1a3c6bc..337a783da8 100644 --- a/analysis/org.eclipse.tracecompass.analysis.os.linux.ui/plugin.xml +++ b/analysis/org.eclipse.tracecompass.analysis.os.linux.ui/plugin.xml @@ -95,5 +95,13 @@ class="org.eclipse.tracecompass.analysis.os.linux.core.latency.LatencyAnalysis"> + + + + + diff --git a/analysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/latency/LatencyTableViewer.java b/analysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/latency/LatencyTableViewer.java index 9c21f008c7..46fcfcdf2c 100644 --- a/analysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/latency/LatencyTableViewer.java +++ b/analysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/latency/LatencyTableViewer.java @@ -13,22 +13,12 @@ package org.eclipse.tracecompass.internal.analysis.os.linux.ui.views.latency; import org.eclipse.jdt.annotation.Nullable; -import org.eclipse.jface.action.Action; -import org.eclipse.jface.action.IAction; -import org.eclipse.jface.action.IMenuManager; -import org.eclipse.jface.action.Separator; -import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.TableViewer; import org.eclipse.tracecompass.analysis.os.linux.core.latency.LatencyAnalysis; import org.eclipse.tracecompass.analysis.timing.core.segmentstore.AbstractSegmentStoreAnalysisModule; import org.eclipse.tracecompass.analysis.timing.ui.views.segmentstore.AbstractSegmentStoreTableViewer; -import org.eclipse.tracecompass.internal.analysis.os.linux.ui.views.latency.statistics.LatencyStatisticsView; import org.eclipse.tracecompass.tmf.core.trace.ITmfTrace; import org.eclipse.tracecompass.tmf.core.trace.TmfTraceUtils; -import org.eclipse.ui.IWorkbench; -import org.eclipse.ui.IWorkbenchPage; -import org.eclipse.ui.PartInitException; -import org.eclipse.ui.PlatformUI; /** * Displays the latency analysis data in a column table @@ -59,23 +49,4 @@ public class LatencyTableViewer extends AbstractSegmentStoreTableViewer { protected @Nullable AbstractSegmentStoreAnalysisModule getSegmentStoreAnalysisModule(ITmfTrace trace) { return TmfTraceUtils.getAnalysisModuleOfClass(trace, LatencyAnalysis.class, LatencyAnalysis.ID); } - - @Override - protected void appendToTablePopupMenu(IMenuManager manager, IStructuredSelection sel) { - super.appendToTablePopupMenu(manager, sel); - manager.add(new Separator()); - IAction showStatisticsAction = new Action(Messages.LatencyTable_ShowStatisticsActionName) { - @Override - public void run() { - final IWorkbench wb = PlatformUI.getWorkbench(); - final IWorkbenchPage activePage = wb.getActiveWorkbenchWindow().getActivePage(); - try { - activePage.showView(LatencyStatisticsView.ID); - } catch (PartInitException e) { - } - } - }; - - manager.add(showStatisticsAction); - } } -- 2.34.1