From c347a3211f99e3eb6c96909d41c61a7ddbdd1531 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Tue, 6 Aug 2019 23:48:44 -0400 Subject: [PATCH] Fix: bt2: use unsigned iteration variable MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This fixes the following compiler diagnostic (gcc 9.1.0): bt2/native_bt.c: In function ‘_wrap_field_class_enumeration_unsigned_get_mapping_labels_for_value’: bt2/native_bt.c:9387:25: error: comparison of integer expressions of different signedness: ‘int’ and ‘uint64_t’ {aka ‘long unsigned int’} [-Werror=sign-compare] 9387 | for (int i = 0; i < *arg4; i++) { | ^ Change-Id: I543c61d64c0cf7b42cb242bdbb7b71cbf67dbe48 Signed-off-by: Simon Marchi Reviewed-on: https://review.lttng.org/c/babeltrace/+/1834 Reviewed-by: Philippe Proulx Tested-by: jenkins --- src/bindings/python/bt2/bt2/native_bt_field_class.i | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/bindings/python/bt2/bt2/native_bt_field_class.i b/src/bindings/python/bt2/bt2/native_bt_field_class.i index 674d6938..5a84b869 100644 --- a/src/bindings/python/bt2/bt2/native_bt_field_class.i +++ b/src/bindings/python/bt2/bt2/native_bt_field_class.i @@ -34,7 +34,9 @@ (bt_field_class_enumeration_mapping_label_array *label_array, uint64_t *count) { if (*$1) { PyObject *py_label_list = PyList_New(*$2); - for (int i = 0; i < *$2; i++) { + uint64_t i; + + for (i = 0; i < *$2; i++) { PyList_SET_ITEM(py_label_list, i, PyUnicode_FromString((*$1)[i])); } -- 2.34.1