Values API: standardize parameters and return values
[babeltrace.git] / cli / babeltrace-cfg-cli-args.c
index 32e950a7d67317a711eefb3bea93cd9532229b58..b50e0a15c38cde32ae2ae5b242a8fcd68199037f 100644 (file)
@@ -35,6 +35,7 @@
 #include <babeltrace/babeltrace.h>
 #include <babeltrace/common-internal.h>
 #include <babeltrace/values.h>
+#include <babeltrace/private-values.h>
 #include <popt.h>
 #include <glib.h>
 #include <sys/types.h>
@@ -84,7 +85,7 @@ struct ini_parsing_state {
        GScanner *scanner;
 
        /* Output map value object being filled (owned by this) */
-       struct bt_value *params;
+       struct bt_private_value *params;
 
        /* Next expected FSM state */
        enum ini_parsing_fsm_state expecting;
@@ -241,7 +242,9 @@ int ini_handle_state(struct ini_parsing_state *state)
                        goto error;
                }
 
-               if (bt_value_map_has_key(state->params, state->last_map_key)) {
+               if (bt_value_map_has_entry(
+                               bt_value_borrow_from_private(state->params),
+                               state->last_map_key)) {
                        g_string_append_printf(state->ini_error,
                                "Duplicate parameter key: `%s`\n",
                                state->last_map_key);
@@ -292,19 +295,22 @@ int ini_handle_state(struct ini_parsing_state *state)
                                goto error;
                        }
 
-                       value = bt_value_integer_create_init(
-                               (int64_t) int_val);
+                       value = bt_value_borrow_from_private(
+                               bt_private_value_integer_create_init(
+                                       (int64_t) int_val));
                        break;
                }
                case G_TOKEN_FLOAT:
                        /* Positive floating point number */
-                       value = bt_value_float_create_init(
-                               state->scanner->value.v_float);
+                       value = bt_value_borrow_from_private(
+                               bt_private_value_real_create_init(
+                                       state->scanner->value.v_float));
                        break;
                case G_TOKEN_STRING:
                        /* Quoted string */
-                       value = bt_value_string_create_init(
-                               state->scanner->value.v_string);
+                       value = bt_value_borrow_from_private(
+                               bt_private_value_string_create_init(
+                                       state->scanner->value.v_string));
                        break;
                case G_TOKEN_IDENTIFIER:
                {
@@ -326,14 +332,17 @@ int ini_handle_state(struct ini_parsing_state *state)
                        } else if (!strcmp(id, "true") || !strcmp(id, "TRUE") ||
                                        !strcmp(id, "yes") ||
                                        !strcmp(id, "YES")) {
-                               value = bt_value_bool_create_init(true);
+                               value = bt_value_borrow_from_private(
+                                       bt_private_value_bool_create_init(true));
                        } else if (!strcmp(id, "false") ||
                                        !strcmp(id, "FALSE") ||
                                        !strcmp(id, "no") ||
                                        !strcmp(id, "NO")) {
-                               value = bt_value_bool_create_init(false);
+                               value = bt_value_borrow_from_private(
+                                       bt_private_value_bool_create_init(false));
                        } else {
-                               value = bt_value_string_create_init(id);
+                               value = bt_value_borrow_from_private(
+                                       bt_private_value_string_create_init(id));
                        }
                        break;
                }
@@ -366,14 +375,16 @@ int ini_handle_state(struct ini_parsing_state *state)
                                goto error;
                        }
 
-                       value = bt_value_integer_create_init(
-                               -((int64_t) int_val));
+                       value = bt_value_borrow_from_private(
+                               bt_private_value_integer_create_init(
+                                       -((int64_t) int_val)));
                        break;
                }
                case G_TOKEN_FLOAT:
                        /* Negative floating point number */
-                       value = bt_value_float_create_init(
-                               -state->scanner->value.v_float);
+                       value = bt_value_borrow_from_private(
+                               bt_private_value_real_create_init(
+                                       -state->scanner->value.v_float));
                        break;
                default:
                        /* Unset value variable will trigger the error */
@@ -414,7 +425,7 @@ error:
 
 success:
        if (value) {
-               if (bt_value_map_insert(state->params,
+               if (bt_private_value_map_insert_entry(state->params,
                                state->last_map_key, value)) {
                        /* Only override return value on error */
                        ret = -1;
@@ -422,7 +433,7 @@ success:
        }
 
 end:
-       BT_PUT(value);
+       BT_OBJECT_PUT_REF_AND_RESET(value);
        return ret;
 }
 
@@ -432,7 +443,8 @@ end:
  * Return value is owned by the caller.
  */
 static
-struct bt_value *bt_value_from_ini(const char *arg, GString *ini_error)
+struct bt_private_value *bt_private_value_from_ini(const char *arg,
+               GString *ini_error)
 {
        /* Lexical scanner configuration */
        GScannerConfig scanner_config = {
@@ -511,7 +523,7 @@ struct bt_value *bt_value_from_ini(const char *arg, GString *ini_error)
                .ini_error = ini_error,
        };
 
-       state.params = bt_value_map_create();
+       state.params = bt_private_value_map_create();
        if (!state.params) {
                goto error;
        }
@@ -539,7 +551,7 @@ struct bt_value *bt_value_from_ini(const char *arg, GString *ini_error)
        goto end;
 
 error:
-       BT_PUT(state.params);
+       BT_OBJECT_PUT_REF_AND_RESET(state.params);
 
 end:
        if (state.scanner) {
@@ -557,9 +569,9 @@ end:
  * Return value is owned by the caller.
  */
 static
-struct bt_value *bt_value_from_arg(const char *arg)
+struct bt_private_value *bt_private_value_from_arg(const char *arg)
 {
-       struct bt_value *params = NULL;
+       struct bt_private_value *params = NULL;
        GString *ini_error = NULL;
 
        ini_error = g_string_new(NULL);
@@ -569,7 +581,7 @@ struct bt_value *bt_value_from_arg(const char *arg)
        }
 
        /* Try INI-style parsing */
-       params = bt_value_from_ini(arg, ini_error);
+       params = bt_private_value_from_ini(arg, ini_error);
        if (!params) {
                printf_err("%s", ini_error->str);
                goto end;
@@ -579,6 +591,7 @@ end:
        if (ini_error) {
                g_string_free(ini_error, TRUE);
        }
+
        return params;
 }
 
@@ -762,7 +775,7 @@ void bt_config_component_destroy(struct bt_object *obj)
                g_string_free(bt_config_component->instance_name, TRUE);
        }
 
-       BT_PUT(bt_config_component->params);
+       BT_OBJECT_PUT_REF_AND_RESET(bt_config_component->params);
        g_free(bt_config_component);
 
 end:
@@ -811,7 +824,7 @@ struct bt_config_component *bt_config_component_create(
        }
 
        /* Start with empty parameters */
-       cfg_component->params = bt_value_map_create();
+       cfg_component->params = bt_private_value_map_create();
        if (!cfg_component->params) {
                print_err_oom();
                goto error;
@@ -820,7 +833,7 @@ struct bt_config_component *bt_config_component_create(
        goto end;
 
 error:
-       BT_PUT(cfg_component);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg_component);
 
 end:
        return cfg_component;
@@ -856,7 +869,7 @@ struct bt_config_component *bt_config_component_from_arg(const char *arg)
        goto end;
 
 error:
-       BT_PUT(cfg_comp);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg_comp);
 
 end:
        g_free(name);
@@ -878,7 +891,7 @@ void bt_config_destroy(struct bt_object *obj)
                goto end;
        }
 
-       BT_PUT(cfg->plugin_paths);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg->plugin_paths);
 
        switch (cfg->command) {
        case BT_CONFIG_COMMAND_RUN:
@@ -902,10 +915,10 @@ void bt_config_destroy(struct bt_object *obj)
        case BT_CONFIG_COMMAND_LIST_PLUGINS:
                break;
        case BT_CONFIG_COMMAND_HELP:
-               BT_PUT(cfg->cmd_data.help.cfg_component);
+               BT_OBJECT_PUT_REF_AND_RESET(cfg->cmd_data.help.cfg_component);
                break;
        case BT_CONFIG_COMMAND_QUERY:
-               BT_PUT(cfg->cmd_data.query.cfg_component);
+               BT_OBJECT_PUT_REF_AND_RESET(cfg->cmd_data.query.cfg_component);
 
                if (cfg->cmd_data.query.object) {
                        g_string_free(cfg->cmd_data.query.object, TRUE);
@@ -1010,13 +1023,13 @@ GScanner *create_csv_identifiers_scanner(void)
  * Return value is owned by the caller.
  */
 static
-struct bt_value *names_from_arg(const char *arg)
+struct bt_private_value *names_from_arg(const char *arg)
 {
        GScanner *scanner = NULL;
-       struct bt_value *names = NULL;
+       struct bt_private_value *names = NULL;
        bool found_all = false, found_none = false, found_item = false;
 
-       names = bt_value_array_create();
+       names = bt_private_value_array_create();
        if (!names) {
                print_err_oom();
                goto error;
@@ -1041,33 +1054,33 @@ struct bt_value *names_from_arg(const char *arg)
                                        !strcmp(identifier, "args") ||
                                        !strcmp(identifier, "arg")) {
                                found_item = true;
-                               if (bt_value_array_append_string(names,
+                               if (bt_private_value_array_append_string_element(names,
                                                "payload")) {
                                        goto error;
                                }
                        } else if (!strcmp(identifier, "context") ||
                                        !strcmp(identifier, "ctx")) {
                                found_item = true;
-                               if (bt_value_array_append_string(names,
+                               if (bt_private_value_array_append_string_element(names,
                                                "context")) {
                                        goto error;
                                }
                        } else if (!strcmp(identifier, "scope") ||
                                        !strcmp(identifier, "header")) {
                                found_item = true;
-                               if (bt_value_array_append_string(names,
+                               if (bt_private_value_array_append_string_element(names,
                                                identifier)) {
                                        goto error;
                                }
                        } else if (!strcmp(identifier, "all")) {
                                found_all = true;
-                               if (bt_value_array_append_string(names,
+                               if (bt_private_value_array_append_string_element(names,
                                                identifier)) {
                                        goto error;
                                }
                        } else if (!strcmp(identifier, "none")) {
                                found_none = true;
-                               if (bt_value_array_append_string(names,
+                               if (bt_private_value_array_append_string_element(names,
                                                identifier)) {
                                        goto error;
                                }
@@ -1097,7 +1110,7 @@ end:
         * least one item is specified.
         */
        if (found_item && !found_none && !found_all) {
-               if (bt_value_array_append_string(names, "none")) {
+               if (bt_private_value_array_append_string_element(names, "none")) {
                        goto error;
                }
        }
@@ -1107,7 +1120,7 @@ end:
        return names;
 
 error:
-       BT_PUT(names);
+       BT_OBJECT_PUT_REF_AND_RESET(names);
        if (scanner) {
                g_scanner_destroy(scanner);
        }
@@ -1122,12 +1135,12 @@ error:
  * Return value is owned by the caller.
  */
 static
-struct bt_value *fields_from_arg(const char *arg)
+struct bt_private_value *fields_from_arg(const char *arg)
 {
        GScanner *scanner = NULL;
-       struct bt_value *fields;
+       struct bt_private_value *fields;
 
-       fields = bt_value_array_create();
+       fields = bt_private_value_array_create();
        if (!fields) {
                print_err_oom();
                goto error;
@@ -1157,7 +1170,7 @@ struct bt_value *fields_from_arg(const char *arg)
                                        !strcmp(identifier, "emf") ||
                                        !strcmp(identifier, "callsite") ||
                                        !strcmp(identifier, "all")) {
-                               if (bt_value_array_append_string(fields,
+                               if (bt_private_value_array_append_string_element(fields,
                                                identifier)) {
                                        goto error;
                                }
@@ -1180,7 +1193,7 @@ struct bt_value *fields_from_arg(const char *arg)
        goto end;
 
 error:
-       BT_PUT(fields);
+       BT_OBJECT_PUT_REF_AND_RESET(fields);
 
 end:
        if (scanner) {
@@ -1240,8 +1253,9 @@ int insert_flat_params_from_array(GString *params_arg,
                goto end;
        }
 
-       for (i = 0; i < bt_value_array_size(names_array); i++) {
-               struct bt_value *str_obj = bt_value_array_get(names_array, i);
+       for (i = 0; i < bt_value_array_get_size(names_array); i++) {
+               struct bt_value *str_obj =
+                       bt_value_array_borrow_element_by_index(names_array, i);
                const char *suffix;
                bool is_default = false;
 
@@ -1251,12 +1265,7 @@ int insert_flat_params_from_array(GString *params_arg,
                        goto end;
                }
 
-               ret = bt_value_string_get(str_obj, &suffix);
-               BT_PUT(str_obj);
-               if (ret) {
-                       printf_err("Unexpected error\n");
-                       goto end;
-               }
+               suffix = bt_value_string_get(str_obj);
 
                g_string_assign(tmpstr, prefix);
                g_string_append(tmpstr, "-");
@@ -1364,7 +1373,7 @@ void add_run_cfg_comp(struct bt_config *cfg,
                struct bt_config_component *cfg_comp,
                enum bt_config_component_dest dest)
 {
-       bt_get(cfg_comp);
+       bt_object_get_ref(cfg_comp);
 
        switch (dest) {
        case BT_CONFIG_COMPONENT_DEST_SOURCE:
@@ -1385,7 +1394,7 @@ static
 int add_run_cfg_comp_check_name(struct bt_config *cfg,
                struct bt_config_component *cfg_comp,
                enum bt_config_component_dest dest,
-               struct bt_value *instance_names)
+               struct bt_private_value *instance_names)
 {
        int ret = 0;
 
@@ -1395,14 +1404,15 @@ int add_run_cfg_comp_check_name(struct bt_config *cfg,
                goto end;
        }
 
-       if (bt_value_map_has_key(instance_names, cfg_comp->instance_name->str)) {
+       if (bt_value_map_has_entry(bt_value_borrow_from_private(instance_names),
+                       cfg_comp->instance_name->str)) {
                printf_err("Duplicate component instance name:\n    %s\n",
                        cfg_comp->instance_name->str);
                ret = -1;
                goto end;
        }
 
-       if (bt_value_map_insert(instance_names,
+       if (bt_private_value_map_insert_entry(instance_names,
                        cfg_comp->instance_name->str, bt_value_null)) {
                print_err_oom();
                ret = -1;
@@ -1416,7 +1426,7 @@ end:
 }
 
 static
-int append_env_var_plugin_paths(struct bt_value *plugin_paths)
+int append_env_var_plugin_paths(struct bt_private_value *plugin_paths)
 {
        int ret = 0;
        const char *envvar;
@@ -1442,7 +1452,7 @@ end:
 }
 
 static
-int append_home_and_system_plugin_paths(struct bt_value *plugin_paths,
+int append_home_and_system_plugin_paths(struct bt_private_value *plugin_paths,
                bool omit_system_plugin_path, bool omit_home_plugin_path)
 {
        int ret;
@@ -1489,7 +1499,8 @@ int append_home_and_system_plugin_paths_cfg(struct bt_config *cfg)
 
 static
 struct bt_config *bt_config_base_create(enum bt_config_command command,
-               struct bt_value *initial_plugin_paths, bool needs_plugins)
+               struct bt_private_value *initial_plugin_paths,
+               bool needs_plugins)
 {
        struct bt_config *cfg;
 
@@ -1505,9 +1516,9 @@ struct bt_config *bt_config_base_create(enum bt_config_command command,
        cfg->command_needs_plugins = needs_plugins;
 
        if (initial_plugin_paths) {
-               cfg->plugin_paths = bt_get(initial_plugin_paths);
+               cfg->plugin_paths = bt_object_get_ref(initial_plugin_paths);
        } else {
-               cfg->plugin_paths = bt_value_array_create();
+               cfg->plugin_paths = bt_private_value_array_create();
                if (!cfg->plugin_paths) {
                        print_err_oom();
                        goto error;
@@ -1517,7 +1528,7 @@ struct bt_config *bt_config_base_create(enum bt_config_command command,
        goto end;
 
 error:
-       BT_PUT(cfg);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg);
 
 end:
        return cfg;
@@ -1525,7 +1536,7 @@ end:
 
 static
 struct bt_config *bt_config_run_create(
-               struct bt_value *initial_plugin_paths)
+               struct bt_private_value *initial_plugin_paths)
 {
        struct bt_config *cfg;
 
@@ -1537,21 +1548,21 @@ struct bt_config *bt_config_run_create(
        }
 
        cfg->cmd_data.run.sources = g_ptr_array_new_with_free_func(
-               (GDestroyNotify) bt_put);
+               (GDestroyNotify) bt_object_put_ref);
        if (!cfg->cmd_data.run.sources) {
                print_err_oom();
                goto error;
        }
 
        cfg->cmd_data.run.filters = g_ptr_array_new_with_free_func(
-               (GDestroyNotify) bt_put);
+               (GDestroyNotify) bt_object_put_ref);
        if (!cfg->cmd_data.run.filters) {
                print_err_oom();
                goto error;
        }
 
        cfg->cmd_data.run.sinks = g_ptr_array_new_with_free_func(
-               (GDestroyNotify) bt_put);
+               (GDestroyNotify) bt_object_put_ref);
        if (!cfg->cmd_data.run.sinks) {
                print_err_oom();
                goto error;
@@ -1567,7 +1578,7 @@ struct bt_config *bt_config_run_create(
        goto end;
 
 error:
-       BT_PUT(cfg);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg);
 
 end:
        return cfg;
@@ -1575,7 +1586,7 @@ end:
 
 static
 struct bt_config *bt_config_list_plugins_create(
-               struct bt_value *initial_plugin_paths)
+               struct bt_private_value *initial_plugin_paths)
 {
        struct bt_config *cfg;
 
@@ -1589,7 +1600,7 @@ struct bt_config *bt_config_list_plugins_create(
        goto end;
 
 error:
-       BT_PUT(cfg);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg);
 
 end:
        return cfg;
@@ -1597,7 +1608,7 @@ end:
 
 static
 struct bt_config *bt_config_help_create(
-               struct bt_value *initial_plugin_paths)
+               struct bt_private_value *initial_plugin_paths)
 {
        struct bt_config *cfg;
 
@@ -1618,7 +1629,7 @@ struct bt_config *bt_config_help_create(
        goto end;
 
 error:
-       BT_PUT(cfg);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg);
 
 end:
        return cfg;
@@ -1626,7 +1637,7 @@ end:
 
 static
 struct bt_config *bt_config_query_create(
-               struct bt_value *initial_plugin_paths)
+               struct bt_private_value *initial_plugin_paths)
 {
        struct bt_config *cfg;
 
@@ -1646,7 +1657,7 @@ struct bt_config *bt_config_query_create(
        goto end;
 
 error:
-       BT_PUT(cfg);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg);
 
 end:
        return cfg;
@@ -1654,7 +1665,7 @@ end:
 
 static
 struct bt_config *bt_config_print_ctf_metadata_create(
-               struct bt_value *initial_plugin_paths)
+               struct bt_private_value *initial_plugin_paths)
 {
        struct bt_config *cfg;
 
@@ -1680,7 +1691,7 @@ struct bt_config *bt_config_print_ctf_metadata_create(
        goto end;
 
 error:
-       BT_PUT(cfg);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg);
 
 end:
        return cfg;
@@ -1688,7 +1699,7 @@ end:
 
 static
 struct bt_config *bt_config_print_lttng_live_sessions_create(
-               struct bt_value *initial_plugin_paths)
+               struct bt_private_value *initial_plugin_paths)
 {
        struct bt_config *cfg;
 
@@ -1715,7 +1726,7 @@ struct bt_config *bt_config_print_lttng_live_sessions_create(
        goto end;
 
 error:
-       BT_PUT(cfg);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg);
 
 end:
        return cfg;
@@ -1723,7 +1734,7 @@ end:
 
 static
 int bt_config_append_plugin_paths_check_setuid_setgid(
-               struct bt_value *plugin_paths, const char *arg)
+               struct bt_private_value *plugin_paths, const char *arg)
 {
        int ret = 0;
 
@@ -1824,7 +1835,7 @@ static
 struct bt_config *bt_config_help_from_args(int argc, const char *argv[],
                int *retcode, bool force_omit_system_plugin_path,
                bool force_omit_home_plugin_path,
-               struct bt_value *initial_plugin_paths)
+               struct bt_private_value *initial_plugin_paths)
 {
        poptContext pc = NULL;
        char *arg = NULL;
@@ -1876,7 +1887,7 @@ struct bt_config *bt_config_help_from_args(int argc, const char *argv[],
                case OPT_HELP:
                        print_help_usage(stdout);
                        *retcode = -1;
-                       BT_PUT(cfg);
+                       BT_OBJECT_PUT_REF_AND_RESET(cfg);
                        goto end;
                default:
                        printf_err("Unknown command-line option specified (option code %d)\n",
@@ -1919,7 +1930,7 @@ struct bt_config *bt_config_help_from_args(int argc, const char *argv[],
        } else {
                print_help_usage(stdout);
                *retcode = -1;
-               BT_PUT(cfg);
+               BT_OBJECT_PUT_REF_AND_RESET(cfg);
                goto end;
        }
 
@@ -1931,7 +1942,7 @@ struct bt_config *bt_config_help_from_args(int argc, const char *argv[],
 
 error:
        *retcode = 1;
-       BT_PUT(cfg);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg);
 
 end:
        g_free(plugin_name);
@@ -1988,7 +1999,7 @@ static
 struct bt_config *bt_config_query_from_args(int argc, const char *argv[],
                int *retcode, bool force_omit_system_plugin_path,
                bool force_omit_home_plugin_path,
-               struct bt_value *initial_plugin_paths)
+               struct bt_private_value *initial_plugin_paths)
 {
        poptContext pc = NULL;
        char *arg = NULL;
@@ -1996,7 +2007,7 @@ struct bt_config *bt_config_query_from_args(int argc, const char *argv[],
        int ret;
        struct bt_config *cfg = NULL;
        const char *leftover;
-       struct bt_value *params = bt_value_null;
+       struct bt_private_value *params = bt_private_value_null;
 
        *retcode = 0;
        cfg = bt_config_query_create(initial_plugin_paths);
@@ -2039,8 +2050,8 @@ struct bt_config *bt_config_query_from_args(int argc, const char *argv[],
                        break;
                case OPT_PARAMS:
                {
-                       bt_put(params);
-                       params = bt_value_from_arg(arg);
+                       bt_object_put_ref(params);
+                       params = bt_private_value_from_arg(arg);
                        if (!params) {
                                printf_err("Invalid format for --params option's argument:\n    %s\n",
                                        arg);
@@ -2051,7 +2062,7 @@ struct bt_config *bt_config_query_from_args(int argc, const char *argv[],
                case OPT_HELP:
                        print_query_usage(stdout);
                        *retcode = -1;
-                       BT_PUT(cfg);
+                       BT_OBJECT_PUT_REF_AND_RESET(cfg);
                        goto end;
                default:
                        printf_err("Unknown command-line option specified (option code %d)\n",
@@ -2085,11 +2096,12 @@ struct bt_config *bt_config_query_from_args(int argc, const char *argv[],
                }
 
                BT_ASSERT(params);
-               BT_MOVE(cfg->cmd_data.query.cfg_component->params, params);
+               BT_OBJECT_MOVE_REF(cfg->cmd_data.query.cfg_component->params,
+                       params);
        } else {
                print_query_usage(stdout);
                *retcode = -1;
-               BT_PUT(cfg);
+               BT_OBJECT_PUT_REF_AND_RESET(cfg);
                goto end;
        }
 
@@ -2104,7 +2116,7 @@ struct bt_config *bt_config_query_from_args(int argc, const char *argv[],
        } else {
                print_query_usage(stdout);
                *retcode = -1;
-               BT_PUT(cfg);
+               BT_OBJECT_PUT_REF_AND_RESET(cfg);
                goto end;
        }
 
@@ -2122,14 +2134,14 @@ struct bt_config *bt_config_query_from_args(int argc, const char *argv[],
 
 error:
        *retcode = 1;
-       BT_PUT(cfg);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg);
 
 end:
        if (pc) {
                poptFreeContext(pc);
        }
 
-       bt_put(params);
+       bt_object_put_ref(params);
        free(arg);
        return cfg;
 }
@@ -2176,7 +2188,7 @@ static
 struct bt_config *bt_config_list_plugins_from_args(int argc, const char *argv[],
                int *retcode, bool force_omit_system_plugin_path,
                bool force_omit_home_plugin_path,
-               struct bt_value *initial_plugin_paths)
+               struct bt_private_value *initial_plugin_paths)
 {
        poptContext pc = NULL;
        char *arg = NULL;
@@ -2227,7 +2239,7 @@ struct bt_config *bt_config_list_plugins_from_args(int argc, const char *argv[],
                case OPT_HELP:
                        print_list_plugins_usage(stdout);
                        *retcode = -1;
-                       BT_PUT(cfg);
+                       BT_OBJECT_PUT_REF_AND_RESET(cfg);
                        goto end;
                default:
                        printf_err("Unknown command-line option specified (option code %d)\n",
@@ -2260,7 +2272,7 @@ struct bt_config *bt_config_list_plugins_from_args(int argc, const char *argv[],
 
 error:
        *retcode = 1;
-       BT_PUT(cfg);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg);
 
 end:
        if (pc) {
@@ -2366,21 +2378,22 @@ static
 struct bt_config *bt_config_run_from_args(int argc, const char *argv[],
                int *retcode, bool force_omit_system_plugin_path,
                bool force_omit_home_plugin_path,
-               struct bt_value *initial_plugin_paths)
+               struct bt_private_value *initial_plugin_paths)
 {
        poptContext pc = NULL;
        char *arg = NULL;
        struct bt_config_component *cur_cfg_comp = NULL;
        enum bt_config_component_dest cur_cfg_comp_dest =
                        BT_CONFIG_COMPONENT_DEST_UNKNOWN;
-       struct bt_value *cur_base_params = NULL;
+       struct bt_private_value *cur_base_params = NULL;
        int opt, ret = 0;
        struct bt_config *cfg = NULL;
-       struct bt_value *instance_names = NULL;
-       struct bt_value *connection_args = NULL;
+       struct bt_private_value *instance_names = NULL;
+       struct bt_private_value *connection_args = NULL;
        GString *cur_param_key = NULL;
        char error_buf[256] = { 0 };
        long retry_duration = -1;
+       enum bt_value_status status;
        struct poptOption run_long_options[] = {
                { "base-params", 'b', POPT_ARG_STRING, NULL, OPT_BASE_PARAMS, NULL, NULL },
                { "component", 'c', POPT_ARG_STRING, NULL, OPT_COMPONENT, NULL, NULL },
@@ -2419,19 +2432,19 @@ struct bt_config *bt_config_run_from_args(int argc, const char *argv[],
        cfg->cmd_data.run.retry_duration_us = 100000;
        cfg->omit_system_plugin_path = force_omit_system_plugin_path;
        cfg->omit_home_plugin_path = force_omit_home_plugin_path;
-       cur_base_params = bt_value_map_create();
+       cur_base_params = bt_private_value_map_create();
        if (!cur_base_params) {
                print_err_oom();
                goto error;
        }
 
-       instance_names = bt_value_map_create();
+       instance_names = bt_private_value_map_create();
        if (!instance_names) {
                print_err_oom();
                goto error;
        }
 
-       connection_args = bt_value_array_create();
+       connection_args = bt_private_value_array_create();
        if (!connection_args) {
                print_err_oom();
                goto error;
@@ -2476,7 +2489,7 @@ struct bt_config *bt_config_run_from_args(int argc, const char *argv[],
                                ret = add_run_cfg_comp_check_name(cfg,
                                        cur_cfg_comp, cur_cfg_comp_dest,
                                        instance_names);
-                               BT_PUT(cur_cfg_comp);
+                               BT_OBJECT_PUT_REF_AND_RESET(cur_cfg_comp);
                                if (ret) {
                                        goto error;
                                }
@@ -2504,9 +2517,11 @@ struct bt_config *bt_config_run_from_args(int argc, const char *argv[],
                        }
 
                        BT_ASSERT(cur_base_params);
-                       bt_put(cur_cfg_comp->params);
-                       cur_cfg_comp->params = bt_value_copy(cur_base_params);
-                       if (!cur_cfg_comp->params) {
+                       bt_object_put_ref(cur_cfg_comp->params);
+                       status = bt_value_copy(
+                               &cur_cfg_comp->params,
+                               bt_value_borrow_from_private(cur_base_params));
+                       if (status != BT_VALUE_STATUS_OK) {
                                print_err_oom();
                                goto error;
                        }
@@ -2516,8 +2531,8 @@ struct bt_config *bt_config_run_from_args(int argc, const char *argv[],
                }
                case OPT_PARAMS:
                {
-                       struct bt_value *params;
-                       struct bt_value *params_to_set;
+                       struct bt_private_value *params;
+                       struct bt_private_value *params_to_set;
 
                        if (!cur_cfg_comp) {
                                printf_err("Cannot add parameters to unavailable component:\n    %s\n",
@@ -2525,23 +2540,24 @@ struct bt_config *bt_config_run_from_args(int argc, const char *argv[],
                                goto error;
                        }
 
-                       params = bt_value_from_arg(arg);
+                       params = bt_private_value_from_arg(arg);
                        if (!params) {
                                printf_err("Invalid format for --params option's argument:\n    %s\n",
                                        arg);
                                goto error;
                        }
 
-                       params_to_set = bt_value_map_extend(cur_cfg_comp->params,
-                               params);
-                       BT_PUT(params);
-                       if (!params_to_set) {
+                       status = bt_value_map_extend(&params_to_set,
+                               bt_value_borrow_from_private(cur_cfg_comp->params),
+                               bt_value_borrow_from_private(params));
+                       BT_OBJECT_PUT_REF_AND_RESET(params);
+                       if (status != BT_VALUE_STATUS_OK) {
                                printf_err("Cannot extend current component parameters with --params option's argument:\n    %s\n",
                                        arg);
                                goto error;
                        }
 
-                       BT_MOVE(cur_cfg_comp->params, params_to_set);
+                       BT_OBJECT_MOVE_REF(cur_cfg_comp->params, params_to_set);
                        break;
                }
                case OPT_KEY:
@@ -2565,7 +2581,7 @@ struct bt_config *bt_config_run_from_args(int argc, const char *argv[],
                                goto error;
                        }
 
-                       if (bt_value_map_insert_string(cur_cfg_comp->params,
+                       if (bt_private_value_map_insert_string_entry(cur_cfg_comp->params,
                                        cur_param_key->str, arg)) {
                                print_err_oom();
                                goto error;
@@ -2582,7 +2598,8 @@ struct bt_config *bt_config_run_from_args(int argc, const char *argv[],
                        break;
                case OPT_BASE_PARAMS:
                {
-                       struct bt_value *params = bt_value_from_arg(arg);
+                       struct bt_private_value *params =
+                               bt_private_value_from_arg(arg);
 
                        if (!params) {
                                printf_err("Invalid format for --base-params option's argument:\n    %s\n",
@@ -2590,20 +2607,20 @@ struct bt_config *bt_config_run_from_args(int argc, const char *argv[],
                                goto error;
                        }
 
-                       BT_MOVE(cur_base_params, params);
+                       BT_OBJECT_MOVE_REF(cur_base_params, params);
                        break;
                }
                case OPT_RESET_BASE_PARAMS:
-                       BT_PUT(cur_base_params);
-                       cur_base_params = bt_value_map_create();
+                       BT_OBJECT_PUT_REF_AND_RESET(cur_base_params);
+                       cur_base_params = bt_private_value_map_create();
                        if (!cur_base_params) {
                                print_err_oom();
                                goto error;
                        }
                        break;
                case OPT_CONNECT:
-                       if (bt_value_array_append_string(connection_args,
-                                       arg)) {
+                       if (bt_private_value_array_append_string_element(
+                                       connection_args, arg)) {
                                print_err_oom();
                                goto error;
                        }
@@ -2621,7 +2638,7 @@ struct bt_config *bt_config_run_from_args(int argc, const char *argv[],
                case OPT_HELP:
                        print_run_usage(stdout);
                        *retcode = -1;
-                       BT_PUT(cfg);
+                       BT_OBJECT_PUT_REF_AND_RESET(cfg);
                        goto end;
                default:
                        printf_err("Unknown command-line option specified (option code %d)\n",
@@ -2650,7 +2667,7 @@ struct bt_config *bt_config_run_from_args(int argc, const char *argv[],
        if (cur_cfg_comp) {
                ret = add_run_cfg_comp_check_name(cfg, cur_cfg_comp,
                        cur_cfg_comp_dest, instance_names);
-               BT_PUT(cur_cfg_comp);
+               BT_OBJECT_PUT_REF_AND_RESET(cur_cfg_comp);
                if (ret) {
                        goto error;
                }
@@ -2670,7 +2687,8 @@ struct bt_config *bt_config_run_from_args(int argc, const char *argv[],
                goto error;
        }
 
-       ret = bt_config_cli_args_create_connections(cfg, connection_args,
+       ret = bt_config_cli_args_create_connections(cfg,
+               bt_value_borrow_from_private(connection_args),
                error_buf, 256);
        if (ret) {
                printf_err("Cannot creation connections:\n%s", error_buf);
@@ -2681,7 +2699,7 @@ struct bt_config *bt_config_run_from_args(int argc, const char *argv[],
 
 error:
        *retcode = 1;
-       BT_PUT(cfg);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg);
 
 end:
        if (pc) {
@@ -2693,10 +2711,10 @@ end:
        }
 
        free(arg);
-       BT_PUT(cur_cfg_comp);
-       BT_PUT(cur_base_params);
-       BT_PUT(instance_names);
-       BT_PUT(connection_args);
+       BT_OBJECT_PUT_REF_AND_RESET(cur_cfg_comp);
+       BT_OBJECT_PUT_REF_AND_RESET(cur_base_params);
+       BT_OBJECT_PUT_REF_AND_RESET(instance_names);
+       BT_OBJECT_PUT_REF_AND_RESET(connection_args);
        return cfg;
 }
 
@@ -2704,12 +2722,12 @@ static
 struct bt_config *bt_config_run_from_args_array(struct bt_value *run_args,
                int *retcode, bool force_omit_system_plugin_path,
                bool force_omit_home_plugin_path,
-               struct bt_value *initial_plugin_paths)
+               struct bt_private_value *initial_plugin_paths)
 {
        struct bt_config *cfg = NULL;
        const char **argv;
        int64_t i, len;
-       const size_t argc = bt_value_array_size(run_args) + 1;
+       const size_t argc = bt_value_array_get_size(run_args) + 1;
 
        argv = calloc(argc, sizeof(*argv));
        if (!argv) {
@@ -2719,22 +2737,20 @@ struct bt_config *bt_config_run_from_args_array(struct bt_value *run_args,
 
        argv[0] = "run";
 
-       len = bt_value_array_size(run_args);
+       len = bt_value_array_get_size(run_args);
        if (len < 0) {
                printf_err("Invalid executable arguments\n");
                goto end;
        }
        for (i = 0; i < len; i++) {
-               int ret;
-               struct bt_value *arg_value = bt_value_array_get(run_args, i);
+               struct bt_value *arg_value =
+                       bt_value_array_borrow_element_by_index(run_args, i);
                const char *arg;
 
                BT_ASSERT(arg_value);
-               ret = bt_value_string_get(arg_value, &arg);
-               BT_ASSERT(ret == 0);
+               arg = bt_value_string_get(arg_value);
                BT_ASSERT(arg);
                argv[i + 1] = arg;
-               bt_put(arg_value);
        }
 
        cfg = bt_config_run_from_args(argc, argv, retcode,
@@ -2936,7 +2952,7 @@ GString *get_component_auto_name(const char *prefix,
                goto end;
        }
 
-       if (!bt_value_map_has_key(existing_names, prefix)) {
+       if (!bt_value_map_has_entry(existing_names, prefix)) {
                g_string_assign(auto_name, prefix);
                goto end;
        }
@@ -2944,7 +2960,7 @@ GString *get_component_auto_name(const char *prefix,
        do {
                g_string_printf(auto_name, "%s-%d", prefix, i);
                i++;
-       } while (bt_value_map_has_key(existing_names, auto_name->str));
+       } while (bt_value_map_has_entry(existing_names, auto_name->str));
 
 end:
        return auto_name;
@@ -2955,12 +2971,12 @@ struct implicit_component_args {
        GString *comp_arg;
        GString *name_arg;
        GString *params_arg;
-       struct bt_value *extra_params;
+       struct bt_private_value *extra_params;
 };
 
 static
 int assign_name_to_implicit_component(struct implicit_component_args *args,
-               const char *prefix, struct bt_value *existing_names,
+               const char *prefix, struct bt_private_value *existing_names,
                GList **comp_names, bool append_to_comp_names)
 {
        int ret = 0;
@@ -2970,7 +2986,8 @@ int assign_name_to_implicit_component(struct implicit_component_args *args,
                goto end;
        }
 
-       name = get_component_auto_name(prefix, existing_names);
+       name = get_component_auto_name(prefix,
+               bt_value_borrow_from_private(existing_names));
 
        if (!name) {
                ret = -1;
@@ -2979,7 +2996,7 @@ int assign_name_to_implicit_component(struct implicit_component_args *args,
 
        g_string_assign(args->name_arg, name->str);
 
-       if (bt_value_map_insert(existing_names, name->str,
+       if (bt_private_value_map_insert_entry(existing_names, name->str,
                        bt_value_null)) {
                print_err_oom();
                ret = -1;
@@ -3002,7 +3019,7 @@ end:
 static
 int append_run_args_for_implicit_component(
                struct implicit_component_args *impl_args,
-               struct bt_value *run_args)
+               struct bt_private_value *run_args)
 {
        int ret = 0;
        size_t i;
@@ -3011,55 +3028,55 @@ int append_run_args_for_implicit_component(
                goto end;
        }
 
-       if (bt_value_array_append_string(run_args, "--component")) {
+       if (bt_private_value_array_append_string_element(run_args, "--component")) {
                print_err_oom();
                goto error;
        }
 
-       if (bt_value_array_append_string(run_args, impl_args->comp_arg->str)) {
+       if (bt_private_value_array_append_string_element(run_args, impl_args->comp_arg->str)) {
                print_err_oom();
                goto error;
        }
 
-       if (bt_value_array_append_string(run_args, "--name")) {
+       if (bt_private_value_array_append_string_element(run_args, "--name")) {
                print_err_oom();
                goto error;
        }
 
-       if (bt_value_array_append_string(run_args, impl_args->name_arg->str)) {
+       if (bt_private_value_array_append_string_element(run_args, impl_args->name_arg->str)) {
                print_err_oom();
                goto error;
        }
 
        if (impl_args->params_arg->len > 0) {
-               if (bt_value_array_append_string(run_args, "--params")) {
+               if (bt_private_value_array_append_string_element(run_args, "--params")) {
                        print_err_oom();
                        goto error;
                }
 
-               if (bt_value_array_append_string(run_args,
+               if (bt_private_value_array_append_string_element(run_args,
                                impl_args->params_arg->str)) {
                        print_err_oom();
                        goto error;
                }
        }
 
-       for (i = 0; i < bt_value_array_size(impl_args->extra_params); i++) {
+       for (i = 0; i < bt_value_array_get_size(
+                       bt_value_borrow_from_private(impl_args->extra_params));
+                       i++) {
                struct bt_value *elem;
                const char *arg;
 
-               elem = bt_value_array_get(impl_args->extra_params, i);
+               elem = bt_value_array_borrow_element_by_index(
+                       bt_value_borrow_from_private(impl_args->extra_params),
+                       i);
                if (!elem) {
                        goto error;
                }
 
                BT_ASSERT(bt_value_is_string(elem));
-               if (bt_value_string_get(elem, &arg)) {
-                       goto error;
-               }
-
-               ret = bt_value_array_append_string(run_args, arg);
-               bt_put(elem);
+               arg = bt_value_string_get(elem);
+               ret = bt_private_value_array_append_string_element(run_args, arg);
                if (ret) {
                        print_err_oom();
                        goto error;
@@ -3092,7 +3109,7 @@ void finalize_implicit_component_args(struct implicit_component_args *args)
                g_string_free(args->params_arg, TRUE);
        }
 
-       bt_put(args->extra_params);
+       bt_object_put_ref(args->extra_params);
 }
 
 static
@@ -3116,7 +3133,7 @@ int init_implicit_component_args(struct implicit_component_args *args,
        args->comp_arg = g_string_new(comp_arg);
        args->name_arg = g_string_new(NULL);
        args->params_arg = g_string_new(NULL);
-       args->extra_params = bt_value_array_create();
+       args->extra_params = bt_private_value_array_create();
 
        if (!args->comp_arg || !args->name_arg ||
                        !args->params_arg || !args->extra_params) {
@@ -3150,25 +3167,25 @@ int append_implicit_component_extra_param(struct implicit_component_args *args,
        BT_ASSERT(key);
        BT_ASSERT(value);
 
-       if (bt_value_array_append_string(args->extra_params, "--key")) {
+       if (bt_private_value_array_append_string_element(args->extra_params, "--key")) {
                print_err_oom();
                ret = -1;
                goto end;
        }
 
-       if (bt_value_array_append_string(args->extra_params, key)) {
+       if (bt_private_value_array_append_string_element(args->extra_params, key)) {
                print_err_oom();
                ret = -1;
                goto end;
        }
 
-       if (bt_value_array_append_string(args->extra_params, "--value")) {
+       if (bt_private_value_array_append_string_element(args->extra_params, "--value")) {
                print_err_oom();
                ret = -1;
                goto end;
        }
 
-       if (bt_value_array_append_string(args->extra_params, value)) {
+       if (bt_private_value_array_append_string_element(args->extra_params, value)) {
                print_err_oom();
                ret = -1;
                goto end;
@@ -3181,7 +3198,8 @@ end:
 static
 int convert_append_name_param(enum bt_config_component_dest dest,
                GString *cur_name, GString *cur_name_prefix,
-               struct bt_value *run_args, struct bt_value *all_names,
+               struct bt_private_value *run_args,
+               struct bt_private_value *all_names,
                GList **source_names, GList **filter_names,
                GList **sink_names)
 {
@@ -3198,14 +3216,15 @@ int convert_append_name_param(enum bt_config_component_dest dest,
                         * component.
                         */
                        name = get_component_auto_name(cur_name_prefix->str,
-                               all_names);
+                               bt_value_borrow_from_private(all_names));
                        append_name_opt = true;
                } else {
                        /*
                         * An explicit name was provided for the user
                         * component.
                         */
-                       if (bt_value_map_has_key(all_names,
+                       if (bt_value_map_has_entry(
+                                       bt_value_borrow_from_private(all_names),
                                        cur_name->str)) {
                                printf_err("Duplicate component instance name:\n    %s\n",
                                        cur_name->str);
@@ -3224,7 +3243,7 @@ int convert_append_name_param(enum bt_config_component_dest dest,
                 * Remember this name globally, for the uniqueness of
                 * all component names.
                 */
-               if (bt_value_map_insert(all_names, name->str, bt_value_null)) {
+               if (bt_private_value_map_insert_entry(all_names, name->str, bt_value_null)) {
                        print_err_oom();
                        goto error;
                }
@@ -3233,12 +3252,12 @@ int convert_append_name_param(enum bt_config_component_dest dest,
                 * Append the --name option if necessary.
                 */
                if (append_name_opt) {
-                       if (bt_value_array_append_string(run_args, "--name")) {
+                       if (bt_private_value_array_append_string_element(run_args, "--name")) {
                                print_err_oom();
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, name->str)) {
+                       if (bt_private_value_array_append_string_element(run_args, name->str)) {
                                print_err_oom();
                                goto error;
                        }
@@ -3306,7 +3325,7 @@ end:
  * function.
  */
 static
-int append_connect_arg(struct bt_value *run_args,
+int append_connect_arg(struct bt_private_value *run_args,
                const char *upstream_name, const char *downstream_name)
 {
        int ret = 0;
@@ -3320,7 +3339,7 @@ int append_connect_arg(struct bt_value *run_args,
                goto end;
        }
 
-       ret = bt_value_array_append_string(run_args, "--connect");
+       ret = bt_private_value_array_append_string_element(run_args, "--connect");
        if (ret) {
                print_err_oom();
                ret = -1;
@@ -3330,7 +3349,7 @@ int append_connect_arg(struct bt_value *run_args,
        g_string_append(arg, e_upstream_name->str);
        g_string_append_c(arg, ':');
        g_string_append(arg, e_downstream_name->str);
-       ret = bt_value_array_append_string(run_args, arg->str);
+       ret = bt_private_value_array_append_string_element(run_args, arg->str);
        if (ret) {
                print_err_oom();
                ret = -1;
@@ -3357,7 +3376,7 @@ end:
  * Appends the run command's --connect options for the convert command.
  */
 static
-int convert_auto_connect(struct bt_value *run_args,
+int convert_auto_connect(struct bt_private_value *run_args,
                GList *source_names, GList *filter_names,
                GList *sink_names)
 {
@@ -3517,6 +3536,7 @@ int fill_implicit_ctf_inputs_args(GPtrArray *implicit_ctf_inputs_args,
 {
        int ret = 0;
        GList *leftover;
+       enum bt_value_status status;
 
        for (leftover = leftovers; leftover != NULL;
                        leftover = g_list_next(leftover)) {
@@ -3539,10 +3559,11 @@ int fill_implicit_ctf_inputs_args(GPtrArray *implicit_ctf_inputs_args,
                 * We need our own copy of the extra parameters because
                 * this is where the unique path goes.
                 */
-               BT_PUT(impl_args->extra_params);
-               impl_args->extra_params =
-                       bt_value_copy(base_implicit_ctf_input_args->extra_params);
-               if (!impl_args->extra_params) {
+               BT_OBJECT_PUT_REF_AND_RESET(impl_args->extra_params);
+               status = bt_value_copy(&impl_args->extra_params,
+                               bt_value_borrow_from_private(
+                               base_implicit_ctf_input_args->extra_params));
+               if (status != BT_VALUE_STATUS_OK) {
                        print_err_oom();
                        destroy_implicit_component_args(impl_args);
                        goto error;
@@ -3578,7 +3599,7 @@ static
 struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                int *retcode, bool force_omit_system_plugin_path,
                bool force_omit_home_plugin_path,
-               struct bt_value *initial_plugin_paths, char *log_level)
+               struct bt_private_value *initial_plugin_paths, char *log_level)
 {
        poptContext pc = NULL;
        char *arg = NULL;
@@ -3597,8 +3618,8 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
        bool print_run_args = false;
        bool print_run_args_0 = false;
        bool print_ctf_metadata = false;
-       struct bt_value *run_args = NULL;
-       struct bt_value *all_names = NULL;
+       struct bt_private_value *run_args = NULL;
+       struct bt_private_value *all_names = NULL;
        GList *source_names = NULL;
        GList *filter_names = NULL;
        GList *sink_names = NULL;
@@ -3612,7 +3633,8 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
        struct implicit_component_args implicit_debug_info_args = { 0 };
        struct implicit_component_args implicit_muxer_args = { 0 };
        struct implicit_component_args implicit_trimmer_args = { 0 };
-       struct bt_value *plugin_paths = bt_get(initial_plugin_paths);
+       struct bt_private_value *plugin_paths =
+               bt_object_get_ref(initial_plugin_paths);
        char error_buf[256] = { 0 };
        size_t i;
        struct bt_common_lttng_live_url_parts lttng_live_url_parts = { 0 };
@@ -3673,13 +3695,13 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                goto error;
        }
 
-       all_names = bt_value_map_create();
+       all_names = bt_private_value_map_create();
        if (!all_names) {
                print_err_oom();
                goto error;
        }
 
-       run_args = bt_value_array_create();
+       run_args = bt_private_value_array_create();
        if (!run_args) {
                print_err_oom();
                goto error;
@@ -3776,13 +3798,13 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                                abort();
                        }
 
-                       if (bt_value_array_append_string(run_args,
+                       if (bt_private_value_array_append_string_element(run_args,
                                        "--component")) {
                                print_err_oom();
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, arg)) {
+                       if (bt_private_value_array_append_string_element(run_args, arg)) {
                                print_err_oom();
                                goto error;
                        }
@@ -3805,13 +3827,13 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args,
+                       if (bt_private_value_array_append_string_element(run_args,
                                        "--params")) {
                                print_err_oom();
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, arg)) {
+                       if (bt_private_value_array_append_string_element(run_args, arg)) {
                                print_err_oom();
                                goto error;
                        }
@@ -3823,22 +3845,22 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, "--key")) {
+                       if (bt_private_value_array_append_string_element(run_args, "--key")) {
                                print_err_oom();
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, "path")) {
+                       if (bt_private_value_array_append_string_element(run_args, "path")) {
                                print_err_oom();
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, "--value")) {
+                       if (bt_private_value_array_append_string_element(run_args, "--value")) {
                                print_err_oom();
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, arg)) {
+                       if (bt_private_value_array_append_string_element(run_args, arg)) {
                                print_err_oom();
                                goto error;
                        }
@@ -3850,22 +3872,22 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, "--key")) {
+                       if (bt_private_value_array_append_string_element(run_args, "--key")) {
                                print_err_oom();
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, "url")) {
+                       if (bt_private_value_array_append_string_element(run_args, "url")) {
                                print_err_oom();
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, "--value")) {
+                       if (bt_private_value_array_append_string_element(run_args, "--value")) {
                                print_err_oom();
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, arg)) {
+                       if (bt_private_value_array_append_string_element(run_args, arg)) {
                                print_err_oom();
                                goto error;
                        }
@@ -3877,12 +3899,12 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, "--name")) {
+                       if (bt_private_value_array_append_string_element(run_args, "--name")) {
                                print_err_oom();
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, arg)) {
+                       if (bt_private_value_array_append_string_element(run_args, arg)) {
                                print_err_oom();
                                goto error;
                        }
@@ -3892,20 +3914,20 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                case OPT_OMIT_HOME_PLUGIN_PATH:
                        force_omit_home_plugin_path = true;
 
-                       if (bt_value_array_append_string(run_args,
+                       if (bt_private_value_array_append_string_element(run_args,
                                        "--omit-home-plugin-path")) {
                                print_err_oom();
                                goto error;
                        }
                        break;
                case OPT_RETRY_DURATION:
-                       if (bt_value_array_append_string(run_args,
+                       if (bt_private_value_array_append_string_element(run_args,
                                        "--retry-duration")) {
                                print_err_oom();
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, arg)) {
+                       if (bt_private_value_array_append_string_element(run_args, arg)) {
                                print_err_oom();
                                goto error;
                        }
@@ -3913,7 +3935,7 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                case OPT_OMIT_SYSTEM_PLUGIN_PATH:
                        force_omit_system_plugin_path = true;
 
-                       if (bt_value_array_append_string(run_args,
+                       if (bt_private_value_array_append_string_element(run_args,
                                        "--omit-system-plugin-path")) {
                                print_err_oom();
                                goto error;
@@ -3925,13 +3947,13 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args,
+                       if (bt_private_value_array_append_string_element(run_args,
                                        "--plugin-path")) {
                                print_err_oom();
                                goto error;
                        }
 
-                       if (bt_value_array_append_string(run_args, arg)) {
+                       if (bt_private_value_array_append_string_element(run_args, arg)) {
                                print_err_oom();
                                goto error;
                        }
@@ -3939,7 +3961,7 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                case OPT_HELP:
                        print_convert_usage(stdout);
                        *retcode = -1;
-                       BT_PUT(cfg);
+                       BT_OBJECT_PUT_REF_AND_RESET(cfg);
                        goto end;
                case OPT_BEGIN:
                case OPT_CLOCK_CYCLES:
@@ -4150,7 +4172,7 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                        break;
                case OPT_FIELDS:
                {
-                       struct bt_value *fields = fields_from_arg(arg);
+                       struct bt_private_value *fields = fields_from_arg(arg);
 
                        if (!fields) {
                                goto error;
@@ -4159,8 +4181,8 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                        implicit_text_args.exists = true;
                        ret = insert_flat_params_from_array(
                                implicit_text_args.params_arg,
-                               fields, "field");
-                       bt_put(fields);
+                               bt_value_borrow_from_private(fields), "field");
+                       bt_object_put_ref(fields);
                        if (ret) {
                                goto error;
                        }
@@ -4168,7 +4190,7 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                }
                case OPT_NAMES:
                {
-                       struct bt_value *names = names_from_arg(arg);
+                       struct bt_private_value *names = names_from_arg(arg);
 
                        if (!names) {
                                goto error;
@@ -4177,8 +4199,8 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                        implicit_text_args.exists = true;
                        ret = insert_flat_params_from_array(
                                implicit_text_args.params_arg,
-                               names, "name");
-                       bt_put(names);
+                               bt_value_borrow_from_private(names), "name");
+                       bt_object_put_ref(names);
                        if (ret) {
                                goto error;
                        }
@@ -4667,17 +4689,18 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                        goto error;
                }
 
-               for (i = 0; i < bt_value_array_size(run_args); i++) {
+               for (i = 0; i < bt_value_array_get_size(
+                               bt_value_borrow_from_private(run_args)); i++) {
                        struct bt_value *arg_value =
-                               bt_value_array_get(run_args, i);
+                               bt_value_array_borrow_element_by_index(
+                                       bt_value_borrow_from_private(run_args),
+                                       i);
                        const char *arg;
                        GString *quoted = NULL;
                        const char *arg_to_print;
 
                        BT_ASSERT(arg_value);
-                       ret = bt_value_string_get(arg_value, &arg);
-                       BT_ASSERT(ret == 0);
-                       BT_PUT(arg_value);
+                       arg = bt_value_string_get(arg_value);
 
                        if (print_run_args) {
                                quoted = bt_common_shell_quote(arg, true);
@@ -4696,7 +4719,8 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                                g_string_free(quoted, TRUE);
                        }
 
-                       if (i < bt_value_array_size(run_args) - 1) {
+                       if (i < bt_value_array_get_size(
+                                       bt_value_borrow_from_private(run_args)) - 1) {
                                if (print_run_args) {
                                        putchar(' ');
                                } else {
@@ -4706,11 +4730,12 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
                }
 
                *retcode = -1;
-               BT_PUT(cfg);
+               BT_OBJECT_PUT_REF_AND_RESET(cfg);
                goto end;
        }
 
-       cfg = bt_config_run_from_args_array(run_args, retcode,
+       cfg = bt_config_run_from_args_array(
+               bt_value_borrow_from_private(run_args), retcode,
                force_omit_system_plugin_path, force_omit_home_plugin_path,
                initial_plugin_paths);
        if (!cfg) {
@@ -4722,7 +4747,7 @@ struct bt_config *bt_config_convert_from_args(int argc, const char *argv[],
 
 error:
        *retcode = 1;
-       BT_PUT(cfg);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg);
 
 end:
        if (pc) {
@@ -4744,8 +4769,8 @@ end:
                g_ptr_array_free(implicit_ctf_inputs_args, TRUE);
        }
 
-       bt_put(run_args);
-       bt_put(all_names);
+       bt_object_put_ref(run_args);
+       bt_object_put_ref(all_names);
        destroy_glist_of_gstring(source_names);
        destroy_glist_of_gstring(filter_names);
        destroy_glist_of_gstring(sink_names);
@@ -4758,7 +4783,7 @@ end:
        finalize_implicit_component_args(&implicit_debug_info_args);
        finalize_implicit_component_args(&implicit_muxer_args);
        finalize_implicit_component_args(&implicit_trimmer_args);
-       bt_put(plugin_paths);
+       bt_object_put_ref(plugin_paths);
        bt_common_destroy_lttng_live_url_parts(&lttng_live_url_parts);
        return cfg;
 }
@@ -4826,7 +4851,7 @@ char log_level_from_arg(const char *arg)
 struct bt_config *bt_config_cli_args_create(int argc, const char *argv[],
                int *retcode, bool force_omit_system_plugin_path,
                bool force_omit_home_plugin_path,
-               struct bt_value *initial_plugin_paths)
+               struct bt_private_value *initial_plugin_paths)
 {
        struct bt_config *config = NULL;
        int i;
@@ -4847,13 +4872,13 @@ struct bt_config *bt_config_cli_args_create(int argc, const char *argv[],
        *retcode = -1;
 
        if (!initial_plugin_paths) {
-               initial_plugin_paths = bt_value_array_create();
+               initial_plugin_paths = bt_private_value_array_create();
                if (!initial_plugin_paths) {
                        *retcode = 1;
                        goto end;
                }
        } else {
-               bt_get(initial_plugin_paths);
+               bt_object_get_ref(initial_plugin_paths);
        }
 
        if (argc <= 1) {
@@ -5015,6 +5040,6 @@ struct bt_config *bt_config_cli_args_create(int argc, const char *argv[],
        }
 
 end:
-       bt_put(initial_plugin_paths);
+       bt_object_put_ref(initial_plugin_paths);
        return config;
 }
This page took 0.048682 seconds and 4 git commands to generate.